good_job 1.11.2 → 1.11.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d78c670393e4cddbedfe9512fdda95855709d830618cd63cfde7e724f26ce6c8
-  data.tar.gz: 494d3b0d6ec2b05d0bcc3386c14baca6071635647ed808a9b3543b5f1ebc4bfb
+  metadata.gz: 5e0f0ca8d7f8b024f5e84b515b8603d362b6c755d54680221e517369b6877c07
+  data.tar.gz: e69518c9d71d7b08e3707c9df8c6429ca4d9823fd1adea32adc6c0bf41ad33f4
 SHA512:
-  metadata.gz: bef7307febc465eab519c44a214287d5203bf0a024d83e46160dbbaf94b3a0fcd1317fbe99e446d9b0f01fb2bc8845a6dfe722fb123020aab96fe31b0c189d71
-  data.tar.gz: 737c03b9ad35169c9db43070abca6f644816876217fd333831db568f43eca6738dd9327eb7a403eb901ab6643e06445ba7764453d3f9b05e9e7c1159f7ba0963
+  metadata.gz: 50d2542bfad082dfba516c08bd994dad3fcd6e8311a8380dc012988c3e2745378271adc7d41cb91897d087a6b2b100cfb69362d3a11cd55c92c2610ceabeb80c
+  data.tar.gz: 69ffc79dc9367fc8522bdcf669cede6791d4e7903847edbc99887404b29ec43361de54a960841ee6cdeaaf236cc77d8c9c60b2c61793b5256bf2455667e0c387

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [v1.11.3](https://github.com/bensheldon/good_job/tree/v1.11.3) (2021-07-25)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v1.11.2...v1.11.3)
+
+**Closed issues:**
+
+- ERROR:  relation "good\_jobs" does not exist at character 454 [\#308](https://github.com/bensheldon/good_job/issues/308)
+- Add Frozen String Literal to all files [\#298](https://github.com/bensheldon/good_job/issues/298)
+- Support for good\_job without Rails? [\#295](https://github.com/bensheldon/good_job/issues/295)
+
+**Merged pull requests:**
+
+- Have prettier Dashboard asset urls e.g. `bootstrap.css` instead of `bootstrap_css.css` [\#306](https://github.com/bensheldon/good_job/pull/306) ([bensheldon](https://github.com/bensheldon))
+- Create dashboard demo app on Heroku [\#305](https://github.com/bensheldon/good_job/pull/305) ([bensheldon](https://github.com/bensheldon))
+- Add Frozen String Literal to all files [\#302](https://github.com/bensheldon/good_job/pull/302) ([tedhexaflow](https://github.com/tedhexaflow))
+
 ## [v1.11.2](https://github.com/bensheldon/good_job/tree/v1.11.2) (2021-07-20)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v1.11.1...v1.11.2)
@@ -22,13 +38,13 @@
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v1.11.0...v1.11.1)
 
-**Closed issues:**
+**Fixed bugs:**
 
-- Database connection required while loading the code on 1.10.x [\#291](https://github.com/bensheldon/good_job/issues/291)
+- Defer accessing ActiveRecord `primary_key` in Lockable [\#293](https://github.com/bensheldon/good_job/pull/293) ([bensheldon](https://github.com/bensheldon))
 
-**Merged pull requests:**
+**Closed issues:**
 
-- Defer accessing ActiveRecord `primary_key` in Lockable [\#293](https://github.com/bensheldon/good_job/pull/293) ([bensheldon](https://github.com/bensheldon))
+- Database connection required while loading the code on 1.10.x [\#291](https://github.com/bensheldon/good_job/issues/291)
 
 ## [v1.11.0](https://github.com/bensheldon/good_job/tree/v1.11.0) (2021-07-07)
 
@@ -50,9 +66,12 @@
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v1.10.0...v1.10.1)
 
-**Merged pull requests:**
+**Fixed bugs:**
 
 - Remove `FOR UPDATE SKIP LOCKED` from job locking sql statement [\#288](https://github.com/bensheldon/good_job/pull/288) ([bensheldon](https://github.com/bensheldon))
+
+**Merged pull requests:**
+
 - Update GH Test Matrix with latest JRuby 9.2.19.0 [\#283](https://github.com/bensheldon/good_job/pull/283) ([tedhexaflow](https://github.com/tedhexaflow))
 
 ## [v1.10.0](https://github.com/bensheldon/good_job/tree/v1.10.0) (2021-06-29)
@@ -61,11 +80,11 @@
 
 **Implemented enhancements:**
 
+- Use `pg_advisory_unlock_all` after each thread's job execution; fix Lockable return values; improve test stability [\#285](https://github.com/bensheldon/good_job/pull/285) ([bensheldon](https://github.com/bensheldon))
 - Add `rails g good_job:update` command to add idempotent migration files, including `active_job_id`, `concurrency_key`, `cron_key` columns [\#266](https://github.com/bensheldon/good_job/pull/266) ([bensheldon](https://github.com/bensheldon))
 
 **Fixed bugs:**
 
-- Use `pg_advisory_unlock_all` after each thread's job execution; fix Lockable return values; improve test stability [\#285](https://github.com/bensheldon/good_job/pull/285) ([bensheldon](https://github.com/bensheldon))
 - Dashboard AssetsController does not raise if verify\_authenticity\_token is not in the callback chain [\#284](https://github.com/bensheldon/good_job/pull/284) ([bensheldon](https://github.com/bensheldon))
 
 **Closed issues:**

data/engine/app/controllers/good_job/active_jobs_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class ActiveJobsController < GoodJob::BaseController
     def show

data/engine/app/controllers/good_job/assets_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class AssetsController < ActionController::Base # rubocop:disable Rails/ApplicationController
     skip_before_action :verify_authenticity_token, raise: false

data/engine/app/controllers/good_job/base_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class BaseController < ActionController::Base # rubocop:disable Rails/ApplicationController
     protect_from_forgery with: :exception

data/engine/app/controllers/good_job/dashboards_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class DashboardsController < GoodJob::BaseController
     class JobFilter

data/engine/app/controllers/good_job/jobs_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class JobsController < GoodJob::BaseController
     def destroy

data/engine/app/helpers/good_job/application_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   module ApplicationHelper
   end

data/engine/app/views/layouts/good_job/base.html.erb

@@ -5,12 +5,12 @@
   <%= csrf_meta_tags %>
   <%= csp_meta_tag %>
 
-  <%= stylesheet_link_tag bootstrap_css_path(v: GoodJob::VERSION) %>
-  <%= stylesheet_link_tag chartist_css_path(v: GoodJob::VERSION) %>
-  <%= stylesheet_link_tag style_css_path(v: GoodJob::VERSION) %>
+  <%= stylesheet_link_tag bootstrap_path(format: :css, v: GoodJob::VERSION) %>
+  <%= stylesheet_link_tag chartist_path(format: :css, v: GoodJob::VERSION) %>
+  <%= stylesheet_link_tag style_path(format: :css, v: GoodJob::VERSION) %>
 
-  <%= javascript_include_tag bootstrap_js_path(v: GoodJob::VERSION) %>
-  <%= javascript_include_tag chartist_js_path(v: GoodJob::VERSION) %>
+  <%= javascript_include_tag bootstrap_path(format: :js, v: GoodJob::VERSION) %>
+  <%= javascript_include_tag chartist_path(format: :js, v: GoodJob::VERSION) %>
 </head>
 <body>
   <nav class="navbar navbar-expand-lg navbar-light bg-light">

data/engine/config/routes.rb

@@ -1,13 +1,19 @@
+# frozen_string_literal: true
 GoodJob::Engine.routes.draw do
   root to: 'dashboards#index'
   resources :active_jobs, only: %i[show]
   resources :jobs, only: %i[destroy]
 
   scope controller: :assets do
-    get :bootstrap_css
-    get :bootstrap_js
-    get :chartist_css
-    get :chartist_js
-    get :style_css
+    constraints(format: :css) do
+      get :bootstrap, action: :bootstrap_css
+      get :chartist, action: :chartist_css
+      get :style, action: :style_css
+    end
+
+    constraints(format: :js) do
+      get :bootstrap, action: :bootstrap_js
+      get :chartist, action: :chartist_js
+    end
   end
 end

data/engine/lib/good_job/engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   class Engine < ::Rails::Engine
     isolate_namespace GoodJob

data/exe/good_job

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 require 'good_job/cli'
 
 GoodJob::CLI.within_exe = true

data/lib/active_job/queue_adapters/good_job_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ActiveJob # :nodoc:
   module QueueAdapters # :nodoc:
     # See {GoodJob::Adapter} for details.

data/lib/generators/good_job/install_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rails/generators'
 require 'rails/generators/active_record'
 module GoodJob

data/lib/generators/good_job/templates/update/migrations/01_create_good_jobs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateGoodJobs < ActiveRecord::Migration[5.2]
   def change
     enable_extension 'pgcrypto'

data/lib/generators/good_job/templates/update/migrations/02_add_active_job_id_concurrency_key_cron_key_to_good_jobs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class AddActiveJobIdConcurrencyKeyCronKeyToGoodJobs < ActiveRecord::Migration[5.2]
   def change
     reversible do |dir|

data/lib/generators/good_job/templates/update/migrations/03_add_active_job_id_index_and_concurrency_key_index_to_good_jobs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class AddActiveJobIdIndexAndConcurrencyKeyIndexToGoodJobs < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 

data/lib/generators/good_job/update_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rails/generators'
 require 'rails/generators/active_record'
 

data/lib/good_job.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "rails"
 require "active_job"
 require "active_job/queue_adapters"

data/lib/good_job/active_job_extensions.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   module ActiveJobExtensions
   end

data/lib/good_job/active_job_extensions/concurrency.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   module ActiveJobExtensions
     module Concurrency

data/lib/good_job/adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   #
   # ActiveJob Adapter.

data/lib/good_job/cli.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'thor'
 
 module GoodJob

data/lib/good_job/configuration.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   #
   # +GoodJob::Configuration+ provides normalized configuration information to

data/lib/good_job/current_execution.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'active_support/core_ext/module/attribute_accessors_per_thread'
 
 module GoodJob

data/lib/good_job/daemon.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   #
   # Manages daemonization of the current process.

data/lib/good_job/execution_result.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   # Stores the results of job execution
   class ExecutionResult

data/lib/good_job/job.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   # ActiveRecord model that represents an +ActiveJob+ job.
   # Parent class can be configured with +GoodJob.active_record_parent_class+.
@@ -10,12 +11,12 @@ module GoodJob
     PreviouslyPerformedError = Class.new(StandardError)
 
     # ActiveJob jobs without a +queue_name+ attribute are placed on this queue.
-    DEFAULT_QUEUE_NAME = 'default'.freeze
+    DEFAULT_QUEUE_NAME = 'default'
     # ActiveJob jobs without a +priority+ attribute are given this priority.
     DEFAULT_PRIORITY = 0
 
-    self.table_name = 'good_jobs'.freeze
-    self.advisory_lockable_column = 'id'.freeze
+    self.table_name = 'good_jobs'
+    self.advisory_lockable_column = 'id'
 
     attr_readonly :serialized_params
 

data/lib/good_job/job_performer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'concurrent/delay'
 
 module GoodJob

data/lib/good_job/lockable.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   #
   # Adds Postgres advisory locking capabilities to an ActiveRecord record.

data/lib/good_job/log_subscriber.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   #
   # Listens to GoodJob notifications and logs them.

data/lib/good_job/multi_scheduler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   # Delegates the interface of a single {Scheduler} to multiple Schedulers.
   class MultiScheduler

data/lib/good_job/notifier.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'concurrent/atomic/atomic_boolean'
 
 module GoodJob # :nodoc:
@@ -13,7 +14,7 @@ module GoodJob # :nodoc:
     AdapterCannotListenError = Class.new(StandardError)
 
     # Default Postgres channel for LISTEN/NOTIFY
-    CHANNEL = 'good_job'.freeze
+    CHANNEL = 'good_job'
     # Defaults for instance of Concurrent::ThreadPoolExecutor
     EXECUTOR_OPTIONS = {
       name: name,

data/lib/good_job/poller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'concurrent/atomic/atomic_boolean'
 
 module GoodJob # :nodoc:

data/lib/good_job/railtie.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module GoodJob
   # Ruby on Rails integration.
   class Railtie < ::Rails::Railtie

data/lib/good_job/scheduler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "concurrent/executor/thread_pool_executor"
 require "concurrent/executor/timer_set"
 require "concurrent/scheduled_task"

data/lib/good_job/version.rb

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '1.11.2'.freeze
+  VERSION = '1.11.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 1.11.2
+  version: 1.11.3
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-20 00:00:00.000000000 Z
+date: 2021-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob