golden_fleece 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6dadad30183120be89348ef186c0be8de8d1cf6e
-  data.tar.gz: 13e14e0c497115e0e7dff33822b2864efd0bb7c6
+  metadata.gz: eca661bb7140e8bb690e74d0609e2b4fbfcefd9a
+  data.tar.gz: 8b8051cab3fe52d6612616e84a624612bcb66c14
 SHA512:
-  metadata.gz: c5b3b5e14665764464cbf89ba630db8c549463572696dc98de7a31a607549426d0d9cc821f06838850313aec07f4f5fcdbaa37cb05acff66544b01638f66fc03
-  data.tar.gz: 7c115cdb975db18cda2b27aca36329e2c7d23e3ac0c160601e922e18f50a9bb348cdc8df721efbeef5071ff19172889c6f7f8529a9e84b9379307d7493fe35ae
+  metadata.gz: 39d48fd3a1ec1900f0945fa5c1cf28f259073065dc3d39e01b0b3acd18946dc45c97d08afdff284c6162d20c973880b4c1de2abc37f6bc2e2f1cc79640b6279b
+  data.tar.gz: 45b4d63d453b2a9740aa1e7a8809bcdd85f89b6ee63b5737ac8f7caa9a791a17870b3f40572ddbd73f094b82fb3738e964657bf268913d091cadf1eb427fc947

data/CHANGELOG.md

@@ -5,7 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
-### [0.1.2] - 2015-05-26
+### [0.1.3] - 2017-05-26
+### Fixed
+- Remove caching from value computations, which didn't make sense because we were caching model instance values at the model class level.
+- Wrong dates in this change log :-)
+
+### [0.1.2] - 2017-05-26
 ### Changed
 - Allow redefining individual schemas
 
@@ -26,6 +31,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Getters
 - Specs
 
-[Unreleased]: https://github.com/earksiinni/golden_fleece/compare/v0.1.2...HEAD
+[Unreleased]: https://github.com/earksiinni/golden_fleece/compare/v0.1.3...HEAD
+[0.1.2]: https://github.com/earksiinni/golden_fleece/compare/v0.1.2...v0.1.3
 [0.1.2]: https://github.com/earksiinni/golden_fleece/compare/v0.1.1...v0.1.2
 [0.1.1]: https://github.com/earksiinni/golden_fleece/compare/v0.1.0...v0.1.1

data/README.md

@@ -178,6 +178,25 @@ person.profile['zip_code'] = 90210
 person.zip_code            # '2b02dbc1030b278245b2b9cb11667eebf7275a52'
 ```
 
+Be careful! Normalizers can change your data when saving your record. Make sure your normalizer doesn't make invalid assumptions about types, etc.:
+
+```ruby
+define_normalizers({
+  csv_to_array: -> record, value { value.to_s.split(/\s*,\s*/) }
+})
+
+define_schemas :settings, {
+  important_ids: { type: :array, normalizer: :csv_to_array }
+}
+
+define_getters :settings
+
+person.profile['important_ids'] = '1001, 1002,1003'
+person.important_ids # [1001, 1002, 1003] (as expected)
+person.save          # normalizer persists the array in place of the CSV string
+person.important_ids # [0, 1002, 1003] (not expected! normalizer is trying to convert your array to a string, then splitting it on commas)
+```
+
 ### Formats
 
 Formats are Procs that can be used to enforce complex validations:

data/lib/golden_fleece/value.rb

@@ -7,34 +7,23 @@ module GoldenFleece
 
     def initialize(schema)
       @schema = schema
-      self.value_initialized = false
     end
 
     def compute(record)
       @record = record
+      @value = Hana::Pointer.new(schema.json_path).eval(record.read_attribute(schema.attribute))
 
-      if dirty?
-        @value = Hana::Pointer.new(schema.json_path).eval(record.read_attribute(schema.attribute))
-
-        cast_booleans
-        apply_normalizers
-        apply_default
-
-        self.value_initialized = true
-      end
+      cast_booleans
+      apply_normalizers
+      apply_default
 
       value
     end
 
     private
 
-    attr_accessor :value_initialized
     attr_reader :schema, :record, :value
 
-    def dirty?
-      record.send("#{schema.attribute}_changed?") || !value_initialized
-    end
-
     # Cast boolean values the way that Rails normally does on boolean columns
     def cast_booleans
       if schema.types.include? Definitions::TYPES[:boolean]

data/lib/golden_fleece/version.rb

@@ -1,3 +1,3 @@
 module GoldenFleece
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: golden_fleece
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Ersin Akinci