gogoodreads 0.0.6 → 0.0.7

data/VERSION

@@ -1 +1 @@
-0.0.6
+0.0.7

data/gogoodreads.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{gogoodreads}
-  s.version = "0.0.6"
+  s.version = "0.0.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Tim Medina"]
@@ -44,11 +44,12 @@ Gem::Specification.new do |s|
     "lib/go_goodreads/user_status.rb",
     "lib/gogoodreads.rb",
     "test/attribute_test.rb",
-    "test/bad_api_key_test.rb",
     "test/book_test.rb",
     "test/config_test.rb",
+    "test/exceptions_test.rb",
     "test/fixtures/vcr_cassettes/book_by_isbn.yml",
     "test/fixtures/vcr_cassettes/book_by_isbn_bad_api_key.yml",
+    "test/fixtures/vcr_cassettes/book_by_isbn_not_found.yml",
     "test/test_helper.rb"
   ]
   s.homepage = %q{http://github.com/iamteem/gogoodreads}
@@ -58,9 +59,9 @@ Gem::Specification.new do |s|
   s.summary = %q{Goodreads API Ruby Interface}
   s.test_files = [
     "test/attribute_test.rb",
-    "test/bad_api_key_test.rb",
     "test/book_test.rb",
     "test/config_test.rb",
+    "test/exceptions_test.rb",
     "test/test_helper.rb"
   ]
 

data/lib/go_goodreads/book.rb

@@ -39,6 +39,13 @@ module GoGoodreads
         book.current_page = params[:page] || 1
         book
       end
+
+    rescue ::RestClient::Exception => ex
+      if ex.http_code == 404
+        return nil
+      else
+        raise
+      end
     end
 
     def self.initialize_with_node(xml)

data/test/book_test.rb

@@ -30,4 +30,11 @@ class BookTest < Test::Unit::TestCase
       assert_nil   book.publication_date
     end
   end
+
+  def test_show_by_isbn_nil_on_not_found
+    VCR.use_cassette('book_by_isbn_not_found') do
+      book = GoGoodreads::Book.show_by_isbn("9780935998603")
+      assert_nil book
+    end
+  end
 end

data/test/{bad_api_key_test.rb → exceptions_test.rb}

@@ -1,7 +1,7 @@
 require 'test_helper'
 
-class BadApiKeyTest < Test::Unit::TestCase
-  def test_raise_exception
+class ExceptionsTest < Test::Unit::TestCase
+  def test_raise_exception_bad_api_key
     GoGoodreads.configure do |config|
       config.api_key = "1IlntIwcUm5CpTbQhu7Zf"
     end

data/test/fixtures/vcr_cassettes/book_by_isbn_not_found.yml

@@ -0,0 +1,36 @@
+--- 
+- !ruby/struct:VCR::HTTPInteraction 
+  request: !ruby/struct:VCR::Request 
+    method: :get
+    uri: http://www.goodreads.com:80/book/isbn?isbn=9780935998603&key=1IlntIwcUm5CpTbQhu7Zg
+    body: 
+    headers: 
+      accept: 
+      - "*/*; q=0.5, application/xml"
+      accept-encoding: 
+      - gzip, deflate
+  response: !ruby/struct:VCR::Response 
+    status: !ruby/struct:VCR::ResponseStatus 
+      code: 404
+      message: Not Found
+    headers: 
+      content-type: 
+      - application/xml; charset=utf-8
+      status: 
+      - "404"
+      x-powered-by: 
+      - Phusion Passenger (mod_rails/mod_rack) 3.0.0
+      x-runtime: 
+      - "13"
+      content-length: 
+      - "30"
+      set-cookie: 
+      - _session_id=e6abd26c8dd41149ff33398f8a37f260; domain=.goodreads.com; path=/; HttpOnly
+      cache-control: 
+      - no-cache
+      server: 
+      - nginx/0.8.52 + Phusion Passenger 3.0.0 (mod_rails/mod_rack)
+    body: |
+      <error>book not found</error>
+
+    http_version: "1.1"

metadata

@@ -2,7 +2,7 @@
 name: gogoodreads
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors: 
 - Tim Medina
@@ -160,11 +160,12 @@ files:
 - lib/go_goodreads/user_status.rb
 - lib/gogoodreads.rb
 - test/attribute_test.rb
-- test/bad_api_key_test.rb
 - test/book_test.rb
 - test/config_test.rb
+- test/exceptions_test.rb
 - test/fixtures/vcr_cassettes/book_by_isbn.yml
 - test/fixtures/vcr_cassettes/book_by_isbn_bad_api_key.yml
+- test/fixtures/vcr_cassettes/book_by_isbn_not_found.yml
 - test/test_helper.rb
 has_rdoc: true
 homepage: http://github.com/iamteem/gogoodreads
@@ -180,7 +181,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -1480672835965473733
+      hash: -2022826134956577794
       segments: 
       - 0
       version: "0"
@@ -199,7 +200,7 @@ specification_version: 3
 summary: Goodreads API Ruby Interface
 test_files: 
 - test/attribute_test.rb
-- test/bad_api_key_test.rb
 - test/book_test.rb
 - test/config_test.rb
+- test/exceptions_test.rb
 - test/test_helper.rb