go_to_param 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05ddd7d3e4b2514e5f5136af63f0263f0bde08c9
-  data.tar.gz: 47acd514926425787274fa1452252147007ed803
+  metadata.gz: 8ff657dfce2b1757a637ff58b8614803f96415b4
+  data.tar.gz: 446aaba35e959473a3ec0df17e3ada34ee91a831
 SHA512:
-  metadata.gz: 2c7e6949c134e0d72dce393533870c28860e8ea44bb51198e42869eba80c36bfee6dc09cb4dd5f288daec909b0f11f31087cfbde871dbbb56d5bcb24241421cb
-  data.tar.gz: ef121087d69984d484e37a647396076cd528eec877889185abf22f5cdff43bc287611bd4543e5707ce6ad635535d90f0044593dc872a2e8df5c89e95c4802de3
+  metadata.gz: 0d882496e336ab925a45599ad950c2c2541c8b6a3b798eea41b1cf75aa7982747b0c9a3481c4c9e17090deb3ed84d3610b5f74054497ac79b3b422ac95ee7e9e
+  data.tar.gz: 405bed370bc54b4a81c0ddecc8968ad31ea3e7d0de39207433ec77b65651fd296026299a474196a9410db868f97862c79796f1a9f465c3cb13a53ddb055c3461

data/lib/go_to_param/version.rb

@@ -1,3 +1,3 @@
 module GoToParam
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/go_to_param.rb

@@ -47,7 +47,7 @@ module GoToParam
 
   def go_to_here_path(additional_query_params = {})
     if request.get?
-      _go_to_add_query_string_from_hash(request.fullpath, additional_query_params)
+      _go_to_add_query_string_from_hash(_go_to_fullpath, additional_query_params)
     else
       nil
     end
@@ -67,4 +67,11 @@ module GoToParam
       [ path, separator, query_string ].join
     end
   end
+
+  # Prevent encoding errors ("incompatible character encodings: UTF-8 and ASCII-8BIT") for certain malformed requests.
+  # Inspired by https://github.com/discourse/discourse/commit/090dc80f8a23dbb3ad703efbac990aa917c06505
+  def _go_to_fullpath
+    path = request.fullpath
+    path.dup.force_encoding("UTF-8").scrub
+  end
 end

data/spec/go_to_param_spec.rb

@@ -99,6 +99,17 @@ describe GoToParam do
       expect(controller.go_to_here_params(bar: 3)).to eq({ go_to: "/example?foo&bar=3" })
     end
 
+    it "makes sure the go_to path is valid UTF-8" do
+      weird_path = "\xE0\x80\x80weird\330stuff".force_encoding("ASCII-8BIT")
+      replacement = "\uFFFD"  # The Unicode 'Replacement Character'
+
+      controller.request = double(get?: true, fullpath: weird_path)
+
+      go_to_value = controller.go_to_here_params[:go_to]
+
+      expect(go_to_value.encoding).to eq(Encoding::UTF_8)
+      expect(go_to_value).to eq("#{replacement}#{replacement}#{replacement}weird#{replacement}stuff")
+    end
   end
 
   describe "#go_to_path" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: go_to_param
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Henrik N
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-20 00:00:00.000000000 Z
+date: 2015-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler