go_import 3.0.30 → 3.0.32

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Zjc5M2UwMDMwNzUxMmJkNWIwZTlhOWJlMWQ3NDFhYzEwYWE1MWE3YQ==
+    ZTVkMWQ0NTA0ZWFlZGVlYTQ3NWMwODA4YmJhNzNkYjRiN2MxNTZiYw==
   data.tar.gz: !binary |-
-    ODNlZjljNTViZTRkMzNiMmU3NWVjOTYzOTVmMzc3MjliY2ZlYmJlYw==
+    NDIzYTJlZmZmMzMwNzQzZmMwZGRmYTE4ODZhMjEyNGUzYTg4M2I3ZQ==
 SHA512:
   metadata.gz: !binary |-
-    ZmE1MWFhZmQ3MzJiYTg4NmVkYTAzZDFlNTYwODNkYzIwYWVkMmFlMWUxZTM5
-    ZmMxZTFiZDM2NGZmNTg3ZDk2Y2EwMGJjMTViNTJjZGNhNjc1ZjIyOTQzMDY3
-    NzA3ZTA0YTVhNTViMTgxMTAxOGUxZTI4YjNkNGU3OWEyOWQ2MTk=
+    YWVkNDJmMmIwNDA2NTNjMjE4MDUzYjgxODE5YjFkZDFlMjk1MmJlMjUwODU5
+    Yjc0NDA2ZDlkMjc3MGRiNzdhOWJmZjkzYTBmNzkyN2JlMTY2NjE4ZjUyMTM0
+    ZmVhYWFjZTVlZjc0NmY0ODlkMGUxZTZjM2U4MDk0ZDQwZGM2NTE=
   data.tar.gz: !binary |-
-    MGY4YjQ3N2I2MzM3OTRiZmYzOGYzYWUwMTYxY2YyNDc2OGQxNGQ4Yzc5ZmZl
-    ZTBhNDc1OTlmM2YzYzdmYjZiYzk0YzE4ZGE2Yjk0NmMyNzU5MWFmYTYwMTQy
-    MDUwZWI3OGM2MWM0ZGY2MDQ1ZGYyODk0ZjBlZDg1YjBiN2JiZGQ=
+    MGQ3MTNjODdlNjc1YjQ0MTlmY2ZjOThjNzU0OWQwZjA2YTAzYTQ3N2RhODEw
+    M2UzMmY5NTFiNjIyMmMwNThmMThhODhiMDZlMjI1ZTJhNmExZTJmMDIxN2I3
+    YjM0OTM3NjAzMGFhNmQyOGVmZTViZWQ5NmZlMzc5M2E1MzliOTE=

data/lib/go_import/can_become_immutable.rb

@@ -0,0 +1,29 @@
+
+module GoImport
+    class CanBecomeImmutable
+        def self.immutable_accessor(name)
+            define_method(name) do
+                return instance_variable_get("@#{name}")
+            end
+            
+            define_method("#{name}=") do |value|
+                raise_if_immutable
+                instance_variable_set("@#{name}", value)
+            end
+        end
+        
+        def raise_if_immutable
+            if @is_immutable
+                raise ObjectIsImmutableError
+            end
+        end
+        
+        def set_is_immutable()
+            @is_immutable = true
+        end
+
+        def is_immutable()
+            @is_immutable
+        end
+    end
+end

data/lib/go_import/errors.rb

@@ -25,4 +25,7 @@ module GoImport
             super("#{classification} is not a valid note classification")
         end
     end
+
+    class ObjectIsImmutableError < StandardError
+    end
 end

data/lib/go_import/model/coworker.rb

@@ -1,9 +1,15 @@
 # encoding: utf-8
 module GoImport
-    class Coworker
+    class Coworker < CanBecomeImmutable
         include SerializeHelper
-        attr_accessor :id, :integration_id, :email, :first_name, :last_name, :direct_phone_number,
-        :mobile_phone_number, :home_phone_number
+        immutable_accessor :id
+        immutable_accessor :integration_id
+        immutable_accessor :email
+        immutable_accessor :first_name
+        immutable_accessor :last_name
+        immutable_accessor :direct_phone_number
+        immutable_accessor :mobile_phone_number
+        immutable_accessor :home_phone_number
 
         def initialize(opt = nil)
             if opt != nil

data/lib/go_import/model/deal.rb

@@ -34,14 +34,19 @@ module GoImport
         end
     end
 
-    class Deal
+    class Deal < CanBecomeImmutable
         include SerializeHelper, ModelHasCustomFields, ModelHasTags
 
         # Get/set the deal's status. Statuses must be configured in
         # LIME Go before the import.
-        attr_accessor :status
+        immutable_accessor :status
 
-        attr_accessor :id, :integration_id, :name, :description, :probability, :order_date
+        immutable_accessor :id
+        immutable_accessor :integration_id
+        immutable_accessor :name
+        immutable_accessor :description
+        immutable_accessor :probability
+        immutable_accessor :order_date
 
         # you add custom values by using {#set_custom_value}
         attr_reader :custom_values
@@ -132,12 +137,14 @@ module GoImport
         # already exists in the application use the status label
         # (String) or integration id (Integer) here.
         def status=(status)
+            raise_if_immutable
             @status = DealStatus.new if @status.nil?
             
             @status.status_reference = DealStatusReference.from_deal_status(status)
         end
 
         def customer=(customer)
+            raise_if_immutable
             @customer_reference = OrganizationReference.from_organization(customer)
 
             if customer.is_a?(Organization)
@@ -151,6 +158,7 @@ module GoImport
         end
 
         def responsible_coworker=(coworker)
+            raise_if_immutable
             @responsible_coworker_reference = CoworkerReference.from_coworker(coworker)
 
             if coworker.is_a?(Coworker)
@@ -159,6 +167,7 @@ module GoImport
         end
 
         def customer_contact=(person)
+            raise_if_immutable
             @customer_contact_reference = PersonReference.from_person(person)
 
             if person.is_a?(Person)
@@ -171,6 +180,8 @@ module GoImport
         # ignored. This makes it easier for us to convert a string
         # into an integer value.
         def value=(value)
+            raise_if_immutable
+            
             if value.nil?
                 @value = "0"
             elsif value.respond_to?(:empty?) && value.empty?

data/lib/go_import/model/note.rb

@@ -1,7 +1,9 @@
 module GoImport
-    class Note
+    class Note < CanBecomeImmutable
         include SerializeHelper
-        attr_accessor :id, :integration_id, :date
+        immutable_accessor :id
+        immutable_accessor :integration_id
+        immutable_accessor :date
 
         attr_reader :text
         attr_reader :organization, :created_by, :person, :deal
@@ -51,6 +53,7 @@ module GoImport
         end
 
         def organization=(org)
+            raise_if_immutable
             @organization_reference = OrganizationReference.from_organization(org)
 
             if org.is_a?(Organization)
@@ -59,6 +62,7 @@ module GoImport
         end
 
         def created_by=(coworker)
+            raise_if_immutable
             @created_by_reference = CoworkerReference.from_coworker(coworker)
 
             if coworker.is_a?(Coworker)
@@ -67,6 +71,7 @@ module GoImport
         end
 
         def person=(person)
+            raise_if_immutable
             @person_reference = PersonReference.from_person(person)
 
             if person.is_a?(Person)
@@ -75,6 +80,7 @@ module GoImport
         end
 
         def deal=(deal)
+            raise_if_immutable
             @deal_reference = DealReference.from_deal(deal)
 
             if deal.is_a?(Deal)
@@ -83,6 +89,7 @@ module GoImport
         end
 
         def classification=(classification)
+            raise_if_immutable
             if classification == NoteClassification::Comment || classification == NoteClassification::SalesCall ||
                     classification == NoteClassification::TalkedTo || classification == NoteClassification::TriedToReach ||
                     classification == NoteClassification::ClientVisit
@@ -93,6 +100,7 @@ module GoImport
         end
 
         def text=(text)
+            raise_if_immutable
             @text = text
 
             if @text.nil?

data/lib/go_import/model/organization.rb

@@ -37,12 +37,20 @@ module GoImport
             end
         end
     end
-
-    class Organization
+    
+    class Organization < CanBecomeImmutable
         include SerializeHelper, ModelHasCustomFields, ModelHasTags
-
-        attr_accessor :id, :integration_id, :name, :organization_number, :email, :web_site,
-        :postal_address, :visit_address, :central_phone_number, :source_data
+        
+        immutable_accessor :id
+        immutable_accessor :integration_id
+        immutable_accessor :name
+        immutable_accessor :organization_number
+        immutable_accessor :email
+        immutable_accessor :web_site
+        immutable_accessor :postal_address
+        immutable_accessor :visit_address
+        immutable_accessor :central_phone_number
+        immutable_accessor :source_data
 
         # Sets/gets the date when this organization's relation was
         # changed. Default is Now.
@@ -127,10 +135,23 @@ module GoImport
             @employees = [] if @employees == nil
             person = if val.is_a? Person then val else Person.new(val) end
             @employees.push(person)
-            person
+
+            # *** TODO:
+            #
+            # The person should be immutable after it has been added
+            # to the organization. However most sources (LIME Easy,
+            # LIME Pro, Excel, SalesForce, etc) are updating the
+            # person after is has been added to the organization. We
+            # must update the sources before we can set the person
+            # immutable here.
+            
+            #person.set_is_immutable
+            
+            return person
         end
 
         def responsible_coworker=(coworker)
+            raise_if_immutable
             @responsible_coworker_reference = CoworkerReference.from_coworker(coworker)
 
             if coworker.is_a?(Coworker)
@@ -142,6 +163,8 @@ module GoImport
         # relation must be a valid value from the Relation module
         # otherwise an InvalidRelationError error will be thrown.
         def relation=(relation)
+            raise_if_immutable
+            
             if relation == Relation::NoRelation || relation == Relation::WorkingOnIt ||
                     relation == Relation::IsACustomer || relation == Relation::WasACustomer || relation == Relation::BeenInTouch
                 @relation = relation
@@ -151,8 +174,10 @@ module GoImport
                 raise InvalidRelationError
             end
         end
-
+        
         def relation_last_modified=(date)
+            raise_if_immutable
+            
             begin
                 @relation_last_modified = @relation != Relation::NoRelation ? Date.parse(date).strftime("%Y-%m-%d") : nil
             rescue

data/lib/go_import/model/person.rb

@@ -28,11 +28,22 @@ module GoImport
         end
     end
 
-    class Person < PersonReference
+    class Person < CanBecomeImmutable    
         include SerializeHelper, ModelHasCustomFields, ModelHasTags
-        attr_accessor :first_name, :last_name,
-            :direct_phone_number, :fax_phone_number, :mobile_phone_number, :home_phone_number,
-            :position, :email, :alternative_email, :postal_address, :currently_employed
+
+        immutable_accessor :id
+        immutable_accessor :integration_id        
+        immutable_accessor :first_name
+        immutable_accessor :last_name
+        immutable_accessor :direct_phone_number
+        immutable_accessor :fax_phone_number
+        immutable_accessor :mobile_phone_number
+        immutable_accessor :home_phone_number
+        immutable_accessor :position
+        immutable_accessor :email
+        immutable_accessor :alternative_email
+        immutable_accessor :postal_address
+        immutable_accessor :currently_employed
 
         # you add custom values by using {#set_custom_value}
         attr_reader :custom_values, :organization

data/lib/go_import/model/rootmodel.rb

@@ -72,6 +72,7 @@ module GoImport
             end
 
             @coworkers[coworker.integration_id] = coworker
+            coworker.set_is_immutable
 
             return coworker
         end
@@ -100,6 +101,7 @@ module GoImport
             end
 
             @organizations[organization.integration_id] = organization
+            organization.set_is_immutable
 
             return organization
         end
@@ -132,6 +134,7 @@ module GoImport
             end
 
             @deals[deal.integration_id] = deal
+            deal.set_is_immutable
 
             return deal
         end
@@ -168,6 +171,7 @@ module GoImport
             end
             
             @notes[note.integration_id] = note
+            note.set_is_immutable
 
             return note
         end
@@ -288,7 +292,8 @@ module GoImport
             end
 
             converter_deal_statuses = @settings.deal.statuses.map {|status| status.label} if @settings.deal != nil
-            @deals.each do |deal|
+            @deals.each do |key, deal|
+            #@deals.each do |deal|
                 error, warning = deal.validate converter_deal_statuses
 
                 if !error.empty?
@@ -299,7 +304,8 @@ module GoImport
                 end
             end
 
-            @notes.each do |note|
+            #@notes.each do |note|
+            @notes.each do |key, note|
                 validation_message = note.validate
 
                 if !validation_message.empty?

data/lib/go_import/model_helpers.rb

@@ -33,6 +33,30 @@ module GoImport
         end
     end
 
+    module ImmutableModel
+        @is_immutable = false
+        def self.immutable_accessor(name)
+            define_method(name) do
+                return instance_variable_get("@#{name}")
+            end
+
+            define_method("#{name}=") do |value|
+                raise_if_immutable
+                instance_variable_set("@#{name}", value)
+            end
+        end
+
+        def raise_if_immutable
+            if @is_immutable
+                raise ObjectIsImmutableError
+            end
+        end
+
+        def is_immutable()
+            @is_immutable = true
+        end
+    end
+    
     module ModelWithIntegrationIdSameAs
         # check if other is same as regarding integration_id or id
         def same_as?(other)

data/lib/go_import.rb

@@ -7,6 +7,7 @@ module GoImport
     require 'go_import/errors'
     require 'go_import/serialize_helper'
     require 'go_import/model_helpers'
+    require 'go_import/can_become_immutable'
     GoImport::require_all_in 'go_import/model/*.rb'
     require 'go_import/csv_helper'
     require 'go_import/roo_helper'

data/sources/lime-easy/.go_import/runner.rb

@@ -78,7 +78,7 @@ def convert_source
     end
 
     # deal notes
-    process_rows(" - Reading Deal Notess '#{DEAL_NOTE_FILE}'", DEAL_NOTE_FILE) do |row|
+    process_rows(" - Reading Deal Notes '#{DEAL_NOTE_FILE}'", DEAL_NOTE_FILE) do |row|
         # adds itself if applicable
         rootmodel.add_note(to_deal_note(converter, row, rootmodel))
     end

data/spec/helpers/xsd_validate_spec.rb

@@ -36,11 +36,10 @@ describe GoImport::SerializeHelper do
             coworker = GoImport::Coworker.new({:integration_id => "1", :first_name => "Vincent", :last_name => "Vega"})
             organization.responsible_coworker = coworker
 
-            emp = organization.add_employee({
-                :integration_id => "1",
-                :first_name => "Kalle",
-                :last_name => "Anka"
-            })
+            emp = GoImport::Person.new
+            emp.integration_id = "1"
+            emp.first_name = "Kalle"
+            emp.last_name = "Anka"
             emp.direct_phone_number = '234234234'
             emp.currently_employed = true
             rootmodel.add_organization organization

data/spec/person_spec.rb

@@ -84,6 +84,21 @@ describe "Person" do
         person.organization.is_a?(GoImport::OrganizationReference).should eq true
     end
 
+    # *** TODO:
+    # Enable this when sources are fixed, see comment in organization.add_employee
+    
+    # it "should be immutable when added to an organization" do
+    #     # given
+    #     org = GoImport::Organization.new({:integration_id => "123", :name => "Lundalogik"})
+    #     person = GoImport::Person.new({:integration_id => "456", :first_name => "vincent"})
+
+    #     # when
+    #     org.add_employee person
+
+    #     # then
+    #     person.is_immutable.should eq true
+    # end
+
     describe "parse_name_to_firstname_lastname_se" do
         it "can parse 'Kalle Nilsson' into firstname 'Kalle' and lastname 'Nilsson'" do
             person.parse_name_to_firstname_lastname_se 'Kalle Nilsson'

data/spec/rootmodel_spec.rb

@@ -27,6 +27,20 @@ describe "RootModel" do
         rootmodel.coworkers.length.should eq 2
     end
 
+    it "will make coworkers immutable after it has been added" do
+        # given
+        coworker = GoImport::Coworker.new
+        coworker.integration_id = "123key"
+        coworker.first_name = "vincent"
+
+        # when
+        rootmodel.add_coworker(coworker)
+
+        # then
+        coworker.is_immutable.should eq true
+    end
+    
+
     it "will only add coworkers" do
         # given
         not_a_coworker = { :integration_id => "123", :first_name => "Vincent" }
@@ -78,6 +92,19 @@ describe "RootModel" do
         rootmodel.organizations.length.should eq 1
     end
 
+    it "will make organizations immutable after it has been added" do
+        # given
+        organization = GoImport::Organization.new
+        organization.integration_id = "123key"
+        organization.name = "Beagle Boys"
+
+        # when
+        rootmodel.add_organization(organization)
+
+        # then
+        organization.is_immutable.should eq true
+    end
+    
     it "will only add organizations" do
         # given
         not_an_organization = { :integration_id => "123", :name => "This is not a note"}
@@ -149,6 +176,19 @@ describe "RootModel" do
         rootmodel.deals.length.should eq 1
     end
 
+    it "will make deal immutable after it has been added" do
+        # given
+        deal = GoImport::Deal.new
+        deal.integration_id = "123key"
+        deal.name = "Big deal"
+
+        # when
+        rootmodel.add_deal(deal)
+
+        # then
+        deal.is_immutable.should eq true
+    end    
+
     it "will only add deals" do
         # given
         not_a_deal = { :integration_id => "123", :name => "This is not a deal" }
@@ -245,6 +285,18 @@ describe "RootModel" do
         }.to raise_error(ArgumentError)
         rootmodel.notes.length.should eq 0
     end
+
+    it "will make note immutable after it has been added" do
+        # given
+        note = GoImport::Note.new        
+        note.text = "this is a note"
+
+        # when
+        rootmodel.add_note(note)
+
+        # then
+        note.is_immutable.should eq true
+    end
     
     it "can add a note from a new note" do
         # given

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_import
 version: !ruby/object:Gem::Version
-  version: 3.0.30
+  version: 3.0.32
 platform: ruby
 authors:
 - Petter Sandholdt
@@ -179,6 +179,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- lib/go_import/can_become_immutable.rb
 - lib/go_import/csv_helper.rb
 - lib/go_import/email_helper.rb
 - lib/go_import/errors.rb