go_import 3.0.21 → 3.0.22

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NWU4ODY3ZjBlYWZjYTExMzE2NjExMmIxODYzZjZkOWJkODk5MDg3ZA==
+    MzkxYmMwYWUwM2M0MjE1YTZmNzA0YjdiN2Q5NWZmMTk0YWVkZDhiOQ==
   data.tar.gz: !binary |-
-    OWNlYzA4NjJmYmIzNDU1OTZlNzFiZGU1YWExNjYxNTM2MGQyMjUxMg==
+    NzBkM2ZkMDkzNWQ1MGM0MDc5MmU5MzBmNDMzYmMwNGRjNGQ5YmVkMg==
 SHA512:
   metadata.gz: !binary |-
-    YzJlNjIxOTViMDhhN2Q0ZGVlMDc2YjA0YThkOGUyNjUyY2I2NmVlMDBjNjZj
-    Y2E2NTkzMDQwZjJjNWZkYjUzZmVhMTc5OTBiZDZlZTBjOTA0ZjM4ZWU3MmRh
-    ZDZiMzU0ZDkzZTI4YWQ1NDhkNmY3YTJhOWM2ZmI0YmZlN2U4ZTQ=
+    N2Y4ZTM1ZWQxNDAyYmQ5MWVhZmE5OGM1NzYzOTJhYTliOWVjNDZjN2I1YmMy
+    MTVkOGU1N2I1ZjVmNmYyYTcwZWQ1YTE0ODQzM2I4OTZlZTFmYTRhM2Q4NDFi
+    ODFjMzI5NDYyNmFjMjAwMDVhODE0ODliNTQ0NGRhNWUwNGQ4MzM=
   data.tar.gz: !binary |-
-    ODU4M2I5NmNlOWM5MTM1M2MwMmFhZjYzNDVhMTRlMWIzOTkwNjFmYmNhNjgz
-    YmFjYmQ0NDRkYTkzYTI1ZGQ0ZmM5MTI0YTY4NmEyYTZjYjEwMWYwNDJhMjcx
-    ZDg3Y2UyMDUwMTQ0YTkyZjFhNDI2NGQxZTA1MTM4ZDYwOTQ5MjU=
+    ZWRkYWI2MGRiZDI1YTcxZmVlNTUyNWNhOWUxZTc0ZmQyZWY4Nzg3YzdlMzI0
+    ZTY3YTZkYjA5MjZlZWRkNWNlOWQ2YzJlZjEzNTZlNTNjYjJlNjA0OWEzMGVk
+    ZmRjMDJlNjU0YjEwZjdmYTAxNTM5MzFjYzlhMmI5OWUzNWQ4Y2I=

data/lib/go_import/model_helpers.rb

@@ -47,6 +47,18 @@ module GoImport
         # @example
         #     obj.set_tag("partner")
         def set_tag(str)
+            if str.nil?
+                return
+            end
+
+            if !str.is_a?(String)
+                return
+            end
+
+            if str.length == 0
+                return
+            end
+            
             @tags = [] if @tags == nil
             if ! @tags.any? {|tag| tag.value == str }
                 @tags.push(Tag.new(str))

data/spec/organization_spec.rb

@@ -12,6 +12,42 @@ describe "Organization" do
         organization.tags[0].value.should eq 'Import'
     end
 
+    it "should not accept empty tags" do
+        # given
+        organization.tags.count.should eq 1
+
+        # when
+        organization.set_tag ""
+
+        # then
+        organization.tags.count.should eq 1
+    end
+
+    it "should not accept nil tags" do
+        # given
+        organization.tags.count.should eq 1
+
+        # when
+        organization.set_tag ""
+
+        # then
+        organization.tags.count.should eq 1
+    end
+
+    it "should not accept objects as tags" do
+        # given
+        organization.tags.count.should eq 1
+
+        # when
+        not_a_tag = {}
+        not_a_tag[:text] = 'this is not a tag'
+        organization.set_tag not_a_tag
+
+        # then
+        organization.tags.count.should eq 1
+    end
+    
+    
     it "must have a name" do
         # given, when
         organization.name = "Lundalogik"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_import
 version: !ruby/object:Gem::Version
-  version: 3.0.21
+  version: 3.0.22
 platform: ruby
 authors:
 - Oskar Gewalli
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-16 00:00:00.000000000 Z
+date: 2014-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes