go_api_client 0.0.6 → 0.0.7

data/Gemfile

@@ -2,5 +2,3 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in go_api_client.gemspec
 gemspec
-
-gem "webmock"

data/go_api_client.gemspec

@@ -5,9 +5,9 @@ require "go_api_client/version"
 Gem::Specification.new do |s|
   s.name        = "go_api_client"
   s.version     = GoApiClient::VERSION
-  s.authors     = ["Nikhil Mungel"]
-  s.email       = ["hyfather@gmail.com"]
-  s.homepage    = ""
+  s.authors     = ["Nikhil Mungel", "Ketan Padegaonkar", "Shishir Das"]
+  s.email       = ["hyfather@gmail.com", "KetanPadegaonkar@gmail.com", "shishir.das@gmail.com"]
+  s.homepage    = "https://github.com/ThoughtWorksInc/go-api-client"
   s.summary     = %q{Client to parse Go CI atom feed}
   s.description = %q{This gem parses atom feed generated by the Go Continuous Integration server and provides an OO representation of the pipelines and stages.}
 
@@ -19,6 +19,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # specify any dependencies here; for example:
-  # s.add_development_dependency "rspec"
+  s.add_development_dependency "webmock"
+
   s.add_runtime_dependency "nokogiri"
 end

data/lib/go_api_client/atom/feed.rb

@@ -1,10 +1,7 @@
 module GoApiClient
   module Atom
     class Feed
-      attr_accessor :updated_at
-      attr_accessor :next_page
-      attr_accessor :url
-      attr_accessor :entries
+      attr_accessor :updated_at, :next_page, :url, :entries
 
       def initialize(root)
         @root = root
@@ -12,14 +9,17 @@ module GoApiClient
 
       def parse!
         self.updated_at = @root.xpath('xmlns:updated').first.content
-        self.next_page  = @root.xpath("xmlns:link[@rel='next']").first.attribute('href').value
-        self.url        = @root.xpath("xmlns:link[@rel='self']").first.attribute('href').value
-
+        self.next_page  = href_from(@root.xpath("xmlns:link[@rel='next']"))
+        self.url        = href_from(@root.xpath("xmlns:link[@rel='self']"))
         self.entries    = @root.xpath("xmlns:entry").collect do |entry|
           Entry.new(entry).parse!
         end
         self
       end
+
+      def href_from(xml)
+        xml.first.attribute('href').value unless xml.empty?
+      end
     end
   end
 end

data/lib/go_api_client/pipeline.rb

@@ -18,11 +18,8 @@ module GoApiClient
 
     def authors
       authors = stages.map(&:authors).flatten
-      authors.map(&:name).flatten.uniq.join(" ,")
-    end
-    
-    def same?(link)
-      @details_link == link
+      authors.map(&:name).flatten.uniq.join(", ")
     end
+
   end
 end

data/lib/go_api_client/stage.rb

@@ -1,31 +1,28 @@
 module GoApiClient
   class Stage
-    attr_reader :authors, :details_link, :name, :result, :jobs
+    attr_accessor :authors, :stage_link, :name, :result, :jobs, :pipeline
 
     def initialize(entry, pipelines)
       @authors = entry.authors
-      @details_link = entry.stage_href
+      @stage_link = entry.stage_href
       @pipelines = pipelines
     end
 
     def fetch
-      doc = Nokogiri::XML(open(self.details_link))
+      doc = Nokogiri::XML(open(self.stage_link))
       @name = doc.root.xpath("@name").first.value
       @result = doc.root.xpath("//result").first.content
       job_detail_links = doc.root.xpath("//job").collect{|job| job.attributes["href"]}
       @jobs = Job.build(self, job_detail_links)
-      
+
       pipeline_link = doc.root.xpath("//pipeline").first.attributes["href"].value
-      existing_pipeline =  @pipelines.find {|p| p.same?(pipeline_link)}
-      
-      if existing_pipeline
-        existing_pipeline.stages << self
-      else
-        new_pipeline = Pipeline.new(pipeline_link).fetch
-        new_pipeline.stages << self
-        @pipelines << new_pipeline
-      end
-      @pipelines
+
+      pipeline = @pipelines[pipeline_link] || Pipeline.new(pipeline_link).fetch
+      pipeline.stages << self
+
+      @pipelines[pipeline_link] ||= pipeline
+      self
     end
   end
 end
+

data/lib/go_api_client/version.rb

@@ -1,3 +1,3 @@
 module GoApiClient
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/lib/go_api_client.rb

@@ -11,10 +11,10 @@ module GoApiClient
   def self.runs(host)
     doc = Nokogiri::XML(open("http://#{host}/go/api/pipelines/defaultPipeline/stages.xml"))
     feed = GoApiClient::Atom::Feed.new(doc.root).parse!
-    pipelines = []
-    feed.entries.collect do |entry|
-      pipelines = Stage.new(entry, pipelines).fetch
+    pipelines = {}
+    feed.entries.each do |entry|
+      Stage.new(entry, pipelines).fetch
     end
-    pipelines
+    pipelines.values
   end
 end

data/test/fixtures/stages_empty.xml

@@ -0,0 +1,9 @@
+<feed xmlns="http://www.w3.org/2005/Atom" xmlns:go="http://www.thoughtworks-studios.com/ns/go">
+    <title><![CDATA[defaultPipeline]]></title>
+    <id>http://localhost:8153/go/api/pipelines/defaultPipeline/stages.xml</id>
+    <author>
+        <name>Go</name>
+    </author>
+    <updated>2012-03-07T11:15:10+05:30</updated>
+    <link rel="self" href="http://localhost:8153/go/api/pipelines/defaultPipeline/stages.xml"/>
+</feed>

data/test/go_api_client/pipeline_test.rb

@@ -1,25 +1,37 @@
 require "test_helper"
 
-class PipelineTest < Test::Unit::TestCase
+module GoApiClient
+  class PipelineTest < Test::Unit::TestCase
 
-  def setup()
-    stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml").to_return(:body => file_contents("pipelines_1.xml"))
-  end
+    def setup
+      stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml").to_return(:body => file_contents("pipelines_1.xml"))
+    end
 
-  def test_fetch_populates_necessary_fields
-    link = "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml"
-    pipeline = GoApiClient::Pipeline.new(link)
-    pipeline.fetch
+    def test_fetch_populates_necessary_fields
+      link = "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml"
+      pipeline = GoApiClient::Pipeline.new(link)
+      pipeline.fetch
 
-    assert_equal "1", pipeline.label
-    assert_equal ["Update README"], pipeline.commit_messages
-  end
+      assert_equal "1", pipeline.label
+      assert_equal ["Update README"], pipeline.commit_messages
+    end
+
+    def test_should_return_string_delimited_list_of_authors
+      link = "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml"
+      pipeline = GoApiClient::Pipeline.new(link).fetch
+      author_foo = Atom::Author.new(nil)
+      author_foo.name = 'foo'
+      author_foo.email = 'foo@example.com'
+      author_foo.uri =  'http://foo.example.com'
+
+      author_bar = Atom::Author.new(nil)
+      author_bar.name = 'bar'
+      author_bar.email = 'bar@example.com'
+      author_bar.uri =  'http://bar.example.com'
 
-  def test_pipeline_instance_identified_by_details_link
-    link = "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml"
-    pipeline = GoApiClient::Pipeline.new(link)
+      pipeline.stages << OpenStruct.new(:authors => [author_foo, author_bar])
+      assert_equal 'foo, bar', pipeline.authors
+    end
 
-    assert pipeline.same?(link)
-    assert(false == pipeline.same?("http://localhost:8153/go/api"))
   end
 end

data/test/go_api_client/stage_test.rb

@@ -1,32 +1,41 @@
 require "test_helper"
 
-class StageTest < Test::Unit::TestCase
+module GoApiClient
+  class StageTest < Test::Unit::TestCase
 
-  def setup()
-    stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/stages.xml").to_return(:body => file_contents("stages.xml"))
-    stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml").to_return(:body => file_contents("pipelines_1.xml"))
-    stub_request(:get, "http://localhost:8153/go/api/stages/1.xml").to_return(:body => file_contents("stages_1.xml"))
-    stub_request(:get, "http://localhost:8153/go/api/stages/2.xml").to_return(:body => file_contents("stages_2.xml"))
-    stub_request(:get, "http://localhost:8153/go/api/jobs/1.xml").to_return(:body => file_contents("jobs_1.xml"))
-    stub_request(:get, "http://localhost:8153/go/api/jobs/2.xml").to_return(:body => file_contents("jobs_2.xml"))
-  end
+    def setup
+      stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/1.xml").to_return(:body => file_contents("pipelines_1.xml"))
+      stub_request(:get, "http://localhost:8153/go/api/stages/1.xml").to_return(:body => file_contents("stages_1.xml"))
+      stub_request(:get, "http://localhost:8153/go/api/stages/2.xml").to_return(:body => file_contents("stages_2.xml"))
+      stub_request(:get, "http://localhost:8153/go/api/jobs/1.xml").to_return(:body => file_contents("jobs_1.xml"))
+      stub_request(:get, "http://localhost:8153/go/api/jobs/2.xml").to_return(:body => file_contents("jobs_2.xml"))
+    end
+
+    def test_stage_parsing
+      stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/stages.xml").to_return(:body => file_contents("stages.xml"))
+      pipelines = GoApiClient.runs("localhost:8153")
+      stages = pipelines.first.stages
 
-  def test_stage
-    pipelines = GoApiClient.runs("localhost:8153")
-    stages = pipelines.first.stages
-    
-    assert_equal 1, pipelines.count
-    assert_equal 2, stages.count
-    assert_equal "oogabooga <twgosaas@gmail.com>", pipelines.first.authors
-    stages.each do |stage|
-      assert_equal "oogabooga <twgosaas@gmail.com>", stage.authors.first.name
-      assert_equal "Failed", stage.result
+      assert_equal 1, pipelines.count
+      assert_equal 2, stages.count
+      assert_equal "oogabooga <twgosaas@gmail.com>", pipelines.first.authors
+      stages.each do |stage|
+        assert_equal "oogabooga <twgosaas@gmail.com>", stage.authors.first.name
+        assert_equal "Failed", stage.result
+      end
+      assert_equal "Acceptance", stages.first.name
+      assert_equal "Units", stages.last.name
+      assert_equal ["Update README"], pipelines.first.commit_messages
+
+      assert_equal "http://localhost:8153/go/files/defaultPipeline/1/Acceptance/1/Test/cruise-output/console.log", stages.first.jobs.first.console_log_url
+      assert_equal "http://localhost:8153/go/files/defaultPipeline/1/Units/1/Test/cruise-output/console.log", stages.last.jobs.first.console_log_url
     end
-    assert_equal "Acceptance", stages.first.name
-    assert_equal "Units", stages.last.name
-    assert_equal ["Update README"], pipelines.first.commit_messages
 
-    assert_equal "http://localhost:8153/go/files/defaultPipeline/1/Acceptance/1/Test/cruise-output/console.log", stages.first.jobs.first.console_log_url
-    assert_equal "http://localhost:8153/go/files/defaultPipeline/1/Units/1/Test/cruise-output/console.log", stages.last.jobs.first.console_log_url
+    def test_empty_atom_feed_should_not_throw_up
+      stub_request(:get, "http://localhost:8153/go/api/pipelines/defaultPipeline/stages.xml").to_return(:body => file_contents("stages_empty.xml"))
+      pipelines = GoApiClient.runs("localhost:8153")
+
+      assert pipelines.empty?
+    end
   end
 end

data/test/test_helper.rb

@@ -1,10 +1,15 @@
 require 'test/unit'
 require 'go_api_client'
-Dir["go_api_client/**/*.rb"].each {|f| require f} 
+require 'ostruct'
+Dir["go_api_client/**/*.rb"].each {|f| require f}
 require 'webmock/test_unit'
 
 def file_contents(file_name)
   File.read(File.expand_path("../../test/fixtures/#{file_name}", __FILE__))
 end
 
-
+module Test::Unit::Assertions
+  def assert_false(test, failure_message = nil)
+    assert(!test, failure_message || "Expected <#{test}> to be <false>.")
+  end
+end

metadata

@@ -1,19 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: go_api_client
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
 - Nikhil Mungel
+- Ketan Padegaonkar
+- Shishir Das
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-28 00:00:00.000000000Z
+date: 2012-03-07 00:00:00.000000000Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: &70210519943860 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70210519943860
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70186482958560 !ruby/object:Gem::Requirement
+  requirement: &70210519941940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,11 +34,13 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70186482958560
+  version_requirements: *70210519941940
 description: This gem parses atom feed generated by the Go Continuous Integration
   server and provides an OO representation of the pipelines and stages.
 email:
 - hyfather@gmail.com
+- KetanPadegaonkar@gmail.com
+- shishir.das@gmail.com
 executables:
 - go_api_client
 extensions: []
@@ -55,10 +70,11 @@ files:
 - test/fixtures/stages.xml
 - test/fixtures/stages_1.xml
 - test/fixtures/stages_2.xml
+- test/fixtures/stages_empty.xml
 - test/go_api_client/pipeline_test.rb
 - test/go_api_client/stage_test.rb
 - test/test_helper.rb
-homepage: ''
+homepage: https://github.com/ThoughtWorksInc/go-api-client
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -91,6 +107,7 @@ test_files:
 - test/fixtures/stages.xml
 - test/fixtures/stages_1.xml
 - test/fixtures/stages_2.xml
+- test/fixtures/stages_empty.xml
 - test/go_api_client/pipeline_test.rb
 - test/go_api_client/stage_test.rb
 - test/test_helper.rb