gnucash 1.2.0 → 1.2.1

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YTlmNWViYWRiZWVmNzlhYWE2NDdmODc1ZGIyYmFmZTEzNzBiOGJkYg==
-  data.tar.gz: !binary |-
-    YmFmZGY1YmQ0NzkxYTRlMGEzYjBiNjVjZDE0ZTBjNDU2MGQxMGVjMQ==
+SHA1:
+  metadata.gz: f91912ae36d38bc2c602c735564159fd14114e43
+  data.tar.gz: c95bc53e838d5595872d3edcb16945ba84e9d0d6
 SHA512:
-  metadata.gz: !binary |-
-    NzExNTNlOTgxZjk3MjI2ZWQ4ZmFlMDIwZDEwOTQ1YzZmN2I4MmEyM2E1YTlm
-    MGNlMjU1NzE2MjdkZTVmZDdmZWM5YzkzNDU3YmM2MThhNzk0NzMyYzViMzBk
-    Y2E0MTM4ZTNmYWIzOGUzNzk1ZDkwYWJjMjU2ZGYyYzEwNzBhNmE=
-  data.tar.gz: !binary |-
-    ZjY0NzY5YjZhN2Y0OWMyNTNmNzRmMjE3MTE0MjFhNjM0YWUzNTcxY2Y1ZmM1
-    ODg2Y2UzMzJhODJjODNiZDIxNDAwOTllMDFhOTVkNTZiYWEwYmIzZWRjYTZk
-    ZTQ1MTU4ODBlZDQ4ZTcxOTkxZWZhNjA5Y2M3ZGQzNGYwN2U0Mzg=
+  metadata.gz: 129f20266029b1d5e2529d3c23084b0d75f13988b87dceb8aad9b58e236ef5001a3014a857d584716aa1914543ee96d7cf449fc51226e896fd713788afe56a49
+  data.tar.gz: 479734374bb70a35026880996ef489923d18544c8b85fe82c2c8bdd4dbb1dba8590c6a60f72cc0edbf44b678ca3eb7593572f4a0303445901a5784314108a442

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/Gemfile.lock

@@ -0,0 +1,50 @@
+PATH
+  remote: .
+  specs:
+    gnucash (1.2.1)
+      nokogiri
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    diff-lcs (1.3)
+    docile (1.1.5)
+    json (2.1.0)
+    mini_portile2 (2.2.0)
+    nokogiri (1.8.0)
+      mini_portile2 (~> 2.2.0)
+    rake (12.0.0)
+    rdoc (5.1.0)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    simplecov (0.15.0)
+      docile (~> 1.1.0)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
+    yard (0.9.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  gnucash!
+  rake
+  rdoc
+  rspec
+  simplecov
+  yard
+
+BUNDLED WITH
+   1.10.6

data/README.md

@@ -1,6 +1,6 @@
 # Gnucash
 
-Ruby library for extracting data from GnuCash data files
+Ruby library for extracting data from XML GnuCash data files
 
 [![Gem Version](https://badge.fury.io/rb/gnucash.png)](http://badge.fury.io/rb/gnucash)
 

data/Rakefile

@@ -7,10 +7,9 @@ end
 require "bundler/gem_tasks"
 require "rake/clean"
 require "rspec/core/rake_task"
-require "rdoc/task"
 require "yard"
 
-CLEAN.include "rdoc"
+CLEAN.include "doc"
 CLEAN.include "pkg"
 CLEAN.include "coverage"
 
@@ -20,10 +19,4 @@ end
 
 RSpec::Core::RakeTask.new("spec")
 
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "Ruby library for extracting data from GnuCash data files"
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
 task :default => :spec

data/gnucash.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |gem|
   gem.version       = Gnucash::VERSION
   gem.authors       = ["Josh Holtrop"]
   gem.email         = ["jholtrop@gmail.com"]
-  gem.description   = %q{Ruby library for extracting data from GnuCash data files}
-  gem.summary       = %q{Extract data from GnuCash data files}
+  gem.description   = %q{Ruby library for extracting data from XML GnuCash data files}
+  gem.summary       = %q{Extract data from XML GnuCash data files}
   gem.homepage      = "https://github.com/holtrop/ruby-gnucash"
   gem.license       = "MIT"
 
@@ -22,10 +22,7 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency "simplecov"
   gem.add_development_dependency "rspec"
-  gem.add_development_dependency "rspec-core"
-  gem.add_development_dependency "rspec-expectations"
-  gem.add_development_dependency "rspec-mocks"
   gem.add_development_dependency "rake"
-  gem.add_development_dependency "rdoc"
   gem.add_development_dependency "yard"
+  gem.add_development_dependency "rdoc"
 end

data/lib/gnucash.rb

@@ -5,12 +5,18 @@ require_relative "gnucash/transaction"
 require_relative "gnucash/value"
 require_relative "gnucash/version"
 
-# Namespace module for gnucash gem functionality
+# Namespace module for gnucash gem functionality.
 module Gnucash
   # Open a GnuCash book from file.
+  #
   # The file can be either a plain-text XML file or a gzipped XML file.
-  # === Arguments
-  # +fname+ _String_:: Name of the file to open.
+  #
+  # @param fname [String]
+  #   The file name of the GnuCash file to open. Only XML format (or gzipped
+  #   XML format) GnuCash data files are recognized.
+  #
+  # @return [Book]
+  #   Gnucash::Book instance.
   def self.open(fname)
     Book.new(fname)
   end

data/lib/gnucash/account.rb

@@ -1,29 +1,29 @@
 module Gnucash
-  # Represent a GnuCash account object
+  # Represent a GnuCash account object.
   class Account
-    # _String_: The name of the account (unqualified)
+    # @return [String] The name of the account (unqualified).
     attr_reader :name
 
-    # _String_: The account description
+    # @return [String] The account description.
     attr_reader :description
 
-    # _String_: The account type (such as "EXPENSE")
+    # @return [String] The account type (such as "EXPENSE").
     attr_reader :type
 
-    # _String_: The GUID of the account
+    # @return [String] The GUID of the account.
     attr_reader :id
 
-    # _Array_: List of _AccountTransaction_ transactions associated with this
-    # account.
+    # @return [Array<AccountTransaction>] List of transactions associated with
+    # this account.
     attr_reader :transactions
 
-    # Boolean: whether the account is a placeholder or not
+    # @return [Boolean] Whether the account is a placeholder or not.
     attr_reader :placeholder
 
     # Create an Account object.
-    # === Arguments
-    # +book+ _Book_:: The Gnucash::Book containing the account
-    # +node+ _Nokogiri::XML::Node_:: Nokogiri XML node
+    #
+    # @param book [Book] The {Gnucash::Book} containing the account.
+    # @param node [Nokogiri::XML::Node] Nokogiri XML node.
     def initialize(book, node)
       @book = book
       @node = node
@@ -41,18 +41,24 @@ module Gnucash
       end
     end
 
-    # Return the fully qualified account name
+    # Return the fully qualified account name.
+    #
+    # @return [String] Fully qualified account name.
     def full_name
       @full_name ||= calculate_full_name
     end
 
-    # Internal method used to associate a transaction with the account
+    # Internal method used to associate a transaction with the account.
+    #
+    # @return [void]
     def add_transaction(act_txn)
       @transactions << act_txn
     end
 
     # Internal method used to complete initialization of the Account after
     # all transactions have been associated with it.
+    #
+    # @return [void]
     def finalize
       @transactions.sort! { |a, b| a.date <=> b.date }
       balance = Value.new(0)
@@ -65,16 +71,21 @@ module Gnucash
       end
     end
 
-    # Return the final balance of the account as a _Gnucash::Value_
+    # Return the final balance of the account as a {Value}.
+    #
+    # @return [Value] The final balance of the account.
     def final_balance
       return Value.new(0) unless @balances.size > 0
       @balances.last[:value]
     end
 
-    # Return the balance of the account as of the date given as a
-    # _Gnucash::Value_. Transactions that occur on the given date are included
-    # in the returned balance.
-    # date can be a _String_ ("YYYY-MM-DD") or _Date_ object.
+    # Return the balance of the account as of the date given as a {Value}.
+    # Transactions that occur on the given date are included in the returned
+    # balance.
+    #
+    # @param date [String, Date] Date on which to query the balance.
+    #
+    # @return [Value] Balance of the account as of the date given.
     def balance_on(date)
       date = Date.parse(date) if date.is_a?(String)
       return Value.new(0) unless @balances.size > 0
@@ -96,6 +107,7 @@ module Gnucash
 
     private
 
+    # @return [String] Fully qualified account name.
     def calculate_full_name
       prefix = ""
       if @parent_id

data/lib/gnucash/account_transaction.rb

@@ -1,21 +1,23 @@
 module Gnucash
   # Class to link a transaction object to an Account.
   class AccountTransaction
-    # _Gnucash::Value_: The transaction value for the linked account
+    # @return [Value] The transaction value for the linked account.
     attr_reader :value
 
     # Construct an AccountTransaction object.
+    #
     # This method is used internally when building a Transaction object.
-    # === Arguments
-    # +real_txn+ _Gnucash::Transaction_:: The linked Transaction object
-    # +value+ _Gnucash::Value_::
+    #
+    # @param real_txn [Transaction]
+    #   The linked Transaction object.
+    # @param value [Value]
     #   The value of the Transaction split for this account
     def initialize(real_txn, value)
       @real_txn = real_txn
       @value = value
     end
 
-    # Pass through any missing method calls to the linked Transaction object
+    # Pass through any missing method calls to the linked Transaction object.
     def method_missing(*args)
       @real_txn.send(*args)
     end

data/lib/gnucash/book.rb

@@ -2,24 +2,27 @@ require "zlib"
 require "nokogiri"
 
 module Gnucash
-  # Represent a GnuCash Book
+  # Represent a GnuCash Book.
   class Book
-    # _Array_ of _Gnucash::Account_ objects in the book
+    # @return [Array<Account>] Accounts in the book.
     attr_reader :accounts
 
-    # _Array_ of _Gnucash::Transaction_ objects in the book
+    # @return [Array<Transaction>] Transactions in the book.
     attr_reader :transactions
 
-    # _Date_ of the first transaction in the book
+    # @return [Date] Date of the first transaction in the book.
     attr_reader :start_date
 
-    # _Date_ of the last transaction in the book
+    # @return [Date] Date of the last transaction in the book.
     attr_reader :end_date
 
     # Construct a Book object.
-    # Normally called internally by Gnucash.open()
-    # === Arguments
-    # +fname+ _String_:: The file name of the GnuCash file to open.
+    #
+    # Normally called internally by {Gnucash.open}.
+    #
+    # @param fname [String]
+    #   The file name of the GnuCash file to open. Only XML format (or gzipped
+    #   XML format) GnuCash data files are recognized.
     def initialize(fname)
       begin
         @ng = Nokogiri.XML(Zlib::GzipReader.open(fname).read)
@@ -37,33 +40,35 @@ module Gnucash
     end
 
     # Return a handle to the Account object that has the given GUID.
-    # === Arguments
-    # +id+ _String_:: GUID
-    # === Return
-    # _Gnucash::Account_ or +nil+
+    #
+    # @param id [String] GUID.
+    #
+    # @return [Account, nil] Account object, or nil if not found.
     def find_account_by_id(id)
       @accounts.find { |a| a.id == id }
     end
 
     # Return a handle to the Account object that has the given fully-qualified
     # name.
-    # === Arguments
-    # +full_name+ _String_::
-    #   Fully-qualified account name (ex: "Expenses::Auto::Gas")
-    # === Return
-    # _Gnucash::Account_ or +nil+
+    #
+    # @param full_name [String]
+    #   Fully-qualified account name (ex: "Expenses::Auto::Gas").
+    #
+    # @return [Account, nil] Account object, or nil if not found.
     def find_account_by_full_name(full_name)
       @accounts.find { |a| a.full_name == full_name }
     end
 
     private
 
+    # @return [void]
     def build_accounts
       @accounts = @book_node.xpath('gnc:account').map do |act_node|
         Account.new(self, act_node)
       end
     end
 
+    # @return [void]
     def build_transactions
       @start_date = nil
       @end_date = nil
@@ -75,6 +80,7 @@ module Gnucash
       end
     end
 
+    # @return [void]
     def finalize
       @accounts.sort! do |a, b|
         a.full_name <=> b.full_name

data/lib/gnucash/transaction.rb

@@ -2,26 +2,27 @@ require "date"
 
 module Gnucash
   # Represent a GnuCash transaction.
+  #
   # Transactions have multiple splits with individual values.
   # Splits are created as AccountTransaction objects which are associated
   # with an individual account.
   class Transaction
-    # _Date_: The date of the transaction
+    # @return [Date] The date of the transaction.
     attr_reader :date
 
-    # _String_: The GUID of the transaction
+    # @return [String] The GUID of the transaction.
     attr_reader :id
 
-    # _String_: The description of the transaction
+    # @return [String] The description of the transaction.
     attr_reader :description
 
-    # _Array_ of _Hash_ with keys +account+ and +value+
+    # @return [Array<Hash>] Hashes with keys +:account+ and +:value+.
     attr_reader :splits
 
-    # Create a new Transaction object
-    # === Arguments
-    # +book+ _Book_:: The Gnucash::Book containing the transaction
-    # +node+ _Nokogiri::XML::Node_:: Nokogiri XML node
+    # Create a new Transaction object.
+    #
+    # @param book [Book] The {Gnucash::Book} containing the transaction.
+    # @param node [Nokogiri::XML::Node] Nokogiri XML node.
     def initialize(book, node)
       @book = book
       @node = node
@@ -29,7 +30,10 @@ module Gnucash
       @date = Date.parse(node.xpath('trn:date-posted/ts:date').text.split(' ').first)
       @description = node.xpath('trn:description').text
       @splits = node.xpath('trn:splits/trn:split').map do |split_node|
-        value = Value.new(split_node.xpath('split:value').text)
+        # Note: split:value represents the split value in the transaction's
+        # currency while split:quantity represents it in the currency
+        # associated with the account associated with this split.
+        value = Value.new(split_node.xpath('split:quantity').text)
         account_id = split_node.xpath('split:account').text
         account = @book.find_account_by_id(account_id)
         unless account

data/lib/gnucash/value.rb

@@ -4,21 +4,23 @@ module Gnucash
   class Value
     include Comparable
 
-    # _Fixnum_:: The raw, undivided integer value
+    # @return [Fixnum] The raw, undivided integer value.
     attr_reader :val
 
-    # Create a new Value object with value 0
+    # Create a new Value object with value 0.
+    #
+    # @return [Value] Zero value.
     def self.zero
       Value.new(0)
     end
 
-    # Construct a Value object
-    # === Arguments
-    # +val+ _String_ or _Fixnum_::
-    #   Either a _String_ in the form "1234/100" or an integer containing the
-    #   raw value
-    # +div+ _Fixnum_::
-    #   The divisor value to use (when +val+ is given as a _Fixnum_)
+    # Construct a Value object.
+    #
+    # @param val [String, Fixnum]
+    #   Either a String in the form "1234/100" or an integer containing the
+    #   raw value.
+    # @param div [Fixnum]
+    #   The divisor value to use (when +val+ is given as a Fixnum).
     def initialize(val, div = 100)
       if val.is_a?(String)
         if val =~ /^(-?\d+)\/(\d+)$/
@@ -35,8 +37,11 @@ module Gnucash
       end
     end
 
-    # Add to a Value object
-    # +other+ can be another Value or a Numeric
+    # Add to a Value object.
+    #
+    # @param other [Value, Numeric]
+    #
+    # @return [Value] Result of addition.
     def +(other)
       if other.is_a?(Value)
         Value.new(@val + other.val)
@@ -47,8 +52,11 @@ module Gnucash
       end
     end
 
-    # Subtract from a Value object
-    # +other+ can be another Value or a Numeric
+    # Subtract from a Value object.
+    #
+    # @param other [Value, Numeric]
+    #
+    # @return [Value] Result of subtraction.
     def -(other)
       if other.is_a?(Value)
         Value.new(@val - other.val)
@@ -59,13 +67,18 @@ module Gnucash
       end
     end
 
-    # Negate a Value
+    # Negate a Value.
+    #
+    # @return [Value] Result of negation.
     def -@
       Value.new(-@val, @div)
     end
 
-    # Multiply a Value object
-    # +other+ should be a Numeric
+    # Multiply a Value object.
+    #
+    # @param other [Numeric] Multiplier.
+    #
+    # @return [Value] Result of multiplication.
     def *(other)
       if other.is_a?(Numeric)
         (to_f * other).round(2)
@@ -74,8 +87,11 @@ module Gnucash
       end
     end
 
-    # Divide a Value object
-    # +other+ should be a Numeric
+    # Divide a Value object.
+    #
+    # @param other [Numeric] Divisor.
+    #
+    # @return [Value] Result of division.
     def /(other)
       if other.is_a?(Numeric)
         (to_f / other).round(2)
@@ -84,17 +100,23 @@ module Gnucash
       end
     end
 
-    # Represent the Value as a string (two decimal places)
+    # Represent the Value as a string (two decimal places).
+    #
+    # @return [String] Representation of value.
     def to_s
       sprintf("%.02f", to_f)
     end
 
-    # Convert the Value to a Float
+    # Convert the Value to a Float.
+    #
+    # @return [Float] Value of the value as a Float.
     def to_f
       @val / @div.to_f
     end
 
-    # Compare two Value objects
+    # Compare two Value objects.
+    #
+    # @return [Integer] Comparison result.
     def <=>(other)
       @val <=> other.val
     end

data/lib/gnucash/version.rb

@@ -1,4 +1,4 @@
 module Gnucash
   # gem version
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/gnucash/account_spec.rb

@@ -10,44 +10,44 @@ module Gnucash
     end
 
     it "gives access to the account name" do
-      @salary.name.should == "Salary"
+      expect(@salary.name).to eq "Salary"
     end
 
     it "gives access to the account description" do
-      @checking.description.should == "Checking Account"
+      expect(@checking.description).to eq "Checking Account"
     end
 
     it "gives access to the fully-qualified account name" do
-      @checking.full_name.should == "Assets:Current Assets:Checking Account"
+      expect(@checking.full_name).to eq "Assets:Current Assets:Checking Account"
     end
 
     it "gives access to the final balance" do
-      @checking.final_balance.should == Value.new(19743000)
+      expect(@checking.final_balance).to eq Value.new(19743000)
     end
 
     describe '.balance_on' do
       it "returns 0 if the given date is before the account's first transaction" do
-        @checking.balance_on("2006-12-12").should == Value.new(0)
+        expect(@checking.balance_on("2006-12-12")).to eq Value.new(0)
       end
 
       it "returns the final balance if the given date is after the account's last transaction" do
-        @checking.balance_on("2013-10-10").should == @checking.final_balance
+        expect(@checking.balance_on("2013-10-10")).to eq @checking.final_balance
       end
 
       it "returns the balance on the given date" do
-        @checking.balance_on("2012-12-25").should == Value.new(19688000)
+        expect(@checking.balance_on("2012-12-25")).to eq Value.new(19688000)
       end
 
       it "includes transactions that occur on the given date" do
-        @checking.balance_on("2007-03-27").should == Value.new(780000)
+        expect(@checking.balance_on("2007-03-27")).to eq Value.new(780000)
       end
     end
 
     it "stores whether the account was a placeholder" do
-      @assets.placeholder.should be_true
-      @checking.placeholder.should be_false
-      @income.placeholder.should be_true
-      @salary.placeholder.should be_false
+      expect(@assets.placeholder).to be_truthy
+      expect(@checking.placeholder).to be_falsey
+      expect(@income.placeholder).to be_truthy
+      expect(@salary.placeholder).to be_falsey
     end
   end
 end

data/spec/gnucash/book_spec.rb

@@ -3,11 +3,11 @@ module Gnucash
     context "with errors" do
       it "raises an error for unexpected XML" do
         gr = "gr"
-        Zlib::GzipReader.should_receive(:open).and_return(gr)
-        gr.should_receive(:read).and_return(nil)
+        expect(Zlib::GzipReader).to receive(:open).and_return(gr)
+        expect(gr).to receive(:read).and_return(nil)
         ng = "ng"
-        Nokogiri.should_receive(:XML).and_return(ng)
-        ng.should_receive(:xpath).with('/gnc-v2/gnc:book').and_return([])
+        expect(Nokogiri).to receive(:XML).and_return(ng)
+        expect(ng).to receive(:xpath).with('/gnc-v2/gnc:book').and_return([])
 
         expect { Gnucash::Book.new('file name') }.to raise_error "Error: Expected to find one gnc:book entry"
       end
@@ -20,19 +20,19 @@ module Gnucash
       end
 
       it "records the date of the earliest transaction" do
-        @subject.start_date.should == Date.parse("2007-01-01")
+        expect(@subject.start_date).to eq Date.parse("2007-01-01")
       end
 
       it "records the date of the last transaction" do
-        @subject.end_date.should == Date.parse("2012-12-28")
+        expect(@subject.end_date).to eq Date.parse("2012-12-28")
       end
 
       it "lets you find an account by id" do
-        @subject.find_account_by_id("67e6e7daadc35716eb6152769373e974").name.should == "Savings Account"
+        expect(@subject.find_account_by_id("67e6e7daadc35716eb6152769373e974").name).to eq "Savings Account"
       end
 
       it "lets you find an account by full name" do
-        @subject.find_account_by_full_name("Assets:Current Assets:Savings Account").id.should == "67e6e7daadc35716eb6152769373e974"
+        expect(@subject.find_account_by_full_name("Assets:Current Assets:Savings Account").id).to eq "67e6e7daadc35716eb6152769373e974"
       end
     end
   end

data/spec/gnucash/transaction_spec.rb

@@ -10,17 +10,17 @@ module Gnucash
         account_text = "account_text"
         date_text = "date_text"
 
-        text.stub(:text) {"hi there"}
-        node.should_receive(:xpath).with('trn:id').and_return(text)
-        date_text.should_receive(:text).and_return("2014-01-20")
-        node.should_receive(:xpath).with('trn:date-posted/ts:date').and_return(date_text)
-        value_text.should_receive(:text).and_return("1177/100")
-        account_text.should_receive(:text).and_return("a1s2d3f4")
-        split_node.should_receive(:xpath).with("split:value").and_return(value_text)
-        split_node.should_receive(:xpath).with("split:account").and_return(account_text)
-        node.should_receive(:xpath).with('trn:description').and_return(text)
-        node.should_receive(:xpath).with('trn:splits/trn:split').and_return([split_node])
-        book.should_receive(:find_account_by_id).and_return(nil)
+        allow(text).to receive(:text) {"hi there"}
+        expect(node).to receive(:xpath).with('trn:id').and_return(text)
+        expect(date_text).to receive(:text).and_return("2014-01-20")
+        expect(node).to receive(:xpath).with('trn:date-posted/ts:date').and_return(date_text)
+        expect(value_text).to receive(:text).and_return("1177/100")
+        expect(account_text).to receive(:text).and_return("a1s2d3f4")
+        expect(split_node).to receive(:xpath).with("split:quantity").and_return(value_text)
+        expect(split_node).to receive(:xpath).with("split:account").and_return(account_text)
+        expect(node).to receive(:xpath).with('trn:description').and_return(text)
+        expect(node).to receive(:xpath).with('trn:splits/trn:split').and_return([split_node])
+        expect(book).to receive(:find_account_by_id).and_return(nil)
 
         expect { Transaction.new(book, node) }.to raise_error /Could not find account/
       end
@@ -33,7 +33,7 @@ module Gnucash
       end
 
       it "keeps track of the transaction description" do
-        @txn.description.should == "Opening Balance"
+        expect(@txn.description).to eq "Opening Balance"
       end
     end
   end

data/spec/gnucash/value_spec.rb

@@ -2,7 +2,7 @@ module Gnucash
   describe Value do
     describe '.zero' do
       it 'creates a Value object with value 0' do
-        Value.zero.val.should == 0
+        expect(Value.zero.val).to eq 0
       end
     end
 
@@ -15,70 +15,70 @@ module Gnucash
     end
 
     it "allows construction from a string" do
-      Value.new("5678/100").val.should == 5678
+      expect(Value.new("5678/100").val).to eq 5678
     end
 
     it "converts the value to the expected string representation" do
-      Value.new("5678/100").to_s.should == "56.78"
-      Value.new("1000231455/100").to_s.should == "10002314.55"
+      expect(Value.new("5678/100").to_s).to eq "56.78"
+      expect(Value.new("1000231455/100").to_s).to eq "10002314.55"
     end
 
     it "allows adding two value objects" do
       a = Value.new("1234/100")
       b = Value.new("2345/100")
       c = a + b
-      c.to_s.should == "35.79"
+      expect(c.to_s).to eq "35.79"
     end
 
     it "allows adding a Value object to a Numeric" do
       a = Value.new("1234/100")
       b = 15
       c = a + b
-      c.should == 27.34
+      expect(c).to eq 27.34
     end
 
     it "allows subtracting two value objects" do
       a = Value.new("-12300/100")
       b = Value.new("99/100")
       c = a - b
-      c.to_s.should == "-123.99"
+      expect(c.to_s).to eq "-123.99"
     end
 
     it "allows subtracting a Numeric from a Value object" do
       a = Value.new("890/100")
       b = 7.8
       c = a - b
-      c.should == 1.1
+      expect(c).to eq 1.1
     end
 
     it "allows negating a Value object" do
       a = Value.new("123/100")
       b = -a
-      b.to_s.should == "-1.23"
+      expect(b.to_s).to eq "-1.23"
     end
 
     it "allows multiplying a Value by a Numeric" do
       a = Value.new("100/100")
       b = 12
       c = a * b
-      c.should == 12.00
+      expect(c).to eq 12.00
     end
 
     it "allows dividing a Value by a Numeric" do
       a = Value.new("150000/100")
       b = 150
       c = a / b
-      c.should == 10.0
+      expect(c).to eq 10.0
     end
 
     it "formats the number with two decimal places" do
-      Value.new("1400/100").to_s.should == "14.00"
+      expect(Value.new("1400/100").to_s).to eq "14.00"
     end
 
     it "supports comparisons between two Value objects" do
-      Value.new("1234/100").should == Value.new(1234)
-      (Value.new("89/100") < Value.new("100/100")).should be_true
-      (Value.new("1234/100") > Value.new("222/100")).should be_true
+      expect(Value.new("1234/100")).to eq Value.new(1234)
+      expect((Value.new("89/100") < Value.new("100/100"))).to be_truthy
+      expect((Value.new("1234/100") > Value.new("222/100"))).to be_truthy
     end
 
     context "errors" do

data/spec/gnucash_spec.rb

@@ -2,11 +2,11 @@ describe Gnucash do
   describe '.open' do
     it 'opens a gzipped gnucash book' do
       book = Gnucash.open("spec/books/sample.gnucash")
-      book.is_a?(Gnucash::Book).should be_true
+      expect(book.is_a?(Gnucash::Book)).to be_truthy
     end
     it 'opens a plain text gnucash book' do
       book = Gnucash.open("spec/books/sample-text.gnucash")
-      book.is_a?(Gnucash::Book).should be_true
+      expect(book.is_a?(Gnucash::Book)).to be_truthy
     end
   end
 end

metadata

@@ -1,151 +1,110 @@
 --- !ruby/object:Gem::Specification
 name: gnucash
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Josh Holtrop
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-20 00:00:00.000000000 Z
+date: 2017-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-core
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-expectations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec-mocks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Ruby library for extracting data from GnuCash data files
+description: Ruby library for extracting data from XML GnuCash data files
 email:
 - jholtrop@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -175,20 +134,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
-summary: Extract data from GnuCash data files
+summary: Extract data from XML GnuCash data files
 test_files:
 - spec/books/sample-text.gnucash
 - spec/books/sample.gnucash
@@ -198,4 +157,3 @@ test_files:
 - spec/gnucash/value_spec.rb
 - spec/gnucash_spec.rb
 - spec/spec_helper.rb
-has_rdoc: