gnista 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36552dd994d8f7ed18d1f26290fca5eaab21608f
-  data.tar.gz: 778bd89aef04ff8f9ef1e2e1e7e2b3d24c0c4cd5
+  metadata.gz: ceb37e2f495af129a1626ca3cc184252378a2200
+  data.tar.gz: a61becb74a8c88c437e918c9ac5771fe3e06134e
 SHA512:
-  metadata.gz: 8ebbd55366f654164ea6b182b90526a64691423331580572253b316c1beb2b5a07b396db8c65e301de84c077e6884cc2759e5f10208ab163af3d02fdaed39024
-  data.tar.gz: bf3ce23592e12a42f12f11ff678a483efdd9ceb2128330ad2446eb645fbd858ea5a225b7e7ffb6f0a11081c1497133d7058858fd7a2fb52cb2fa4a1f53b4bc88
+  metadata.gz: 76b51e8b8e8764535b94cb7c163519c6e6024e8a7d8cb165f23a73283e2bcf8994f11cf36fde211c922a924f88f0639a0c3be8fb7567b4d4ca7d50423bb02e1a
+  data.tar.gz: 60320d0666a4bd17a27290f2aebbf15eff3f2cac1909ec4f4bd9026dd20f5d65631107f9f968529a0d98c82bcedf1a5cf02e37b8fac1f0952a7063188ff91c42

data/HISTORY.md

@@ -1,3 +1,17 @@
+# Version 0.0.5
+
+Release date 2014-03-26
+
+### Added
+
+* Useful error messages on build.
+* Rubinius compatible tests.
+
+### Fixed
+
+* SEGFAULT on interrupted initialization.
+* Boolean consistency.
+
 # Version 0.0.4
 
 Release date 2013-09-16
@@ -47,4 +61,4 @@ Release date 2013-09-12
 
 Release date 2013-09-11
 
-__Initial release__
+__Initial release__

data/ext/gnista/extconf.rb

@@ -3,7 +3,7 @@ require 'mkmf'
 extension_name = 'gnista'
 dir_config(extension_name)
 
-have_library('sparkey') or raise
-have_header('sparkey/sparkey.h') or raise
+have_library('sparkey') or raise "Sparkey is missing"
+have_header('sparkey/sparkey.h') or raise "sparkey.h could not be found"
 
-create_makefile(extension_name)
+create_makefile(extension_name)

data/ext/gnista/gnista.c

@@ -1,24 +1,24 @@
 #include <ruby.h>
 #include <sparkey/sparkey.h>
 
-typedef int bool;
+typedef uint8_t bool;
 #define true 1
 #define false 0
 
 
 typedef struct instance_logwriter {
 	sparkey_logwriter *logwriter;
-	int open;
+	bool open;
 } instance_logwriter;
 
 typedef struct instance_logreader {
 	sparkey_logreader *logreader;
-	int open;
+	bool open;
 } instance_logreader;
 
 typedef struct instance_hashreader {
 	sparkey_hashreader *hashreader;
-	int open;
+	bool open;
 } instance_hashreader;
 
 /********************************************************************************/
@@ -57,6 +57,7 @@ static void dealloc_logwriter(void *p) {
 
 static VALUE alloc_logwriter(VALUE klass) {
 	instance_logwriter *i_logwriter = ALLOC(instance_logwriter);
+	i_logwriter->open = false;
 	return Data_Wrap_Struct(klass, 0, dealloc_logwriter, i_logwriter);
 }
 
@@ -91,7 +92,6 @@ static VALUE method_logwriter_initialize(VALUE self, VALUE args) {
 
 	if (returncode != SPARKEY_SUCCESS) {
 		raise_sparkey(returncode);
-		i_logwriter->open = false;
 	} else {
 		i_logwriter->open = true;
 		rb_iv_set(self, "@logpath", rb_ary_entry(args, 0));
@@ -186,6 +186,7 @@ static void dealloc_logreader(void *p) {
 
 static VALUE alloc_logreader(VALUE klass) {
 	instance_logreader *i_logreader = ALLOC(instance_logreader);
+	i_logreader->open = false;
 	return Data_Wrap_Struct(klass, 0, dealloc_logreader, i_logreader);
 }
 
@@ -204,7 +205,6 @@ static VALUE method_logreader_initialize(VALUE self, VALUE filename) {
 
 	if (returncode != SPARKEY_SUCCESS) {
 		raise_sparkey(returncode);
-		i_logreader->open = false;
 	} else {
 		i_logreader->open = true;
 		rb_iv_set(self, "@logpath", filename);
@@ -238,7 +238,7 @@ static VALUE method_logreader_each(VALUE self) {
 	VALUE del_sym = ID2SYM(rb_intern("delete"));
 	uint8_t *keybuf = malloc(sparkey_logreader_maxkeylen(i_logreader->logreader));
 	uint8_t *valuebuf = malloc(sparkey_logreader_maxvaluelen(i_logreader->logreader));
-	while (1) {
+	while (true) {
 		returncode = sparkey_logiter_next(logiter, i_logreader->logreader);
 
 		if (sparkey_logiter_state(logiter) != SPARKEY_ITER_ACTIVE) {
@@ -332,6 +332,7 @@ static void dealloc_hashreader(void *p) {
 
 static VALUE alloc_hashreader(VALUE klass) {
 	instance_hashreader *i_hashreader = ALLOC(instance_hashreader);
+	i_hashreader->open = false;
 	return Data_Wrap_Struct(klass, 0, dealloc_hashreader, i_hashreader);
 }
 
@@ -378,7 +379,6 @@ static VALUE method_hash_initialize(VALUE self, VALUE hash_filename, VALUE log_f
 
 	if (returncode != SPARKEY_SUCCESS) {
 		raise_sparkey(returncode);
-		i_hashreader->open = false;
 	} else {
 		i_hashreader->open = true;
 		rb_iv_set(self, "@hashpath", hash_filename);
@@ -412,7 +412,7 @@ static VALUE method_hash_each(VALUE self) {
 
 	uint8_t *keybuf = malloc(sparkey_logreader_maxkeylen(logreader));
 	uint8_t *valuebuf = malloc(sparkey_logreader_maxvaluelen(logreader));
-	while (1) {
+	while (true) {
 		returncode = sparkey_logiter_hashnext(logiter, i_hashreader->hashreader);
 
 		if (sparkey_logiter_state(logiter) != SPARKEY_ITER_ACTIVE) {

data/lib/gnista/version.rb

@@ -1,3 +1,3 @@
 module Gnista
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/test/test_commands.rb

@@ -238,9 +238,7 @@ describe Gnista do
     end
 
     logreader = Gnista::Logreader.new log_path
-    _,value,_ = logreader.first
-    value.must_equal "value1"
-
+    logreader.count.must_equal 1
     logreader.close!
   end
 

data/test/test_gnista.rb

@@ -54,4 +54,18 @@ describe Gnista do
     FileUtils.rm log_path
   end
 
+  it "will throw exception on invalid arguments" do
+    assert_raises TypeError do
+      Gnista::Logwriter.new 123
+    end
+
+    assert_raises GnistaException do
+      Gnista::Logreader.new "none_existing_file"
+    end
+
+    assert_raises GnistaException do
+      Gnista::Hash.new "none_existing_file", "none_existing_file"
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gnista
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Emanuel Andersson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-16 00:00:00.000000000 Z
+date: 2014-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler