gnip-rule 0.3.1 → 0.4.0

data/lib/gnip-rule/rule.rb

@@ -58,7 +58,7 @@ module GnipRule
     end
 
     def too_many_positive_terms?
-      @value.scan(/\b\w+|\"[\-\s\w]+\"\b/).size > 10
+      @value.scan(/\b\w+|\"[\-\s\w]+\"\b/).size > 30
     end
 
     def contains_empty_source?

data/lib/gnip-rule/version.rb

@@ -1,3 +1,3 @@
 module GnipRule
-  VERSION = '0.3.1'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gnip-rule
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-04 00:00:00.000000000 Z
+date: 2013-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 10.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 10.0.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -34,7 +34,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -42,7 +42,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 2.13.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -74,7 +74,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.6.2
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -82,7 +82,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.5.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -90,7 +90,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.5.0
 - !ruby/object:Gem::Dependency
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
@@ -162,7 +162,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.7.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -170,7 +170,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.7.7
 description: Ruby library for working with the Gnip Rules API
 email:
 - me@eriwen.com
@@ -178,24 +178,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .pryrc
-- .rvmrc
-- .travis.yml
-- CONTRIBUTING.md
-- Gemfile
-- Guardfile
-- LICENSE
-- README.md
-- Rakefile
-- gnip-rule.gemspec
-- lib/gnip-rule.rb
 - lib/gnip-rule/client.rb
 - lib/gnip-rule/rule.rb
 - lib/gnip-rule/version.rb
-- spec/gnip-rule/client_spec.rb
-- spec/gnip-rule/rule_spec.rb
-- spec/spec-helper.rb
+- lib/gnip-rule.rb
 homepage: https://github.com/eriwen/gnip-rule
 licenses: []
 post_install_message: 
@@ -216,12 +202,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: gnip-rule
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Ruby library for working with the Gnip Rules API
-test_files:
-- spec/gnip-rule/client_spec.rb
-- spec/gnip-rule/rule_spec.rb
-- spec/spec-helper.rb
-has_rdoc: 
+test_files: []

data/.gitignore

@@ -1,6 +0,0 @@
-*.gem
-.bundle
-.idea
-Gemfile.lock
-pkg/*
-.rbx

data/.pryrc

@@ -1,2 +0,0 @@
-$: << "/Users/eric/src/gnip-rule/lib/"
-require 'gnip-rule'

data/.rvmrc

@@ -1 +0,0 @@
-rvm use 1.9.3@gnip-rule --create

data/.travis.yml

@@ -1,7 +0,0 @@
-language: ruby
-rvm:
-  - 1.9.3
-  - 1.8.7
-  - jruby-19mode
-  - rbx-19mode
-script: rspec spec

data/CONTRIBUTING.md

@@ -1,9 +0,0 @@
-When submitting pull requests, please do the following to make it easier to incorporate your changes:
-
-* Include unit and/or functional specs that validate changes you're making.
-* Rebase your changes onto the HEAD of my fork if you can do so cleanly.
-* If submitting additional functionality, provide an example of how to use it.
-* Please keep code style consistent with surrounding code.
-
-## Testing
-You can run all tests by simply running `bundle exec rspec spec` from your favorite shell.

data/Gemfile

@@ -1,4 +0,0 @@
-source 'http://rubygems.org'
-
-# Specify your gem's dependencies in gnip-rule.gemspec
-gemspec

data/Guardfile

@@ -1,5 +0,0 @@
-guard 'rspec', :cli => '--drb --format Fuubar --color', :version => 2 do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-end

data/LICENSE

@@ -1,19 +0,0 @@
-Copyright (c) 2012 Eric Wendelin
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of
-this software and associated documentation files (the "Software"), to deal in
-the Software without restriction, including without limitation the rights to
-use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
-of the Software, and to permit persons to whom the Software is furnished to do
-so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

data/README.md

@@ -1,40 +0,0 @@
-# gnip-rule [![Build Status](https://secure.travis-ci.org/eriwen/gnip-rule.png)](http://travis-ci.org/eriwen/gnip-rule) [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/eriwen/gnip-rule)
-This gem simplifies the effort to add/delete/list rules using the [Gnip Rules API](http://support.gnip.com/customer/portal/articles/477713-rules-methods-documentation). It handles HTTP request/response and helps your rules conform to Gnip's restrictions.
-
-## Installation
-`gem install gnip-rule` or add the following to your `Gemfile`:
-
-```ruby
-gem 'gnip-rule', '~> 0.3.1'
-```
-
-## Usage
-
-```ruby
-require 'gnip-rule'
-
-rules = GnipRule::Client.new(API_URL, USERNAME, PASSWORD)
-
-# Add as a String, Rule, or Array of either
-rules.add('foo')
-rules.add('bar', 'tag')
-rules.add(['foo', 'bar', 'baz'], 'tag')
-rules.add(GnipRule::Rule.new('value', 'tag'))
-rules.add([GnipRule::Rule.new('foo', 'bar'), GnipRule::Rule.new('baz', 'tag2')])
-
-# Same with delete
-rules.delete('baz', 'tag')
-rules.delete(['foo', 'bar'])
-rules.delete(GnipRule::Rule.new('value', 'tag'))
-
-# Get all rules
-rules_list = rules.list()
-rules_list.each { |rule| rule.valid? }
-jsonified = rules_list.map { |rule| rule.as_json `}
-rules_tagged_foo = rules_list.select { |rule| rule.tag == 'foo' }
-```
-
-## License
-Licenced under the [MIT License](http://www.opensource.org/licenses/mit-license.php)
-
-I provide this software free of charge. If you find it helpful, please endorse me on coderwall: [![endorse](http://api.coderwall.com/eriwen/endorsecount.png)](http://coderwall.com/eriwen)

data/Rakefile

@@ -1,10 +0,0 @@
-require 'bundler'
-Bundler::GemHelper.install_tasks
-
-require 'rspec/core/rake_task'
-
-desc "Run all RSpec tests"
-RSpec::Core::RakeTask.new(:spec)
-
-task :default => :spec
-task :test => [:spec]

data/gnip-rule.gemspec

@@ -1,44 +0,0 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path('../lib', __FILE__)
-require 'gnip-rule/version'
-
-Gem::Specification.new do |s|
-  s.name        = 'gnip-rule'
-  s.version     = GnipRule::VERSION
-
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Eric Wendelin']
-  s.email       = ['me@eriwen.com']
-  s.homepage    = 'https://github.com/eriwen/gnip-rule'
-  s.summary     = %q{Ruby library for working with the Gnip Rules API}
-  s.description = s.summary
-
-  s.rubyforge_project = 'gnip-rule'
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ['lib']
-
-  s.add_development_dependency 'rake', '~> 0.9.2'
-  s.add_development_dependency 'rspec', '~> 2.10.0'
-  s.add_development_dependency 'webmock', '~> 1.8.11'
-  s.add_development_dependency 'guard', '~> 1.4.0'
-  s.add_development_dependency 'guard-rspec', '~> 1.2.0'
-  s.add_development_dependency 'fuubar', '~> 1.1.0'
-
-  if RbConfig::CONFIG['host_os'] =~ /darwin/
-    s.add_development_dependency 'rb-fsevent'
-    s.add_development_dependency 'ruby_gntp'
-  elsif RbConfig::CONFIG['host_os'] =~ /linux/
-    s.add_development_dependency 'rb-inotify'
-    s.add_development_dependency 'libnotify'
-  elsif RbConfig::CONFIG['host_os'] =~ /msmin|mingw/
-    s.add_development_dependency 'wdm'
-    s.add_development_dependency 'rb-notifu'
-  end
-
-  s.add_dependency 'rest-client', '~> 1.6.7'
-  s.add_dependency 'json', '~> 1.7.0'
-  s.add_dependency 'jruby-openssl' if RUBY_PLATFORM == 'java'
-end

data/spec/gnip-rule/client_spec.rb

@@ -1,90 +0,0 @@
-require 'spec-helper'
-
-require 'gnip-rule/client'
-
-describe GnipRule::Client do
-  let(:xml_base_url) { 'https://api.gnip.com:443/accounts/foo/publishers/twitter/streams/track/prod/rules.xml' }
-  let(:base_url) { 'https://api.gnip.com:443/accounts/foo/publishers/twitter/streams/track/prod/rules.json' }
-  let(:base_url_with_auth) { 'https://username:password@api.gnip.com:443/accounts/foo/publishers/twitter/streams/track/prod/rules.json' }
-
-  describe '.new' do
-    it 'should convert XML URLs to JSON' do
-      GnipRule::Client.new(xml_base_url, 'username', 'password').url.should == base_url
-    end
-
-    it 'should not munch JSON URLs' do
-      GnipRule::Client.new(base_url, 'username', 'password').url.should == base_url
-    end
-
-  end
-
-  describe 'instance' do
-    subject { GnipRule::Client.new(base_url, 'username', 'password') }
-
-    describe '#add' do
-      it 'should POST rule to the given URL with given credentials' do
-        stub_request(:post, base_url_with_auth).
-            with(:body => '{"rules":[{"value":"value","tag":"tag"}]}').
-            to_return(:status => 200, :body => '', :headers => {})
-        subject.add('value', 'tag')
-      end
-
-      it 'should raise an error if Gnip returns HTTP error' do
-        stub_request(:post, base_url_with_auth).
-            with(:body => '{"rules":[{"value":"value","tag":"tag"}]}').
-            to_return(:status => 401, :body => 'Error message', :headers => {})
-        lambda { subject.add('value', 'tag') }.should raise_error
-      end
-    end
-
-    describe '#delete' do
-      it 'should POST rule json to a URL with given credentials' do
-        stub_request(:post, "#{base_url_with_auth}?_method=delete").
-            with(:body => '{"rules":[{"value":"value","tag":"tag"}]}').
-            to_return(:status => 200, :body => '', :headers => {})
-        subject.delete('value', 'tag')
-      end
-    end
-
-    describe '#list' do
-      it 'should GET a URL with given credentials' do
-        stub_request(:get, base_url_with_auth).
-            to_return(:status => 200, :body => '{"rules":[{"value":"foo","tag":"baz"},{"value":"bar","tag":"baz"}]}')
-        rules = subject.list()
-        rules.size.should == 2
-        rules.map { |r| r.valid?.should == true }
-      end
-
-      it 'should raise an error if Gnip returns HTTP error' do
-        stub_request(:get, base_url).
-            with(:body => '{"rules":[{"value":"value","tag":"tag"}]}').
-            to_return(:status => 401, :body => 'Error message', :headers => {})
-        lambda { subject.list() }.should raise_error
-      end
-    end
-
-    describe '#jsonify_rules' do
-      it 'should JSONify Strings' do
-        json = subject.gen_json_payload('foo', 'bar')
-        json.should == '{"rules":[{"value":"foo","tag":"bar"}]}'
-      end
-
-      it 'should JSONify Rules' do
-        json = subject.gen_json_payload(GnipRule::Rule.new('baz', 'foo'))
-        json.should == '{"rules":[{"value":"baz","tag":"foo"}]}'
-      end
-
-      it 'should JSONify an Array of Strings with a tag' do
-        json = subject.gen_json_payload(['foo', 'bar'], 'baz')
-        json.should == '{"rules":[{"value":"foo","tag":"baz"},{"value":"bar","tag":"baz"}]}'
-      end
-
-      it 'should JSONify an Array of Rules' do
-        rule1 = GnipRule::Rule.new('baz', 'foo')
-        rule2 = GnipRule::Rule.new('bar', 'thing')
-        json = subject.gen_json_payload([rule1, rule2])
-        json.should == '{"rules":[{"value":"baz","tag":"foo"},{"value":"bar","tag":"thing"}]}'
-      end
-    end
-  end
-end

data/spec/gnip-rule/rule_spec.rb

@@ -1,58 +0,0 @@
-require 'spec-helper'
-
-require 'gnip-rule/rule'
-
-describe GnipRule::Rule do
-  describe '#initialize' do
-    it 'should allow an optional tag' do
-      rule = GnipRule::Rule.new('value')
-      rule.tag.should be_nil
-
-      rule_with_tag = GnipRule::Rule.new('value', 'tag')
-      rule_with_tag.tag.should == 'tag'
-    end
-  end
-
-  describe '#valid?' do
-    it 'should consider rules with "stop words" to be invalid' do
-      GnipRule::Rule.new('an value').should_not be_valid
-    end
-    it 'should consider rules that are too long to be invalid' do
-      rule = GnipRule::Rule.new('01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789')
-      rule.should_not be_valid
-    end
-    it 'should consider empty sources to be invalid' do
-      GnipRule::Rule.new('foo source: bar').should_not be_valid
-    end
-    it 'should consider negative ORs to be invalid' do
-      GnipRule::Rule.new('-iphone OR ipad').should_not be_valid
-    end
-    it 'should consider rules with more than 10 positive terms invalid' do
-      GnipRule::Rule.new('one two three four five six seven eight nine ten eleven').should_not be_valid
-    end
-    it 'should consider stop words within quotes to be valid' do
-      GnipRule::Rule.new('"foo the bar" baz').should be_valid
-    end
-    it 'should consider rules without "stop words" to be valid' do
-      GnipRule::Rule.new('value').should be_valid
-    end
-  end
-
-  describe '#to_json' do
-    it 'should omit tag if tag not defined' do
-      rule = GnipRule::Rule.new('foo')
-      rule.to_json.should == '{"value":"foo"}'
-    end
-    it 'should add tag if defined' do
-      rule = GnipRule::Rule.new('foo', 'bar')
-      rule.to_json.should == '{"value":"foo","tag":"bar"}'
-    end
-  end
-
-  describe '#to_rule' do
-    it 'should return itself' do
-      rule = GnipRule::Rule.new('foo', 'bar')
-      rule.to_rule.should == rule
-    end
-  end
-end

data/spec/spec-helper.rb

@@ -1,7 +0,0 @@
-require 'bundler'
-Bundler.setup
-
-require 'rspec'
-require 'webmock/rspec'
-
-WebMock.disable_net_connect!