gnar-style 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c222fc1471d241fe62e1afe3046348625896a2aef836a28eca5684a7622e680d
-  data.tar.gz: 47dba4a6d06015d7d11296fd852a5cd1fc5c7ca1197612e2f329f4e791358c8e
+  metadata.gz: 914d7ad97c12ec17319105f392c94eb1a438ca6af3ae13596d332c6fc588f55e
+  data.tar.gz: 89f4fd1fb7ba1e97f2b576d1391f801e8eb279169505448b740e7af7193f3287
 SHA512:
-  metadata.gz: 3efe3411beb63fc6cb5b2430e34f7e45ccf74919d5db2247d7cae55a057d52886f41b089bdee82a35f8b46d754036e2993007c4c5d3a4ae96432fd6dd4c26f1a
-  data.tar.gz: 9e159330e68ffa66a74270a5448d702508998789f73deb753c741117a4fcfe19e9ab36b7481d2afa84a2578e920e6d4caa167d37261d654f7e612d3ffe7a6048
+  metadata.gz: 5e02261cd29fc55d57fd3ba8e9c7472c4142fa8507184089c2a7ff4751c12a4fc867119907f1e5200474c7b0aa08171a8515db75dd4801b2d68c4aa996892641
+  data.tar.gz: 41a466d4a3b62cc98a1538b77dd17db86a9586b60c680193e3f8ba12b6d1a9f97889522e02e461d4c56415cd94a2bb34c310bcf6d189ca74338d5c21b5e3c9b0

data/.circleci/config.yml

@@ -0,0 +1,36 @@
+# Ruby CircleCI 2.0 configuration file
+#
+# Check https://circleci.com/docs/2.0/language-ruby/ for more details
+#
+version: 2
+jobs:
+  build:
+    docker:
+      - image: circleci/ruby:2.6.2
+        environment:
+          RAILS_ENV: test
+    steps:
+      - checkout
+
+      # Download and cache dependencies
+      - restore_cache:
+          keys:
+          - gnar-style-{{ checksum "gnar-style.gemspec" }}
+          # fallback to using the latest cache if no exact match is found
+          - gnar-style-
+
+      # Bundle install dependencies
+      - run:
+          name: install dependencies
+          command: bundle install --path vendor/bundle
+
+      # Store bundle cache
+      - save_cache:
+          paths:
+            - vendor/bundle
+          key: gnar-style-{{ checksum "gnar-style.gemspec" }}
+
+      # Tests
+      - run:
+          name: RSpec
+          command: bundle exec rspec

data/CHANGELOG.md

@@ -1,13 +1,41 @@
 ## Current release (in development)
 
+## 0.6.0 - 2019-04-23
+
+* Remove Style/IfUnlessModifier cop. [#33](https://github.com/TheGnarCo/gnar-style/pull/33)
+
+  [Kevin Murphy](https://github.com/kevin-j-m)
+
+* Allow conditional assignment in ternaries. [#30](https://github.com/TheGnarCo/gnar-style/pull/30)
+
+  [Andrew Palmer](https://github.com/apalmer0)
+
+* Remove non-null database validation default value cop. [#29](https://github.com/TheGnarCo/gnar-style/pull/29)
+
+  [Andrew Palmer](https://github.com/apalmer0)
+
+* Enforce consistent array indentation. [#28](https://github.com/TheGnarCo/gnar-style/pull/28)
+
+  [Andrew Palmer](https://github.com/apalmer0)
+
+* Exclude `bin/` and `node_modules` directories. [#26](https://github.com/TheGnarCo/gnar-style/pull/26)
+
+  [Zach Fletcher](https://github.com/zfletch)
+
+* Expand empty methods. [#23](https://github.com/TheGnarCo/gnar-style/pull/23)
+
+  [Blake Williams](https://github.com/BlakeWilliams)
+
 ## 0.5.0 - 2018-07-17
 
 * Update conditional assignment preferred style. [#20](https://github.com/TheGnarCo/gnar-style/pull/20)
+
   [Kevin Murphy](https://github.com/kevin-j-m)
 
 ## 0.4.0 - 2018-03-05
 
 * Update trailing comma literal cops for new rubocop version. [#17](https://github.com/TheGnarCo/gnar-style/pull/17)
+
   [Kevin Murphy](https://github.com/kevin-j-m)
 
 ## 0.3.0 - 2017-11-03

data/README.md

@@ -120,6 +120,10 @@ gnar-style provides defaults for three different scenarios. You can specify whic
 * `rubocop_rails.yml` - Styling for use in a rails project.
 * `rubocop_gem.yml` - Styling for use in a gem.
 
+## Philosophy
+
+Our adherence to our style guide is based on the general case, and not to ensure there are no exceptions. Our philosophy is to use the guide precisely in that way - as a guide. It's not meant as a command that must be taken, but a suggestion to be considered. To the extent that deviations make sense sometimes - great, deviate. However, having rubocop start the discussion and if nothing else, having the author justify to themselves why this deviation is warranted, can be valuable.  
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/TheGnarCo/gnar-style. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/gnar/style/version.rb

@@ -1,5 +1,5 @@
 module Gnar
   module Style
-    VERSION = "0.5.0".freeze
+    VERSION = "0.6.0".freeze
   end
 end

data/rubocop/rubocop.yml

@@ -1,21 +1,54 @@
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
+Layout/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Metrics/BlockLength:
   Exclude:
-    - 'Gemfile'
+    - 'spec/**/*'
 
 Metrics/LineLength:
   Max: 100
   Severity: refactor
 
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/**/*'
+
+Rails/NotNullColumn:
+  Enabled: false
+
 Style/ConditionalAssignment:
   EnforcedStyle: assign_inside_condition
+  IncludeTernaryExpressions: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/Documentation:
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/ParenthesesAroundCondition:
   Enabled: false
 
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+  Exclude:
+    - 'Gemfile'
+
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 Style/TrailingCommaInArguments:
   EnforcedStyleForMultiline: comma
 
@@ -24,23 +57,3 @@ Style/TrailingCommaInArrayLiteral:
 
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: comma
-
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-Style/ParenthesesAroundCondition:
-  Enabled: false
-
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-Layout/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
-
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*'
-
-Metrics/ModuleLength:
-  Exclude:
-    - 'spec/**/*'

data/rubocop/rubocop_rails.yml

@@ -3,6 +3,8 @@ inherit_from: rubocop.yml
 AllCops:
   Exclude:
     - db/schema.rb
+    - 'bin/**/*'
+    - 'node_modules/**/*'
     - 'vendor/**/*'
 
 Rails:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gnar-style
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - The Gnar Company
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-17 00:00:00.000000000 Z
+date: 2019-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -88,6 +88,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -126,8 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Style guide default configuration for The Gnar Company