gmoney 0.4.2 → 0.4.3

data/README.rdoc

@@ -82,6 +82,9 @@ Transactions
     > transaction.price = 3.50
     > transaction.save #returns transaction object
     
+    Note:  While updating transactions it is not possible to change the portfolio or ticker property as these values are used
+           by Google to identify specific transactions.
+    
   Deleting
     > GMoney::Transaction.delete '2/NASDAQ:GOOG/1'
   

data/Rakefile

@@ -20,7 +20,7 @@ desc "Gemify GMoney"
   namespace :gemify do
   Echoe.new('gmoney', GMoney.version) do |p|
     p.description = "A gem for interacting with the Google Finance API"
-    p.url = "http://github.com/jspradlin/gmoney"
+    p.url = "http://www.justinspradlin.com/programming/introducing-gmoney-a-rubygem-for-interacting-with-the-google-finance-api/"
     p.author = "Justin Spradlin"
     p.email = "jspradlin@gmail.com"
     p.ignore_pattern = ["coverage/*", "*~"]

data/gmoney.gemspec

@@ -2,16 +2,16 @@
 
 Gem::Specification.new do |s|
   s.name = %q{gmoney}
-  s.version = "0.4.2"
+  s.version = "0.4.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Justin Spradlin"]
-  s.date = %q{2010-01-30}
+  s.date = %q{2010-03-02}
   s.description = %q{A gem for interacting with the Google Finance API}
   s.email = %q{jspradlin@gmail.com}
   s.extra_rdoc_files = ["README.rdoc", "lib/extensions/fixnum.rb", "lib/extensions/nil_class.rb", "lib/extensions/string.rb", "lib/gmoney.rb", "lib/gmoney/authentication_request.rb", "lib/gmoney/feed_parser.rb", "lib/gmoney/gf_request.rb", "lib/gmoney/gf_response.rb", "lib/gmoney/gf_service.rb", "lib/gmoney/gf_session.rb", "lib/gmoney/portfolio.rb", "lib/gmoney/portfolio_feed_parser.rb", "lib/gmoney/position.rb", "lib/gmoney/position_feed_parser.rb", "lib/gmoney/transaction.rb", "lib/gmoney/transaction_feed_parser.rb"]
   s.files = ["Manifest", "README.rdoc", "Rakefile", "gmoney.gemspec", "lib/extensions/fixnum.rb", "lib/extensions/nil_class.rb", "lib/extensions/string.rb", "lib/gmoney.rb", "lib/gmoney/authentication_request.rb", "lib/gmoney/feed_parser.rb", "lib/gmoney/gf_request.rb", "lib/gmoney/gf_response.rb", "lib/gmoney/gf_service.rb", "lib/gmoney/gf_session.rb", "lib/gmoney/portfolio.rb", "lib/gmoney/portfolio_feed_parser.rb", "lib/gmoney/position.rb", "lib/gmoney/position_feed_parser.rb", "lib/gmoney/transaction.rb", "lib/gmoney/transaction_feed_parser.rb", "spec/authentication_request_spec.rb", "spec/fixtures/cacert.pem", "spec/fixtures/default_portfolios_feed.xml", "spec/fixtures/empty_portfolio_feed.xml", "spec/fixtures/new_portfolio_feed.xml", "spec/fixtures/new_transaction_feed.xml", "spec/fixtures/portfolio_9_feed.xml", "spec/fixtures/portfolio_feed_with_returns.xml", "spec/fixtures/position_feed_for_9_GOOG.xml", "spec/fixtures/positions_feed_for_portfolio_14.xml", "spec/fixtures/positions_feed_for_portfolio_9.xml", "spec/fixtures/positions_feed_for_portfolio_9r.xml", "spec/fixtures/transaction_feed_for_GOOG_1.xml", "spec/fixtures/transactions_feed_for_GOOG.xml", "spec/fixtures/updated_portfolio_feed.xml", "spec/gmoney_spec.rb", "spec/nil_class_spec.rb", "spec/portfolio_feed_parser_spec.rb", "spec/portfolio_spec.rb", "spec/position_feed_parser_spec.rb", "spec/position_spec.rb", "spec/request_spec.rb", "spec/response_spec.rb", "spec/service_spec.rb", "spec/session_spec.rb", "spec/spec.opts", "spec/spec_helper.rb", "spec/string_spec.rb", "spec/transaction_feed_parser_spec.rb", "spec/transaction_spec.rb"]
-  s.homepage = %q{http://github.com/jspradlin/gmoney}
+  s.homepage = %q{http://www.justinspradlin.com/programming/introducing-gmoney-a-rubygem-for-interacting-with-the-google-finance-api/}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Gmoney", "--main", "README.rdoc"]
   s.require_paths = ["lib"]
   s.rubyforge_project = %q{gmoney}

data/lib/gmoney.rb

@@ -28,10 +28,11 @@ require 'gmoney/transaction'
 require 'gmoney/transaction_feed_parser'
 
 module GMoney
-  VERSION = '0.4.2'
-  GF_URL = "https://finance.google.com/finance"
+  VERSION = '0.4.3'
+  GF_URL = "http://finance.google.com/finance"
   GF_FEED_URL = "#{GF_URL}/feeds/default"
   GF_PORTFOLIO_FEED_URL = "#{GF_FEED_URL}/portfolios"
+  GF_GOOGLE_DATA_VERSION = 2
   
   HTTPOK = 200
   HTTPCreated = 201

data/lib/gmoney/gf_request.rb

@@ -9,7 +9,8 @@ module GMoney
       end
       
       @method ||= :get
-      @headers ||= {}
+      @headers ||= {}      
+      @headers['GData-Version'] = GF_GOOGLE_DATA_VERSION
     end    
   end 
 end

data/lib/gmoney/portfolio.rb

@@ -71,7 +71,6 @@ module GMoney
 
       @currency_code ||= 'USD'
       
-      #Rcov hates multi-line strings and I hate red on my test coverage report.
       atom_string = "<?xml version='1.0'?><entry xmlns='http://www.w3.org/2005/Atom' xmlns:gf='http://schemas.google.com/finance/2007' xmlns:gd='http://schemas.google.com/g/2005'><title type='text'>#{title}</title> <gf:portfolioData currencyCode='#{currency_code}'/></entry>"
       
       url = @id ? @id : GF_PORTFOLIO_FEED_URL

data/spec/portfolio_spec.rb

@@ -11,7 +11,7 @@ describe GMoney::Portfolio do
   end
   
   before(:each) do
-    @url = 'https://finance.google.com/finance/feeds/default/portfolios'
+    @url = "#{GMoney::GF_URL}/feeds/default/portfolios"
   
     @gf_request = GMoney::GFRequest.new(@url)
     @gf_request.method = :get   
@@ -40,7 +40,7 @@ describe GMoney::Portfolio do
   end
 
   it "should return a portfolio with returns data is :returns == true" do
-    @url = 'https://finance.google.com/finance/feeds/default/portfolios?returns=true'
+    @url = "#{GMoney::GF_URL}/feeds/default/portfolios?returns=true"
     @gf_response.body = @feed_with_returns
 
     portfolios = portfolio_helper(@url, :all, {:returns => true})
@@ -158,7 +158,7 @@ describe GMoney::Portfolio do
 
     portfolio_return = portfolio.save
     
-    portfolio_return.id.should be_eql('http://finance.google.com/finance/feeds/user@example.com/portfolios/38')
+    portfolio_return.id.should be_eql("#{GMoney::GF_URL}/feeds/user@example.com/portfolios/38")
     portfolio_return.title.should be_eql("New Portfolio")
   end
   

data/spec/request_spec.rb

@@ -18,7 +18,7 @@ describe GMoney::GFRequest do
   
   it "should be able to take header parameters as a Hash" do
     gfrequest_with_header_hash = GMoney::GFRequest.new('http://someurl.com', {:headers => {:header1 => 'some header'}})
-    gfrequest_with_header_hash.headers.should == {:header1 => 'some header'}
+    gfrequest_with_header_hash.headers.should == {:header1 => 'some header', "GData-Version" => 2}
   end  
   
   it "should not accept random options" do

data/spec/service_spec.rb

@@ -74,7 +74,7 @@ describe GMoney::GFService do
     set_url_expectations    
     http = set_http_expectations
     request = set_request_expecations(class_type)
-    set_header_expectations(request) if with_headers
+    set_header_expectations(request)
     res = set_response_expecations
 
     http.should_receive(:request).with(request).and_return(res) 
@@ -123,5 +123,6 @@ describe GMoney::GFService do
   def set_header_expectations(req)
     req.should_receive(:[]=).with(:h1, "header 1").any_number_of_times
     req.should_receive(:[]=).with(:h2, "header 2").any_number_of_times
+    req.should_receive(:[]=).with("GData-Version", 2).any_number_of_times    
   end
 end

data/spec/transaction_spec.rb

@@ -8,7 +8,7 @@ describe GMoney::Transaction do
   end
   
   before(:each) do
-    @url = 'https://finance.google.com/finance/feeds/default/portfolios/9/positions/NASDAQ:GOOG/transactions' 
+    @url = "#{GMoney::GF_URL}/feeds/default/portfolios/9/positions/NASDAQ:GOOG/transactions"
     @transaction_id = '9/NASDAQ:GOOG'
     
     @gf_request = GMoney::GFRequest.new(@url)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gmoney
 version: !ruby/object:Gem::Version 
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors: 
 - Justin Spradlin
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-30 00:00:00 -05:00
+date: 2010-03-02 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -89,7 +89,7 @@ files:
 - spec/transaction_feed_parser_spec.rb
 - spec/transaction_spec.rb
 has_rdoc: true
-homepage: http://github.com/jspradlin/gmoney
+homepage: http://www.justinspradlin.com/programming/introducing-gmoney-a-rubygem-for-interacting-with-the-google-finance-api/
 licenses: []
 
 post_install_message: