gm-notepad 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7132b07f0d60930e2ee6872e5b61cdc7c316b948911b73ba3a03ea2b55425b85
-  data.tar.gz: 06a8a66713c90f704e1756510f799a810b96e98233141100a17c122a99bbcc2b
+  metadata.gz: 183a799326643a98e2ee4936d5788549453746e1f74fcd5439b85ffbcfbb24f8
+  data.tar.gz: 1e55a32eaab16d88b6ae07ecfa155b01fb2c261943d80cf95175200b3c239553
 SHA512:
-  metadata.gz: eb74e6192b9d77c1d48b46be76651a6fea524d481a88537f63ae20f041a8b3b0a370773ca7c6efe0c2ea293c4ddaa9bfa1e6b1196885829a8a35e7b5847a12a4
-  data.tar.gz: '04984f322e40f16053b54210262691e0336024bb73b9dd72c78a9b0f1262d1597e9d6f9bef4969970179366c0d62c16ba8a08bb6a78ed6a269059cb502756582'
+  metadata.gz: 0ca9a59b30268a02d7e94718276f597f6c120f4f5cfa120e0f6159a2ee340eb7e69491326d1f04c148994b040f704b876acfd53f02d463b66ff407e0990b34de
+  data.tar.gz: 6207a2cd3628d05ebf53e97e232c25c3ee1cb5bfd36a909ed6177ff4c79089957ab32c3829badbb11863a5a72bc814de0ddf93c562d335e104775a4ce2de95d0

data/gm-notepad.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "dry-container"
   spec.add_dependency "dry-initializer"
   spec.add_dependency "term-ansicolor"
+  spec.add_dependency "popen4"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"

data/lib/gm/notepad/container.rb

@@ -11,6 +11,22 @@ module Gm
         Config
       end
 
+      # Responsible for handling command line parsing. I wanted a separate function to unit test.
+      register "shell_handler" do
+        require "popen4"
+        ->(input) do
+          output = ""
+          POpen4.popen4(input.to_s) do |stdout, stderr, stdin, pid|
+            output = stdout.read.strip
+          end
+          if output.empty?
+            "# Command Not Found: #{input.to_s.inspect}"
+          else
+            output
+          end
+        end
+      end
+
       register "table_registry" do
         require 'gm/notepad/table_registry'
         TableRegistry.build_and_load

data/lib/gm/notepad/input_handlers/shell_out_handler.rb

@@ -1,9 +1,11 @@
 require "gm/notepad/input_handlers/default_handler"
-require "shellwords"
 module Gm
   module Notepad
     module InputHandlers
+      # Responsible for handling shell out commands
       class ShellOutHandler < DefaultHandler
+        option :shell_handler, default: -> { Container.resolve(:shell_handler) }
+
         SHELL_OUT_HANDLER_REGEXP = /^`/.freeze
         TO_OUTPUT_REGEXP = /^\>/.freeze
 
@@ -20,8 +22,7 @@ module Gm
           else
             to_output = false
           end
-          command = input.to_s.split
-          response = `#{command.shelljoin}`.strip
+          response = shell_handler.call(input)
 
           input.for_rendering(
             text: response,

data/lib/gm/notepad/version.rb

@@ -1,5 +1,5 @@
 module Gm
   module Notepad
-    VERSION = "0.0.13"
+    VERSION = "0.0.14"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gm-notepad
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Jeremy Friesen
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: popen4
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement