globalize 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 34b357eb2051fae6a0a588bac79f4865412887c7
-  data.tar.gz: 87dcd21c654f413edc206becf2a249433a7128b0
-SHA512:
-  metadata.gz: 934e4cbf69e650b3adc36fe5569007343d91bd6d9d1145e9b01e40e5c0039cebc4ddce55c9d109c46e76f657550f59477a291f86566eb33fdde8d1572596a468
-  data.tar.gz: 432ad39f1c190b723e688170306f94f9b98c6797fd70b73f3cfcee85366629338ded33aaeae0e827ff46535b4f1a8c3c306eacb4903251b6f405835cb2a363d9
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZjA4YjdiYjFmODI5ZjE4ZjVkMWU5NDRjOTZhNDRmODc1MDQwMzdmOQ==
+  data.tar.gz: !binary |-
+    YTY3NTk5N2ZjY2E4ODFiOGVjYTI2OGE0YzkxODMzOGU3OTU3OTA2MQ==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    Yzg0MWI0YTQzZTMwODMzZTdhMGZjYTZkZjJiMjQ0OTFlYjhjNWY5MzVlMTNi
+    N2U3NTg1NmU3YWE3ZjAwMjJjNmNmMDM3NmYyNzU0ZTZiMTFiMjU0MTZkNzFi
+    MmY3OTBhOGYwODIxNzgwYWU4NWRkY2Y4OTRhOWQyYWMyMDMzZmM=
+  data.tar.gz: !binary |-
+    OGE1NGU3NjY0MzRlZWJiYzU4OTRiN2NkMWRjOTlmMzAxMTUyYzkyMjgzMmM2
+    YTM0MWE1ZWRiYWQ5ZjViNDhhOTQ0MzljN2JkNjE4OTFjN2Y0YzU2YmI5OWRi
+    MjA1ZWFiYzJkZGU0YTkwZjc1ZDY1YWMxMTE5OTJhNGZmZWYyYzE=

data/CHANGELOG.md

@@ -0,0 +1,69 @@
+# Globalize Changelog
+
+## 4.0.0 (2014-1-4)
+* Extract all versioning-related code to separate [globalize-versioning](https://github.com/globalize/globalize-versioning) gem.
+
+## 4.0.0.alpha.5 (2014-1-4)
+* Fix issue where globalize breaks has_many through when model called with `where` (thanks [Paul McMahon](https://github.com/pwim)).
+* Modify dup so that translations are copied, and remove custom clone code to conform to Rails/AR semantics (thanks [Paul McMahon](https://github.com/pwim)).
+
+## 4.0.0.alpha.4 (2013-12-30)
+* Add this changelog.
+* Add contributing guidelines.
+* Group options into more structured methods in act_macro.rb.
+* Remove dynamic finder code from globalize3, no longer used in AR4.
+* Get hash of translated attributes by calling attribute on model, not translation.
+* Define translation readers/writers in separate methods.
+* Test against AR 4.1 and AR 4.0.
+* Switch to minitest-reporters for colouring output from minitest.
+* Remove find_or_instantiator_by_attributes which is no longer used in AR4.
+* Set I18n.available_locales in tests to avoid deprecation message.
+* Reorganize specs into describe blocks to clarify object of specs.
+
+## 4.0.0.alpha.3 (2013-12-18)
+
+* Move ActiveRecord::Relation#where_values_hash patch into globalize relation class to avoid monkeypatching.
+* Add Code Climate Score (thanks [BrandonMathis](https://github.com/BrandonMathis)).
+* Query using Globalize.fallbacks rather than locale only when fetching a record (thanks [@huoxito](https://github.com/huoxito)).
+* Use a module (QueryMethods) rather than a class for overriding functionality of ActiveRecord::Relation.
+* Use ActiveRecord::Relation#extending! to extend ActiveRecord::Base#relation with QueryMethods, works with associations as well.
+
+## 4.0.0.alpha.2 (2013-10-24)
+
+* Add license to gemspec.
+* Update references to ActiveRecord 3 -> ActiveRecord.
+* Replace references to globalize3 with globalize and remove references to ActiveRecord 3.x.
+* Document `3-0-stable` branch in readme.
+* Convert test syntax to MiniTest::Spec.
+* Extract easy accessors functionality, moved to new [globalize-accessors](https://github.com/globalize/globalize-accessors) gem.
+* Check that `first` is not nil before reloading translations, fixes [#282](https://github.com/globalize/globalize/issues/282).
+* Duplicate arguments in query finders before modifying them, fixes [#284](https://github.com/globalize/globalize/issues/284).
+* Add test for `find_or_create_by` with translated attribute.
+
+## 4.0.0.alpha.1 (2013-10-9)
+
+* Initial release of Rails 4-compatible gem.
+
+## 3.0.4 (2014-1-8)
+* Extract all versioning-related code to separate [globalize-versioning](https://github.com/globalize/globalize-versioning) gem.
+
+## 3.0.3 (2013-12-26)
+
+* Ensure that foreign key is always set when saving translations (thanks [Andrew Feng](https://github.com/mingliangfeng)).
+* Patch I18n to add back I18n.interpolate after it was removed (accidentally?) in v0.5.2 (see [svenfuchs/i18n#232](https://github.com/svenfuchs/i18n/issues/232). Hopefully this patch will be temporary.
+* Explicitly test compatibility with FriendlyId to avoid issues like [#306](https://github.com/globalize/globalize/issues/306).
+* Only override ActiveRecord::Base#relation to patch where_values_hash if using AR >= 3.2.1.
+
+## 3.0.2 (2013-12-07)
+
+* Alias `ActiveRecord::Base#relation` and include query method overrides as module, fixes [#306](https://github.com/globalize/globalize/issues/306) and [norman/friendly_id#485](https://github.com/norman/friendly_id/issues/485).
+
+## 3.0.1 (2013-11-07)
+
+* Move `ActiveRecord::Relation#where_values_hash` patch to Globalize-specific Relation class that inherits from `ActiveRecord::Relation` to fix compatibility issue with Squeel ([#288](https://github.com/globalize/globalize/issues/288)).
+* Use FriendlyId pattern for overriding `ActiveRecord::Base#relation` to avoid conflict.
+* Remove `:null => false` condition on reference to parent model in translation table migration, partial fix for [refinery/refinerycms#2450](https://github.com/refinery/refinerycms/issues/2450).
+
+## 3.0.0 (2013-10-24)
+
+* Initial release with new version numbering.

data/CONTRIBUTING.md

@@ -0,0 +1,37 @@
+# Contributing to Globalize
+
+Globalize is a community project, and would not be here today if it were not for the support of the community of [contributors](https://github.com/globalize/globalize/graphs/contributors) that have kept it alive and running. Thank you for your support!
+
+## Bugs
+
+If you find a bug or something is not working as expected, please search through the [github issues](https://github.com/globalize/globalize/issues) and on [stackoverflow](http://stackoverflow.com/questions/tagged/globalize) first. If you cannot find any answers related to your issue, post a new one and we will try to address it as soon as we can. Note that we prioritize Rails 4 issues (`master` branch) over Rails 3 issues (`3-0-stable` branch).
+
+If you also have some idea how to fix the bug, then by all means post a pull request (see below).
+
+## Features
+
+Have an idea for a new feature? Great! Keep in mind though that we are trying to cut down on non-core functionality in the Globalize core and push it to separate extensions, such as [globalize-accessors](https://github.com/globalize/globalize-accessors). If you are proposing something like this, we would prefer you to create a separate repository and gem for it.
+
+If however your feature would improve the core functionality of Globalize, please do submit a PR, preferably to the `master` branch.
+
+## Refactoring
+
+Have some free time? Help us improve our [code climate score](https://codeclimate.com/github/globalize/globalize) by refactoring the codebase. If the tests still pass and the changes seem reasonable, we will happily merge them. As elsewhere, priority always goes to the Rails/AR 4 series (`master` branch).
+
+## Documentation
+
+Globalize needs better documentation. That includes more inline comments explaining clearly what code is doing, as well as reference documentation beyond the [readme](readme.md) -- possibly in the github wiki. Please contact us if you would like to help with documentation.
+
+## Pull Requests
+
+Have a bug fix, code improvement or proposed feature? Do the following:
+
+1. Fork the repository.
+2. Create your feature branch: `git checkout -b my_new_feature`
+3. Commit your changes: `git commit -am 'Add some new feature'`
+4. Push to the branch: `git push origin my_new_feature`
+5. Submit a pull request.
+
+For pull requests to Rails/ActiveRecord 4 version of Globalize (v3.x), post to the `master` branch. For pull requests to the Rails/ActiveRecord 3.x version of Globalize (3.x), post to the `3-0-stable` branch.
+
+When you submit the pull request, Travis CI will run the [test suite](https://travis-ci.org/globalize/globalize) against your branch and will highlight any failures. Unless there is a good reason for it, we do not generally accept pull requests that take Globalize from green to red.

data/Gemfile.lock

@@ -1,73 +1,38 @@
-GIT
-  remote: git://github.com/airblade/paper_trail.git
-  revision: c4e188c27040888515866660bac94740b92a262b
-  branch: master
-  specs:
-    paper_trail (3.0.0)
-      activerecord (>= 3.0, < 5.0)
-      activesupport (>= 3.0, < 5.0)
-
-GIT
-  remote: git://github.com/bmabey/database_cleaner.git
-  revision: c0c7885466287dcde3dbac195a5f10df306db098
-  branch: master
-  specs:
-    database_cleaner (1.2.0)
-
 PATH
   remote: .
   specs:
-    globalize (4.0.0.alpha.3)
-      activemodel (>= 4.0.0)
-      activerecord (>= 4.0.0)
-      paper_trail (~> 3.0.0.beta)
+    globalize (3.0.3)
+      activemodel (~> 3.0.0)
+      activerecord (~> 3.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.0.2)
-      activesupport (= 4.0.2)
-      builder (~> 3.1.0)
-    activerecord (4.0.2)
-      activemodel (= 4.0.2)
-      activerecord-deprecated_finders (~> 1.0.2)
-      activesupport (= 4.0.2)
-      arel (~> 4.0.0)
-    activerecord-deprecated_finders (1.0.3)
-    activesupport (4.0.2)
-      i18n (~> 0.6, >= 0.6.4)
-      minitest (~> 4.2)
-      multi_json (~> 1.3)
-      thread_safe (~> 0.1)
-      tzinfo (~> 0.3.37)
-    ansi (1.4.3)
-    arel (4.0.1)
-    atomic (1.1.14)
-    builder (3.1.4)
-    coderay (1.1.0)
+    activemodel (3.0.20)
+      activesupport (= 3.0.20)
+      builder (~> 2.1.2)
+      i18n (~> 0.5.0)
+    activerecord (3.0.20)
+      activemodel (= 3.0.20)
+      activesupport (= 3.0.20)
+      arel (~> 2.0.10)
+      tzinfo (~> 0.3.23)
+    activesupport (3.0.20)
+    arel (2.0.10)
+    builder (2.1.2)
+    database_cleaner (0.6.7)
     ffi2-generators (0.1.1)
-    hashie (2.0.5)
-    i18n (0.6.9)
+    friendly_id (4.0.10.1)
+      activerecord (>= 3.0, < 4.0)
+    i18n (0.5.3)
     json (1.8.1)
-    method_source (0.8.2)
+    metaclass (0.0.1)
     minitest (4.7.5)
-    minitest-reporters (0.14.23)
-      ansi
-      builder
-      minitest (>= 2.12, < 5.0)
-      powerbar
-    multi_json (1.8.2)
-    powerbar (1.0.11)
-      ansi (~> 1.4.0)
-      hashie (>= 1.1.0)
-    pry (0.9.12.4)
-      coderay (~> 1.0)
-      method_source (~> 0.8)
-      slop (~> 3.4)
-    pry-nav (0.2.3)
-      pry (~> 0.9.10)
-    rake (10.1.0)
-    rdoc (3.12.2)
+    mocha (0.14.0)
+      metaclass (~> 0.0.1)
+    pathname_local (0.0.2)
+    rake (10.1.1)
+    rdoc (4.1.0)
       json (~> 1.4)
     rubysl (2.0.15)
       rubysl-abbrev (~> 2.0)
@@ -173,7 +138,7 @@ GEM
     rubysl-coverage (2.0.3)
     rubysl-csv (2.0.2)
       rubysl-english (~> 2.0)
-    rubysl-curses (2.0.0)
+    rubysl-curses (2.0.1)
     rubysl-date (2.0.6)
     rubysl-delegate (2.0.1)
     rubysl-digest (2.0.3)
@@ -271,24 +236,24 @@ GEM
     rubysl-xmlrpc (2.0.0)
     rubysl-yaml (2.0.4)
     rubysl-zlib (2.0.1)
-    slop (3.4.7)
     sqlite3 (1.3.8)
-    thread_safe (0.1.3)
-      atomic
+    test-unit (2.0.0.0)
+    test_declarative (0.0.5)
     tzinfo (0.3.38)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  database_cleaner!
+  database_cleaner (~> 0.6.0)
+  friendly_id
   globalize!
   minitest
-  minitest-reporters
-  paper_trail!
-  pry
-  pry-nav
+  mocha
+  pathname_local
   rake
   rdoc
   rubysl (~> 2.0)
   sqlite3
+  test-unit
+  test_declarative

data/lib/globalize.rb

@@ -10,7 +10,6 @@ end
 
 module Globalize
   autoload :ActiveRecord, 'globalize/active_record'
-  autoload :Versioning,   'globalize/versioning'
   autoload :Interpolation,   'globalize/interpolation'
 
   class << self

data/lib/globalize/active_record/act_macro.rb

@@ -77,17 +77,6 @@ module Globalize
         after_create :save_translations!
         after_update :save_translations!
 
-        if options[:versioning]
-          if options[:versioning].is_a?(Hash)
-            translation_class.versioned options[:versioning]
-          else
-            ::ActiveRecord::Base.extend(Globalize::Versioning::PaperTrail)
-
-            translation_class.has_paper_trail
-            delegate :version, :versions, :to => :translation
-          end
-        end
-
         translation_class.instance_eval %{ attr_accessible :locale }
       end
     end

data/lib/globalize/version.rb

@@ -1,3 +1,3 @@
 module Globalize
-  Version = '3.0.3'
+  Version = '3.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: globalize
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Sven Fuchs
@@ -14,50 +14,48 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-26 00:00:00.000000000 Z
+date: 2014-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
+    - - <
+      - !ruby/object:Gem::Version
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
+    - - <
+      - !ruby/object:Gem::Version
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
+    - - <
+      - !ruby/object:Gem::Version
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: paper_trail
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
+    - - <
       - !ruby/object:Gem::Version
-        version: '2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '2'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -76,70 +74,98 @@ dependencies:
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pathname_local
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: test_declarative
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: friendly_id
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Rails I18n de-facto standard library for ActiveRecord model/data translation.
@@ -148,52 +174,74 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/globalize.rb
-- lib/patches/active_record/xml_attribute_serializer.rb
-- lib/patches/active_record/uniqueness_validator.rb
-- lib/patches/active_record/query_method.rb
-- lib/patches/i18n/interpolate.rb
+- lib/globalize/interpolation.rb
+- lib/globalize/version.rb
 - lib/globalize/active_record.rb
-- lib/globalize/versioning/paper_trail.rb
+- lib/globalize/active_record/attributes.rb
+- lib/globalize/active_record/instance_methods.rb
 - lib/globalize/active_record/adapter.rb
-- lib/globalize/active_record/query_methods.rb
-- lib/globalize/active_record/migration.rb
-- lib/globalize/active_record/act_macro.rb
 - lib/globalize/active_record/translation.rb
-- lib/globalize/active_record/instance_methods.rb
-- lib/globalize/active_record/class_methods.rb
+- lib/globalize/active_record/act_macro.rb
 - lib/globalize/active_record/exceptions.rb
-- lib/globalize/active_record/attributes.rb
-- lib/globalize/versioning.rb
-- lib/globalize/version.rb
-- lib/globalize/interpolation.rb
+- lib/globalize/active_record/query_methods.rb
+- lib/globalize/active_record/class_methods.rb
+- lib/globalize/active_record/migration.rb
+- lib/globalize.rb
 - lib/i18n/missing_translations_raise_handler.rb
 - lib/i18n/missing_translations_log_handler.rb
-- Rakefile
+- lib/patches/active_record/uniqueness_validator.rb
+- lib/patches/active_record/query_method.rb
+- lib/patches/active_record/xml_attribute_serializer.rb
+- lib/patches/i18n/interpolate.rb
+- CONTRIBUTING.md
+- Gemfile.lock
+- CHANGELOG.md
 - LICENSE
+- Rakefile
 - Gemfile
-- Gemfile.lock
 homepage: https://github.com/globalize/globalize
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: ! '
+
+  Globalize has extracted versioning support to a separate gem named
+
+  globalize-versioning. If you are using versioning (with paper_trail
+
+  or any other versioning gem), please add the line
+
+  "gem ''globalize-versioning''" to your Gemfile and go to the github
+
+  page at globalize/globalize-versioning if you encounter any problems.
+
+
+  Note that the globalize-versioning gem does not delegate versions to
+
+  the translation table, so you will have to update your syntax to
+
+  the form: `post.translation.versions`. See the globalize-versioning
+
+  readme for details.
+
+
+'
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.5
 signing_key: 
 specification_version: 4
 summary: Rails I18n de-facto standard library for ActiveRecord model/data translation

data/lib/globalize/versioning.rb

@@ -1,5 +0,0 @@
-module Globalize
-  module Versioning
-    autoload :PaperTrail, 'globalize/versioning/paper_trail'
-  end
-end

data/lib/globalize/versioning/paper_trail.rb

@@ -1,41 +0,0 @@
-require 'paper_trail'
-
-module Globalize
-  module Versioning
-    module PaperTrail
-      # At present this isn't used but we may use something similar in paper trail
-      # shortly, so leaving it around to reference easily.
-      #def versioned_columns
-        #super + self.class.translated_attribute_names
-      #end
-    end
-  end
-end
-
-ActiveRecord::Base.class_eval do
-  class << self
-    def has_paper_trail_with_globalize(*args)
-      has_paper_trail_without_globalize(*args)
-      include Globalize::Versioning::PaperTrail
-    end
-    alias_method_chain :has_paper_trail, :globalize
-  end
-end
-
-Version.class_eval do
-
-  before_save do |version|
-    version.locale = Globalize.locale.to_s
-  end
-
-  def self.locale_conditions_to_sql
-    "locale = '#{Globalize.locale.to_s}'"
-  end
-
-  scope :for_this_locale, lambda{ { :conditions => locale_conditions_to_sql } }
-
-  def sibling_versions_with_locales
-    sibling_versions_without_locales.for_this_locale
-  end
-  alias_method_chain :sibling_versions, :locales
-end