global_collect 0.3.0 → 0.4.0

data/HISTORY

@@ -1,3 +1,7 @@
+v0.4.0 (2010-09-19)
+===================
+* Fix method names for DO_PAYMENT response to match idiom used in other responses.
+
 v0.3.0 (2010-09-15)
 ===================
 * Add recurring payment support via DO_PAYMENT method

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.0

data/examples/get_order_status.rb

@@ -1,7 +1,7 @@
 require 'rubygems'
 require File.join(File.dirname(__FILE__), '..', "lib", "global_collect")
 
-GlobalCollect.merchant_id           = "5393"
+GlobalCollect.merchant_id           = ""
 GlobalCollect.authentication_scheme = :ip_check
 GlobalCollect.environment           = :test
 GlobalCollect.ip_address            = ""
@@ -9,7 +9,7 @@ GlobalCollect.ip_address            = ""
 
 client    = GlobalCollect.merchant_link_client
 
-req = GlobalCollect::Requests::GetOrderStatus.new("777")
+req = GlobalCollect::Requests::GetOrderStatus.new("53")
 req.version = "2.0"
 response  = client.make_request(req)
 p response.success?

data/examples/recurring_do_payment.rb

@@ -1,7 +1,7 @@
 require 'rubygems'
 require File.join(File.dirname(__FILE__), '..', "lib", "global_collect")
 
-GlobalCollect.merchant_id           = "5393"
+GlobalCollect.merchant_id           = ""
 GlobalCollect.authentication_scheme = :ip_check
 GlobalCollect.environment           = :test
 GlobalCollect.ip_address            = ""
@@ -41,7 +41,7 @@ puts "This is a multi-stage example. Please read the source for instructions."
 #     ]
 #   )
 # )
-# p response.success?       
+# p response.success?
 
 # ===============================================================================
 # Then you need to visit the FORMACTION URL in a browser, and fill in some
@@ -82,4 +82,4 @@ puts "This is a multi-stage example. Please read the source for instructions."
 #     ]
 #   )
 # )
-# p response.success?     
+# p response.success?

data/global_collect.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{global_collect}
-  s.version = "0.3.0"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Timon Karnezos"]
-  s.date = %q{2010-09-15}
+  s.date = %q{2010-09-23}
   s.description = %q{Gives minimally intrusive access to Global Collect's payment processing API. 
 Currently implements a very small segment of the full API but is built with 
 extensibility in mind.

data/lib/global_collect/builders/do_payment/payment.rb

@@ -7,7 +7,7 @@ module GlobalCollect::Builders::DoPayment
         end
       end
     end
-    
+
     # WDL §5.13.1 specifies general payment fields
     def payment_fields
       %w[

data/lib/global_collect/responses/do_payment/credit_card_response_methods.rb

@@ -2,28 +2,28 @@ module GlobalCollect::Responses::DoPayment
   # WDL §5.13.2 specifies the possible return keys
   module CreditCardResponseMethods
     [
-      "CURRENCYCODE"        ,
-      "AMOUNT"              ,
-      "PAYMENTREFERENCE"    ,
-      "ADDITIONALREFERENCE" ,
-      "EXTERNALREFERENCE"   ,
-      "STATUSID"            ,
-      "STATUSDATE"          ,
-      "AVSRESULT"           ,
-      "CVVRESULT"           ,
-      "FRAUDRESULT"         ,
-      "FRAUDCODE"           ,
-      "FRAUDNEURAL"         ,
-      "FRAUDCRF"            ,
-      "AUTHORISATIONCODE"
+      "CURRENCY CODE"        ,
+      "AMOUNT"               ,
+      "PAYMENT REFERENCE"    ,
+      "ADDITIONAL REFERENCE" ,
+      "EXTERNAL REFERENCE"   ,
+      "STATUS ID"            ,
+      "STATUS DATE"          ,
+      "AVS RESULT"           ,
+      "CVV RESULT"           ,
+      "FRAUD RESULT"         ,
+      "FRAUD CODE"           ,
+      "FRAUD NEURAL"         ,
+      "FRAUD CRF"            ,
+      "AUTHORISATION CODE"
     ].each do |meth|
       define_method meth.downcase.gsub(/\s+/, "_") do
         row[meth.gsub(/\s+/, "")]
       end
     end
-    
+
     def payment_status
-      GlobalCollect::Const::PaymentStatus.from_code(statusid)
+      GlobalCollect::Const::PaymentStatus.from_code(status_id)
     end
   end
 end

data/spec/builders/do_payment/payment_spec.rb

@@ -8,11 +8,11 @@ describe "the DO_PAYMENT payment builder" do
     @builder = GlobalCollect::Builders::DoPayment::Payment.new('foo' => 'bar')
     @builder.build(@node)
     xml = @node.target!
-    
+
     xml.should have_xpath("/PAYMENT")
     xml.should_not have_xpath("/PAYMENT/foo")
   end
-  
+
   it "should build known keys" do
     fields = %w[
       MERCHANTREFERENCE

data/spec/request_models/insert_order_with_payment/recurring_hosted_credit_card_online_payment_spec.rb

@@ -11,7 +11,7 @@ describe GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringHostedCr
     )
     model["CVVINDICATOR"].should == "8"
   end
-  
+
   it "should set CVVINDICATOR to '8' when it is set to something invalid" do
     model = GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringHostedCreditCardOnlinePayment.new(
       "PAYMENTPRODUCTID" => "1",
@@ -23,7 +23,7 @@ describe GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringHostedCr
     )
     model["CVVINDICATOR"].should == "8"
   end
-  
+
   it "should set CVVINDICATOR to '8' when it is set to the wrong thing" do
     model = GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringHostedCreditCardOnlinePayment.new(
       "PAYMENTPRODUCTID" => "1",

data/spec/request_models/insert_order_with_payment/recurring_order_spec.rb

@@ -11,7 +11,7 @@ describe GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringOrder do
     )
     model["ORDERTYPE"].should == "4"
   end
-  
+
   it "should set ORDERTYPE to '4' when it is set to something invalid" do
     model = GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringOrder.new(
       "ORDERID"      => "1",
@@ -23,7 +23,7 @@ describe GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringOrder do
     )
     model["ORDERTYPE"].should == "4"
   end
-  
+
   it "should set ORDERTYPE to '4' when it is set to the wrong thing" do
     model = GlobalCollect::RequestModels::InsertOrderWithPayment::RecurringOrder.new(
       "ORDERID"      => "1",

data/spec/responses/do_payment/credit_card_response_methods_spec.rb

@@ -9,7 +9,7 @@ describe GlobalCollect::Responses::DoPayment::CreditCardResponseMethods do
   end
 
   it "should see the methods" do
-    @response.statusid.should == "800"
+    @response.status_id.should == "800"
     @response.payment_status.should_not be_nil
     @response.payment_status.code.should be(800)
   end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Timon Karnezos
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-15 00:00:00 -07:00
+date: 2010-09-23 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency