global-registry-bindings 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6fde0711e44617c813c4e88abe88119ddc008c76
-  data.tar.gz: 4b1f10e75f4b95b7ccfbc2462403bd6cffcf3f6a
+  metadata.gz: 4dd8d8a7069e77c3eff998918b8481ebb8c961ef
+  data.tar.gz: 9bb711799fc0cc935d1fcb564901f4acad662de4
 SHA512:
-  metadata.gz: 170479033b4c6c4d80952dcc9751ccd16e22dd3268d27fb2829380ee03757c51daa4191b9144c4ef48dae7175f6dd977a323fcd4b553ec6529d88deb578d71dd
-  data.tar.gz: 489177982a94ec7303ce80e311d27bd23392920e2a6e3281ca62ef4937fe7b7c5f8568cfdf19960eed7c4f2dd1bd5943021841c6a9c5d5a65eba6559f6a1f701
+  metadata.gz: abd20332493b5b8551079714b63d3eb2e14302586730ed3de4d8324c2c849ac7099533f60615b0bcdcbd830ec8b5c11f3073865c793dde86c4ec17909b4b3878
+  data.tar.gz: 7c1a0eeec3b0ff7a3b5c9f01d3bfe2ed77b227231ec51a66536201328209293b685d7db4986d987684b8f66aae5d4c4f45bf2cbdb4683897d5753577e5fbb449

data/lib/global_registry_bindings/entity/push_entity_methods.rb

@@ -22,15 +22,15 @@ module GlobalRegistry #:nodoc:
           else
             create_entity_in_global_registry
           end
-        rescue RestClient::ResourceNotFound
-          global_registry_entity.id_value = nil
-          push_entity_to_global_registry
         end
 
         def update_entity_in_global_registry
           entity_attributes = { global_registry_entity.type => model.entity_attributes_to_push }
           GlobalRegistry::Entity.put(global_registry_entity.id_value, entity: entity_attributes)
           update_fingerprint
+        rescue RestClient::ResourceNotFound
+          global_registry_entity.id_value = nil
+          create_entity_in_global_registry
         end
 
         def create_entity_in_global_registry

data/lib/global_registry_bindings/version.rb

@@ -2,6 +2,6 @@
 
 module GlobalRegistry #:nodoc:
   module Bindings #:nodoc:
-    VERSION = '0.3.2'
+    VERSION = '0.3.3'
   end
 end

data/spec/workers/push_entity_worker_spec.rb

@@ -246,14 +246,16 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
           end
 
           context 'invalid entity id' do
-            let!(:requests) do
-              [stub_request(:put,
-                            'https://backend.global-registry.org/entities/f8d20318-2ff2-4a98-a5eb-e9d840508bf1')
+            let!(:requests) { [update_request, create_request] }
+            let!(:update_request) do
+              stub_request(:put, 'https://backend.global-registry.org/entities/f8d20318-2ff2-4a98-a5eb-e9d840508bf1')
+                .with(body: entity_body)
+                .to_return(status: 404)
+            end
+            let!(:create_request) do
+              stub_request(:post, 'https://backend.global-registry.org/entities')
                 .with(body: entity_body)
-                .to_return(status: 404),
-               stub_request(:post, 'https://backend.global-registry.org/entities')
-                 .with(body: entity_body)
-                 .to_return(body: file_fixture('post_entities_person.json'), status: 200)]
+                .to_return(body: file_fixture('post_entities_person.json'), status: 200)
             end
 
             it 'should push entity as create' do
@@ -262,6 +264,18 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
               expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
               expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
             end
+
+            context 'response is also not found on create' do
+              let!(:create_request) do
+                stub_request(:post, 'https://backend.global-registry.org/entities')
+                  .with(body: entity_body)
+                  .to_return(status: 404)
+              end
+
+              it 'should raise an error' do
+                expect { worker.push_entity_to_global_registry }.to raise_error(RestClient::NotFound)
+              end
+            end
           end
 
           context 'fingerprints match' do
@@ -446,17 +460,29 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
                                                 client_integration_id: address.id,
                                                 client_updated_at: '2001-02-03 00:00:00'
                                               } } } })
-            .to_return(body: file_fixture('put_entities_address.json'), status: 200)
+            .to_return(response)
         end
+        let!(:response) { { body: file_fixture('put_entities_address.json'), status: 200 } }
 
-        it 'should push address entity' do
+        subject do
           address.address1 = '100 Sesame Street'
           address.primary = false
-          expect do
-            worker.push_entity_to_global_registry
-          end.to_not(change { address.global_registry_id })
+          worker.push_entity_to_global_registry
+        end
+
+        it 'should push address entity' do
+          expect { subject }.to_not(change { address.global_registry_id })
           expect(request).to have_been_requested.once
         end
+
+        context 'response not found' do
+          let!(:response) { { status: 404 } }
+
+          it 'should raise an error' do
+            expect { subject }.to raise_error(RestClient::NotFound)
+            expect(request).to have_been_requested.once
+          end
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: global-registry-bindings
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Brian Zoetewey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-04 00:00:00.000000000 Z
+date: 2019-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord