glimr-api-client 0.1.11 → 0.1.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b660ea3d34bcf9f237a01cb8e3f6d8c480e70af6
-  data.tar.gz: 95f00b2723dfae4ae96bbba8a6e89e8c92ab9d6d
+  metadata.gz: 6cbd60fb640a1ffbeae5e9bb2b4e886a9013095a
+  data.tar.gz: 932ef88b4ea067de7969970e9ba2f71142a8c339
 SHA512:
-  metadata.gz: 32ffc15aa4ec65672fbfee9437e8a266b67a46b9551d76109e5c8fd02fe231dea71958a9ff2a4090491adfb18d254a4448efc54a05954e743a679639ec91562e
-  data.tar.gz: 12e813eb6878271af81521e7f656c6d54eb6996354d81befd04b40d275a8b8b7a2890209cbca1056e0749825579d279b7a720ecd48fdac9261cc72cca975dc66
+  metadata.gz: 22d04e89360d24aa9a537ef7a8bbe26772b31f915fc3b794935932316e14b90fdb77f2ef565571a1a503a1f4b7373485cce689134a81f3936bfae4ad82b7a043
+  data.tar.gz: 033de5166aaf1c4f2bb39ad393a40e9e2799bca4edde1ef1c0f0c08915c7aeaa4c4df3b722017e56b1a4338c8ef2080bb9a71520621c4d0c30d0d2fe62f2eb2e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    glimr-api-client (0.1.11)
+    glimr-api-client (0.1.13)
       excon (~> 0.51)
 
 GEM

data/lib/glimr_api_client/api.rb

@@ -4,7 +4,6 @@ module GlimrApiClient
   module Api
     def post
       client("#{api_url}#{endpoint}").post(body: request_body.to_json).tap { |resp|
-        # Only timeouts and network issues raise errors.
         handle_response_errors(resp)
         @body = resp.body
       }
@@ -26,8 +25,9 @@ module GlimrApiClient
                 'https://glimr-api.taxtribunals.dsd.io/Live_API/api/tdsapi')
     end
 
+    # Only timeouts and network issues raise errors.
     def handle_response_errors(resp)
-      if (!endpoint.eql?('/paymenttaken') && resp.status.equal?(404))
+      if resp.status.equal?(404) && endpoint.eql?('/requestpayablecasefees')
         raise CaseNotFound, resp.status
       elsif (400..599).cover?(resp.status)
         re_raise_error(endpoint, resp.status)

data/lib/glimr_api_client/case.rb

@@ -19,7 +19,19 @@ module GlimrApiClient
     end
 
     def title
-      @title ||= response_body.fetch(:caseTitle)
+      # This should be;
+      #
+      #   @title ||= response_body.fetch(:caseTitle)
+      #
+      # But, a change in the Glimr API means that the title is
+      # currently being returned with each fee liability. So,
+      # for the time being, we will fetch it from there.
+      # I'm leaving the "Missing Title" text so that nobody forgets
+      # that this needs to be fixed, preferably by changing the
+      # Glimr RequestPayableCaseFees API call back to returning
+      # caseTitle at the top-level of the response data.
+
+      @title ||= fees.any? ? fees.first.case_title : "Missing Title"
     end
 
     def fees
@@ -27,7 +39,8 @@ module GlimrApiClient
         OpenStruct.new(
           glimr_id: Integer(fee.fetch(:feeLiabilityId)),
           description: fee.fetch(:onlineFeeTypeDescription),
-          amount: Integer(fee.fetch(:payableWithUnclearedInPence))
+          amount: Integer(fee.fetch(:payableWithUnclearedInPence)),
+          case_title: fee.fetch(:caseTitle)
         )
       end
     end

data/lib/glimr_api_client/update.rb

@@ -9,9 +9,9 @@ module GlimrApiClient
     def check_request!
       errors = []
       [:feeLiabilityId, :paymentReference, :govpayReference, :paidAmountInPence].each do |required|
-        errors << required if request_body.fetch(required).blank?
+        errors << required if request_body.fetch(required).nil?
       end
-      raise RequestError, errors unless errors.blank?
+      raise RequestError, errors unless errors.empty?
     end
 
     def endpoint

data/lib/glimr_api_client/version.rb

@@ -1,3 +1,3 @@
 module GlimrApiClient
-  VERSION = '0.1.11'
+  VERSION = '0.1.13'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimr-api-client
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.13
 platform: ruby
 authors:
 - Todd Tyree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2016-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler