glimpse-redis 1.0.1 → 1.1.0

data/CHANGELOG.md

@@ -5,3 +5,7 @@
 # 1.0.1
 
 - Fixed a bug where Redis::Client may have a block passed to some methods and if not passed would return 0 instead of true or false.
+
+# 1.1.0
+
+- Query count and Query time are now threadsafe.

data/glimpse-redis.gemspec

@@ -19,4 +19,5 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'glimpse'
   gem.add_dependency 'redis'
+  gem.add_dependency 'atomic', '>= 1.0.0'
 end

data/lib/glimpse-redis/version.rb

@@ -1,5 +1,5 @@
 module Glimpse
   module Redis
-    VERSION = '1.0.1'
+    VERSION = '1.1.0'
   end
 end

data/lib/glimpse/views/redis.rb

@@ -1,19 +1,21 @@
 require 'redis'
+require 'atomic'
 
 # Instrument Redis time
 class Redis::Client
   class << self
     attr_accessor :query_time, :query_count
   end
-  self.query_count = 0
-  self.query_time = 0
+  self.query_count = Atomic.new(0)
+  self.query_time = Atomic.new(0)
 
   def call_with_timing(*args, &block)
     start = Time.now
     call_without_timing(*args, &block)
   ensure
-    Redis::Client.query_time += (Time.now - start)
-    Redis::Client.query_count += 1
+    duration = (Time.now - start)
+    Redis::Client.query_time.update { |value| value + duration }
+    Redis::Client.query_count.update { |value| value + 1 }
   end
   alias_method_chain :call, :timing
 end
@@ -22,7 +24,7 @@ module Glimpse
   module Views
     class Redis < View
       def duration
-        ::Redis::Client.query_time
+        ::Redis::Client.query_time.value
       end
 
       def formatted_duration
@@ -35,7 +37,7 @@ module Glimpse
       end
 
       def calls
-        ::Redis::Client.query_count
+        ::Redis::Client.query_count.value
       end
 
       def results
@@ -47,8 +49,8 @@ module Glimpse
       def setup_subscribers
         # Reset each counter when a new request starts
         subscribe 'start_processing.action_controller' do
-          ::Redis::Client.query_time = 0
-          ::Redis::Client.query_count = 0
+          ::Redis::Client.query_time.value = 0
+          ::Redis::Client.query_count.value = 0
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: glimpse-redis
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-11 00:00:00.000000000 Z
+date: 2013-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: glimpse
@@ -43,6 +43,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: atomic
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: Provide a glimpse into the Redis calls made within your Rails application.
 email:
 - me@garrettbjerkhoel.com