glimpse-pg 1.0.0 → 1.1.0

data/CHANGELOG.md

@@ -0,0 +1,7 @@
+# 1.0.0
+
+- Initial release.
+
+# 1.1.0
+
+- Query count and Query time are now threadsafe.

data/glimpse-pg.gemspec

@@ -17,5 +17,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
+  gem.add_dependency 'glimpse'
   gem.add_dependency 'pg'
+  gem.add_dependency 'atomic', '>= 1.0.0'
 end

data/lib/glimpse-pg/version.rb

@@ -1,5 +1,5 @@
 module Glimpse
   module PG
-    VERSION = '1.0.0'
+    VERSION = '1.1.0'
   end
 end

data/lib/glimpse/views/pg.rb

@@ -1,19 +1,21 @@
 require 'pg'
+require 'atomic'
 
 # Instrument SQL time
 class PG::Connection
   class << self
     attr_accessor :query_time, :query_count
   end
-  self.query_count = 0
-  self.query_time = 0
+  self.query_count = Atomic.new(0)
+  self.query_time = Atomic.new(0)
 
   def exec_with_timing(*args)
     start = Time.now
     exec_without_timing(*args)
   ensure
-    PG::Connection.query_time += (Time.now - start)
-    PG::Connection.query_count += 1
+    duration = (Time.now - start)
+    PG::Connection.query_time.update { |value| value + duration }
+    PG::Connection.query_count.update { |value| value + 1 }
   end
   alias_method_chain :exec, :timing
 
@@ -21,8 +23,9 @@ class PG::Connection
     start = Time.now
     async_exec_without_timing(*args)
   ensure
-    PG::Connection.query_time += (Time.now - start)
-    PG::Connection.query_count += 1
+    duration = (Time.now - start)
+    PG::Connection.query_time.update { |value| value + duration }
+    PG::Connection.query_count.update { |value| value + 1 }
   end
   alias_method_chain :async_exec, :timing
 end
@@ -31,15 +34,20 @@ module Glimpse
   module Views
     class PG < View
       def duration
-        ::PG::Connection.query_time
+        ::PG::Connection.query_time.value
       end
 
       def formatted_duration
-        "%.2fms" % (duration * 1000)
+        ms = duration * 1000
+        if ms >= 1000
+          "%.2fms" % ms
+        else
+          "%.0fms" % ms
+        end
       end
 
       def calls
-        ::PG::Connection.query_count
+        ::PG::Connection.query_count.value
       end
 
       def results
@@ -51,8 +59,8 @@ module Glimpse
       def setup_subscribers
         # Reset each counter when a new request starts
         before_request do
-          ::PG::Connection.query_time = 0
-          ::PG::Connection.query_count = 0
+          ::PG::Connection.query_time.value = 0
+          ::PG::Connection.query_count.value = 0
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: glimpse-pg
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,24 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-10 00:00:00.000000000 Z
+date: 2013-03-17 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: glimpse
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -27,6 +43,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: atomic
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: Provide a glimpse into the Postgres queries made during your application's
   requests.
 email:
@@ -36,6 +68,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md