glimmer 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53c846877535c288cc80b8c2972b14f5fd961b6e3e51f744278e8c6da47cfe6d
-  data.tar.gz: 4be53a6c16f2a9ae9c6101ca4726b576bec5e17dae05f55d64c0714ab13ab6fd
+  metadata.gz: 8f82e6793a331105407650a919d3d973f360c9e0c5e6bd49d185bd44dd9ec745
+  data.tar.gz: 190ea8ddbe57f41100e9fa539f4e9465b9d621418e3f00e291b91103f04484ce
 SHA512:
-  metadata.gz: 8f717afdd64e347b706a3d909474b579031c4a235d4881c490958d7c743892f363b64ae29f40bf8401506f327764163c4d08660cb6a29d8507b7077f11e06c29
-  data.tar.gz: c2b5de327710faa1e6dde42e5ef011af9b5375b87c030edeea40a0e672c7abd8a848dd1f8f48da9deeee903be27c9cc8e79e4a8a404a31cbf522be11dad35ee3
+  metadata.gz: b57d3b3d4754fc2d5229c3ec2c2e7518336091b1d305a1d4c2d6b1b601a50245f75340ba2dc213168349408389f324afeeeb734ae81faa2045dd6d6e0e5d7da3
+  data.tar.gz: b2fd672bed1bf48b99c7e92ad8b82fb910c0d0330b78152fbf3cbe4a6c33e34dae4a0ed945ab2e646492af2daad1f9a224488ee5064a7d4f6650f6238882f86e

data/README.markdown

@@ -1,10 +1,8 @@
-# Glimmer (JRuby Desktop UI DSL + Data-Binding)
+# Glimmer 0.4.7 Beta (JRuby Desktop UI DSL + Data-Binding)
 [![Coverage Status](https://coveralls.io/repos/github/AndyObtiva/glimmer/badge.svg?branch=master)](https://coveralls.io/github/AndyObtiva/glimmer?branch=master)
 
 Glimmer is a cross-platform Ruby desktop development library. Glimmer's main innovation is a JRuby DSL that enables easy and efficient authoring of desktop application user-interfaces while relying on the robust platform-independent Eclipse SWT library. Glimmer additionally innovates by having built-in desktop UI data-binding support to greatly facilitate synchronizing the UI with domain models. As a result, that achieves true decoupling of object oriented components, enabling developers to solve business problems without worrying about UI concerns, or alternatively drive development UI-first, and then write clean business components test-first afterward.
 
-You may learn more by reading this article: [Eclipse Zone Tutorial](http://eclipse.dzone.com/articles/an-introduction-glimmer)
-
 ## Examples
 
 ### Hello World
@@ -65,12 +63,7 @@ Glimmer app:
 
 ![Tic Tac Toe](https://github.com/AndyObtiva/glimmer/raw/master/images/glimmer-tic-tac-toe.png)
 
-## Resources
-
-* [Eclipse Zone Tutorial](http://eclipse.dzone.com/articles/an-introduction-glimmer)
-* [InfoQ Article](http://www.infoq.com/news/2008/02/glimmer-jruby-swt)
-* [RubyConf 2008 Video](https://confreaks.tv/videos/rubyconf2008-desktop-development-with-glimmer)
-* [Code Blog](http://andymaleh.blogspot.com/search/label/Glimmer)
+NOTE: Glimmer is in beta mode. Please help make better by adopting for small or low risk projects and providing feedback.
 
 ## Background
 
@@ -112,14 +105,14 @@ Please follow these instructions to make the `glimmer` command available on your
 
 Run this command to install directly:
 ```
-jgem install glimmer -v 0.4.6
+jgem install glimmer -v 0.4.7
 ```
 
 ### Option 2: Bundler
 
 Add the following to `Gemfile`:
 ```
-gem 'glimmer', '~> 0.4.6'
+gem 'glimmer', '~> 0.4.7'
 ```
 
 And, then run:
@@ -528,7 +521,7 @@ Check out the samples directory for more advanced examples of layouts in Glimmer
 
 Glimmer composites always come with grid_layout by default, but you can still specify explicitly if you'd like to set specific properties on it.
 
-Glimmer shell always comes containing one composite by default that wraps around specified shell content. That specific composite (the one directly under shell) has fill_layout with :horizontal type.
+Glimmer shell always comes with fill_layout having :horizontal type.
 
 This is a great guide for learning more about SWT layouts:
 
@@ -936,7 +929,9 @@ Definition:
 ```ruby
 class Sandwich
   include Glimmer::SWT::CustomWidget
+
   options :orientation, :bg_color
+
   def body
     composite(swt_style) { # gets custom widget style
       fill_layout orientation # using orientation option
@@ -1089,6 +1084,13 @@ Example:
 jruby -J-XstartOnFirstThread -J-classpath "path_to/swt.jar" -r glimmer -S application.rb
 ```
 
+## Resources
+
+* [Eclipse Zone Tutorial](http://eclipse.dzone.com/articles/an-introduction-glimmer)
+* [InfoQ Article](http://www.infoq.com/news/2008/02/glimmer-jruby-swt)
+* [RubyConf 2008 Video](https://confreaks.tv/videos/rubyconf2008-desktop-development-with-glimmer)
+* [Code Blog](http://andymaleh.blogspot.com/search/label/Glimmer)
+
 ## Feature Suggestions
 
 These features have been suggested. You might see them in a future version of Glimmer. You are welcome to contribute more feature suggestions.

data/lib/glimmer.rb

@@ -46,6 +46,7 @@ module Glimmer
   end
 
   def self.dsl(dsl)
+    @@parent_stack = []
     CommandHandlerChainFactory.select_dsl(dsl)
   end
 
@@ -60,7 +61,7 @@ module Glimmer
   end
 
   def dsl(dsl)
-    CommandHandlerChainFactory.select_dsl(dsl)
+    Glimmer.dsl(dsl)
   end
 end
 

data/lib/glimmer/command_handler_chain_link.rb

@@ -13,7 +13,8 @@ module Glimmer
       elsif @next_chain_link
         return @next_chain_link.handle(parent, command_symbol, *args, &block)
       else
-        Glimmer.logger.debug "Command: #{command_symbol} cannot be handled!"
+        # TODO see if we need a better response here (e.g. dev mode error raising vs production mode silent failure)
+        Glimmer.logger.error "Command: #{command_symbol} cannot be handled!"
         return nil
       end
     end

data/lib/glimmer/swt/command_handlers/bind_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../model_binding"
 
 module Glimmer
@@ -17,7 +18,7 @@ module Glimmer
         def can_handle?(parent, command_symbol, *args, &block)
           # TODO refactor this long condition below
           (
-            parent.is_a?(GWidget) and
+            (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
             command_symbol.to_s == "bind" and
             (
               (

data/lib/glimmer/swt/command_handlers/color_command_handler.rb

@@ -17,7 +17,7 @@ module Glimmer
         def do_handle(parent, command_symbol, *args, &block)
           if args.first.is_a?(Display) || args.first.nil?
             display = args.delete_at(0)
-          elsif parent.is_a?(GWidget)
+          elsif parent.is_a?(GWidget) || parent.is_a?(CustomWidget)
             display = parent.widget.display
           else
             display = GDisplay.instance.display

data/lib/glimmer/swt/command_handlers/combo_selection_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 
 module Glimmer
   module SWT
@@ -11,7 +12,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(Combo) and
           command_symbol.to_s == "selection" and
           args.size == 1 and
@@ -36,7 +37,7 @@ module Glimmer
               model_binding.call(widget_binding.evaluate_property)
             }
           }
-        end        
+        end
       end
     end
   end

data/lib/glimmer/swt/command_handlers/custom_widget_command_handler.rb

@@ -9,14 +9,14 @@ module Glimmer
         include CommandHandler
 
         def can_handle?(parent, command_symbol, *args, &block)
-          (parent.is_a?(GWidget) || parent.is_a?(SWT::CustomWidget)) and
-          SWT::CustomWidget.for(command_symbol)
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
+          CustomWidget.for(command_symbol)
         end
 
         def do_handle(parent, command_symbol, *args, &block)
           options = args.pop if args.last.is_a?(Hash)
           Glimmer.logger.debug "Custom widget #{command_symbol} styles are: [" + args.inspect + "] and options are: #{options}"
-          SWT::CustomWidget.for(command_symbol).new(parent, *args, options, &block)
+          CustomWidget.for(command_symbol).new(parent, *args, options, &block)
         end
       end
     end

data/lib/glimmer/swt/command_handlers/data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../observable_model"
 require File.dirname(__FILE__) + "/../model_binding"
 require File.dirname(__FILE__) + "/../widget_binding"
@@ -20,40 +21,10 @@ module Glimmer
 
         include_package 'org.eclipse.swt.widgets'
 
-        @@widget_data_binders = {
-          Java::OrgEclipseSwtWidgets::Text => {
-            :text => Proc.new do |g_widget, model_binding|
-              add_contents(g_widget) {
-                on_modify_text { |modify_event|
-                  model_binding.call(g_widget.widget.getText)
-                }
-              }
-            end,
-          },
-          Java::OrgEclipseSwtWidgets::Button => {
-            :selection => Proc.new do |g_widget, model_binding|
-              add_contents(g_widget) {
-                on_widget_selected { |selection_event|
-                  model_binding.call(g_widget.widget.getSelection)
-                }
-              }
-            end
-          },
-          Java::OrgEclipseSwtWidgets::Spinner => {
-            :selection => Proc.new do |g_widget, model_binding|
-              add_contents(g_widget) {
-                on_widget_selected { |selection_event|
-                  model_binding.call(g_widget.widget.getSelection)
-                }
-              }
-            end
-          }
-        }
-
         def can_handle?(parent, command_symbol, *args, &block)
-          (parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           args.size == 1 and
-          args[0].is_a?(ModelBinding))
+          args[0].is_a?(ModelBinding)
         end
 
         def do_handle(parent, command_symbol, *args, &block)
@@ -62,9 +33,7 @@ module Glimmer
           widget_binding = WidgetBinding.new(*widget_binding_parameters)
           widget_binding.call(model_binding.evaluate_property)
           widget_binding.observe(model_binding)
-          widget_data_binder_map = @@widget_data_binders[parent.widget.class]
-          widget_data_binder = widget_data_binder_map[command_symbol.to_s.to_sym] if widget_data_binder_map
-          widget_data_binder.call(parent, model_binding) if widget_data_binder
+          parent.add_observer(model_binding, command_symbol.to_s.to_sym) #TODO consider reversing statement
         end
       end
     end

data/lib/glimmer/swt/command_handlers/layout_command_handler.rb

@@ -11,7 +11,7 @@ module Glimmer
         include_package 'org.eclipse.swt.layout'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(Composite) and
           command_symbol.to_s.end_with?('_layout') and
           GLayout.layout_exists?(command_symbol.to_s)

data/lib/glimmer/swt/command_handlers/layout_data_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../g_layout_data"
 
 module Glimmer
@@ -12,7 +13,7 @@ module Glimmer
         include_package 'org.eclipse.swt.layout'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           command_symbol.to_s == 'layout_data'
         end
 

data/lib/glimmer/swt/command_handlers/list_selection_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../list_selection_binding"
 
 module Glimmer
@@ -12,7 +13,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(List) and
           command_symbol.to_s == "selection" and
           args.size == 1 and
@@ -41,7 +42,7 @@ module Glimmer
               model_binding.call(list_selection_binding.evaluate_property)
             }
           }
-        end        
+        end
       end
     end
   end

data/lib/glimmer/swt/command_handlers/tab_item_command_handler.rb

@@ -9,9 +9,19 @@ module Glimmer
         include CommandHandler
         include Glimmer
 
+        include_package 'org.eclipse.swt.widgets'
+
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
-          command_symbol.to_s == "tab_item"
+          initial_condition = (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) &&
+            command_symbol.to_s == "tab_item"
+          if initial_condition
+            if parent.widget.is_a?(TabFolder)
+              return true
+            else
+              Glimmer.logger.error "tab_item widget may only be used directly under a tab_folder widget!"
+            end
+          end
+          false
         end
 
         def do_handle(parent, command_symbol, *args, &block)

data/lib/glimmer/swt/command_handlers/table_column_properties_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 
 module Glimmer
   module SWT
@@ -13,7 +14,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(Table) and
           command_symbol.to_s == "column_properties" and
           block == nil

data/lib/glimmer/swt/command_handlers/table_items_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../table_items_binding"
 
 module Glimmer
@@ -12,7 +13,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(Table) and
           command_symbol.to_s == "items" and
           args.size == 2 and

data/lib/glimmer/swt/command_handlers/tree_items_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 require File.dirname(__FILE__) + "/../tree_items_binding"
 
 module Glimmer
@@ -11,7 +12,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          (parent.is_a?(GWidget)) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           (parent.widget.is_a?(Tree)) and
           (command_symbol.to_s == "items") and
           (args.size == 2) and

data/lib/glimmer/swt/command_handlers/tree_properties_data_binding_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 
 module Glimmer
   module SWT
@@ -13,7 +14,7 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          parent.is_a?(GWidget) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           parent.widget.is_a?(Tree) and
           command_symbol.to_s == "tree_properties" and
           block == nil

data/lib/glimmer/swt/command_handlers/widget_command_handler.rb

@@ -12,7 +12,7 @@ module Glimmer
         include_package 'org.eclipse.swt.browser'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          (parent.is_a?(GWidget) || parent.is_a?(SWT::CustomWidget)) and
+          (parent.is_a?(GWidget) || parent.is_a?(CustomWidget)) and
           command_symbol.to_s != "shell" and
           GWidget.widget_exists?(command_symbol.to_s)
         end

data/lib/glimmer/swt/command_handlers/widget_listener_command_handler.rb

@@ -1,5 +1,6 @@
 require File.dirname(__FILE__) + "/../../command_handler"
 require File.dirname(__FILE__) + "/../g_widget"
+require File.dirname(__FILE__) + "/../custom_widget"
 
 module Glimmer
   module SWT
@@ -10,8 +11,9 @@ module Glimmer
         include_package 'org.eclipse.swt.widgets'
 
         def can_handle?(parent, command_symbol, *args, &block)
-          Glimmer.logger.debug "parent is a widget: " + (parent.is_a?(GWidget)).to_s
-          return unless parent.is_a?(GWidget)
+          widget_parentage = (parent.is_a?(GWidget) || parent.is_a?(CustomWidget))
+          Glimmer.logger.debug "parent is a widget: #{widget_parentage}"
+          return unless widget_parentage
           Glimmer.logger.debug "on listener?: " + (command_symbol.to_s[0,3] == "on_").to_s
           return unless command_symbol.to_s[0,3] == "on_"
           Glimmer.logger.debug "command symbol is longer than 3: " + (command_symbol.to_s.length > 3).to_s

data/lib/glimmer/swt/custom_widget.rb

@@ -1,6 +1,7 @@
 require 'set'
 
 require_relative 'proc_tracker'
+require_relative 'observable_model'
 
 module Glimmer
   module SWT
@@ -8,6 +9,7 @@ module Glimmer
       include SuperModule
       include Glimmer
       include Parent
+      include ObservableModel
 
       class << self
         def for(underscored_custom_widget_name)
@@ -67,6 +69,20 @@ module Glimmer
         raise 'Not implemented!'
       end
 
+      # TODO consider using delegators
+
+      def can_add_listener?(underscored_listener_name)
+        @body_root.can_add_listener?(underscored_listener_name)
+      end
+
+      def add_listener(underscored_listener_name, &block)
+        @body_root.add_listener(underscored_listener_name, &block)
+      end
+
+      def add_observer(observer, attribute_name)
+        @body_root.add_observer(observer, attribute_name)
+      end
+
       def has_attribute?(attribute_name, *args)
         respond_to?(attribute_setter(attribute_name), args) ||
           @body_root.has_attribute?(attribute_name, *args)
@@ -80,12 +96,24 @@ module Glimmer
         end
       end
 
+      def get_attribute(attribute_name)
+        if respond_to?(attribute_name)
+          send(attribute_name)
+        else
+          @body_root.get_attribute(attribute_name)
+        end
+      end
+
       def attribute_setter(attribute_name)
         "#{attribute_name}="
       end
 
       def process_block(block)
-        @content.call if @content && !@content.called?
+        if block.source_location == @content&.__getobj__.source_location
+          @content.call unless @content.called?
+        else
+          block.call
+        end
       end
     end
   end

data/lib/glimmer/swt/g_tab_item_composite.rb

@@ -1,4 +1,3 @@
-require File.dirname(__FILE__) + "/g_widget_listener"
 require File.dirname(__FILE__) + "/g_runnable"
 
 module Glimmer
@@ -29,6 +28,14 @@ module Glimmer
           super(attribute_name, *args)
         end
       end
+
+      def get_attribute(attribute_name)
+        if attribute_name.to_s == "text"
+          @tab_item.widget.text
+        else
+          super(attribute_name)
+        end
+      end
     end
   end
 end

data/lib/glimmer/swt/g_widget.rb

@@ -13,6 +13,8 @@ module Glimmer
       include_package 'org.eclipse.swt.layout'
       include_package 'org.eclipse.swt.graphics'
       include_package 'org.eclipse.swt.browser'
+
+      include Glimmer
       include Parent
 
       attr_reader :widget
@@ -56,6 +58,10 @@ module Glimmer
         @widget.send(attribute_setter(attribute_name), *args)
       end
 
+      def get_attribute(attribute_name)
+        @widget.send(attribute_getter(attribute_name))
+      end
+
       def property_type_converters
         color_converter = Proc.new do |value|
           if value.is_a?(Symbol) || value.is_a?(String)
@@ -81,6 +87,38 @@ module Glimmer
         }
       end
 
+      def widget_property_listener_installers
+        @widget_property_listener_installers ||= {
+          Java::OrgEclipseSwtWidgets::Text => {
+            :text => Proc.new do |observer|
+              add_contents(self) {
+                on_modify_text { |modify_event|
+                  observer.call(widget.getText)
+                }
+              }
+            end,
+          },
+          Java::OrgEclipseSwtWidgets::Button => {
+            :selection => Proc.new do |observer|
+              add_contents(self) {
+                on_widget_selected { |selection_event|
+                  observer.call(widget.getSelection)
+                }
+              }
+            end
+          },
+          Java::OrgEclipseSwtWidgets::Spinner => {
+            :selection => Proc.new do |observer|
+              add_contents(self) {
+                on_widget_selected { |selection_event|
+                  observer.call(widget.getSelection)
+                }
+              }
+            end
+          }
+        }
+      end
+
       def apply_property_type_converters(attribute_name, args)
         if args.count == 1
           value = args.first
@@ -194,6 +232,16 @@ module Glimmer
         @widget.dispose
       end
 
+      def add_observer(observer, property_name)
+        property_listener_installers = widget_property_listener_installers[widget.class]
+        widget_listener_installer = property_listener_installers[property_name.to_s.to_sym] if property_listener_installers
+        widget_listener_installer.call(observer) if widget_listener_installer
+      end
+
+      def remove_observer(observer, property_name)
+        # TODO consider implementing if remove_observer is needed (consumers can remove listener via SWT API)
+      end
+
       private
 
       def style(underscored_widget_name, styles)
@@ -209,6 +257,10 @@ module Glimmer
       def attribute_setter(attribute_name)
         "set#{attribute_name.to_s.camelcase(:upper)}"
       end
+
+      def attribute_getter(attribute_name)
+        "get#{attribute_name.to_s.camelcase(:upper)}"
+      end
     end
   end
 end

data/lib/glimmer/swt/observable_model.rb

@@ -40,6 +40,7 @@ module Glimmer
       end
 
       def property_observer_hash
+        # TODO simplify with ||=
         @property_observers = Hash.new unless @property_observers
         @property_observers
       end

data/lib/glimmer/swt/widget_binding.rb

@@ -13,7 +13,8 @@ module Glimmer
         @widget = model
         @property = property
         @translator = translator || proc {|value| value}
-        add_contents(@widget) {
+
+        add_contents(@widget) { # TODO consider having custom widgets support on_widget_disposed event and any event on their body_root
           on_widget_disposed { |dispose_event|
             unregister_all_observables
           }
@@ -24,7 +25,7 @@ module Glimmer
         @widget.set_attribute(@property, converted_value) unless evaluate_property == converted_value
       end
       def evaluate_property
-        @widget.widget.send(@property)
+        @widget.get_attribute(@property)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimmer
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - AndyMaleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-26 00:00:00.000000000 Z
+date: 2020-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement