gl_rubocop 0.5.4 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbecf0a138a66001d115607b6e635bda71eb4a2637c7eaa86b164807313efc8c
-  data.tar.gz: a40a64ea1547488a822ed7f021c688da5187ec57dde140357d05b3f624c9bbfb
+  metadata.gz: 5609bd9d5a3b5e3fe6dded2031b9e86d4f51716b511a032205ed4e6564007c6a
+  data.tar.gz: 0b28be74b5a9a19773bdab6bec25f8dd4031eb7ed4dd53451af5609a330fb595
 SHA512:
-  metadata.gz: 25d837867c4e28a5e2e7134db085a93b94392ceb783bd533240c04a9f582adbfc60033edd5fadce6b5bfa5ebf569728fd258b2394a8f4dff6c9128df44fca953
-  data.tar.gz: 6af51558e77b72d5f791f51a5cb87f4a4fa51c953d08b69f9a4c1d87b6724cf5f9601a94e9b8f47f0ee6d06618a53e6c8bb50774cdd5796ddaebc59f98aafe4e
+  metadata.gz: fde9706801fcbd3f2eb95f1f02f8e85bda03a864a2e72e9b06ecf2b821b629f83e3b43cc6c8245db412afb30e0e425df79efb0bdfdd44b1b3ef34c66e7c52a9b
+  data.tar.gz: c9bb0a94e4bae6ea981de96f42bfe7d3ae69aef0703ce9afe35f7c53d6396bb381a689da7e8745365c34a3207a7fb836d0185680716458b4b656086d22dc0cfb

data/default.yml

@@ -14,6 +14,7 @@ require:
   - ./lib/gl_rubocop/gl_cops/limit_flash_options.rb
   - ./lib/gl_rubocop/gl_cops/no_stubbing_env.rb
   - ./lib/gl_rubocop/gl_cops/no_stubbing_perform_async.rb
+  - ./lib/gl_rubocop/gl_cops/no_transaction_in_controllers.rb
   - ./lib/gl_rubocop/gl_cops/prevent_haml_files.rb
   - ./lib/gl_rubocop/gl_cops/rails_cache.rb
   - ./lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
@@ -86,6 +87,12 @@ GLCops/NoStubbingPerformAsync:
   Include:
     - "**/*spec.rb"
 
+GLCops/NoTransactionInControllers:
+  Enabled: true
+  Include:
+    - "app/controllers/**/*"
+    - "packs/**/app/controllers/**/*"
+
 GLCops/PreventHamlFiles:
   Enabled: true
 

data/lib/gl_rubocop/gl_cops/no_transaction_in_controllers.rb

@@ -0,0 +1,37 @@
+module GLRubocop
+  module GLCops
+    # This cop bans the use of ActiveRecord transactions within controllers.
+    #
+    # Per our controller standards RFC, opening a database transaction in a controller
+    # entangles the networking layer with the database layer and violates separation of
+    # concerns. Transactional logic belongs in a GLCommand or service object.
+    #
+    # Good:
+    #   # app/commands/transfer_funds.rb
+    #   ActiveRecord::Base.transaction do
+    #     # ...
+    #   end
+    #
+    # Bad:
+    #   # app/controllers/transfers_controller.rb
+    #   ActiveRecord::Base.transaction do
+    #     # ...
+    #   end
+    class NoTransactionInControllers < RuboCop::Cop::Base
+      MSG = 'Database transactions are not allowed in controllers. Move transactional ' \
+            'logic into a GLCommand or service object.'.freeze
+
+      # Matches `.transaction` called on a constant receiver, e.g.
+      # ActiveRecord::Base.transaction, ApplicationRecord.transaction, SomeModel.transaction
+      def_node_matcher :transaction_on_const?, <<~PATTERN
+        (send (const ...) :transaction ...)
+      PATTERN
+
+      def on_send(node)
+        return unless transaction_on_const?(node)
+
+        add_offense(node)
+      end
+    end
+  end
+end

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.5.4'.freeze
+  VERSION = '0.5.5'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-06-22 00:00:00.000000000 Z
+date: 2026-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -170,6 +170,7 @@ files:
 - lib/gl_rubocop/gl_cops/no_hardcoded_strings_in_erb_text_elements.rb
 - lib/gl_rubocop/gl_cops/no_stubbing_env.rb
 - lib/gl_rubocop/gl_cops/no_stubbing_perform_async.rb
+- lib/gl_rubocop/gl_cops/no_transaction_in_controllers.rb
 - lib/gl_rubocop/gl_cops/prevent_haml_files.rb
 - lib/gl_rubocop/gl_cops/rails_cache.rb
 - lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
@@ -205,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
+rubygems_version: 3.3.27
 signing_key:
 specification_version: 4
 summary: A shareable configuration of Give Lively's rubocop rules.