gl_rubocop 0.3.3 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d0d6882bfbd2fb93c58c4c0e3a9302e4f98ac4977aa469e0b40a57856a7cfd0
-  data.tar.gz: 86ea3ab20f3b8899e6b8806ad1daabf561d732c6ad26c80017102e57c8f67bf1
+  metadata.gz: 2dc8147315555f5d211c9d5577a449f69d73b913126481bc1477ea5ede612f38
+  data.tar.gz: ddd3961ae821ea369248be94d91dc23559ef5993261f75e660cdf05246a28358
 SHA512:
-  metadata.gz: bac9a336b0f9e60517d727a5791f8cf909d824ce978e30dff1bb3a4788d22ed358fff0106e14db757c64c3079a0fa7df7b7cb632df258bce529a963b3d6763d4
-  data.tar.gz: 7b84eda9ac0ea8feddc5996f499b36c4d0408d729f764b95b882dbdcfdf5fe7a44e08d1e1eaa6dec5e726bfcfd75e45ad88e157d017afc3497ea4e43378ef5a4
+  metadata.gz: d1b05b7ffd3b6917ac6838fea98e817572629d5b25258816b773a69671b51487754caabf5283cb840451b800f2f695fa551b4ddf4faebfe93ab2c914a7456f70
+  data.tar.gz: 60be23fbb3bfb84505da907c041bb7708a1f0b7f5e7ff5dcfbd6b3fa1db37866880092612d7a7302ec5eefdf6f97751244bf0df37e5ecd95223b1ce74a0e2dee

data/default.yml

@@ -17,6 +17,7 @@ require:
   - ./lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
   - ./lib/gl_rubocop/gl_cops/unique_identifier.rb
   - ./lib/gl_rubocop/gl_cops/tailwind_no_contradicting_class_name.rb
+  - ./lib/gl_rubocop/gl_cops/valid_data_test_id.rb
   - ./lib/gl_rubocop/gl_cops/view_component_initialize_keyword_args.rb
 
 AllCops:
@@ -76,6 +77,13 @@ GLCops/UniqueIdentifier:
   Include:
     - "app/components/**/*.erb"
 
+GLCops/ValidDataTestId:
+  Enabled: true
+  Include:
+    - "**/*.erb"
+    - "**/*.haml"
+    - "**/*.rb"
+
 GLCops/ViewComponentInitializeKeywordArgs:
   Enabled: true
   Include:

data/lib/gl_rubocop/gl_cops/valid_data_test_id.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+require_relative '../helpers/haml_content_helper'
+require_relative '../helpers/erb_content_helper'
+
+module GLRubocop
+  module GLCops
+    class ValidDataTestId < RuboCop::Cop::Cop
+      include GLRubocop::HamlContentHelper
+      include GLRubocop::ErbContentHelper
+
+      MSG = 'Use data-test-id instead of %<invalid>s'
+
+      # Invalid variations of data-test-id
+      # Matches: data-testid, data_test_id, datatestid, dataTestId, etc.
+      # Does NOT match: data-test-id (the valid format)
+      INVALID_PATTERN = /\bdata(?!-test-id\b)[-_]?test[-_]?id\b/i
+
+      def investigate(processed_source)
+        return unless haml_file? || erb_file?
+
+        content = haml_file? ? read_haml_file : read_erb_file
+        return unless content
+
+        check_file_content(content, processed_source)
+      end
+
+      def on_str(node)
+        return unless node.str_type?
+
+        check_string_content(node.value, node)
+      end
+
+      private
+
+      def check_file_content(content, processed_source)
+        return unless content.match?(INVALID_PATTERN)
+
+        match = content.match(INVALID_PATTERN)
+        invalid_attr = match[0].split(/[=:]/).first.gsub(/["']/, '')
+        range = processed_source.buffer.source_range
+        add_offense(
+          nil,
+          location: range,
+          message: format(MSG, invalid: invalid_attr)
+        )
+      end
+
+      def check_string_content(content, node)
+        return unless content.match?(INVALID_PATTERN)
+
+        match = content.match(INVALID_PATTERN)
+        invalid_attr = match[0].split(/[=:]/).first.gsub(/["']/, '')
+        add_offense(
+          node,
+          message: format(MSG, invalid: invalid_attr)
+        )
+      end
+    end
+  end
+end

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.3.3'.freeze
+  VERSION = '0.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-11-12 00:00:00.000000000 Z
+date: 2026-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -171,6 +171,7 @@ files:
 - lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
 - lib/gl_rubocop/gl_cops/tailwind_no_contradicting_class_name.rb
 - lib/gl_rubocop/gl_cops/unique_identifier.rb
+- lib/gl_rubocop/gl_cops/valid_data_test_id.rb
 - lib/gl_rubocop/gl_cops/view_component_initialize_keyword_args.rb
 - lib/gl_rubocop/helpers/erb_content_helper.rb
 - lib/gl_rubocop/helpers/haml_content_helper.rb