gl_command 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b0e88d785a51d72653d8691d86236df3791dadaa84b46a548895e045509e1428
-  data.tar.gz: 582d39e38c74b40ac251dd91071fe602a8860f6ecda15a7ece244e21541352d1
+  metadata.gz: 2c64386ffafec990d01604c12482b0cf2deb8b4caff95c638d9d4e8835c4cb92
+  data.tar.gz: 9a58f0b30039b493382f01d22fb8cc2c8d6950af71f16ec3b4e708a776e78af9
 SHA512:
-  metadata.gz: e8758b174cdf1f76a4b35d466876a8fbaa848f2546628ea777e7db594a1221a3ca9db2c31f0be77a6d58c62a739f62294e23e63050ed76bd48ca85fcbbfcdb0b
-  data.tar.gz: ed20e53cb69da3c59f2919e7f89c505d2470a9fa44138fdd9334c12c6bebcb1c89dd34a9598b9f33a0c0a29ea875fefa7f10c89e16a2d0cfe07fb1bcb133c392
+  metadata.gz: 126e275c0bd65be3fb7fe1ead77e283231a158359b1c95ab00d691e010287f41b397a97a9202de316ba921313b1df66c59e76b4f5e13d62d4130d762aba6f803
+  data.tar.gz: 728454632aa41f5b740b4f3eaf97c85ee8022857ac349ca86bfa0d655687fc6b402b7501629e580c3ed3c2b87b621a56a11333a95f3239d8ec0095901bb0e311

data/lib/gl_command/callable.rb

@@ -35,9 +35,13 @@ module GLCommand
         call(*posargs, **args.merge(raise_errors: true))
       end
 
-      def build_context(raise_errors: false, skip_unknown_parameters: false,
+      # error can be passed to build context, useful for stubbing in tests
+      def build_context(raise_errors: false, skip_unknown_parameters: false, error: nil,
                         **arguments_and_returns)
-        context_class.new(self, raise_errors:, skip_unknown_parameters:, **arguments_and_returns)
+        new_context = context_class.new(self, raise_errors:, skip_unknown_parameters:,
+                                              **arguments_and_returns)
+        new_context.error = error if error.present?
+        new_context
       end
 
       def requires(*attributes, **strong_attributes)

data/lib/gl_command/context.rb

@@ -25,7 +25,12 @@ module GLCommand
     attr_reader :klass, :error
     attr_writer :full_error_message
 
-    delegate :errors, to: :@callable, allow_nil: true
+    # If someone calls errors on a context, they expect to get the errors!
+    # Make that work, but also try to make it clear that they probably shouldn't be using that for presentation
+    def errors
+      current_errors&.add(:base, "full_error_message: #{full_error_message}") if @failure && current_errors.blank?
+      current_errors
+    end
 
     def chain?
       false
@@ -48,7 +53,7 @@ module GLCommand
     end
 
     def failure?
-      @failure || errors.present? || @full_error_message.present? || false
+      @failure || current_errors.present? || @full_error_message.present? || false
     end
 
     def success?
@@ -103,7 +108,7 @@ module GLCommand
             passed_error.is_a?(ActiveRecord::RecordInvalid) && defined?(passed_error.record.errors)
           # Return a new error if it's an error (rather than the class)
           passed_error.is_a?(Class) ? passed_error.new(@full_error_message) : passed_error
-        elsif errors.present? # check for validation errors
+        elsif current_errors.present? # check for validation errors
           # Assign ActiveRecord::RecordInvalid if validatable error
           ActiveRecord::RecordInvalid.new(@callable)
         else
@@ -123,6 +128,10 @@ module GLCommand
 
     private
 
+    def current_errors
+      @callable&.errors
+    end
+
     def exception?(passed_error)
       passed_error.is_a?(Exception) ||
         (passed_error.respond_to?(:ancestors) && passed_error.ancestors.include?(Exception))

data/lib/gl_command/version.rb

@@ -1,3 +1,3 @@
 module GLCommand
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.1.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_command
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-28 00:00:00.000000000 Z
+date: 2024-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord