gjp 0.5.0 → 0.6.0

data/.gitignore

@@ -13,7 +13,8 @@ test/version_tmp
 tmp
 
 # SPEC generated files
-spec/data/tomcat/org.apache.tomcat\:tomcat\:7.0.40
+spec/data/nailgun/com.martiansoftware\:nailgun-all\:0.9.1
+spec/data/struts-apps/org.apache.struts\:struts2-apps\:
 
 # YARD artifacts
 .yardoc

data/README.md

@@ -15,9 +15,9 @@ Easiest install is via RubyGems:
 ## Usage
 
 Currently available tools:
-* `gjp get-pom PATH` will attempt to find an artifact's pom.xml, if it exists (from the package itself or through search.maven.org)
-* `gjp get-source-address PATH` will attempt to find the SCM address of an artifact from its pom.xml (from the pom.xml itself or through api.github.com)
-* `gjp get-source PATH ADDRESS` downloads the source of a pom.xml's project from its SCM at ADDRESS
+* `gjp get-pom JAR` will attempt to find an jar's pom.xml (either from the package itself or through search.maven.org);
+* `gjp get-source-address POM` will attempt to find the SCM Internet address of a pom.xml (from the file itself or through api.github.com);
+* `gjp get-source POM ADDRESS` downloads the source of a pom.xml's project from its SCM at ADDRESS;
 
 ## Source
 

data/lib/gjp.rb

@@ -2,6 +2,7 @@ require "gjp/version"
 require "gjp/logger"
 require "gjp/cli"
 require "gjp/pom"
+require "gjp/version_matcher"
 require "gjp/get_pom"
 require "gjp/get_source_address"
 require "gjp/get_source"

data/lib/gjp/get_pom.rb

@@ -4,9 +4,10 @@ require "digest/sha1"
 require "zip/zip"
 require "rest_client"
 require "json"
-require "text"
 require "pathname"
 
+require "gjp/version_matcher"
+
 # implements the get-pom subcommand
 class PomGetter
 
@@ -51,22 +52,21 @@ class PomGetter
   # returns a pom from search.maven.org with a heuristic name search
   def self.get_pom_from_heuristic(file)
     filename = Pathname.new(file).basename.to_s
-    matches = filename.match(/([^\/]*?)(?:[\.\-\_ ~,]([0-9].*))?\.jar$/)
-    if matches != nil and matches.length > 1
-      my_artifact_id = matches[1]
-      my_version = matches[2]
+    if filename =~ /([^\/]*)\.jar$/
+			my_artifact_id, my_version = VersionMatcher.split_version($1)
+
       result = repository_search({:q => my_artifact_id}).first
       if result != nil
           results = repository_search({:q => "g:\"#{result["g"]}\" AND a:\"#{result["a"]}\"", :core => "gav"})
           their_versions = results.map {|doc| doc["v"]}
-          best_matched_version = if my_version != nil then best_match(my_version, their_versions) else their_versions.max end
+          best_matched_version = if my_version != nil then VersionMatcher.best_match(my_version, their_versions) else their_versions.max end
           best_matched_result = (results.select{|result| result["v"] == best_matched_version}).first
           
           $log.warn("pom.xml for #{file} found on search.maven.org with heuristic search (#{best_matched_result["g"]}:#{best_matched_result["a"]}:#{best_matched_result["v"]})")
           
           return repository_download(best_matched_result)
       end
-   end
+		end
   end
   
   # returns a JSON result from search.maven.com
@@ -84,75 +84,5 @@ class PomGetter
     end
   end
   
-  # returns the "best match" between a version number and a set of available version numbers
-  # using a heuristic criterion. Idea:
-  #  - split the version number in chunks divided by ., - etc.
-  #  - every chunk with same index is "compared", differences make up a score
-  #  - "comparison" is a subtraction if the chunk is an integer, a string distance measure otherwise
-  #  - score weighs differently on chunk index (first chunks are most important)
-  #  - lowest score wins
-  def self.best_match(my_version, their_versions)
-    $log.debug("version comparison: #{my_version} vs #{their_versions.join(', ')}")
-  
-    my_chunks = my_version.split /[\.\-\_ ~,]/
-    their_chunks_hash = Hash[
-      their_versions.map do |their_version|
-        their_chunks_for_version = their_version.split /[\.\-\_ ~,]/
-        their_chunks_for_version += [nil]*[my_chunks.length - their_chunks_for_version.length, 0].max
-        [their_version, their_chunks_for_version]
-      end
-    ]
-    
-    max_chunks_length = ([my_chunks.length] + their_chunks_hash.values.map {|chunk| chunk.length}).max
-    
-    scoreboard = []
-    their_versions.each do |their_version|
-      their_chunks = their_chunks_hash[their_version]
-      score = 0
-      their_chunks.each_with_index do |their_chunk, i|
-        score_multiplier = 100**(max_chunks_length -i -1)
-        my_chunk = my_chunks[i]
-        score += chunk_distance(my_chunk, their_chunk) * score_multiplier
-      end
-      scoreboard << {:version => their_version, :score => score}
-    end
-    
-    scoreboard = scoreboard.sort_by {|element| element[:score]}
-
-    $log.debug("scoreboard: ")
-    scoreboard.each_with_index do |element, i|
-      $log.debug("  #{i+1}. #{element[:version]} (score: #{element[:score]})")
-    end
-    
-    winner = scoreboard.first
-    
-    if winner != nil
-      return winner[:version]
-    end
-  end
-  
-  # returns a score representing the distance between two version chunks
-  # for integers, the score is the difference between their values
-  # for strings, the score is the Levenshtein distance
-  # in any case score is normalized between 0 (identical) and 99 (very different/uncomparable)
-  def self.chunk_distance(my_chunk, their_chunk)
-    if my_chunk == nil
-      my_chunk = "0"
-    end
-    if their_chunk == nil
-      their_chunk = "0"
-    end
-    if my_chunk.is_i? and their_chunk.is_i?
-      return [(my_chunk.to_i - their_chunk.to_i).abs, 99].min
-    else
-      return [Text::Levenshtein.distance(my_chunk.upcase, their_chunk.upcase), 99].min
-    end
-  end
-end
-
-class String
-  def is_i?
-    !!(self =~ /^[0-9]+$/)
-  end
 end
 

data/lib/gjp/get_source.rb

@@ -10,20 +10,72 @@ class SourceGetter
     $log.info("downloading: #{address} in #{directory}, pomfile: #{pomfile}")
     
     dummy, prefix, scm_address = address.split(/^([^:]+):(.*)$/)
-    
     $log.info("prefix: #{prefix}, scm_address: #{scm_address}")
-        
-    if prefix == "git"
-      get_source_from_git(scm_address, pomfile, directory)
-    end
+	
+		get_source_from_scm(prefix, scm_address, pomfile, directory)
   end
 
-  # checks out from git
-  def self.get_source_from_git(scm_address, pomfile, directory)
+  # checks code out from an scm
+  def self.get_source_from_scm(prefix, scm_address, pomfile, directory)
     pom = Pom.new(pomfile)
     dir = File.join(directory, "#{pom.group_id}:#{pom.artifact_id}:#{pom.version}")
+		begin
+	    Dir::mkdir(dir)
+		rescue Errno::EEXIST
+			$log.warn("Source directory exists, leaving...")
+		end
     
-    Dir::mkdir(dir)
-    `git clone #{scm_address} #{dir}`
+		if prefix == "git"
+			get_source_from_git(scm_address, dir, pom.version)
+    elsif prefix == "svn"
+			get_source_from_svn(scm_address, dir, pom.version)
+		end
   end
+
+  # checks code out of git
+	def self.get_source_from_git(scm_address, dir, version)
+		`git clone #{scm_address} #{dir}`
+		
+		Dir.chdir(dir) do
+			tags = `git tag`.split("\n")
+		  
+			if tags.any?
+				best_tag = get_best_tag(tags, version)		 	
+				$log.info("checking out tag: #{best_tag}")
+
+				`git checkout #{best_tag}`
+			end	
+		end
+	end
+
+  # checks code out of svn
+	def self.get_source_from_svn(scm_address, dir, version)
+		`svn checkout #{scm_address} #{dir}`
+		
+		Dir.chdir(dir) do
+			tags = `svn ls "^/tags"`.split("\n")
+			
+			if tags.any?
+				best_tag = get_best_tag(tags, version)		 	
+				$log.info("checking out tag: #{best_tag}")
+
+				`svn checkout #{scm_address}/tags/#{best_tag}`
+			end
+		end
+	end
+
+	# return the (heuristically) most similar tag to the specified version
+	def self.get_best_tag(tags, version)
+		versions_to_tags =Hash[
+			*tags.map do |tag|
+				[VersionMatcher.split_version(tag)[1], tag]
+			end.flatten
+		]
+			
+	  $log.info("found the following versions and tags: #{versions_to_tags}")
+
+		best_version = VersionMatcher.best_match(version, versions_to_tags.keys)
+		versions_to_tags[best_version]
+	end
 end
+

data/lib/gjp/version.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
 
 module Gjp
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/lib/gjp/version_matcher.rb

@@ -0,0 +1,99 @@
+# encoding: UTF-8
+
+require "text"
+
+# heuristically matches version strings
+class VersionMatcher 
+
+	# heuristically extracts a version number from a full name
+  # assumes that all leading non-numeric chars are not related the version
+  # returns a version string
+	def self.extract_version(full_name)
+		full_name.sub /^[^0-9]+/, ""
+	end  
+
+	# heuristically splits a full name into an artifact name and version string
+  # assumes that version strings begin with a numeric character and are separated
+  # by a ., -, _, ~ or space
+  # returns a [name, version] pair
+	def self.split_version(full_name)	
+    matches = full_name.match(/(.*?)(?:[\.\-\_ ~,]?([0-9].*))?$/)
+    if matches != nil and matches.length > 1
+      [matches[1], matches[2]]
+		else
+			[full_string, nil]
+		end
+	end
+
+	# returns the "best match" between a version number and a set of available version numbers
+  # using a heuristic criterion. Idea:
+  #  - split the version number in chunks divided by ., - etc.
+  #  - every chunk with same index is "compared", differences make up a score
+  #  - "comparison" is a subtraction if the chunk is an integer, a string distance measure otherwise
+  #  - score weighs differently on chunk index (first chunks are most important)
+  #  - lowest score wins
+  def self.best_match(my_version, their_versions)
+    $log.debug("version comparison: #{my_version} vs #{their_versions.join(', ')}")
+  
+    my_chunks = my_version.split /[\.\-\_ ~,]/
+    their_chunks_hash = Hash[
+      their_versions.map do |their_version|
+        their_chunks_for_version = their_version.split /[\.\-\_ ~,]/
+        their_chunks_for_version += [nil]*[my_chunks.length - their_chunks_for_version.length, 0].max
+        [their_version, their_chunks_for_version]
+      end
+    ]
+    
+    max_chunks_length = ([my_chunks.length] + their_chunks_hash.values.map {|chunk| chunk.length}).max
+    
+    scoreboard = []
+    their_versions.each do |their_version|
+      their_chunks = their_chunks_hash[their_version]
+      score = 0
+      their_chunks.each_with_index do |their_chunk, i|
+        score_multiplier = 100**(max_chunks_length -i -1)
+        my_chunk = my_chunks[i]
+        score += chunk_distance(my_chunk, their_chunk) * score_multiplier
+      end
+      scoreboard << {:version => their_version, :score => score}
+    end
+    
+    scoreboard = scoreboard.sort_by {|element| element[:score]}
+
+    $log.debug("scoreboard: ")
+    scoreboard.each_with_index do |element, i|
+      $log.debug("  #{i+1}. #{element[:version]} (score: #{element[:score]})")
+    end
+    
+    winner = scoreboard.first
+    
+    if winner != nil
+      return winner[:version]
+    end
+  end
+  
+  # returns a score representing the distance between two version chunks
+  # for integers, the score is the difference between their values
+  # for strings, the score is the Levenshtein distance
+  # in any case score is normalized between 0 (identical) and 99 (very different/uncomparable)
+  def self.chunk_distance(my_chunk, their_chunk)
+    if my_chunk == nil
+      my_chunk = "0"
+    end
+    if their_chunk == nil
+      their_chunk = "0"
+    end
+    if my_chunk.is_i? and their_chunk.is_i?
+      return [(my_chunk.to_i - their_chunk.to_i).abs, 99].min
+    else
+      return [Text::Levenshtein.distance(my_chunk.upcase, their_chunk.upcase), 99].min
+    end
+  end
+end
+
+class String
+  def is_i?
+    !!(self =~ /^[0-9]+$/)
+  end
+end
+

data/spec/data/struts-apps/pom.xml

@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+/*
+ * $Id: pom.xml 1462297 2013-03-28 20:51:02Z lukaszlenart $
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.struts</groupId>
+        <artifactId>struts2-parent</artifactId>
+        <version>2.3.14</version>
+    </parent>
+    <groupId>org.apache.struts</groupId>
+    <artifactId>struts2-apps</artifactId>
+    <packaging>pom</packaging>
+    <name>Webapps</name>
+    <modules>
+        <module>blank</module>
+        <module>jboss-blank</module>
+        <module>mailreader</module>
+        <module>portlet</module>
+        <module>showcase</module>
+        <module>rest-showcase</module>
+    </modules>
+
+    <scm>
+       <connection>scm:svn:http://svn.apache.org/repos/asf/struts/struts2/tags/STRUTS_2_3_14/apps</connection>
+       <developerConnection>scm:svn:https://svn.apache.org/repos/asf/struts/struts2/tags/STRUTS_2_3_14/apps</developerConnection>
+       <url>http://svn.apache.org/viewcvs.cgi/struts/struts2/tags/STRUTS_2_3_14/apps</url>
+    </scm>
+
+    <profiles>
+        <profile>
+            <id>hostedqa</id>
+            <dependencies>
+                <dependency>
+                    <groupId>com.hostedqa</groupId>
+                    <artifactId>hostedqa-remote-ant</artifactId>
+                    <version>1.7</version>
+                    <scope>test</scope>
+                </dependency>
+            </dependencies>
+            <repositories>
+                <repository>
+                    <id>codehaus</id>
+                    <name>codehaus</name>
+                    <url>http://repository.codehaus.org</url>
+                </repository>
+                <repository>
+                    <id>maven-hostedqa</id>
+                    <name>maven-hostedqa</name>
+                    <snapshots>
+                        <enabled>true</enabled>
+                        <updatePolicy>always</updatePolicy>
+                        <checksumPolicy>ignore</checksumPolicy>
+                    </snapshots>
+                    <releases>
+                        <enabled>true</enabled>
+                    </releases>
+                    <url>http://maven.hostedqa.com</url>
+                </repository>
+            </repositories>
+            <build>
+                <resources>
+                    <!-- Include resources under src/main/java in WEB-INF/classes -->
+                    <resource>
+                        <directory>src/main/java</directory>
+                            <includes>
+                                <include>**/*.properties</include>
+                                <include>**/*.xml</include>
+                             </includes>
+                     </resource>
+                </resources>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-antrun-plugin</artifactId>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <executions>
+                            <execution>
+                                <phase>package</phase>
+                                <goals>
+                                    <goal>run</goal>
+                                </goals>
+                                <configuration>
+                                    <tasks>
+                                        <taskdef resource="hostedqatasks" classpathref="maven.plugin.classpath" />
+                                        <upload file="${project.build.directory}/${project.build.finalName}.war" account="struts" email="${email}" password="${password}" resourceId="${resourceId}" />
+
+                                        <playsuite suiteId="${suiteId}" clientConfigs="${clientConfigs}" appConfigs="${appConfigs}" account="struts" email="${email}" password="${password}" />
+                                    </tasks>
+                                </configuration>
+                            </execution>
+                        </executions>
+                        <dependencies>
+                            <dependency>
+                                <groupId>com.hostedqa</groupId>
+                                <artifactId>hostedqa-remote-ant</artifactId>
+                                <version>1.7</version>
+                            </dependency>
+                        </dependencies>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+        <profile>
+            <id>release</id>
+            <activation>
+                <property>
+                    <name>release</name>
+                </property>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <inherited>true</inherited>
+                        <groupId>org.codehaus.mojo</groupId>
+                        <artifactId>rat-maven-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <phase>verify</phase>
+                                <goals>
+                                    <goal>check</goal>
+                                </goals>
+                                <configuration>
+                                    <addDefaultLicenseMatchers>false</addDefaultLicenseMatchers>
+                                    <licenseMatchers>
+                                        <classNames>
+                                            <className>rat.analysis.license.ApacheSoftwareLicense20</className>
+                                        </classNames>
+                                    </licenseMatchers>
+                                    <includes>
+                                        <include>pom.xml</include>
+                                    </includes>
+                                    <excludes>
+                                        <exclude>src/**</exclude>
+                                    </excludes>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
+    <build>
+        <plugins>
+            <!-- Include source code under WEB-INF/src/java -->
+            <plugin>
+                <artifactId>maven-antrun-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>copy-sources</id>
+                        <phase>process-sources</phase>
+                        <configuration>
+                            <tasks>
+                                <copy todir="${project.build.directory}/${project.artifactId}/WEB-INF/src/java" failonerror="false">
+                                    <fileset dir="${basedir}/src/main/java" />
+                                </copy>
+                                <copy todir="${project.build.directory}/${project.artifactId}/WEB-INF/src/java" failonerror="false">
+                                    <fileset dir="${basedir}/src/main/resources" />
+                                </copy>
+                            </tasks>
+                        </configuration>
+                        <goals>
+                            <goal>run</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-war-plugin</artifactId>
+                <configuration>
+                    <webResources>
+                        <resource>
+                            <directory>${basedir}/src/main/resources</directory>
+                            <targetPath>META-INF</targetPath>
+                            <includes>
+                                <include>LICENSE.txt</include>
+                                <include>NOTICE.txt</include>
+                            </includes>
+                        </resource>
+                    </webResources>
+                    <warSourceExcludes>WEB-INF/classes/LICENSE.txt,WEB-INF/classes/NOTICE.txt</warSourceExcludes>
+                </configuration>
+            </plugin>
+        </plugins>
+
+        <finalName>${project.artifactId}</finalName>
+
+    </build>
+
+    <dependencies>
+
+        <dependency>
+            <groupId>org.apache.struts</groupId>
+            <artifactId>struts2-core</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-test</artifactId>
+            <version>${struts2.springPlatformVersion}</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+
+</project>

data/spec/lib/get_pom_spec.rb

@@ -29,52 +29,7 @@ describe PomGetter do
       pom_path = File.join(dir_path, "pom.xml")
       jar_path = File.join(dir_path, "nailgun-0.7.1.jar")
       PomGetter.get_pom(jar_path).should eq(File.read(pom_path))
-    end
-            
-    it "computes chunk distances" do
-      PomGetter.chunk_distance(nil, "1").should eq(1)
-      PomGetter.chunk_distance("alpha", nil).should eq(5)
-      
-      PomGetter.chunk_distance("1", "1").should eq(0)
-      PomGetter.chunk_distance("1", "9").should eq(8)
-      PomGetter.chunk_distance("1", "999").should eq(99)
-
-      PomGetter.chunk_distance("snap", "SNAP").should eq(0)
-      PomGetter.chunk_distance("snap", "snippete").should eq(5)
-      PomGetter.chunk_distance("snap", "l"*999).should eq(99)
-      
-      PomGetter.chunk_distance("1", "SNAP").should eq(4)
-      
-      PomGetter.chunk_distance("0", "10").should eq(10)
-      PomGetter.chunk_distance("0", "9").should eq(9)
-    end
-    
-    it "finds the best match" do
-      my_version = "1.0"
-      available_versions = ["1.0", "1", "2.0", "1.0.1", "4.5.6.7.8"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.0")
-      
-      available_versions = ["3.0", "2.0", "1.0.1"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.0.1")
-
-      available_versions = ["1.snap", "2.0", "4.0.1"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.snap")
-
-      available_versions = ["1.10", "1.9", "2.0", "3.0.1"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.9")
-      
-      my_version = "1.snap"
-      available_versions = ["1.snap", "1"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.snap")
-
-      my_version = "1.very-very_very_longish"
-      available_versions = ["1.snap", "1"]
-      PomGetter.best_match(my_version, available_versions).should eq("1.snap")
-
-      my_version = "1.snap"
-      available_versions = []
-      PomGetter.best_match(my_version, available_versions).should be_nil
-    end
+    end         
   end
 end
 

data/spec/lib/get_source_spec.rb

@@ -6,17 +6,31 @@ require "fileutils"
 describe SourceGetter do
   describe ".get_source_from_git" do
     it "gets the sources from a git repo" do
-      
-      dir_path = File.join("spec", "data", "tomcat")
+      dir_path = File.join("spec", "data", "nailgun")
       pom_path = File.join(dir_path, "pom.xml")
+      repo_path = File.join(dir_path, "com.martiansoftware:nailgun-all:0.9.1")
+      file_path = File.join(repo_path, "README.md")
 
-      SourceGetter.get_source("git:https://github.com/apache/tomcat", pom_path, dir_path)
+      FileUtils.rm_rf(repo_path)
+
+      SourceGetter.get_source("git:git@github.com:martylamb/nailgun.git", pom_path, dir_path)
+
+      File.open(file_path).readline.should eq "nailgun\n"
+    end
+  end
+  
+	describe ".get_source_from_svn" do
+    it "gets the sources from an svn repo" do  
+      dir_path = File.join("spec", "data", "struts-apps")
+      pom_path = File.join(dir_path, "pom.xml")
+      repo_path = File.join(dir_path, "org.apache.struts:struts2-apps:")
+      file_path = File.join(repo_path, "showcase", "README.txt")
 
-      repo_path = File.join(dir_path, "org.apache.tomcat:tomcat:7.0.40")
-      file_path = File.join(repo_path, "LICENSE")
-      File.open(file_path).readline.should eq "\n"
-      
       FileUtils.rm_rf(repo_path)
+
+      SourceGetter.get_source("svn:http://svn.apache.org/repos/asf/struts/struts2/tags/STRUTS_2_3_14/apps", pom_path, dir_path)
+
+      File.open(file_path).readline.should eq "README.txt - showcase\n"
     end
   end
 end

data/spec/lib/version_matcher_spec.rb

@@ -0,0 +1,64 @@
+# encoding: UTF-8
+
+require 'spec_helper'
+
+describe VersionMatcher do      
+	
+	it "splits full names into names and version numbers" do
+		VersionMatcher.split_version("moio-3.2beta1").should eq(["moio", "3.2beta1"])
+		VersionMatcher.split_version("3.2beta1").should eq(["3", "2beta1"])
+		VersionMatcher.split_version("v3.2beta1").should eq(["v", "3.2beta1"])
+	end
+
+	it "extracts version numbers" do
+		VersionMatcher.extract_version("moio-3.2beta1").should eq("3.2beta1")
+		VersionMatcher.extract_version("3.2beta1").should eq("3.2beta1")
+		VersionMatcher.extract_version("v3.2beta1").should eq("3.2beta1")
+	end
+
+	it "computes chunk distances" do
+		VersionMatcher.chunk_distance(nil, "1").should eq(1)
+		VersionMatcher.chunk_distance("alpha", nil).should eq(5)
+		
+		VersionMatcher.chunk_distance("1", "1").should eq(0)
+		VersionMatcher.chunk_distance("1", "9").should eq(8)
+		VersionMatcher.chunk_distance("1", "999").should eq(99)
+
+		VersionMatcher.chunk_distance("snap", "SNAP").should eq(0)
+		VersionMatcher.chunk_distance("snap", "snippete").should eq(5)
+		VersionMatcher.chunk_distance("snap", "l"*999).should eq(99)
+		
+		VersionMatcher.chunk_distance("1", "SNAP").should eq(4)
+		
+		VersionMatcher.chunk_distance("0", "10").should eq(10)
+		VersionMatcher.chunk_distance("0", "9").should eq(9)
+	end
+	
+	it "finds the best match" do
+		my_version = "1.0"
+		available_versions = ["1.0", "1", "2.0", "1.0.1", "4.5.6.7.8"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.0")
+		
+		available_versions = ["3.0", "2.0", "1.0.1"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.0.1")
+
+		available_versions = ["1.snap", "2.0", "4.0.1"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.snap")
+
+		available_versions = ["1.10", "1.9", "2.0", "3.0.1"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.9")
+		
+		my_version = "1.snap"
+		available_versions = ["1.snap", "1"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.snap")
+
+		my_version = "1.very-very_very_longish"
+		available_versions = ["1.snap", "1"]
+		VersionMatcher.best_match(my_version, available_versions).should eq("1.snap")
+
+		my_version = "1.snap"
+		available_versions = []
+		VersionMatcher.best_match(my_version, available_versions).should be_nil
+	end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gjp
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-31 00:00:00.000000000 Z
+date: 2013-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -162,17 +162,20 @@ files:
 - lib/gjp/logger.rb
 - lib/gjp/pom.rb
 - lib/gjp/version.rb
+- lib/gjp/version_matcher.rb
 - spec/data/antlr/antlr-2.7.2.jar
 - spec/data/antlr/pom.xml
 - spec/data/commons-logging/commons-logging-1.1.1.jar
 - spec/data/commons-logging/pom.xml
 - spec/data/nailgun/nailgun-0.7.1.jar
 - spec/data/nailgun/pom.xml
+- spec/data/struts-apps/pom.xml
 - spec/data/tomcat/pom.xml
 - spec/lib/get_pom_spec.rb
 - spec/lib/get_source_address_spec.rb
 - spec/lib/get_source_spec.rb
 - spec/lib/pom_spec.rb
+- spec/lib/version_matcher_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/SilvioMoioli/gjp
 licenses: []
@@ -205,9 +208,11 @@ test_files:
 - spec/data/commons-logging/pom.xml
 - spec/data/nailgun/nailgun-0.7.1.jar
 - spec/data/nailgun/pom.xml
+- spec/data/struts-apps/pom.xml
 - spec/data/tomcat/pom.xml
 - spec/lib/get_pom_spec.rb
 - spec/lib/get_source_address_spec.rb
 - spec/lib/get_source_spec.rb
 - spec/lib/pom_spec.rb
+- spec/lib/version_matcher_spec.rb
 - spec/spec_helper.rb