gitloc-joshcheek 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b1873f050be3c185343f26b8c3280b35ba138e9
-  data.tar.gz: c85f0aae4d3ba91adab62b1fbfe2fb41ffee5cc0
+  metadata.gz: 6ec9dcb4b36696c324cc09aec617329dff6c7655
+  data.tar.gz: bbc405ce8916d69c63932d041eceb2bae1f56b0d
 SHA512:
-  metadata.gz: 77503d71edf83d1a5d42f89f0806b1114014a171dc295610a752fff235c432cf4cf0d6b508cc8e995bbcbd46a743620f0ec3124b5b75a550d16fd1de1c4411b5
-  data.tar.gz: 4ac211de0fc05b7acf9863c54f07d25b43cd709cc8c0357dcc6f18a52515a20398a013afd236d9dc0f737bb6f9a0e7d5f28236ac52b1b846ea8af0faed3a75fd
+  metadata.gz: 0fbd3346232119866b67fec2d385f0762eb7d8b35f533c4adc2f70871a1a4efb3a2cc9218a0f4cc86e51647ad3e0408559356c487e8495871780d0a3a32aaecc
+  data.tar.gz: 46140da2cb32f341383e2fb7a8b1dc64dc70d9ad3b3e43e335a962a5104781509795e9271b0fd684e60d832156aa12d17867dd6d68997ce799e8b61a624ce584

data/Gemfile

@@ -0,0 +1,2 @@
+source 'https://rubygems.org'
+gemspec

data/Gemfile.lock

@@ -0,0 +1,37 @@
+PATH
+  remote: .
+  specs:
+    gitloc-joshcheek (0.2.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    coderay (1.1.0)
+    diff-lcs (1.2.5)
+    method_source (0.8.2)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rspec (3.2.0)
+      rspec-core (~> 3.2.0)
+      rspec-expectations (~> 3.2.0)
+      rspec-mocks (~> 3.2.0)
+    rspec-core (3.2.0)
+      rspec-support (~> 3.2.0)
+    rspec-expectations (3.2.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-mocks (3.2.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.2.0)
+    rspec-support (3.2.1)
+    slop (3.6.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  gitloc-joshcheek!
+  pry
+  rspec (~> 3.0)

data/bin/gitloc

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
-require 'gitloc'
-Gitloc.call(ARGV, $stdout, $stderr)
+require 'gitloc/binary'
+Gitloc::Binary.call(ARGV, $stdout, $stderr)

data/gitloc.gemspec

@@ -9,7 +9,8 @@ Gem::Specification.new do |s|
   s.description = "Example project for the Turing School of Software and Design, see https://github.com/JoshCheek/elective-building-a-gem -- gives lines-of-code information for a git repo."
   s.authors     = ["Josh Cheek"]
   s.email       = 'josh.cheek@gmail.com'
-  s.files       = Dir["**/*"].select { |f| File.file? f }
+  s.files       = Dir["**/*"].select { |f| File.file? f } - Dir['*.gem']
   s.homepage    = 'https://github.com/JoshCheek/elective-building-a-gem'
   s.executables << 'gitloc'
+  s.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/gitloc.rb

@@ -1,25 +1,21 @@
 require 'tmpdir'
 require 'open3'
 
+require 'gitloc/errors'
 require 'gitloc/version'
+require 'gitloc/line_counts'
 
 class Gitloc
-  def self.call(argv, outstream, errstream)
-    repo = argv.first
-
-    Dir.mktmpdir { |dir|
+  def self.call(repo)
+    names_to_bodies = Dir.mktmpdir { |dir|
       Dir.chdir dir
       out, err, status = Open3.capture3 'git', 'clone', repo, 'cloned'
-      unless status.success?
-        errstream.puts out, err
-        exit "Failed somehow >.<"
-      end
+      raise RepoDoesNotExistError, repo unless status.success?
       Dir.chdir 'cloned'
-      files = Dir['**/*'].reject { |name| File.directory? name }
-      files.each do |filename|
-        loc = File.readlines(filename).count { |line| line !~ /^\s*$/ }
-        outstream.puts "#{loc}\t#{filename}"
-      end
+      Dir['**/*'].reject { |name| File.directory? name }
+                 .map    { |name| [name, File.read(name) ] }
     }
+
+    LineCounts.call(names_to_bodies)
   end
 end

data/lib/gitloc/binary.rb

@@ -0,0 +1,13 @@
+require 'gitloc'
+
+class Gitloc
+  class Binary
+    def self.call(argv, outstream, errstream)
+      repo = argv.first
+      files_to_lines = Gitloc.call(repo)
+      files_to_lines.each do |filename, loc|
+        outstream.puts "#{loc}\t#{filename}"
+      end
+    end
+  end
+end

data/lib/gitloc/errors.rb

@@ -0,0 +1,9 @@
+class Gitloc
+  Error = Class.new StandardError
+
+  class RepoDoesNotExistError < Error
+    def initialize(repo_name)
+      super "#{repo_name} does not exist"
+    end
+  end
+end

data/lib/gitloc/line_counts.rb

@@ -0,0 +1,15 @@
+class Gitloc
+  module LineCounts
+    def self.call(names_to_bodies)
+      names_to_bodies
+        .map    { |name, body| [name, count_lines(body)] }
+        .select { |name, body| body }
+    end
+
+    def self.count_lines(body)
+      body.lines.count { |line| line !~ /^\s*$/ }
+    rescue ArgumentError
+      nil
+    end
+  end
+end

data/lib/gitloc/version.rb

@@ -1,3 +1,3 @@
 class Gitloc
-  VERSION = "0.1.1"
+  VERSION = '0.2.0'
 end

data/spec/gitloc_spec.rb

@@ -0,0 +1,8 @@
+require 'gitloc'
+
+RSpec.describe Gitloc do
+  it 'raises RepoDoesNotExistError when the repo does not exist' do
+    expect { Gitloc.call("not-a-repo") }
+      .to raise_error Gitloc::RepoDoesNotExistError, /not-a-repo/
+  end
+end

data/spec/line_counts_spec.rb

@@ -0,0 +1,27 @@
+require 'gitloc/line_counts'
+
+RSpec.describe Gitloc::LineCounts do
+  it 'returns the counts for each file' do
+    counts = described_class.call([["file1", "l1"],
+                                   ["file2", "l1\nl2\nl3"]])
+    expect(counts).to eq [["file1", 1], ["file2", 3]]
+  end
+
+  it 'does not count empty lines' do
+    counts = described_class.call([["file1", ""]])
+    expect(counts).to eq [["file1", 0]]
+
+    counts = described_class.call([["file1", "\n"]])
+    expect(counts).to eq [["file1", 0]]
+
+    counts = described_class.call([["file1", "\nline1\nline2\n"]])
+    expect(counts).to eq [["file1", 2]]
+  end
+
+  it 'omits files of binary data' do
+    counts = described_class.call([["keep1", ""],
+                                   ["binary", "GIF89a\u0000\u0002\u0000\u0001\xD5\u0000\u0000\xCD\xCF\xCF\u00135A/IR\x89\x91\u0017\x85\x92\x93rx{\xBA\xBC\xBD\n"],
+                                   ["keep2", ""]])
+    expect(counts).to eq [["keep1", 0], ["keep2", 0]]
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gitloc-joshcheek
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Josh Cheek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-17 00:00:00.000000000 Z
-dependencies: []
+date: 2015-02-23 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: Example project for the Turing School of Software and Design, see https://github.com/JoshCheek/elective-building-a-gem
   -- gives lines-of-code information for a git repo.
 email: josh.cheek@gmail.com
@@ -18,13 +32,20 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- Gemfile
+- Gemfile.lock
 - Readme.md
 - bin/gitloc
 - gitloc.gemspec
 - lib/gitloc.rb
+- lib/gitloc/binary.rb
+- lib/gitloc/errors.rb
+- lib/gitloc/line_counts.rb
 - lib/gitloc/version.rb
 - spec/acceptance_spec.rb
 - spec/fixtures/2loc
+- spec/gitloc_spec.rb
+- spec/line_counts_spec.rb
 homepage: https://github.com/JoshCheek/elective-building-a-gem
 licenses:
 - MIT