gitlab_quality-test_tooling 3.20.2 → 3.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d63cdc47b44dd111330eaffb4e37c889d8785eb395094eec7398c97870f889f
-  data.tar.gz: bbe3389c97486d566bb8a948da3a88cf94633857d8eee5ad9fbb53e6ba38aef5
+  metadata.gz: 6fa78c58b83ed94504f42df7a78f5bdbddea78f9466134618b6c9b34fa99d679
+  data.tar.gz: bb3b04f2dee89712fd561a944de2d397db62867351f562ac0b0e7cac721424d2
 SHA512:
-  metadata.gz: 81d28ad1a352c06db086546c5eef55f9f82aa982904e4f3e03ab1c7e509d0a18fde12f6e77e7a09eda3c549dd15ff1d0090f532a2da60eda68d31eba77cee93f
-  data.tar.gz: 8aeb35ec5c0fc54e86c9cb029f44c62feb9dbc1e5031f6d4aaba07a9a3e3791a739841da7a1080bf1c28c05c81baee57a42742dca5ab60d1420e8e74360b9b9c
+  metadata.gz: d969c70fbf9efb0aac4020367999aca505d226125a63daeaa8dc6f5ad409f84d8f9bc6a411ada6c9aa5c91627ef8bec768a165bcf4258df0e7e65426d63776c3
+  data.tar.gz: d3329d8d499320cd0fdad6a8a2c9ea669d7310b1076aa5c8130e3c4b79e6f12e2fc2a32ecaa0a11f057860f8c8f82db9551120f5f0b5ce28f9a1898597a74842

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (3.20.2)
+    gitlab_quality-test_tooling (3.21.0)
       activesupport (>= 7.0)
       amatch (~> 0.4.1)
       fog-google (~> 1.24, >= 1.24.1)

data/exe/test-coverage

@@ -73,7 +73,9 @@ options = OptionParser.new do |opts|
       'Inserts rows into code_coverage.test_coverage_per_file and runs the daily ' \
       'test_health_risk aggregation unless --skip-aggregation. Needs only the ' \
       '--clickhouse-* options; --test-reports and --jest-quarantine-file are ' \
-      'optional enrichment. (e.g., "tmp/per-test-coverage-*.ndjson")') do |pattern|
+      'optional enrichment. --test-reports also requires --clickhouse-shared-database, ' \
+      'since category ownership is read from the shared database. ' \
+      '(e.g., "tmp/per-test-coverage-*.ndjson")') do |pattern|
     params[:per_test_coverage] = pattern
   end
 
@@ -135,7 +137,16 @@ mode =
 clickhouse_required = [:clickhouse_url, :clickhouse_database, :clickhouse_username]
 full_export_required =
   [:test_reports, :coverage_report, :test_map, :responsibility_patterns, :clickhouse_shared_database] + clickhouse_required
-required_params = mode == :full_export ? full_export_required : clickhouse_required
+# Per-test mode reads category_owners from the shared database only when it enriches
+# rows (--test-reports present), so require the shared database exactly then.
+per_test_enriching = mode == :per_test && params[:test_reports]
+required_params =
+  case mode
+  when :full_export
+    full_export_required
+  else
+    per_test_enriching ? clickhouse_required + [:clickhouse_shared_database] : clickhouse_required
+  end
 
 unless params.any? && (required_params - params.keys).none?
   puts "Missing argument(s). Required arguments are: #{required_params}\nPassed arguments are: #{params}\n"
@@ -149,7 +160,13 @@ if clickhouse_password.to_s.strip.empty?
   exit 1
 end
 
-non_empty_params = mode == :full_export ? clickhouse_required + [:clickhouse_shared_database] : clickhouse_required
+non_empty_params =
+  if mode == :full_export || per_test_enriching
+    clickhouse_required + [:clickhouse_shared_database]
+  else
+    clickhouse_required
+  end
+
 non_empty_params.each do |param|
   next unless params[param].to_s.strip.empty?
 
@@ -189,6 +206,7 @@ when :per_test
   GitlabQuality::TestTooling::CodeCoverage::PerTestCoverageExporter.new(
     coverage_glob: params[:per_test_coverage],
     clickhouse: clickhouse_data,
+    clickhouse_shared_database: params[:clickhouse_shared_database],
     test_reports: params[:test_reports],
     jest_quarantine_file: params[:jest_quarantine_file],
     skip_aggregation: params.fetch(:skip_aggregation, false)

data/lib/gitlab_quality/test_tooling/code_coverage/per_test_coverage_exporter.rb

@@ -23,12 +23,15 @@ module GitlabQuality
       # aggregation once at the end.
       class PerTestCoverageExporter
         # @param clickhouse [Hash] connection params (:url, :database, :username, :password)
+        # @param clickhouse_shared_database [String, nil] the shared database holding the
+        #   canonical `category_owners`. Required only when enriching (test_reports present).
         def initialize(
-          coverage_glob:, clickhouse:,
+          coverage_glob:, clickhouse:, clickhouse_shared_database: nil,
           test_reports: nil, jest_quarantine_file: nil,
           captured_sha: ENV.fetch('CI_COMMIT_SHA', ''), skip_aggregation: false, logger: nil)
           @coverage_glob = coverage_glob
           @clickhouse = clickhouse
+          @clickhouse_shared_database = clickhouse_shared_database
           @test_reports = test_reports
           @jest_quarantine_file = jest_quarantine_file
           @captured_sha = captured_sha.to_s
@@ -65,8 +68,8 @@ module GitlabQuality
 
         private
 
-        attr_reader :coverage_glob, :clickhouse, :test_reports, :jest_quarantine_file,
-          :captured_sha, :skip_aggregation, :logger
+        attr_reader :coverage_glob, :clickhouse, :clickhouse_shared_database, :test_reports,
+          :jest_quarantine_file, :captured_sha, :skip_aggregation, :logger
 
         def insert(coverage_files)
           tests_to_categories, feature_categories_to_teams = resolve_categories
@@ -144,14 +147,21 @@ module GitlabQuality
           [tests_to_categories_from(report_files), feature_categories_to_teams]
         end
 
-        # Category to group/stage/section, read from `code_coverage.category_owners`
-        # (populated by sync-category-owners). This is the source the full
-        # coverage export already uses, and it retains categories the live
-        # stages.yml fetch has since dropped (global_search and the Duo/AI groups),
-        # so more rows resolve to a real group instead of blank. `owner_records`
-        # gives string-keyed values; PerTestCoverageData reads symbol keys.
+        # Category to group/stage/section, read from `category_owners` in the shared
+        # database, the same source the full coverage export uses. The shared copy is
+        # refreshed by sync-category-owners; the legacy `code_coverage.category_owners`
+        # stopped updating in December 2025, so reading it would drop every category
+        # added since. `owner_records` gives string-keyed values; PerTestCoverageData
+        # reads symbol keys.
         def feature_categories_to_teams
-          ClickHouse::CategoryOwnersTable.new(**clickhouse_credentials).owner_records.transform_values do |owner|
+          if clickhouse_shared_database.to_s.strip.empty?
+            raise ArgumentError,
+              'clickhouse_shared_database is required to enrich per-test rows with category owners'
+          end
+
+          shared_credentials = clickhouse_credentials.merge(database: clickhouse_shared_database)
+
+          ClickHouse::CategoryOwnersTable.new(**shared_credentials).owner_records.transform_values do |owner|
             { group: owner["group"], stage: owner["stage"], section: owner["section"] }
           end
         end

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -151,7 +151,6 @@ module GitlabQuality
               line_number: extract_line_number(test),
               exception: extract_exception_data(test),
               ci_job_url: test.ci_job_url,
-              testcase: extract_test_id_or_name(test),
               product_group: extract_product_group(test),
               level: extract_level(test)
             }
@@ -184,14 +183,6 @@ module GitlabQuality
           }
         end
 
-        def extract_test_id_or_name(test)
-          return test.example_id if test.respond_to?(:example_id)
-          return test.id if test.respond_to?(:id)
-          return test.name if test.respond_to?(:name)
-
-          "#{test.relative_file}:#{test.respond_to?(:line_number) ? test.line_number : 'unknown'}"
-        end
-
         def new_issue_labels(test)
           up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS + group_and_category_labels_for_test(test))
         end

data/lib/gitlab_quality/test_tooling/report/report_as_issue.rb

@@ -63,7 +63,6 @@ module GitlabQuality
           | Test level | `#{test.level}` |
           | Hash | `#{test_hash(test)}` |
           | Max expected duration | < #{test.max_duration_for_test} seconds |
-          #{"| Test case | #{test.testcase} |" if test.testcase}
           <!-- Don't modify this section as it's auto-generated -->
           DESCRIPTION
         end

data/lib/gitlab_quality/test_tooling/report/report_results.rb

@@ -49,16 +49,11 @@ module GitlabQuality
 
               report_test(test)
             end
-
-            test_results.write
           end
         end
 
         def report_test(test)
           testcase = testcase_project_reporter.find_or_create_testcase(test)
-          # The API returns the test case with an issue URL since it is technically a type of issue.
-          # This updates the URL to a valid test case link.
-          test.testcase = testcase.web_url.sub('/issues/', '/quality/test_cases/')
 
           result_issue, is_new = results_issue_project_reporter.get_related_issue(testcase, test)
 

data/lib/gitlab_quality/test_tooling/report/results_in_test_cases.rb

@@ -18,18 +18,17 @@ module GitlabQuality
           find_testcase(test) || create_issue(test)
         end
 
-        def add_result_issue_link_to_testcase(testcase, result_issue, test)
+        def add_result_issue_link_to_testcase(testcase, result_issue, _test)
           results_section = testcase.description.include?(TEST_CASE_RESULTS_SECTION_TEMPLATE) ? '' : TEST_CASE_RESULTS_SECTION_TEMPLATE
 
           gitlab.edit_issue(iid: testcase.iid,
             options: { description: (testcase.description + results_section + "\n\n#{result_issue.web_url}") })
-          # We are using test.testcase for the url here instead of testcase.web_url since it has the updated test case path
-          puts "Added results issue #{result_issue.web_url} link to test case #{test.testcase}"
+          puts "Added results issue #{result_issue.web_url} link to test case #{testcase.web_url}"
         end
 
         def update_testcase(testcase, test)
-          puts "Labels updated for test case #{test.testcase}." if update_labels(testcase, test)
-          puts "Quarantine section updated for test case #{test.testcase}." if update_quarantine_section(testcase, test)
+          puts "Labels updated for test case #{testcase.web_url}." if update_labels(testcase, test)
+          puts "Quarantine section updated for test case #{testcase.web_url}." if update_quarantine_section(testcase, test)
         end
 
         private

data/lib/gitlab_quality/test_tooling/test_meta/processor/meta_processor.rb

@@ -37,7 +37,7 @@ module GitlabQuality
               description_start_index + description_length
             end
 
-            # List specs in markdown with details such as link to code, testcase, metrics and failure issue
+            # List specs in markdown with details such as link to code, metrics and failure issue
             #
             # @param [Hash<String,Hash>] commits The commits hash to use for spec details
             # @return String
@@ -45,7 +45,7 @@ module GitlabQuality
               commits.each_with_index.map do |(changed_line_number, spec), index|
                 <<~MARKDOWN
                   #{index + 1}. [`#{spec['name']}`](https://gitlab.com/#{context.project}/-/blob/#{context.ref}/#{spec['file_path']}#L#{changed_line_number.to_i + 1})
-                      | [Testcase](#{spec['testcase']}) | [Spec metrics](#{context.single_spec_metrics_link(spec['file_path'])})
+                      | [Spec metrics](#{context.single_spec_metrics_link(spec['file_path'])})
                       #{failure_issue_text(spec)}
                 MARKDOWN
               end.join("\n")

data/lib/gitlab_quality/test_tooling/test_result/j_unit_test_result.rb

@@ -4,8 +4,6 @@ module GitlabQuality
   module TestTooling
     module TestResult
       class JUnitTestResult < BaseTestResult
-        attr_accessor :testcase # Ignore it for now
-
         def name
           report['name']
         end

data/lib/gitlab_quality/test_tooling/test_result/json_test_result.rb

@@ -60,14 +60,6 @@ module GitlabQuality
           report.fetch('ci_job_url', '')
         end
 
-        def testcase
-          report.fetch('testcase', '')
-        end
-
-        def testcase=(new_testcase)
-          report['testcase'] = new_testcase
-        end
-
         def quarantine_type
           quarantine['type'] if quarantine?
         end

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "3.20.2"
+    VERSION = "3.21.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 3.20.2
+  version: 3.21.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-07-16 00:00:00.000000000 Z
+date: 2026-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control