gitlab_quality-test_tooling 2.7.0 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc2b98142fc0891fe937da031f64a665ef016c153263b01b7c9820b284967800
-  data.tar.gz: 588d0cec55fb89405d61d6e41528343929d948fe6fb03717edf2e895fe727e5c
+  metadata.gz: 8547ed9407707737f7d776f263543f3681e19706d7705591968f2e0ec348ed88
+  data.tar.gz: 84f1fb8007ce5c5dd96a1782cfa7b75207d456df2b9c163ddde5900f3efe6ad2
 SHA512:
-  metadata.gz: 2402289c4b5282ad62289b7560b0faadc8cabc675d7e0262b38e6582cee5e2e6a2711ab053dc677d2e32d917c8a29608e8b90b485d977d4fe244c6a7e4c47505
-  data.tar.gz: 4bebf905075eb9b8ca2fb707c004d78746d8d8e518a6e10ee7d1085a2e3450b8a33d672a9ef382103deaf996591bd1f7c6b5d86f2249276a7a576a61074acbd7
+  metadata.gz: 43e26da079892ae22a44025b4c96a076b65499e1ab1a5574da130132e9c70358ed12ae9ba123bb645b757b8e177bb59c11fd036f5e8d9d14e22620c5c0616958
+  data.tar.gz: f236ba27bc98161951cc4d98e4ff22321eeee476b6e305c0b67e2d58b09f6329a0361c9d834c20ff3efa86b41f5763733eb278c755fffa1e5fa49d25c556c1a9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (2.7.0)
+    gitlab_quality-test_tooling (2.8.0)
       activesupport (>= 7.0, < 7.2)
       amatch (~> 0.4.1)
       fog-google (~> 1.24, >= 1.24.1)

data/lib/gitlab_quality/test_tooling/report/concerns/group_and_category_labels.rb

@@ -5,20 +5,14 @@ module GitlabQuality
     module Report
       module Concerns
         module GroupAndCategoryLabels
-          def labels_inference
-            @labels_inference ||= GitlabQuality::TestTooling::LabelsInference.new
-          end
-
-          def new_issue_labels(test)
-            debug_line = '  => [DEBUG] '
-            debug_line += "product_group: #{test&.product_group}; " if test.respond_to?(:product_group)
-            debug_line += "feature_category: #{test&.feature_category}" if test.respond_to?(:feature_category)
-            puts debug_line
+          def group_and_category_labels_for_test(test)
+            labels_inference = GitlabQuality::TestTooling::LabelsInference.new
+            new_labels       = Set.new
 
-            new_labels = self.class::NEW_ISSUE_LABELS
             new_labels += labels_inference.infer_labels_from_product_group(test.product_group) if test.respond_to?(:product_group)
             new_labels += labels_inference.infer_labels_from_feature_category(test.feature_category) if test.respond_to?(:feature_category)
-            up_to_date_labels(test: test, new_labels: new_labels)
+
+            new_labels
           end
         end
       end

data/lib/gitlab_quality/test_tooling/report/concerns/utils.rb

@@ -15,6 +15,10 @@ module GitlabQuality
             "#{title[...MAX_TITLE_LENGTH - 3]}..."
           end
 
+          def label_names_to_label_quick_action(label_names)
+            %(/label #{label_names.map { |label| %(~"#{label}") }.join(' ')})
+          end
+
           def new_issue_title(test)
             "[Test] #{partial_file_path(test.file)} | #{search_safe(test.name)}".strip
           end

data/lib/gitlab_quality/test_tooling/report/failed_test_issue.rb

@@ -57,7 +57,7 @@ module GitlabQuality
           current_reports_note = find_failure_discussion_note(issue: issue, test: test, reports_discussion: reports_discussion)
 
           new_reports_list = new_reports_list(current_reports_note: current_reports_note, test: test)
-          note_body        = new_note_body(
+          note_body        = append_quick_actions_to_note(
             new_reports_list: new_reports_list,
             related_issues: related_issues,
             options: {
@@ -105,6 +105,14 @@ module GitlabQuality
           IDENTITY_LABELS
         end
 
+        def new_issue_labels(test)
+          up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS + group_and_category_labels_for_test(test))
+        end
+
+        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
+          (base_issue_labels + super).to_a
+        end
+
         def report_section_header
           REPORT_SECTION_HEADER
         end
@@ -139,10 +147,6 @@ module GitlabQuality
           quick_actions.join("\n")
         end
 
-        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
-          (base_issue_labels + super).to_a
-        end
-
         def find_failure_discussion_note(issue:, test:, reports_discussion:)
           return unless reports_discussion
 

data/lib/gitlab_quality/test_tooling/report/flaky_test_issue.rb

@@ -44,6 +44,14 @@ module GitlabQuality
           IDENTITY_LABELS
         end
 
+        def new_issue_labels(test)
+          up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS)
+        end
+
+        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
+          (base_issue_labels + super).to_a
+        end
+
         def report_section_header
           REPORT_SECTION_HEADER
         end
@@ -52,22 +60,22 @@ module GitlabQuality
           REPORTS_DOCUMENTATION
         end
 
-        def health_problem_status_label_quick_action(reports_list, **)
+        def health_problem_status_label_quick_action(reports_list, options: {})
           case reports_list.reports_count
           when 399..Float::INFINITY
-            '/label ~"flakiness::1"'
+            label_names = Set.new(['flakiness::1'])
+            label_names += group_and_category_labels_for_test(options[:test]) if options.key?(:test)
+            label_names_to_label_quick_action(label_names)
           when 37..398
-            '/label ~"flakiness::2"'
+            label_names = Set.new(['flakiness::2'])
+            label_names += group_and_category_labels_for_test(options[:test]) if options.key?(:test)
+            label_names_to_label_quick_action(label_names)
           when 13..36
             '/label ~"flakiness::3"'
           else
             '/label ~"flakiness::4"'
           end
         end
-
-        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
-          (base_issue_labels + super).to_a
-        end
       end
     end
   end

data/lib/gitlab_quality/test_tooling/report/health_problem_reporter.rb

@@ -45,6 +45,10 @@ module GitlabQuality
           []
         end
 
+        def new_issue_labels(_test)
+          []
+        end
+
         def search_labels
           BASE_SEARCH_LABELS
         end
@@ -57,10 +61,6 @@ module GitlabQuality
           ''
         end
 
-        def health_problem_status_label_quick_action(*)
-          ''
-        end
-
         def item_extra_content(_test)
           found_label
         end
@@ -115,7 +115,13 @@ module GitlabQuality
           current_reports_note = existing_reports_note(issue_iid: issue.iid)
 
           new_reports_list = new_reports_list(current_reports_note: current_reports_note, test: test)
-          note_body        = new_note_body(new_reports_list: new_reports_list, related_issues: related_issues)
+          note_body        = append_quick_actions_to_note(
+            new_reports_list: new_reports_list,
+            related_issues: related_issues,
+            options: {
+              test: test
+            }
+          )
 
           if current_reports_note
             gitlab.edit_issue_note(
@@ -138,7 +144,7 @@ module GitlabQuality
           )
         end
 
-        def new_note_body(new_reports_list:, related_issues:, options: {})
+        def append_quick_actions_to_note(new_reports_list:, related_issues:, options: {})
           report = new_reports_list
 
           quick_actions = [
@@ -164,10 +170,15 @@ module GitlabQuality
           end
         end
 
+        # Defined in subclasses
+        def health_problem_status_label_quick_action(*)
+          ''
+        end
+
         def identity_labels_quick_action
           return if identity_labels.empty?
 
-          %(/label #{identity_labels.map { |label| %(~"#{label}") }.join(' ')})
+          label_names_to_label_quick_action(identity_labels)
         end
 
         def relate_issues_quick_actions(issues)

data/lib/gitlab_quality/test_tooling/report/knapsack_report_issue.rb

@@ -39,6 +39,10 @@ module GitlabQuality
           search_and_create_issue
         end
 
+        def new_issue_labels(test)
+          up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS + group_and_category_labels_for_test(test))
+        end
+
         def search_and_create_issue
           filtered_report = KnapsackReports::SpecRunTimeReport.new(
             token: token,

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -80,6 +80,14 @@ module GitlabQuality
           end
         end
 
+        def new_issue_labels(test)
+          up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS + group_and_category_labels_for_test(test))
+        end
+
+        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
+          (Set.new(base_issue_labels) + (super << pipeline_name_label)).to_a
+        end
+
         def test_metric_collections
           @test_metric_collections ||= Dir.glob(metrics_files).map do |path|
             TestMetrics::JsonTestMetricCollection.new(path)
@@ -448,10 +456,6 @@ module GitlabQuality
           section
         end
 
-        def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
-          (Set.new(base_issue_labels) + (super << pipeline_name_label)).to_a
-        end
-
         def new_issue_assignee_id(test)
           return unless test.product_group?
 

data/lib/gitlab_quality/test_tooling/report/report_as_issue.rb

@@ -144,6 +144,9 @@ module GitlabQuality
           gitlab.edit_issue(iid: issue.iid, options: { labels: labels.to_a })
         end
 
+        # Infer labels from the test, and optionally from the issue and new_labels in arguments
+        #
+        # Called when we're updating a test health issue with a new test report.
         def up_to_date_labels(test:, issue: nil, new_labels: Set.new)
           labels = issue_labels(issue)
           labels |= new_labels.to_set

data/lib/gitlab_quality/test_tooling/report/slow_test_issue.rb

@@ -34,6 +34,10 @@ module GitlabQuality
           IDENTITY_LABELS
         end
 
+        def new_issue_labels(test)
+          up_to_date_labels(test: test, new_labels: NEW_ISSUE_LABELS)
+        end
+
         def report_section_header
           REPORT_SECTION_HEADER
         end
@@ -42,12 +46,16 @@ module GitlabQuality
           REPORTS_DOCUMENTATION
         end
 
-        def health_problem_status_label_quick_action(reports_list, **)
+        def health_problem_status_label_quick_action(reports_list, options: {})
           case reports_list.reports_count
           when 6099..Float::INFINITY
-            '/label ~"slowness::1"'
+            label_names = Set.new(['slowness::1'])
+            label_names += group_and_category_labels_for_test(options[:test]) if options.key?(:test)
+            label_names_to_label_quick_action(label_names)
           when 2177..6098
-            '/label ~"slowness::2"'
+            label_names = Set.new(['slowness::2'])
+            label_names += group_and_category_labels_for_test(options[:test]) if options.key?(:test)
+            label_names_to_label_quick_action(label_names)
           when 521..2176
             '/label ~"slowness::3"'
           else

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "2.7.0"
+    VERSION = "2.8.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.8.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-02-13 00:00:00.000000000 Z
+date: 2025-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control