gitlab-triage 1.43.0 → 1.43.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95d1d38e50b3032593baffe5e3122da139f542294529cadaaffa5e2861d0a428
-  data.tar.gz: 83ac90f1c5815c5a39a6cb5d3d84b34112a1a3a72f2dd9a9481291bc171648c3
+  metadata.gz: e9477540c0d56866682afeb01649483e1b1d1eb7401906e7d2b74459426f9cbd
+  data.tar.gz: f68223b942d7617c0caadd7c928f192c751573c6fd2df012afec95650c7e25c9
 SHA512:
-  metadata.gz: 8d0aef0429e6892959468c199b0bddbb18ecf02bf864ee038f59b01f35e779a200724e8841b3f603add6267a5a6b3c7746520d10bc48d77c2a6a025e5d3ddaa2
-  data.tar.gz: 70ea6376e7855ce5ac2207d0f0dc779d8d4e32eb800192c5d3ec8cbfa546425797087525c6a281bfd5513b4d8d4619cf6a81e7fd2e59b7c48d77972653ca5b37
+  metadata.gz: bc6d78e35535fa13116db621b8d7e32ceed744d1d020d5d38e52ece77363d70f01bbc5aa9eaaa8e02fc13e0f4bee1677392d145bf7c9f1eb21d4df109e5d95e6
+  data.tar.gz: 351c4c8e9a2cbf255682391a3911f0049d9bca0ab247ef96eae9e576f3d0e811792b4a4154bed4efa60836b1ad1b93284b8b94f3beec54a286d075cc65db799c

data/.gitignore

@@ -3,7 +3,6 @@
 /.rspec
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /pkg/

data/.gitlab-ci.yml

@@ -7,26 +7,27 @@ stages:
 default:
   tags:
     - gitlab-org
- 
+
 .ruby-cache: &ruby-cache
   cache:
     key:
       files:
-        - Gemfile
-        - gitlab-triage.gemspec
+        - Gemfile.lock
     paths:
       - vendor/ruby
-      - Gemfile.lock
     policy: pull
 
 .use-ruby:
   image: ruby:3.2
   <<: *ruby-cache
+  variables:
+    BUNDLE_FROZEN: "true"
+    BUNDLE_PATH: "vendor"
   before_script:
     - ruby --version
     - gem install bundler --no-document
     - bundle --version
-    - bundle install --jobs $(nproc) --path=vendor --retry 3 --quiet
+    - bundle install --jobs $(nproc) --retry 3 --quiet
     - bundle check
 
 workflow:

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 10000`
-# on 2024-04-16 16:23:46 UTC using RuboCop version 1.57.2.
+# on 2024-06-13 12:56:53 UTC using RuboCop version 1.62.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -25,6 +25,17 @@ CodeReuse/ActiveRecord:
     - 'spec/support/shared_examples/label_command_shared_examples.rb'
     - 'spec/support/stub_api.rb'
 
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Categories, ExpectedOrder.
+# ExpectedOrder: module_inclusion, constants, public_class_methods, initializer, public_methods, protected_methods, private_methods
+Layout/ClassStructure:
+  Exclude:
+    - 'lib/gitlab/triage/filters/base_conditions_filter.rb'
+    - 'lib/gitlab/triage/filters/member_conditions_filter.rb'
+    - 'lib/gitlab/triage/graphql_queries/query_builder.rb'
+    - 'lib/gitlab/triage/limiters/base_limiter.rb'
+
 # Offense count: 1
 Lint/ToEnumArguments:
   Exclude:
@@ -43,6 +54,51 @@ Performance/MethodObjectAsBlock:
 RSpec/MultipleMemoizedHelpers:
   Max: 10
 
+# Offense count: 305
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/gitlab/triage/action/comment_on_summary_spec.rb'
+    - 'spec/gitlab/triage/action/comment_spec.rb'
+    - 'spec/gitlab/triage/action/delete_spec.rb'
+    - 'spec/gitlab/triage/action/issue_spec.rb'
+    - 'spec/gitlab/triage/action/summarize_spec.rb'
+    - 'spec/gitlab/triage/action_spec.rb'
+    - 'spec/gitlab/triage/engine_spec.rb'
+    - 'spec/gitlab/triage/entity_builders/issue_builder_spec.rb'
+    - 'spec/gitlab/triage/entity_builders/summary_builder_spec.rb'
+    - 'spec/gitlab/triage/expand_condition/expansion_spec.rb'
+    - 'spec/gitlab/triage/expand_condition/list_spec.rb'
+    - 'spec/gitlab/triage/expand_condition/sequence_spec.rb'
+    - 'spec/gitlab/triage/expand_condition_spec.rb'
+    - 'spec/gitlab/triage/filters/branch_date_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/discussions_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/issue_date_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/merge_request_date_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/no_additional_labels_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/ruby_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/filters/votes_conditions_filter_spec.rb'
+    - 'spec/gitlab/triage/limiters/date_field_limiter_spec.rb'
+    - 'spec/gitlab/triage/network_adapters/httparty_adapter_spec.rb'
+    - 'spec/gitlab/triage/policies/base_policy_spec.rb'
+    - 'spec/gitlab/triage/policies/rule_policy_spec.rb'
+    - 'spec/gitlab/triage/policies/summary_policy_spec.rb'
+    - 'spec/gitlab/triage/resource/base_spec.rb'
+    - 'spec/gitlab/triage/resource/context_spec.rb'
+    - 'spec/gitlab/triage/resource/epic_spec.rb'
+    - 'spec/gitlab/triage/resource/instance_version_spec.rb'
+    - 'spec/gitlab/triage/resource/issue_spec.rb'
+    - 'spec/gitlab/triage/resource/label_event_spec.rb'
+    - 'spec/gitlab/triage/resource/label_spec.rb'
+    - 'spec/gitlab/triage/resource/linked_issue_spec.rb'
+    - 'spec/gitlab/triage/resource/merge_request_spec.rb'
+    - 'spec/gitlab/triage/resource/milestone_spec.rb'
+    - 'spec/gitlab/triage/resource/shared/issuable_spec.rb'
+    - 'spec/gitlab/triage/rest_api_network_spec.rb'
+    - 'spec/gitlab/triage/retryable_spec.rb'
+    - 'spec/gitlab/triage/url_builders/url_builder_spec.rb'
+
 # Offense count: 10
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
@@ -54,13 +110,6 @@ RSpec/NoExpectationExample:
     - 'spec/integration/redact_confidentials_spec.rb'
     - 'spec/integration/summary_policies_spec.rb'
 
-# Offense count: 1
-# Configuration parameters: Include.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/SpecFilePathSuffix:
-  Exclude:
-    - 'spec/integration/issue_action_policy.rb'
-
 # Offense count: 12
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:

data/.tool-versions

@@ -1 +1 @@
-ruby 3.2.3
+ruby 3.1.5

data/Gemfile.lock

@@ -0,0 +1,239 @@
+PATH
+  remote: .
+  specs:
+    gitlab-triage (1.43.1)
+      activesupport (>= 5.1)
+      globalid (~> 1.0, >= 1.0.1)
+      graphql (< 2.1.0)
+      graphql-client (~> 0.16)
+      httparty (~> 0.20.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (7.1.3.4)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      mutex_m
+      tzinfo (~> 2.0)
+    addressable (2.8.6)
+      public_suffix (>= 2.0.2, < 6.0)
+    ast (2.4.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.8)
+    claide (1.1.0)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    concurrent-ruby (1.3.3)
+    connection_pool (2.4.1)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    crack (1.0.0)
+      bigdecimal
+      rexml
+    danger (9.4.3)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 3.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.13)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (>= 4.0)
+      terminal-table (>= 1, < 4)
+    danger-gitlab (8.0.0)
+      danger
+      gitlab (~> 4.2, >= 4.2.0)
+    diff-lcs (1.5.1)
+    drb (2.2.1)
+    faraday (2.9.1)
+      faraday-net_http (>= 2.0, < 3.2)
+    faraday-http-cache (2.5.1)
+      faraday (>= 0.8)
+    faraday-net_http (3.1.0)
+      net-http
+    ffi (1.17.0)
+    formatador (1.1.0)
+    git (1.19.1)
+      addressable (~> 2.8)
+      rchardet (~> 1.8)
+    gitlab (4.19.0)
+      httparty (~> 0.20)
+      terminal-table (>= 1.5.1)
+    gitlab-dangerfiles (2.11.0)
+      danger (>= 8.4.5)
+      danger-gitlab (>= 8.0.0)
+    gitlab-styles (12.0.1)
+      rubocop (~> 1.62.1)
+      rubocop-factory_bot (~> 2.25.1)
+      rubocop-graphql (~> 1.5.0)
+      rubocop-performance (~> 1.20.2)
+      rubocop-rails (~> 2.24.0)
+      rubocop-rspec (~> 2.27.1)
+    globalid (1.2.1)
+      activesupport (>= 6.1)
+    graphql (2.0.31)
+      base64
+    graphql-client (0.22.0)
+      activesupport (>= 3.0)
+      graphql (>= 1.13.0)
+    guard (2.18.1)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.13.0)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    hashdiff (1.1.0)
+    httparty (0.20.0)
+      mime-types (~> 3.0)
+      multi_xml (>= 0.5.2)
+    i18n (1.14.5)
+      concurrent-ruby (~> 1.0)
+    json (2.7.2)
+    kramdown (2.4.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    language_server-protocol (3.17.0.3)
+    lefthook (1.6.16)
+    listen (3.9.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.10)
+    method_source (1.1.0)
+    mime-types (3.5.2)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2024.0305)
+    minitest (5.23.1)
+    multi_xml (0.6.0)
+    mutex_m (0.2.0)
+    nap (1.1.0)
+    nenv (0.3.0)
+    net-http (0.4.1)
+      uri
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (9.1.0)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
+    open4 (1.3.4)
+    parallel (1.25.1)
+    parser (3.3.3.0)
+      ast (~> 2.4.1)
+      racc
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (5.0.5)
+    racc (1.8.0)
+    rack (3.1.3)
+    rainbow (3.1.1)
+    rake (13.2.1)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.11.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (2.9.2)
+    rexml (3.3.0)
+      strscan
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.62.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
+    rubocop-capybara (2.21.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-graphql (1.5.2)
+      rubocop (>= 0.90, < 2)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.24.1)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (2.27.1)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+    ruby-progressbar (1.13.0)
+    sawyer (0.9.2)
+      addressable (>= 2.3.5)
+      faraday (>= 0.17.3, < 3)
+    shellany (0.0.1)
+    strscan (3.1.0)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.3.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.5.0)
+    uri (0.13.0)
+    webmock (3.23.1)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    yard (0.9.36)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  gitlab-dangerfiles (~> 2.11.0)
+  gitlab-styles (~> 12.0)
+  gitlab-triage!
+  guard-rspec (~> 4.7.3)
+  lefthook (~> 1.3)
+  rake (~> 13.2)
+  rspec (~> 3.8)
+  webmock (~> 3.4)
+  yard
+
+BUNDLED WITH
+   2.5.11

data/gitlab-triage.gemspec

@@ -40,18 +40,15 @@ Gem::Specification.new do |spec|
   # see: https://github.com/github/graphql-client/pull/314
   # We can remove this check once PR 314 is merged and released
   spec.add_dependency 'graphql', '< 2.1.0'
-  spec.add_dependency 'httparty', '~> 0.17'
+  # Matching version of triage-ops's httparty
+  spec.add_dependency 'httparty', '~> 0.20.0'
 
   spec.add_development_dependency 'gitlab-dangerfiles', '~> 2.11.0'
-  spec.add_development_dependency 'gitlab-styles', '~> 10.0'
+  spec.add_development_dependency 'gitlab-styles', '~> 12.0'
   spec.add_development_dependency 'guard-rspec', '~> 4.7.3'
   spec.add_development_dependency 'lefthook', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 13.2'
   spec.add_development_dependency 'rspec', '~> 3.8'
-  # we do not commit the bundle lockfile, so this temporary workaround needs to be
-  # present until 2.21.3 or 2.22.x is released
-  # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/63
-  spec.add_development_dependency 'rubocop-rails', '!= 2.21.2'
   spec.add_development_dependency 'webmock', '~> 3.4'
   spec.add_development_dependency 'yard'
 end

data/lib/gitlab/triage/engine.rb

@@ -168,7 +168,7 @@ module Gitlab
           raise(
             ArgumentError,
             "--resource-reference can only start with '#' or '!' when --source=projects is passed " \
-            "('#{options.resource_reference}' passed)!"
+              "('#{options.resource_reference}' passed)!"
           )
         end
       end

data/lib/gitlab/triage/graphql_queries/query_builder.rb

@@ -151,9 +151,9 @@ module Gitlab
           args =
             case condition.to_s
             when 'forbidden_labels'
-              ['labels', condition_params, { negated: true }]
+              ['labelName', condition_params, { negated: true }]
             when 'labels'
-              ['labels', condition_params, {}]
+              ['labelName', condition_params, {}]
             else
               return nil
             end

data/lib/gitlab/triage/policies/base_policy.rb

@@ -21,7 +21,7 @@ module Gitlab
         end
 
         def name
-          @name ||= (policy_spec[:name] || "#{type}-#{object_id}")
+          @name ||= policy_spec[:name] || "#{type}-#{object_id}"
         end
 
         def source

data/lib/gitlab/triage/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Triage
-    VERSION = '1.43.0'
+    VERSION = '1.43.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 1.43.0
+  version: 1.43.1
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-11 00:00:00.000000000 Z
+date: 2024-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,14 +78,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: 0.20.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.17'
+        version: 0.20.0
 - !ruby/object:Gem::Dependency
   name: gitlab-dangerfiles
   requirement: !ruby/object:Gem::Requirement
@@ -106,14 +106,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -170,20 +170,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.8'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "!="
-      - !ruby/object:Gem::Version
-        version: 2.21.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "!="
-      - !ruby/object:Gem::Version
-        version: 2.21.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -237,6 +223,7 @@ files:
 - CONTRIBUTING.md
 - Dangerfile
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LICENSE.md
 - README.md