gitlab-triage 1.40.0 → 1.41.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cfdea1ee1028eae3c0856a944bf0b1c4c6888868256f0b7cd9db1e8a76be5834
-  data.tar.gz: e62f0fba823a7cbcee083a8e95041c1adb20f014f82dcd111648f5d5560922cc
+  metadata.gz: 3eb3292f79448004c49e7196b24da06e6609f5a0215a985472c95de9aeac4150
+  data.tar.gz: f6f94b45be9c7fe6cc43732e3d953455dad93e7246d69ea81162a91f6557a862
 SHA512:
-  metadata.gz: a418d3df3aa5db3b89521404bcd77b7a5e4ab40b8b0063e56e11f78e8297ba7e2637ec9ef62ccbce08cf3cde4bfd1e562b043727e7a8442bf2c8e9d45a50c6f3
-  data.tar.gz: 44fad5107f9ad6ad62519da34fb56ae9518a1f652cbe6ccf6e6fd3d0d07b83e98106bc1235482fff05151deb06507d75d74aa82d9f117b0af72ce3f0763f967e
+  metadata.gz: 2b9866966f5f200c25500af8679d2206e413fdd212dba09bbf48ae63d4cb55bf1415b0afded9f308864657f5246fe55cb859769fb2564aa49b4bb0adc946145a
+  data.tar.gz: d662bcbe691135305db76078e76d67be3073273ba4c3dd4f39d5a98a649be5ed0ed06c280869549a3bb3e7bceb74942a34aa8312e3a514ebfec835b1f343f5bd

data/.gitlab/merge_request_templates/Release.md

@@ -2,7 +2,7 @@
 commit from this merge request, and `<NEW_VERSION>` with the upcoming version number. -->
 ## Diff
 
-https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/compare/v<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
+https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/compare/v<PREVIOUS_VERSION>...<COMMIT_UPDATING_VERSION>
 
 ## Checklist
 

data/README.md

@@ -631,7 +631,7 @@ conditions:
 
 ##### Protected condition
 
-** This condition is only applicable for branches**
+**This condition is only applicable for branches**
 
 Accept a boolean.
 If not specified, default to `false` to filter out protected branches.
@@ -692,7 +692,7 @@ resources. For example, if the conditions are satisfied by thousands of issues a
 limit can be configured to process only fifty of them to avoid making an
 overwhelming number of changes at once.
 
-Accepts a key and value pair where the key is `most_recent` or `oldest`and the
+Accepts a key and value pair where the key is `most_recent` or `oldest` and the
 value is the number of resources to act on. The following table outlines how
 each key affects the sorting and order of resources that it limits.
 
@@ -840,7 +840,8 @@ The following placeholders are supported:
 - `author`: the username of the resource's author as `@user1`
 - `assignee`: the username of the resource's assignee as `@user1`
 - `assignees`: the usernames of the resource's assignees as `@user1, @user2`
-- `closed_by`: the user that closed the resource as `@user1` (if applicable)
+- `reviewers`: the usernames ot the resource's reviewers as `@user1, @user2` (if applicable)
+- `closed_by`: the user that closed the resource as `@user1` (if applicable) 
 - `merged_by`: the user that merged the resource as `@user1` (if applicable)
 - `milestone`: the resource's current milestone
 - `labels`: the resource's labels as `~label1, ~label2`
@@ -906,6 +907,22 @@ actions:
     {{author}} Are you still interested in finishing this merge request?
 ```
 
+###### Comment internal action option
+
+Determines whether the note is added as an internal comment to the resource.
+
+If the option is set to `false` or not set, the comment will not be internal. \
+When it is set to `true`, the comment will be internal.
+
+Example:
+
+```yml
+actions:
+  comment_internal: true
+  comment: |
+    This issue has breached SLA, please take a look @team!
+```
+
 ###### Harnessing Quick Actions
 
 [GitLab's quick actions feature](https://docs.gitlab.com/ce/user/project/quick_actions.html) is available in Core.
@@ -1019,21 +1036,24 @@ resource_rules:
 
 Which could generate an issue like:
 
-* Title:
-  ```
-  Issues require labels
-  ```
-* Description:
-  ``` markdown
-  The following issues require labels:
+Title:
+
+```
+Issues require labels
+```
+
+Description:
 
-  - [ ] [An example issue](http://example.com/group/project/issues/1) ~"label A", ~"label B"
-  - [ ] [Another issue](http://example.com/group/project/issues/2) ~"label B", ~"label C"
+```markdown
+The following issues require labels:
 
-  Please take care of them before the end of 2000-01-01
+- [ ] [An example issue](http://example.com/group/project/issues/1) ~"label A", ~"label B"
+- [ ] [Another issue](http://example.com/group/project/issues/2) ~"label B", ~"label C"
 
-  /label ~"needs attention"
-  ```
+Please take care of them before the end of 2000-01-01
+
+/label ~"needs attention"
+```
 
 ##### Comment on summary action
 
@@ -1208,28 +1228,31 @@ resource_rules:
 
 Which could generate an issue like:
 
-* Title:
-  ```
-  Newest and oldest issues summary
-  ```
-* Description:
-  ``` markdown
-  Please triage the following issues:
+Title:
 
-  Please triage the following new issues:
+```
+Newest and oldest issues summary
+```
+
+Description:
+
+```markdown
+Please triage the following issues:
 
-  - [ ] [A new issue](http://example.com/group/project/issues/4)
-  - [ ] [Another new issue](http://example.com/group/project/issues/3) ~"label B", ~"label C"
+Please triage the following new issues:
 
-  Please triage the following old issues:
+- [ ] [A new issue](http://example.com/group/project/issues/4)
+- [ ] [Another new issue](http://example.com/group/project/issues/3) ~"label B", ~"label C"
 
-  - [ ] [An old issue](http://example.com/group/project/issues/1) ~"label A", ~"label B"
-  - [ ] [Another old issue](http://example.com/group/project/issues/2) ~"label C"
+Please triage the following old issues:
 
-  Please take care of them before the end of 2000-01-01
+- [ ] [An old issue](http://example.com/group/project/issues/1) ~"label A", ~"label B"
+- [ ] [Another old issue](http://example.com/group/project/issues/2) ~"label C"
 
-  /label ~"needs attention"
-  ```
+Please take care of them before the end of 2000-01-01
+
+/label ~"needs attention"
+```
 
 > **Note:** If a specific policy doesn't yield any resources, it will not
 > generate the corresponding description. If all policies yield no resources,
@@ -1276,6 +1299,7 @@ Here's a list of currently available Ruby expression API:
 | Method              | Return type | Description |
 | ----                | ----        | ----        |
 | first_contribution? | Boolean     | `true` if it's the author's first contribution to the project; `false` otherwise. This API requires an additional API request for the merge request, thus would be slower. |
+| closes_issues       | [Issue]     | The list of issues that would be closed by merging the provided merge request |
 
 ##### Methods for `Milestone`
 

data/lib/gitlab/triage/action/comment.rb

@@ -63,7 +63,7 @@ module Gitlab
         def perform(resource, comment)
           network.post_api(
             build_post_url(resource),
-            body: comment)
+            post_body(comment))
         end
 
         def build_post_url(resource)
@@ -103,6 +103,13 @@ module Gitlab
             resource['iid']
           end
         end
+
+        def post_body(comment)
+          body = { body: comment }
+          body[:internal] = true if policy.actions[:comment_internal]
+
+          body
+        end
       end
     end
   end

data/lib/gitlab/triage/command_builders/text_content_builder.rb

@@ -19,6 +19,7 @@ module Gitlab
           author: "@{{author.username}}",
           assignee: "@{{assignee.username}}",
           assignees: "@{{assignees.username}}",
+          reviewers: "@{{reviewers.username}}",
           source_branch: "{{source_branch}}",
           target_branch: "{{target_branch}}",
           closed_by: "@{{closed_by.username}}",

data/lib/gitlab/triage/resource/merge_request.rb

@@ -17,6 +17,12 @@ module Gitlab
             expanded[:first_contribution]
           end
         end
+
+        def closes_issues
+          @closes_issues ||= network.query_api_cached(
+            resource_url(sub_resource_type: 'closes_issues'))
+            .map { |issue| Issue.new(issue, parent: self) }
+        end
       end
     end
   end

data/lib/gitlab/triage/rest_api_network.rb

@@ -46,7 +46,11 @@ module Gitlab
           when Array
             resources.concat(results)
           when Hash
-            resources << results
+            if results['message']&.match?(/404 Group|Project Not Found/)
+              raise_unexpected_response(results)
+            else
+              resources << results
+            end
           else
             raise_unexpected_response(results)
           end

data/lib/gitlab/triage/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Triage
-    VERSION = '1.40.0'
+    VERSION = '1.41.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 1.40.0
+  version: 1.41.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-30 00:00:00.000000000 Z
+date: 2023-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport