gitlab-triage 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f66d8205af90c7d802349af07f84b1dd4479e8fda279f2cbcd6732fca07e19a
-  data.tar.gz: 2c2915b5044889177e1fab61d9a7c30755a5629bd95352b044aaf43c794dd9cb
+  metadata.gz: f135ad3ee8a932b96aa63b996b47c3dfb4c144a8294087492c75b206fd9cc0a5
+  data.tar.gz: 0af305681bc53fdd8d3b7f0a8eb86889d1da37bef53b24d837b067c336d02142
 SHA512:
-  metadata.gz: 7032c596be646b9119be23d50f29538734b810b7b1565c7ff814e672f6d444a8c1f666779764e4ef83a1cc915d49a8fb2a99747b9921ef9653f6c06a90ec30e4
-  data.tar.gz: 865d9321ce3ae41de914ef51daf621eb3208e77029e192e58166ac481ff612793801d4d9ad1d2e5e4f6dfd8180ec0c1f3eebbe37f559e60300e1e917af5e1f40
+  metadata.gz: 4e415ad62d834aaf20ca0f567bdd135fc36d8e9c8cd92251410aab5464232c227af6032adcbba9bc7ca955bbbc72e4192f495dc56ecc1f18d2fac249cc96fd42
+  data.tar.gz: 8a6b44160f809fb5b4fc3ef5bcd0d09f7b12dba043d543a27c8b4ce31549b2b9cb32317bd205bcd23faaf445a3fca27bf80af9a937f52dfd2c96073530600ebb

data/.gitlab-ci.yml

@@ -19,7 +19,7 @@ stages:
 before_script:
   - gem install bundler
   - bundle --version
-  - bundle install --jobs $(nproc) --retry 3 --quiet
+  - bundle update --jobs $(nproc) --retry 3 --quiet
 
 ###################
 ## Prepare stage ##

data/Gemfile

@@ -2,3 +2,9 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in gitlab-rubocop.gemspec
 gemspec
+
+group :test do
+  # Pin these dependencies, otherwise a new rule could break the CI pipelines
+  gem 'rubocop', '0.51.0'
+  gem 'rubocop-rspec', '1.19.0'
+end

data/README.md

@@ -1,4 +1,4 @@
-[![pipeline status](https://gitlab.com/gitlab-org/triage/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/triage/commits/master)
+[![pipeline status](https://gitlab.com/gitlab-org/gitlab-triage/badges/master/pipeline.svg)](https://gitlab.com/gitlab-org/gitlab-triage/commits/master)
 
 # GitLab Triage Project
 
@@ -45,7 +45,7 @@ resource_rules:
             interval: 5
           state: opened
           label:
-            - No label
+            - No Label
         actions:
           labels:
             - needs attention
@@ -86,6 +86,7 @@ Available condition types:
 - [`upvotes` condition](#upvotes-condition)
 - [`labels` condition](#labels-condition)
 - [`forbidden_labels` condition](#forbidden-labels-condition)
+- [`author_member` condition](#author-member-condition)
 
 ##### Date condition
 
@@ -188,6 +189,30 @@ conditions:
     - awaiting feedback
 ```
 
+##### Author Member condition
+
+This condition determines whether the author of a resource is a member of the specified group or project.
+
+This is useful for determining whether Issues or Merge Requests have been raised by a Community Contributor.
+
+Accepts a hash of fields.
+
+| Field           | Type    | Values                              | Required  |
+| ---------       | ----    | ----                                | --------  |
+| `source`        | string  | `group`, `project`                  | yes       |
+| `condition`     | string  | `member_of`, `not_member_of`        | yes       |
+| `source_id`     | integer | integer                             | yes       |
+
+Example:
+
+```yml
+conditions:
+  author:
+    source: group
+    condition: not_member_of
+    source_id: 9970
+```
+
 #### Actions field
 
 Used to declare an action to be carried out on a resource if **all** conditions are satisfied.

data/lib/gitlab/triage/engine.rb

@@ -3,6 +3,7 @@ require 'active_support/all'
 require_relative 'limiters/date_conditions_limiter'
 require_relative 'limiters/votes_conditions_limiter'
 require_relative 'limiters/forbidden_labels_conditions_limiter'
+require_relative 'limiters/author_member_conditions_limiter'
 require_relative 'command_builders/comment_command_builder'
 require_relative 'command_builders/label_command_builder'
 require_relative 'command_builders/remove_label_command_builder'
@@ -99,6 +100,7 @@ module Gitlab
           results << Limiters::DateConditionsLimiter.new(resource, conditions[:date]).calculate if conditions[:date]
           results << Limiters::VotesConditionsLimiter.new(resource, conditions[:upvotes]).calculate if conditions[:upvotes]
           results << Limiters::ForbiddenLabelsConditionsLimiter.new(resource, conditions[:forbidden_labels]).calculate if conditions[:forbidden_labels]
+          results << Limiters::AuthorMemberConditionsLimiter.new(resource, conditions[:author_member], { host_url: host_url, api_version: api_version, token: options.token, network: network }).calculate if conditions[:author]
           !results.uniq.include?(false)
         end
       end
@@ -148,7 +150,7 @@ module Gitlab
         get_url = UrlBuilders::UrlBuilder.new(
           host_url: host_url,
           api_version: api_version,
-          project_id: options.project_id,
+          source_id: options.project_id,
           resource_type: resource_type,
           params: params
         ).build
@@ -163,7 +165,7 @@ module Gitlab
         post_url = UrlBuilders::UrlBuilder.new(
           host_url: host_url,
           api_version: api_version,
-          project_id: options.project_id,
+          source_id: options.project_id,
           resource_type: resource_type,
           resource_id: resource['iid'],
           sub_resource_type: 'notes'

data/lib/gitlab/triage/limiters/author_member_conditions_limiter.rb

@@ -0,0 +1,84 @@
+require_relative 'base_conditions_limiter'
+require_relative '../url_builders/url_builder'
+
+module Gitlab
+  module Triage
+    module Limiters
+      class AuthorMemberConditionsLimiter < BaseConditionsLimiter
+        SOURCES = %w[project group].freeze
+        CONDITIONS = %w[member_of not_member_of].freeze
+
+        def initialize(resource, condition, net = {})
+          @net = net
+          @network = net[:network]
+          super(resource, condition)
+        end
+
+        def self.limiter_parameters
+          [
+            {
+              name: :source,
+              type: String,
+              values: SOURCES
+            },
+            {
+              name: :condition,
+              type: String,
+              values: CONDITIONS
+            },
+            {
+              name: :source_id,
+              type: Numeric
+            }
+          ]
+        end
+
+        def initialize_variables(condition)
+          @source = condition[:source].to_sym
+          @condition = condition[:condition].to_sym
+          @source_id = condition[:source_id]
+        end
+
+        def resource_value
+          @resource[:author][:username]
+        end
+
+        def condition_value
+          members.map do |member|
+            member[:username]
+          end
+        end
+
+        def calculate
+          case @condition
+          when :member_of
+            condition_value.include?(resource_value)
+          when :not_member_of
+            !condition_value.include?(resource_value)
+          end
+        end
+
+        def members
+          @members ||= @network.query_api(@net[:token], member_url)
+        end
+
+        def member_url
+          UrlBuilders::UrlBuilder.new(net_opts).build
+        end
+
+        private
+
+        def net_opts
+          {
+            host_url: @net[:host_url],
+            api_version: @net[:api_version],
+            resource_type: 'members',
+            source: @source == :group ? 'groups' : 'projects',
+            source_id: @source_id,
+            params: { per_page: 100 }
+          }
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/url_builders/url_builder.rb

@@ -5,7 +5,8 @@ module Gitlab
         def initialize(options)
           @host_url = options.fetch(:host_url)
           @api_version = options.fetch(:api_version)
-          @project_id = options.fetch(:project_id)
+          @source = options.fetch(:source, 'projects')
+          @source_id = options.fetch(:source_id)
           @resource_type = options.fetch(:resource_type)
           @sub_resource_type = options.fetch(:sub_resource_type, nil)
           @resource_id = options.fetch(:resource_id, nil)
@@ -27,7 +28,7 @@ module Gitlab
         end
 
         def base_url
-          "#{host_with_api_url}/projects/#{CGI.escape(@project_id.to_s)}/#{@resource_type}"
+          "#{host_with_api_url}/#{@source}/#{CGI.escape(@source_id.to_s)}/#{@resource_type}"
         end
 
         def params_string

data/lib/gitlab/triage/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Triage
-    VERSION = '0.3.0'.freeze
+    VERSION = '0.4.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-12 00:00:00.000000000 Z
+date: 2018-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -127,6 +127,7 @@ files:
 - lib/gitlab/triage/filter_builders/base_filter_builder.rb
 - lib/gitlab/triage/filter_builders/multi_filter_builder.rb
 - lib/gitlab/triage/filter_builders/single_filter_builder.rb
+- lib/gitlab/triage/limiters/author_member_conditions_limiter.rb
 - lib/gitlab/triage/limiters/base_conditions_limiter.rb
 - lib/gitlab/triage/limiters/date_conditions_limiter.rb
 - lib/gitlab/triage/limiters/forbidden_labels_conditions_limiter.rb
@@ -162,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: GitLab triage automation project.