gitlab-triage 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b9611f0a3f4f58779cf16cfa76d2dc93889646dc7566b8dc75116838f362940
-  data.tar.gz: 6d8c4675ead2c209ab18df6f8bb6068cf9c2a80f262d7d6759921f90679f1e47
+  metadata.gz: 9d589eb58296c263748c53e0888e6eb3368bb02328c74245f5d25055a2ca7a37
+  data.tar.gz: 3e6d2b8e2536016b933b7d31a73781474fa772c7346dbb6ce76f10554196a1dc
 SHA512:
-  metadata.gz: 521a204ed0b650f6f31d8cb78583525ea58f2fb9378db976bf1a1e42af3a58b475480c8128cc59f43fdf065214e23557356502c4ee2340d444806fe56a3cfe33
-  data.tar.gz: a9d972bdd97dc71c4759849ec6b17a6a0f1f0bfc634c3aaf9c895b1f5e7e53a119642ebad19b39ffb156a583efaf06c0ce6a5b5cfb6f27cb384fc963252e215b
+  metadata.gz: 0fb236cfb7041f4e91e3b7a92cd4a4da95fce95a516c078e1737f6b2178f93c7e8e54463b3090ad0ae87c255c67b379547d767ec50fe8e0b04203d2d78762ea6
+  data.tar.gz: 8f23c54a9b1412b5588ef77a0a6d2e64ef2e6a0b489aeaa24746c870f816ec6b6bf7a3d2be506bf85956f4e0fabb2807c73861c008cc5cade1fddcfb47bee0be

data/.gitlab-ci.yml

@@ -34,8 +34,6 @@ setup-test-env:
     paths:
       - vendor/cache/
       - Gemfile.lock
-  except:
-    - schedules
 
 ################
 ## Test stage ##
@@ -45,8 +43,6 @@ styles:
   stage: test
   script:
     - bundle exec rubocop
-  except:
-    - schedules
 
 specs:
   <<: *pull-cache
@@ -75,59 +71,32 @@ codequality:
   artifacts:
     paths:
       - codeclimate.json
-  except:
-    - schedules
 
 ##################
 ## Triage stage ##
 ##################
-dry-run:bin:gitlab-org/triage:
+dry-run:bin:gitlab-triage:
   <<: *pull-cache
   stage: triage
   script:
     - bundle exec rake install:local
     - gitlab-triage --help
-    - gitlab-triage --dry-run --token $API_TOKEN --project-id $CI_PROJECT_PATH
-  except:
-    - schedules
+    - gitlab-triage --dry-run --debug --token $API_TOKEN --project-id $CI_PROJECT_PATH
 
-dry-run:bin:gitlab-org/gitlab-ce:
+dry-run:bin:gitlab-ce:
   <<: *pull-cache
   stage: triage
   script:
     - bundle exec rake install:local
     - gitlab-triage --help
-    - gitlab-triage --dry-run --token $API_TOKEN --project-id gitlab-org/gitlab-ce
+    - gitlab-triage --dry-run --debug --token $API_TOKEN --project-id gitlab-org/gitlab-ce
   when: manual
-  except:
-    - schedules
 
-dry-run:gem:gitlab-org/triage:
+dry-run:gem:gitlab-triage:
   <<: *pull-cache
   stage: triage
   script:
     - gem install gitlab-triage
     - gitlab-triage --help
-    - gitlab-triage --dry-run --token $API_TOKEN --project-id $CI_PROJECT_PATH
+    - gitlab-triage --dry-run --debug --token $API_TOKEN --project-id $CI_PROJECT_PATH
   when: manual
-  except:
-    - schedules
-
-###############
-## Schedules ##
-###############
-run:triage:gitlab-ce:
-  stage: triage
-  script:
-    - gem install gitlab-triage
-    - gitlab-triage --token $API_TOKEN --project-id gitlab-org/gitlab-ce
-  only:
-    - schedules
-
-run:triage:triage:
-  stage: triage
-  script:
-    - gem install gitlab-triage
-    - gitlab-triage --token $API_TOKEN --project-id $CI_PROJECT_PATH
-  only:
-    - schedules

data/.triage-policies.yml

@@ -99,16 +99,6 @@ resource_rules:
           labels:
             - auto updated
             - potential proposal
-          mention:
-            - markglenfletcher
-          comment: |
-            In order to get this request some attention, this issue has been marked as a potentially interesting proposal as it meets the following criteria:
-
-            * Labelled as a feature proposal
-            * More than 10 upvotes
-            * Unscheduled (not associated with a milestone)
-
-            Thanks for your proposal!
       - name: Mark unpopular, old feature proposals for closure
         conditions:
           date:

data/CONTRIBUTING.md

@@ -0,0 +1,31 @@
+## Developer Certificate of Origin + License
+
+By contributing to GitLab B.V., You accept and agree to the following terms and
+conditions for Your present and future Contributions submitted to GitLab B.V.
+Except for the license granted herein to GitLab B.V. and recipients of software
+distributed by GitLab B.V., You reserve all right, title, and interest in and to
+Your Contributions. All Contributions are subject to the following DCO + License
+terms.
+
+[DCO + License](https://gitlab.com/gitlab-org/dco/blob/master/README.md)
+
+## Style guide
+
+This project employs [rubocop](https://github.com/bbatsov/rubocop) to enforce code styles. Check your new branch by:
+
+```
+git checkout my_branch
+bundle install --path vendor/bundle
+bundle exec rubocop
+```
+
+## Testing
+
+- Please consider tests for any code change that is made
+- Please ensure that the existing test suite passes
+
+```
+git checkout my_branch
+bundle install --path vendor/bundle
+bundle exec rake spec
+```

data/LICENSE.md

@@ -0,0 +1,25 @@
+Copyright (c) 2011-2017 GitLab B.V.
+
+With regard to the GitLab Software:
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+For all third party components incorporated into the GitLab Software, those
+components are licensed under the original license provided by the owner of the
+applicable component.

data/README.md

@@ -85,6 +85,7 @@ Available condition types:
 - [`state` condition](#state-condition)
 - [`upvotes` condition](#upvotes-condition)
 - [`labels` condition](#labels-condition)
+- [`forbidden_labels` condition](#forbidden-labels-condition)
 
 ##### Date condition
 
@@ -173,17 +174,31 @@ conditions:
     - feature proposal
 ```
 
+##### Forbidden labels condition
+
+Accepts an array of strings. Each element in the array represents the name of a label to filter on.
+
+> Note: **All** specified labels must be absent on the resource for the condition to be satisfied
+
+Example:
+
+```yml
+conditions:
+  forbidden_labels:
+    - awaiting feedback
+```
+
 #### Actions field
 
 Used to declare an action to be carried out on a resource if **all** conditions are satisfied.
 
 Available action types:
-- [`label` action](#label-action)
+- [`labels` action](#labels-action)
 - [`status` action](#status-action)
 - [`mention` action](#mention-action)
 - [`comment` action](#comment-action)
 
-##### Label action
+##### Labels action
 
 Adds a number of labels to the resource.
 
@@ -193,7 +208,7 @@ Example:
 
 ```yml
 actions:
-  label:
+  labels:
     - feature proposal
     - awaiting feedback
 ```
@@ -283,3 +298,7 @@ run:triage:triage:
 ```
 
 > Note: You can use the [`--init-ci`](#usage) option to add an example [`.gitlab-ci.yml` file](support/.gitlab-ci.example.yml) to your project
+
+### Contributing
+
+Please refer to the [Contributing Guide](CONTRIBUTING.md)

data/lib/gitlab/triage/engine.rb

@@ -2,6 +2,7 @@ require 'active_support/all'
 
 require_relative 'limiters/date_conditions_limiter'
 require_relative 'limiters/votes_conditions_limiter'
+require_relative 'limiters/forbidden_labels_conditions_limiter'
 require_relative 'command_builders/comment_command_builder'
 require_relative 'command_builders/label_command_builder'
 require_relative 'command_builders/cc_command_builder'
@@ -18,13 +19,13 @@ module Gitlab
     class Engine
       attr_reader :host_url, :api_version, :per_page, :policies, :options
 
-      def initialize(policies:, options:, network_adapter: Gitlab::Triage::NetworkAdapters::HttpartyAdapter.new)
+      def initialize(policies:, options:, network_adapter_class: Gitlab::Triage::NetworkAdapters::HttpartyAdapter)
         @host_url = policies.delete(:host_url) { 'https://gitlab.com' }
         @api_version = policies.delete(:api_version) { 'v4' }
         @per_page = policies.delete(:per_page) { 100 }
         @policies = policies
         @options = options
-        @network_adapter = network_adapter
+        @network_adapter_class = network_adapter_class
 
         options.dry_run = true if ENV['TEST'] == 'true'
 
@@ -65,7 +66,11 @@ module Gitlab
       end
 
       def network
-        @network ||= Network.new(@network_adapter)
+        @network ||= Network.new(network_adapter, options)
+      end
+
+      def network_adapter
+        @network_adapter ||= @network_adapter_class.new(options)
       end
 
       def rule_conditions(rule)
@@ -92,6 +97,7 @@ module Gitlab
           results = []
           results << Limiters::DateConditionsLimiter.new(resource, conditions[:date]).calculate if conditions[:date]
           results << Limiters::VotesConditionsLimiter.new(resource, conditions[:upvotes]).calculate if conditions[:upvotes]
+          results << Limiters::ForbiddenLabelsConditionsLimiter.new(resource, conditions[:forbidden_labels]).calculate if conditions[:forbidden_labels]
           !results.uniq.include?(false)
         end
       end

data/lib/gitlab/triage/limiters/forbidden_labels_conditions_limiter.rb

@@ -0,0 +1,36 @@
+require_relative 'base_conditions_limiter'
+
+module Gitlab
+  module Triage
+    module Limiters
+      class ForbiddenLabelsConditionsLimiter < BaseConditionsLimiter
+        def self.limiter_parameters
+          []
+        end
+
+        def validate_condition(condition)
+          raise ArgumentError, 'condition must be an array containing forbidden label values' unless condition.is_a?(Array)
+        end
+
+        def initialize_variables(forbidden_labels)
+          @attribute = :labels
+          @forbidden_labels = forbidden_labels
+        end
+
+        def resource_value
+          @resource[@attribute]
+        end
+
+        def calculate
+          label_intersection.empty?
+        end
+
+        private
+
+        def label_intersection
+          resource_value & @forbidden_labels
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/network.rb

@@ -2,14 +2,18 @@ require 'active_support/all'
 require 'net/protocol'
 
 require_relative 'retryable'
+require_relative 'ui'
 
 module Gitlab
   module Triage
     class Network
       include Retryable
 
-      def initialize(adapter)
+      attr_reader :options
+
+      def initialize(adapter, options = {})
         @adapter = adapter
+        @options = options
       end
 
       def query_api(token, url)

data/lib/gitlab/triage/network_adapters/base_adapter.rb

@@ -0,0 +1,15 @@
+require 'httparty'
+
+module Gitlab
+  module Triage
+    module NetworkAdapters
+      class BaseAdapter
+        attr_reader :options
+
+        def initialize(options = {})
+          @options = options
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/triage/network_adapters/httparty_adapter.rb

@@ -1,9 +1,12 @@
 require 'httparty'
 
+require_relative 'base_adapter'
+require_relative '../ui'
+
 module Gitlab
   module Triage
     module NetworkAdapters
-      class HttpartyAdapter
+      class HttpartyAdapter < BaseAdapter
         def get(token, url)
           response = HTTParty.get(
             url,
@@ -13,6 +16,8 @@ module Gitlab
             }
           )
 
+          puts Gitlab::Triage::UI.debug "response: #{response.inspect}" if options.debug
+
           {
             more_pages: (response.headers["x-next-page"] != ""),
             next_page_url: url + "&page=#{response.headers['x-next-page']}",

data/lib/gitlab/triage/network_adapters/test_adapter.rb

@@ -1,9 +1,11 @@
 require 'httparty'
 
+require_relative 'base_adapter'
+
 module Gitlab
   module Triage
     module NetworkAdapters
-      class TestAdapter
+      class TestAdapter < BaseAdapter
         def get(_token, url)
           results =
             case url

data/lib/gitlab/triage/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Triage
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.2.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-triage
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-13 00:00:00.000000000 Z
+date: 2017-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,8 +108,10 @@ files:
 - ".gitlab/issue_templates/Policy.md"
 - ".rubocop.yml"
 - ".triage-policies.yml"
+- CONTRIBUTING.md
 - Gemfile
 - Guardfile
+- LICENSE.md
 - README.md
 - Rakefile
 - bin/gitlab-triage
@@ -126,9 +128,11 @@ files:
 - lib/gitlab/triage/filter_builders/single_filter_builder.rb
 - lib/gitlab/triage/limiters/base_conditions_limiter.rb
 - lib/gitlab/triage/limiters/date_conditions_limiter.rb
+- lib/gitlab/triage/limiters/forbidden_labels_conditions_limiter.rb
 - lib/gitlab/triage/limiters/name_conditions_limiter.rb
 - lib/gitlab/triage/limiters/votes_conditions_limiter.rb
 - lib/gitlab/triage/network.rb
+- lib/gitlab/triage/network_adapters/base_adapter.rb
 - lib/gitlab/triage/network_adapters/httparty_adapter.rb
 - lib/gitlab/triage/network_adapters/test_adapter.rb
 - lib/gitlab/triage/retryable.rb
@@ -157,7 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.0
+rubygems_version: 2.7.2
 signing_key: 
 specification_version: 4
 summary: GitLab triage automation project.