gitlab-styles 6.5.0 → 6.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f15e657637a0d30fed824f3d8312b970b9ee9bebc5a0feb603b83fa884b1705
-  data.tar.gz: fef3baec21ab04501f316d754a02aab77fb4dc816a048f87070d6d1b4a28f74c
+  metadata.gz: f43bff11daad05b1bb5f442c18f3fa7b8ef871e60f7675dd165f55b1515953f7
+  data.tar.gz: 57317b8cb40639df642e1d058f342eba63979b237f18cc5d5290065aef5a3a5f
 SHA512:
-  metadata.gz: 9954e550cf2ead877c73939a6f20893be5a584eb2c4f0850ea2cb5c8f4e976f3a20d3f910c0a39072c87e666cba51a8f5d283c56e33e2b2db76b1376f18cab7f
-  data.tar.gz: a54833e11f28072707ca11e21428820d888a8c95f89a5577e2633d324311400eca5d277b93311a405239397ca9ad3abac2a9982fcd5ace63f5a4491af970d513
+  metadata.gz: bb319a3ada8ae43e77ba1de5aeb4234e9c6d8c97848f3ae3870222a4b0a4f4ae2f8f2d6356f8cd9b9747101482758834ceacb5cd2cef09519fd17e736a272c05
+  data.tar.gz: bb37685d5084df12a4820c47ce43ec0106aa50e05f9a7ddbde97c9956a7ec50e62fac388a968ba909c356c66324511fa5f407455b538ea1d183d2fa2f20367d1

data/gitlab-styles.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['gitlab_rubygems@gitlab.com']
 
   spec.summary       = 'GitLab style guides and shared style configs.'
-  spec.homepage      = 'https://gitlab.com/gitlab-org/gitlab-styles'
+  spec.homepage      = 'https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|

data/lib/gitlab/styles/rubocop/cop/performance/rubyzip.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module Performance
+          # This cop flags inefficient uses of rubyzip's Zip::File, since when instantiated
+          # it reads the file's Central Directory into memory entirely. For zips with many
+          # files and directories, this can be very expensive even when the archive's size
+          # in bytes is small.
+          #
+          # See also:
+          # - https://github.com/rubyzip/rubyzip/issues/506
+          # - https://github.com/rubyzip/rubyzip#notes-on-zipinputstream
+          class Rubyzip < RuboCop::Cop::Cop
+            MSG = 'Be careful when opening or iterating zip files via Zip::File. ' \
+                  'Zip archives may contain many entries, and their file index is ' \
+                  'read into memory upon construction, which can lead to ' \
+                  'high memory use and poor performance. ' \
+                  'Consider iterating archive entries via Zip::InputStream instead.'
+
+            def_node_matcher :reads_central_directory?, <<-PATTERN
+              (send
+                (const
+                  (const {nil? (cbase)} :Zip) :File) {:new :open :foreach} ...)
+            PATTERN
+
+            def on_send(node)
+              return unless reads_central_directory?(node)
+
+              add_offense(node)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '6.5.0'
+    VERSION = '6.6.0'
   end
 end

data/rubocop-performance.yml

@@ -1,6 +1,7 @@
 ---
 require:
   - rubocop-performance
+  - ./lib/gitlab/styles/rubocop
 
 # Used to identify usages of ancestors.include? and change them to use ⇐ instead.
 # https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performanceancestorsinclude
@@ -112,3 +113,9 @@ Performance/Sum:
 # Checks for `.times.map` calls.
 Performance/TimesMap:
   Enabled: true
+
+# Flags potentially expensive operations on ZIP archives.
+Performance/Rubyzip:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 6.5.0
+  version: 6.6.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-17 00:00:00.000000000 Z
+date: 2021-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -177,6 +177,7 @@ files:
 - lib/gitlab/styles/rubocop/cop/line_break_after_guard_clauses.rb
 - lib/gitlab/styles/rubocop/cop/line_break_around_conditional_block.rb
 - lib/gitlab/styles/rubocop/cop/migration/update_large_table.rb
+- lib/gitlab/styles/rubocop/cop/performance/rubyzip.rb
 - lib/gitlab/styles/rubocop/cop/polymorphic_associations.rb
 - lib/gitlab/styles/rubocop/cop/rails/include_url_helper.rb
 - lib/gitlab/styles/rubocop/cop/redirect_with_status.rb
@@ -211,7 +212,7 @@ files:
 - rubocop-rspec.yml
 - rubocop-security.yml
 - rubocop-style.yml
-homepage: https://gitlab.com/gitlab-org/gitlab-styles
+homepage: https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles
 licenses:
 - MIT
 metadata: {}