gitlab-styles 5.4.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2ceb4c3c99df5b88255a7b7bcd4cbfaa5e029f81cc73f09b937cb15b7e53ffd
-  data.tar.gz: e4e5a5425299c7cb3d8e40f79fb4f817444aec62c378d8c8b547a309e3fe7211
+  metadata.gz: 88825b6aaa4961f16a29bfc14cdb1d590700a74e81fe68e072fccd2046506c6b
+  data.tar.gz: 5634afcb51a117e54f4760c43f12d3b2564d08b62bbcd49d97b7cde7c88014d6
 SHA512:
-  metadata.gz: 1626e2623b8e2d5bb2eeff292a4746a8352f302a53277b9118bd20494f6489501f7f19c0442510435ca55ac92cdf61536dfe5bb5c3ad09a9f3eea1b769636780
-  data.tar.gz: b64077d9097e0d3adb6365fe41662b6e5264921ebfa5ed493b7dec7c8eaa8dbc4ae63c286b51f34b55811664a8a8e3fa9da5aa0098840f5dfddac54c9af419b4
+  metadata.gz: 99652ceb45ae8e31ac3105bd7913a2c85e0a5a22cd97ad5d30081fd1b55b4d1734671d9cdbfdf1875dbdbc314efb9fe433b8859a18761ebea1d1054f58aa88d1
+  data.tar.gz: 2b16d7dc347ec66fd1656d735bc6427c485c88e27d7fb3030e0a852d76fb338705a976e85fb949b25b3994035134251da3771a9f3c914767d6d7158ecf5137e4

data/Gemfile

@@ -7,7 +7,7 @@ gemspec
 
 group :test do
   # Pin these dependencies, otherwise a new rule could break the CI pipelines
-  gem 'rubocop', '0.89.1'
+  gem 'rubocop', '0.91.1'
   gem 'rubocop-rspec', '1.44.1'
   gem 'rspec-parameterized', '0.4.2', require: false
 end

data/gitlab-styles.gemspec

@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.89.1'
-  spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.0'
-  spec.add_dependency 'rubocop-performance', '~> 1.8.1'
-  spec.add_dependency 'rubocop-rails', '~> 2.8'
+  spec.add_dependency 'rubocop', '~> 0.91.1'
+  spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.1'
+  spec.add_dependency 'rubocop-performance', '~> 1.9.2'
+  spec.add_dependency 'rubocop-rails', '~> 2.9'
   spec.add_dependency 'rubocop-rspec', '~> 1.44'
 
   spec.add_development_dependency 'bundler', '~> 2.1'

data/lib/gitlab/styles/rubocop.rb

@@ -2,7 +2,7 @@
 
 # Auto-require all cops under `gitlab/styles/rubocop/cop/**/*.rb`
 cops_glob = File.join(__dir__, 'rubocop', 'cop', '**', '*.rb')
-Dir[cops_glob].sort.each(&method(:require))
+Dir[cops_glob].sort.each { |cop| require(cop) }
 
 module Gitlab
   module Styles

data/lib/gitlab/styles/rubocop/cop/internal_affairs/deprecate_cop_helper.rb

@@ -7,7 +7,7 @@ module Gitlab
         module InternalAffairs
           # Cop that denies the use of CopHelper.
           class DeprecateCopHelper < RuboCop::Cop::Cop
-            MSG = 'Do not use `CopHelper` or methods from it, use improved patterns described in https://github.com/rubocop-hq/rubocop/issues/8003'
+            MSG = 'Do not use `CopHelper` or methods from it, use improved patterns described in https://www.rubydoc.info/gems/rubocop/RuboCop/RSpec/ExpectOffense'
 
             def_node_matcher :cop_helper, <<~PATTERN
               (send nil? ${:include :extend :prepend}

data/lib/gitlab/styles/rubocop/cop/rspec/verbose_include_metadata.rb

@@ -52,7 +52,7 @@ module Gitlab
 
             def invalid_metadata_matches(node, &block)
               include_metadata(node) do |matches|
-                matches.select(&method(:invalid_metadata?)).each(&block)
+                matches.select { |match| invalid_metadata?(match) }.each(&block)
               end
             end
 

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '5.4.0'
+    VERSION = '6.0.0'
   end
 end

data/rubocop-layout.yml

@@ -12,6 +12,9 @@ Layout/ArrayAlignment:
 Layout/AssignmentIndentation:
   Enabled: true
 
+Layout/BeginEndAlignment: # (new in 0.91)
+  Enabled: true
+
 # Align block ends correctly.
 Layout/BlockAlignment:
   Enabled: true

data/rubocop-lint.yml

@@ -28,6 +28,9 @@ Lint/BinaryOperatorWithIdenticalOperands:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantDefinitionInBlock: # (new in 0.91)
+  Enabled: true
+
 # Check for debugger calls.
 Lint/Debugger:
   Enabled: true
@@ -47,6 +50,9 @@ Lint/DeprecatedOpenSSLConstant:
 Lint/DuplicateElsifCondition:
   Enabled: true
 
+Lint/DuplicateRequire: # (new in 0.90)
+  Enabled: true
+
 # Checks that there are no repeated exceptions used in 'rescue' expressions.
 # https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintduplicaterescueexception
 Lint/DuplicateRescueException:
@@ -69,6 +75,9 @@ Lint/EmptyConditionalBody:
 Lint/EmptyEnsure:
   Enabled: true
 
+Lint/EmptyFile: # (new in 0.90)
+  Enabled: true
+
 # Checks for the presence of `when` branches without a body.
 Lint/EmptyWhen:
   Enabled: true
@@ -94,6 +103,9 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
+Lint/IdentityComparison: # (new in 0.91)
+  Enabled: true
+
 # Checks for adjacent string literals on the same line, which could better be
 # represented as a single string literal.
 Lint/ImplicitStringConcatenation:
@@ -200,6 +212,9 @@ Lint/SuppressedException:
 Lint/TopLevelReturnWithArgument:
   Enabled: true
 
+Lint/TrailingCommaInAttributeDeclaration: # (new in 0.90)
+  Enabled: true
+
 # Do not use prefix `_` for a variable that is used.
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
@@ -238,10 +253,16 @@ Lint/UselessAssignment:
 Lint/UselessElseWithoutRescue:
   Enabled: true
 
+Lint/UselessMethodDefinition: # (new in 0.90)
+  Enabled: true
+
 # Checks for useless setter call to a local variable.
 Lint/UselessSetterCall:
   Enabled: true
 
+Lint/UselessTimes: # (new in 0.91)
+  Enabled: true
+
 # Possible use of operator/literal/variable in void context.
 Lint/Void:
   Enabled: true

data/rubocop-performance.yml

@@ -10,6 +10,9 @@ Performance/AncestorsInclude:
 Performance/BigDecimalWithNumericArgument:
   Enabled: true
 
+Performance/BlockGivenWithExplicitBlock: # (new in 1.9)
+  Enabled: true
+
 # Use `caller(n..n)` instead of `caller`.
 Performance/Caller:
   Enabled: false
@@ -18,11 +21,20 @@ Performance/Caller:
 Performance/Casecmp:
   Enabled: true
 
+Performance/CollectionLiteralInLoop: # (new in 1.8)
+  Enabled: true
+
+Performance/ConstantRegexp: # (new in 1.9)
+  Enabled: true
+
 # Use `str.{start,end}_with?(x, ..., y, ...)` instead of
 # `str.{start,end}_with?(x, ...) || str.{start,end}_with?(y, ...)`.
 Performance/DoubleStartEndWith:
   Enabled: true
 
+Performance/MethodObjectAsBlock: # (new in 1.9)
+  Enabled: true
+
 # Use `Range#cover?` instead of `Range#include?`.
 Performance/RangeInclude:
   Enabled: true

data/rubocop-rails.yml

@@ -24,6 +24,9 @@ Rails/AfterCommitOverride:
 Rails/ApplicationRecord:
   Enabled: false
 
+Rails/AttributeDefaultBlockValue: # (new in 2.9)
+  Enabled: true
+
 # Enforce using `blank?` and `present?`.
 Rails/Blank:
   Enabled: false
@@ -168,6 +171,9 @@ Rails/TimeZone:
 Rails/Validation:
   Enabled: true
 
+Rails/WhereEquals: # (new in 2.9)
+  Enabled: true
+
 # Enforces consistent style when using exists?.
 # https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railswhereexists
 Rails/WhereExists:

data/rubocop-style.yml

@@ -84,6 +84,9 @@ Style/ClassVars:
 Style/ColonMethodCall:
   Enabled: true
 
+Style/CombinableLoops: # (new in 0.90)
+  Enabled: true
+
 # This cop checks that comment annotation keywords are written according
 # to guidelines.
 Style/CommentAnnotation:
@@ -202,6 +205,9 @@ Style/InfiniteLoop:
 Style/InverseMethods:
   Enabled: false
 
+Style/KeywordParametersOrder: # (new in 0.90)
+  Enabled: true
+
 # Use lambda.call(...) instead of lambda.(...).
 Style/LambdaCall:
   Enabled: true
@@ -335,6 +341,9 @@ Style/RedundantRegexpCharacterClass:
 Style/RedundantRegexpEscape:
   Enabled: true
 
+Style/RedundantSelfAssignment: # (new in 0.90)
+  Enabled: true
+
 # Use `sort` instead of `sort_by { |x| x }`.
 Style/RedundantSortBy:
   Enabled: true
@@ -358,6 +367,9 @@ Style/SignalException:
 Style/SlicingWithRange:
   Enabled: true
 
+Style/SoleNestedConditional: # (new in 0.89)
+  Enabled: true
+
 # Check for the usage of parentheses around stabby lambda arguments.
 Style/StabbyLambdaParentheses:
   EnforcedStyle: require_parentheses

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 6.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-06 00:00:00.000000000 Z
+date: 2021-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.91.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 0.91.1
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.1.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.8'
+        version: '2.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.8'
+        version: '2.9'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement