gitlab-styles 5.3.0 → 5.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53b2719f9b6600bdfd8b362ad363f86f35dbae708f8ebd41f1ef2e2429d4c4f0
-  data.tar.gz: f480238835c2218118ea34ac3ebf2869e2386e500304530fd08a112701175845
+  metadata.gz: b2ceb4c3c99df5b88255a7b7bcd4cbfaa5e029f81cc73f09b937cb15b7e53ffd
+  data.tar.gz: e4e5a5425299c7cb3d8e40f79fb4f817444aec62c378d8c8b547a309e3fe7211
 SHA512:
-  metadata.gz: f5d87f035504e911546c7aaaaad23bac44035f65848d0a3c74cf284bdddd4e8f460c6da7e4766ee9465f75051d38d5e1d3c4b674bc910ce320204e356a9f3622
-  data.tar.gz: b97be714bb886604639de5d788284b0c8af1b081ce279c8a5fdf6dafff9b2aeee83060576f0ce0322bb49168ccdc58a4abafd0de13442425d705523d9d6a6a5d
+  metadata.gz: 1626e2623b8e2d5bb2eeff292a4746a8352f302a53277b9118bd20494f6489501f7f19c0442510435ca55ac92cdf61536dfe5bb5c3ad09a9f3eea1b769636780
+  data.tar.gz: b64077d9097e0d3adb6365fe41662b6e5264921ebfa5ed493b7dec7c8eaa8dbc4ae63c286b51f34b55811664a8a8e3fa9da5aa0098840f5dfddac54c9af419b4

data/.rubocop.yml

@@ -3,3 +3,8 @@ inherit_from:
 
 require:
   - rubocop/cop/internal_affairs
+
+InternalAffairs/DeprecateCopHelper:
+  Enabled: true
+  Include:
+    - spec/**/*.rb

data/lib/gitlab/styles/rubocop/cop/internal_affairs/deprecate_cop_helper.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module InternalAffairs
+          # Cop that denies the use of CopHelper.
+          class DeprecateCopHelper < RuboCop::Cop::Cop
+            MSG = 'Do not use `CopHelper` or methods from it, use improved patterns described in https://github.com/rubocop-hq/rubocop/issues/8003'
+
+            def_node_matcher :cop_helper, <<~PATTERN
+              (send nil? ${:include :extend :prepend}
+                (const _ {:CopHelper}))
+            PATTERN
+
+            def_node_search :cop_helper_method, <<~PATTERN
+              (send nil? {:inspect_source :inspect_source_file :parse_source :autocorrect_source_file :autocorrect_source :_investigate} ...)
+            PATTERN
+
+            def_node_search :cop_helper_method_on_instance, <<~PATTERN
+              (send (send nil? _) {:messages :highlights :offenses} ...)
+            PATTERN
+
+            def on_send(node)
+              cop_helper(node) do
+                add_offense(node)
+              end
+
+              cop_helper_method(node) do
+                add_offense(node)
+              end
+
+              cop_helper_method_on_instance(node) do
+                add_offense(node)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '5.3.0'
+    VERSION = '5.4.0'
   end
 end

data/rubocop-default.yml

@@ -20,3 +20,6 @@ inherit_from:
   - rubocop-rspec.yml
   - rubocop-security.yml
   - rubocop-style.yml
+
+InternalAffairs/DeprecateCopHelper:
+  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 5.3.0
+  version: 5.4.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-12-11 00:00:00.000000000 Z
+date: 2021-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -153,6 +153,7 @@ files:
 - lib/gitlab/styles/rubocop/cop/custom_error_class.rb
 - lib/gitlab/styles/rubocop/cop/gem_fetcher.rb
 - lib/gitlab/styles/rubocop/cop/in_batches.rb
+- lib/gitlab/styles/rubocop/cop/internal_affairs/deprecate_cop_helper.rb
 - lib/gitlab/styles/rubocop/cop/line_break_after_guard_clauses.rb
 - lib/gitlab/styles/rubocop/cop/line_break_around_conditional_block.rb
 - lib/gitlab/styles/rubocop/cop/migration/update_large_table.rb