gitlab-styles 4.3.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00dda1d4ea5cfd931d74ccf3def7dd6ed3552359c2519e7b6a73464cb3612b92
-  data.tar.gz: 8fd90715af2921b22e53d241f12e4a546f8d53923a688028132af3e5e28f0349
+  metadata.gz: f34644596ecbfd782a8a8d5781251743cbe2f0ef079467416c4e15c784769693
+  data.tar.gz: 531fb802e1a50564fbbfad34e96f66b8a2227e6c182999750a39456f2ae17c98
 SHA512:
-  metadata.gz: 58e29fee8c087356c272e72e9d3a8b719581e5f185ceed85d554a9ccb664654288373b2a6d1e4c1ba9587bfce4c2225960797e4c89e321688da8fa52d4a12b81
-  data.tar.gz: a2c2f9843238a87f1af60f28beac5ec8c1ae5f1d236ab1554e88d07f95824e6474dda3b96ff5ec26a3219015c5415ea21824d41cc98d3cd06990b5ff55104097
+  metadata.gz: 9a4036572db91754b18045e0e9ec40d9747a633773c49fb3edcdc53d0ac8b6ae2743f94ffe5fc2ce6cc8a60a51216eb7b85c89dfb039f747370cca4831c9cc41
+  data.tar.gz: 78eb2aaec9c221dad33fb99c719c3ad838a39f4978381b2f99ef011f87c8c8ee67a24d9b6e26af2eea4d1b3a03e03e80aab5c2718afaa998764a3cf68d8153e4

data/.editorconfig

@@ -0,0 +1,18 @@
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{rb,yml}]
+indent_size = 2
+
+[*.{rb,yml,md}]
+indent_style = space
+charset = utf-8
+
+[*.{md,markdown}]
+trim_trailing_whitespace = false

data/Gemfile

@@ -7,7 +7,7 @@ gemspec
 
 group :test do
   # Pin these dependencies, otherwise a new rule could break the CI pipelines
-  gem 'rubocop', '0.82.0'
-  gem 'rubocop-rspec', '1.36.0'
+  gem 'rubocop', '0.89.1'
+  gem 'rubocop-rspec', '1.44.1'
   gem 'rspec-parameterized', '0.4.2', require: false
 end

data/gitlab-styles.gemspec

@@ -5,6 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gitlab/styles/version'
 
 Gem::Specification.new do |spec|
+  spec.required_ruby_version = '>= 2.6'
   spec.name          = 'gitlab-styles'
   spec.version       = Gitlab::Styles::VERSION
   spec.authors       = ['GitLab']
@@ -21,11 +22,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.82.0'
+  spec.add_dependency 'rubocop', '~> 0.89.1'
   spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.0'
-  spec.add_dependency 'rubocop-performance', '~> 1.5.2'
-  spec.add_dependency 'rubocop-rails', '~> 2.5'
-  spec.add_dependency 'rubocop-rspec', '~> 1.36'
+  spec.add_dependency 'rubocop-performance', '~> 1.8.1'
+  spec.add_dependency 'rubocop-rails', '~> 2.8'
+  spec.add_dependency 'rubocop-rspec', '~> 1.44'
 
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'rake', '~> 10.0'

data/lib/gitlab/styles/rubocop.rb

@@ -8,6 +8,7 @@ require 'gitlab/styles/rubocop/cop/polymorphic_associations'
 require 'gitlab/styles/rubocop/cop/active_record_dependent'
 require 'gitlab/styles/rubocop/cop/in_batches'
 require 'gitlab/styles/rubocop/cop/line_break_after_guard_clauses'
+require 'gitlab/styles/rubocop/cop/code_reuse/active_record'
 require 'gitlab/styles/rubocop/cop/migration/update_large_table'
 require 'gitlab/styles/rubocop/cop/without_reactive_cache'
 require 'gitlab/styles/rubocop/cop/rspec/single_line_hook'

data/lib/gitlab/styles/rubocop/cop/code_reuse/active_record.rb

@@ -0,0 +1,131 @@
+# frozen_string_literal: true
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module CodeReuse
+          # Cop that denies the use of ActiveRecord methods outside of models.
+          class ActiveRecord < RuboCop::Cop::Cop
+            MSG = 'This method can only be used inside an ActiveRecord model: ' \
+        'https://gitlab.com/gitlab-org/gitlab-foss/issues/49653'
+
+            # Various methods from ActiveRecord::Querying that are denied. We
+            # exclude some generic ones such as `any?` and `first`, as these may
+            # lead to too many false positives, since `Array` also supports these
+            # methods.
+            #
+            # The keys of this Hash are the denied method names. The values are
+            # booleans that indicate if the method should only be denied if any
+            # arguments are provided.
+            NOT_ALLOWED = {
+              average: true,
+              calculate: true,
+              count_by_sql: true,
+              create_with: true,
+              distinct: false,
+              eager_load: true,
+              exists?: true,
+              find_by: true,
+              find_by!: true,
+              find_by_sql: true,
+              find_each: true,
+              find_in_batches: true,
+              find_or_create_by: true,
+              find_or_create_by!: true,
+              find_or_initialize_by: true,
+              first!: false,
+              first_or_create: true,
+              first_or_create!: true,
+              first_or_initialize: true,
+              from: true,
+              group: true,
+              having: true,
+              ids: false,
+              includes: true,
+              joins: true,
+              limit: true,
+              lock: false,
+              many?: false,
+              offset: true,
+              order: true,
+              pluck: true,
+              preload: true,
+              readonly: false,
+              references: true,
+              reorder: true,
+              rewhere: true,
+              take: false,
+              take!: false,
+              unscope: false,
+              where: false,
+              with: true
+            }.freeze
+
+            def on_send(node)
+              receiver = node.children[0]
+              send_name = node.children[1]
+              first_arg = node.children[2]
+
+              return unless receiver && NOT_ALLOWED.key?(send_name)
+
+              # If the rule requires an argument to be given, but none are
+              # provided, we won't register an offense. This prevents us from
+              # adding offenses for `project.group`, while still covering
+              # `Project.group(:name)`.
+              return if NOT_ALLOWED[send_name] && !first_arg
+
+              add_offense(node, location: :selector)
+            end
+
+            # We can not auto correct code like this, as it requires manual
+            # refactoring. Instead, we'll just allow the surrounding scope.
+            #
+            # Despite this method's presence, you should not use it. This method
+            # exists to make it possible to allow large chunks of offenses we
+            # can't fix in the short term. If you are writing new code, follow the
+            # code reuse guidelines, instead of allowing any new offenses.
+            def autocorrect(node)
+              scope = surrounding_scope_of(node)
+              indent = indentation_of(scope)
+
+              lambda do |corrector|
+                # This prevents us from inserting the same enable/disable comment
+                # for a method or block that has multiple offenses.
+                next if allowed_scopes.include?(scope)
+
+                corrector.insert_before(
+                  scope.source_range,
+                  "# rubocop: disable #{cop_name}\n#{indent}"
+                )
+
+                corrector.insert_after(
+                  scope.source_range,
+                  "\n#{indent}# rubocop: enable #{cop_name}"
+                )
+
+                allowed_scopes << scope
+              end
+            end
+
+            def indentation_of(node)
+              ' ' * node.loc.expression.source_line[/\A */].length
+            end
+
+            def surrounding_scope_of(node)
+              %i[def defs block begin].each do |type|
+                if (found = node.each_ancestor(type).first)
+                  return found
+                end
+              end
+            end
+
+            def allowed_scopes
+              @allowed_scopes ||= Set.new
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/rubocop/cop/rspec/base.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'rubocop-rspec'
+require_relative '../../rspec/helpers'
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Cop
+        module RSpec
+          class Base < RuboCop::Cop::RSpec::Base
+            include Rubocop::Rspec::Helpers
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/rubocop/cop/rspec/empty_line_after_let_block.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop-rspec'
+require_relative 'base'
 
 module Gitlab
   module Styles
@@ -38,22 +39,21 @@ module Gitlab
           #     let(:last_thing) { 'last thing' }
           #   end
           #
-          class EmptyLineAfterLetBlock < RuboCop::Cop::RSpec::Cop
-            include RuboCop::RSpec::BlankLineSeparation
+          class EmptyLineAfterLetBlock < Base
+            extend RuboCop::Cop::AutoCorrector
+            include RuboCop::RSpec::EmptyLineSeparation
 
             MSG = 'Add an empty line after `%<let>s` block.'
 
-            def_node_matcher :lets, Helpers::ALL.block_pattern
+            def_node_matcher :lets, LET.block_pattern
 
             def on_block(node)
               lets(node) do
                 break if last_child?(node)
                 next if node.single_line?
 
-                missing_separating_line(node) do |location|
-                  add_offense(node,
-                              location: location,
-                              message: format(MSG, let: node.method_name))
+                missing_separating_line_offense(node) do |method|
+                  format(MSG, let: method)
                 end
               end
             end

data/lib/gitlab/styles/rubocop/cop/rspec/empty_line_after_shared_example.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop-rspec'
+require_relative 'base'
 
 module Gitlab
   module Styles
@@ -38,8 +39,9 @@ module Gitlab
           #     it_behaves_like 'does this'
           #   end
           #
-          class EmptyLineAfterSharedExample < RuboCop::Cop::RSpec::Cop
-            include RuboCop::RSpec::BlankLineSeparation
+          class EmptyLineAfterSharedExample < Base
+            extend RuboCop::Cop::AutoCorrector
+            include RuboCop::RSpec::EmptyLineSeparation
 
             MSG = 'Add an empty line after `%<example>s` block.'
 
@@ -50,10 +52,8 @@ module Gitlab
               shared_examples(node) do
                 break if last_child?(node)
 
-                missing_separating_line(node) do |location|
-                  add_offense(node,
-                              location: location,
-                              message: format(MSG, example: node.method_name))
+                missing_separating_line_offense(node) do |method|
+                  format(MSG, example: method)
                 end
               end
             end

data/lib/gitlab/styles/rubocop/cop/rspec/have_link_parameters.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop-rspec'
+require_relative 'base'
 
 module Gitlab
   module Styles
@@ -17,7 +18,9 @@ module Gitlab
           #   # good
           #   expect(page).to have_link('Link', href: 'https://example.com')
           #   expect(page).to have_link('Example')
-          class HaveLinkParameters < RuboCop::Cop::RSpec::Cop
+          class HaveLinkParameters < Base
+            extend RuboCop::Cop::AutoCorrector
+
             MESSAGE = "The second argument to `have_link` should be a Hash."
 
             def_node_matcher :unused_parameters?, <<~PATTERN
@@ -29,11 +32,13 @@ module Gitlab
             def on_send(node)
               return unless unused_parameters?(node)
 
-              location = node.arguments[1..-1]
-                .map(&:source_range)
-                .reduce(:join)
+              location = node.arguments[1..]
+                           .map(&:source_range)
+                           .reduce(:join)
 
-              add_offense(node, location: location, message: MESSAGE)
+              add_offense(location, message: MESSAGE) do |corrector|
+                corrector.insert_after(location.end, "\n")
+              end
             end
           end
         end

data/lib/gitlab/styles/rubocop/cop/rspec/single_line_hook.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop-rspec'
+require_relative 'base'
 
 module Gitlab
   module Styles
@@ -23,7 +24,7 @@ module Gitlab
           #   after(:each) do
           #     undo_something
           #   end
-          class SingleLineHook < RuboCop::Cop::RSpec::Cop
+          class SingleLineHook < Base
             MESSAGE = "Don't use single-line hook blocks."
 
             def_node_search :rspec_hook?, <<~PATTERN
@@ -34,7 +35,7 @@ module Gitlab
               return unless node.single_line?
               return unless rspec_hook?(node)
 
-              add_offense(node, location: :expression, message: MESSAGE)
+              add_offense(node, message: MESSAGE)
             end
           end
         end

data/lib/gitlab/styles/rubocop/cop/rspec/verbose_include_metadata.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'rubocop-rspec'
+require_relative 'base'
 
 module Gitlab
   module Styles
@@ -17,7 +18,9 @@ module Gitlab
           #   # good
           #   describe MyClass, :js do
           #   end
-          class VerboseIncludeMetadata < RuboCop::Cop::RSpec::Cop
+          class VerboseIncludeMetadata < Base
+            extend RuboCop::Cop::AutoCorrector
+
             MSG = 'Use `%s` instead of `%s`.'
 
             SELECTORS = %i[describe context feature example_group it specify example scenario its].freeze
@@ -37,25 +40,19 @@ module Gitlab
 
             def on_send(node)
               invalid_metadata_matches(node) do |match|
-                add_offense(node, location: :expression, message: format(MSG, good(match), bad(match)))
-              end
-            end
-
-            def autocorrect(node)
-              lambda do |corrector|
-                invalid_metadata_matches(node) do |match|
-                  corrector.replace(match.loc.expression, good(match))
+                add_offense(node, message: format(MSG, good(match), bad(match))) do |corrector|
+                  invalid_metadata_matches(node) do |match|
+                    corrector.replace(match.loc.expression, good(match))
+                  end
                 end
               end
             end
 
             private
 
-            def invalid_metadata_matches(node)
+            def invalid_metadata_matches(node, &block)
               include_metadata(node) do |matches|
-                matches.select(&method(:invalid_metadata?)).each do |match|
-                  yield match
-                end
+                matches.select(&method(:invalid_metadata?)).each(&block)
               end
             end
 

data/lib/gitlab/styles/rubocop/model_helpers.rb

@@ -7,7 +7,7 @@ module Gitlab
         # Returns true if the given node originated from the models directory.
         def in_model?(node)
           path = node.location.expression.source_buffer.name
-          pwd = RuboCop::PathUtil.pwd
+          pwd = Dir.pwd
           models_path = File.join(pwd, 'app', 'models')
           ee_models_path = File.join(pwd, 'ee', 'app', 'models')
 

data/lib/gitlab/styles/rubocop/rspec/helpers.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'rubocop-rspec'
+
+module Gitlab
+  module Styles
+    module Rubocop
+      module Rspec
+        module Helpers
+          include RuboCop::RSpec::Language
+
+          LET = SelectorSet.new(%i[let_it_be]) + Helpers::ALL
+        end
+      end
+    end
+  end
+end

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '4.3.0'
+    VERSION = '5.0.0'
   end
 end

data/rubocop-all.yml

@@ -1,3 +1,4 @@
+---
 AllCops:
   TargetRubyVersion: 2.6
   # Cop names are not displayed in offense messages by default. Change behavior

data/rubocop-bundler.yml

@@ -1,3 +1,4 @@
+---
 # Gems in consecutive lines should be alphabetically sorted
 Bundler/OrderedGems:
   Enabled: false

data/rubocop-code_reuse.yml

@@ -0,0 +1,24 @@
+# Denies the use of ActiveRecord methods outside of configured
+# excluded directories
+# Directories that allow the use of the denied methods.
+# To start we provide a default configuration that matches
+# a standard Rails app and enable.
+# The default configuration can be overridden by
+# providing your own Exclusion list as follows:
+# CodeReuse/ActiveRecord:
+#  Enabled: true
+#  Exclude:
+#    - app/models/**/*.rb
+#    - config/**/*.rb
+#    - db/**/*.rb
+#    - lib/tasks/**/*.rb
+#    - spec/**/*.rb
+#    - lib/gitlab/**/*.rb
+CodeReuse/ActiveRecord:
+  Enabled: true
+  Exclude:
+    - app/models/**/*.rb
+    - config/**/*.rb
+    - db/**/*.rb
+    - lib/tasks/**/*.rb
+    - spec/**/*.rb

data/rubocop-default.yml

@@ -1,3 +1,4 @@
+---
 require:
   - rubocop-gitlab-security
   - rubocop-performance

data/rubocop-gemspec.yml

@@ -1,3 +1,4 @@
+---
 # Dependencies in the gemspec should be alphabetically sorted
 # Configuration parameters: Include, TreatCommentsAsGroupSeparators.
 Gemspec/OrderedDependencies:

data/rubocop-layout.yml

@@ -1,3 +1,4 @@
+---
 # Check indentation of private/protected visibility modifiers.
 Layout/AccessModifierIndentation:
   Enabled: true
@@ -60,6 +61,11 @@ Layout/EmptyLines:
 Layout/EmptyLinesAroundAccessModifier:
   Enabled: true
 
+# Checks for a newline after an attribute accessor or a group of them
+# https://docs.rubocop.org/rubocop/0.89/cops_layout.html#layoutemptylinesaroundattributeaccessor
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
 # Keeps track of empty lines around block bodies.
 Layout/EmptyLinesAroundBlockBody:
   Enabled: true

data/rubocop-lint.yml

@@ -1,3 +1,4 @@
+---
 # Checks for ambiguous block association with method when param passed without
 # parentheses.
 Lint/AmbiguousBlockAssociation:
@@ -18,6 +19,10 @@ Lint/AmbiguousRegexpLiteral:
 Lint/AssignmentInCondition:
   Enabled: false
 
+# Checks for places where binary operator has identical operands
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 # Default values in optional keyword arguments and optional ordinal arguments
 # should not refer back to the name of the argument.
 Lint/CircularArgumentReference:
@@ -31,6 +36,22 @@ Lint/Debugger:
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+# Algorithmic constants for OpenSSL::Cipher and OpenSSL::Digest deprecated since OpenSSL version 2.2.0.
+# Prefer passing a string instead.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintdeprecatedopensslconstant
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+# Checks that there are no repeated conditions used in if 'elsif'.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintduplicateelsifcondition
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+# Checks that there are no repeated exceptions used in 'rescue' expressions.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintduplicaterescueexception
+Lint/DuplicateRescueException:
+  Enabled: true
+
 # Check for immutable argument given to each_with_object.
 Lint/EachWithObjectArgument:
   Enabled: true
@@ -39,6 +60,11 @@ Lint/EachWithObjectArgument:
 Lint/ElseLayout:
   Enabled: true
 
+# Checks for the presence of if, elsif and unless branches without a body.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintemptyconditionalbody
+Lint/EmptyConditionalBody:
+  Enabled: true
+
 # Checks for empty ensure block.
 Lint/EmptyEnsure:
   Enabled: true
@@ -55,6 +81,11 @@ Lint/EnsureReturn:
 Lint/FlipFlop:
   Enabled: true
 
+# Checks for the presence of precise comparison of floating point numbers.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintfloatcomparison
+Lint/FloatComparison:
+  Enabled: true
+
 # Catches floating-point literals too large or small for Ruby to represent.
 Lint/FloatOutOfRange:
   Enabled: true
@@ -81,10 +112,21 @@ Lint/LiteralAsCondition:
 Lint/LiteralInInterpolation:
   Enabled: true
 
-# This cop checks for uses of *begin...end while/until something*.
+# Checks for uses of *begin...end while/until something*.
 Lint/Loop:
   Enabled: false
 
+# Checks for the presence of constructors and lifecycle callbacks without calls to super.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintmissingsuper
+Lint/MissingSuper:
+  Enabled: false
+
+# Do not mix named captures and numbered captures in a Regexp literal
+# because numbered capture is ignored if they’re mixed.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintmixedregexpcapturetypes
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
 # Do not use nested method definitions.
 Lint/NestedMethodDefinition:
   Enabled: true
@@ -93,6 +135,11 @@ Lint/NestedMethodDefinition:
 Lint/NextWithoutAccumulator:
   Enabled: true
 
+# Looks for references of Regexp captures that are out of range and thus always returns nil.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintoutofrangeregexpref
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 # Checks for method calls with a space before the opening parenthesis.
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
@@ -126,6 +173,11 @@ Lint/RescueException:
 Lint/SafeNavigationWithEmpty:
   Enabled: true
 
+# Checks for self-assignments.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintselfassignment
+Lint/SelfAssignment:
+  Enabled: true
+
 # Checks for the order which exceptions are rescued to avoid rescueing a less specific exception before a more specific exception.
 Lint/ShadowedException:
   Enabled: false
@@ -143,6 +195,11 @@ Lint/StructNewOverride:
 Lint/SuppressedException:
   Enabled: false
 
+# Checks for top level return with arguments.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#linttoplevelreturnwithargument
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
 # Do not use prefix `_` for a variable that is used.
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
@@ -155,6 +212,11 @@ Lint/UnifiedInteger:
 Lint/UnreachableCode:
   Enabled: true
 
+# Checks for loops that will have at most one iteration.
+# https://docs.rubocop.org/rubocop/0.89/cops_lint.html#lintunreachableloop
+Lint/UnreachableLoop:
+  Enabled: true
+
 # This cop checks for unused block arguments.
 Lint/UnusedBlockArgument:
   Enabled: false
@@ -172,10 +234,6 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
-# Checks for comparison of something with itself.
-Lint/UselessComparison:
-  Enabled: true
-
 # Checks for useless `else` in `begin..end` without `rescue`.
 Lint/UselessElseWithoutRescue:
   Enabled: true

data/rubocop-metrics.yml

@@ -1,3 +1,4 @@
+---
 # A calculated magnitude based on number of assignments,
 # branches, and conditions.
 Metrics/AbcSize:

data/rubocop-migrations.yml

@@ -1,3 +1,4 @@
+---
 # Checks for methods that may lead to batch type issues on a table that's been
 # explicitly denied because of its size.
 #

data/rubocop-naming.yml

@@ -1,3 +1,4 @@
+---
 # Check the naming of accessor methods for get_/set_.
 Naming/AccessorMethodName:
   Enabled: false

data/rubocop-performance.yml

@@ -1,3 +1,15 @@
+---
+# Used to identify usages of ancestors.include? and change them to use ⇐ instead.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performanceancestorsinclude
+Performance/AncestorsInclude:
+  Enabled: true
+
+# Identifies places where numeric argument to BigDecimal should be converted to string.
+# Initializing from String is faster than from Numeric for BigDecimal.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancebigdecimalwithnumericargument
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
 # Use `caller(n..n)` instead of `caller`.
 Performance/Caller:
   Enabled: false
@@ -31,17 +43,53 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 1
 
+# Identifies places where sort { |a, b| a <=> b } can be replaced with sort.
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceredundantsortblock
+Performance/RedundantSortBlock:
+  Enabled: true
+
+# Checks for redundant String#chars.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performanceredundantstringchars
+Performance/RedundantStringChars:
+  Enabled: true
+
+# Identifies places where reverse.first(n) and reverse.first can be replaced by last(n).reverse and last.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancereversefirst
+Performance/ReverseFirst:
+  Enabled: true
+
+# Identifies places where sort { |a, b| b <=> a } can be replaced by a faster sort.reverse.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesortreverse
+Performance/SortReverse:
+  Enabled: true
+
+# Identifies places where gsub(/a+/, 'a') and gsub!(/a+/, 'a') can be replaced by squeeze('a') and squeeze!('a').
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesqueeze
+Performance/Squeeze:
+  Enabled: true
+
 # Use `start_with?` instead of a regex match anchored to the beginning of a
 # string.
 Performance/StartWith:
   Enabled: true
 
+# Identifies unnecessary use of a regex where String#include? would suffice.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancestringinclude
+Performance/StringInclude:
+  Enabled: true
+
 # Use `tr` instead of `gsub` when you are replacing the same number of
 # characters. Use `delete` instead of `gsub` when you are deleting
 # characters.
 Performance/StringReplacement:
   Enabled: true
 
+# Identifies places where custom code finding the sum of elements in some
+# Enumerable object can be replaced by Enumerable#sum method.
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesum
+Performance/Sum:
+  Enabled: true
+
 # Checks for `.times.map` calls.
 Performance/TimesMap:
   Enabled: true

data/rubocop-rails.yml

@@ -1,3 +1,4 @@
+---
 # Enables Rails cops.
 Rails:
   Enabled: true
@@ -7,6 +8,18 @@ Rails/ActionFilter:
   Enabled: true
   EnforcedStyle: action
 
+# Checks that Active Record callbacks are declared in the order in which they will be executed.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsactiverecordcallbacksorder
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+# Enforces that there is only one call to after_commit
+# (and its aliases - after_create_commit, after_update_commit, and after_destroy_commit)
+# with the same callback name per model.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsaftercommitoverride
+Rails/AfterCommitOverride:
+  Enabled: true
+
 # Check that models subclass ApplicationRecord.
 Rails/ApplicationRecord:
   Enabled: false
@@ -43,6 +56,12 @@ Rails/FindBy:
     - 'app/**/*.rb'
     - 'lib/**/*.rb'
 
+# Enforces that ActiveRecord#find is used instead of where.take!, find_by!, and find_by_id!
+# to retrieve a single record by primary key when you expect it to be found.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsfindbyid
+Rails/FindById:
+  Enabled: true
+
 # Prefer `all.find_each` over `all.find`.
 Rails/FindEach:
   Enabled: true
@@ -57,6 +76,26 @@ Rails/HasAndBelongsToMany:
 Rails/HttpPositionalArguments:
   Enabled: true
 
+# Checks that Active Support’s inquiry method is not used.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsinquiry
+Rails/Inquiry:
+  Enabled: true
+
+# Enforces that mailer names end with Mailer suffix.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsmailername
+Rails/MailerName:
+  Enabled: true
+
+# Identifies places where defining routes with match can be replaced with a specific HTTP method.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsmatchroute
+Rails/MatchRoute:
+  Enabled: true
+
+# Enforces the use of collection.exclude?(obj) over !collection.include?(obj).
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsnegateinclude
+Rails/NegateInclude:
+  Enabled: true
+
 # Checks for calls to puts, print, etc.
 Rails/Output:
   Enabled: true
@@ -71,6 +110,16 @@ Rails/Output:
 Rails/OutputSafety:
   Enabled: false
 
+# Enforces the use of pluck over map.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railspluck
+Rails/Pluck:
+  Enabled: true
+
+# Identifies places where pluck is used in where query methods and can be replaced with select.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railspluckinwhere
+Rails/PluckInWhere:
+  Enabled: true
+
 # Checks for incorrect grammar when using methods like `3.day.ago`.
 Rails/PluralizationGrammar:
   Enabled: true
@@ -87,10 +136,30 @@ Rails/ReadWriteAttribute:
 Rails/RelativeDateConstant:
   Enabled: false
 
+# Looks for inline rendering within controller actions.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsrenderinline
+Rails/RenderInline:
+  Enabled: true
+
+# Identifies places where render text: can be replaced with render plain:.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsrenderplaintext
+Rails/RenderPlainText:
+  Enabled: true
+
 # Checks the arguments of ActiveRecord scopes.
 Rails/ScopeArgs:
   Enabled: true
 
+# Enforces that short forms of I18n methods are used: t instead of translate and l instead of localize.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railsshorti18n
+Rails/ShortI18n:
+  Enabled: true
+
+# Checks SQL heredocs to use .squish.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railssquishedsqlheredocs
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
 # This cop checks for the use of Time methods without zone.
 Rails/TimeZone:
   Enabled: false
@@ -98,3 +167,13 @@ Rails/TimeZone:
 # This cop checks for the use of old-style attribute validation macros.
 Rails/Validation:
   Enabled: true
+
+# Enforces consistent style when using exists?.
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railswhereexists
+Rails/WhereExists:
+  Enabled: true
+
+# Identifies places where manually constructed SQL in where can be replaced with where.not(...).
+# https://docs.rubocop.org/rubocop-rails/2.8/cops_rails.html#railswherenot
+Rails/WhereNot:
+  Enabled: true

data/rubocop-rspec.yml

@@ -1,3 +1,4 @@
+---
 # Check that instances are not being stubbed globally.
 RSpec/AnyInstance:
   Enabled: false
@@ -142,6 +143,11 @@ RSpec/SingleLineHook:
     - 'spec/factories/*'
     - 'spec/requests/api/v3/*'
 
+# Checks that message expectations do not have a configured response.
+# https://docs.rubocop.org/rubocop-rspec/1.44/cops_rspec.html#rspecstubbedmock
+RSpec/StubbedMock:
+  Enabled: false
+
 # Checks for stubbed test subjects.
 RSpec/SubjectStub:
   Enabled: false

data/rubocop-security.yml

@@ -1,3 +1,4 @@
+---
 # This cop checks for the use of JSON class methods which have potential
 # security issues.
 Security/JSONLoad:

data/rubocop-style.yml

@@ -1,3 +1,9 @@
+---
+# Checks for grouping of accessors in class and module bodies.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleaccessorgrouping
+Style/AccessorGrouping:
+  Enabled: true
+
 # Use alias_method instead of alias.
 Style/Alias:
   EnforcedStyle: prefer_alias_method
@@ -8,6 +14,11 @@ Style/Alias:
 Style/AndOr:
   Enabled: true
 
+# Enforces the use of Array() instead of explicit Array check or [*var]
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylearraycoercion
+Style/ArrayCoercion:
+  Enabled: true
+
 # Use `Array#join` instead of `Array#*`.
 Style/ArrayJoin:
   Enabled: true
@@ -24,6 +35,11 @@ Style/Attr:
 Style/BeginBlock:
   Enabled: true
 
+# Checks for places where attr_reader and attr_writer for the same method can be combined into single attr_accessor.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylebisectedattraccessor
+Style/BisectedAttrAccessor:
+  Enabled: true
+
 # Do not use block comments.
 Style/BlockComments:
   Enabled: true
@@ -33,10 +49,15 @@ Style/BlockComments:
 Style/BlockDelimiters:
   Enabled: true
 
-# This cop checks for uses of the case equality operator(===).
+# Checks for uses of the case equality operator(===).
 Style/CaseEquality:
   Enabled: false
 
+# Identifies places where if-elsif constructions can be replaced with case-when.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylecaselikeif
+Style/CaseLikeIf:
+  Enabled: true
+
 # Checks for uses of character literals.
 Style/CharacterLiteral:
   Enabled: true
@@ -95,6 +116,12 @@ Style/EndBlock:
 Style/EvenOdd:
   Enabled: true
 
+# Enforces the use of explicit block argument to avoid writing block literal that
+# just passes its arguments to another block.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleexplicitblockargument
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 # Enforces consistency when using exponential notation for numbers in the code
 Style/ExponentialNotation:
   Enabled: true
@@ -111,6 +138,13 @@ Style/FormatStringToken:
 Style/FrozenStringLiteralComment:
   Enabled: true
 
+# Enforces the use of $stdout/$stderr/$stdin instead of STDOUT/STDERR/STDIN. STDOUT/STDERR/STDIN are constants,
+# and while you can actually reassign (possibly to redirect some stream) constants in Ruby,
+# you’ll get an interpreter warning if you do so.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleglobalstdstream
+Style/GlobalStdStream:
+  Enabled: true
+
 # Do not introduce global variables.
 Style/GlobalVars:
   Enabled: true
@@ -118,10 +152,20 @@ Style/GlobalVars:
     - 'lib/backup/**/*'
     - 'lib/tasks/**/*'
 
+# Checks for presence or absence of braces around hash literal as a last array item depending on configuration.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylehashaslastarrayitem
+Style/HashAsLastArrayItem:
+  Enabled: true
+
 # Checks for uses of each_key and each_value Hash methods.
 Style/HashEachMethods:
   Enabled: true
 
+# Checks for places where case-when represents a simple 1:1 mapping and can be replaced with a hash lookup.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylehashlikecase
+Style/HashLikeCase:
+  Enabled: false
+
 # Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
 # over 1.8 syntax `{ :a => 1, :b => 2 }`.
 Style/HashSyntax:
@@ -161,6 +205,11 @@ Style/InverseMethods:
 Style/LambdaCall:
   Enabled: true
 
+# Checks for places where keyword arguments can be used instead of boolean arguments when defining methods.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleoptionalbooleanparameter
+Style/OptionalBooleanParameter:
+  Enabled: false
+
 # Use `strip` instead of `lstrip.rstrip`.
 Style/Strip:
   Enabled: true
@@ -248,10 +297,25 @@ Style/PreferredHashMethods:
 Style/RedundantCapitalW:
   Enabled: true
 
+# Checks for redundant assignment before returning.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleredundantassignment
+Style/RedundantAssignment:
+  Enabled: true
+
 # Checks for an obsolete RuntimeException argument in raise/fail.
 Style/RedundantException:
   Enabled: true
 
+# Identifies places where fetch(key) { value } can be replaced by fetch(key, value).
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleredundantfetchblock
+Style/RedundantFetchBlock:
+  Enabled: true
+
+# Checks for the presence of superfluous .rb extension in the filename provided to require and require_relative.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleredundantfileextensioninrequire
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
 # Checks for parentheses that seem not to serve any purpose.
 Style/RedundantParentheses:
   Enabled: true
@@ -260,6 +324,16 @@ Style/RedundantParentheses:
 Style/RedundantPercentQ:
   Enabled: false
 
+# Checks for unnecessary single-element Regexp character classes.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleredundantregexpcharacterclass
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+# Checks for redundant escapes inside Regexp literals.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleredundantregexpescape
+Style/RedundantRegexpEscape:
+  Enabled: true
+
 # Use `sort` instead of `sort_by { |x| x }`.
 Style/RedundantSortBy:
   Enabled: true
@@ -268,16 +342,31 @@ Style/RedundantSortBy:
 Style/Semicolon:
   Enabled: true
 
+# Sometimes using dig method ends up with just a single argument. In such cases, dig should be replaced with [].
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylesingleargumentdig
+Style/SingleArgumentDig:
+  Enabled: true
+
 # Checks for proper usage of fail and raise.
 Style/SignalException:
   EnforcedStyle: only_raise
   Enabled: true
 
+# Checks that arrays are sliced with endless ranges instead of ary[start..-1] on Ruby 2.6+.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleslicingwithrange
+Style/SlicingWithRange:
+  Enabled: true
+
 # Check for the usage of parentheses around stabby lambda arguments.
 Style/StabbyLambdaParentheses:
   EnforcedStyle: require_parentheses
   Enabled: true
 
+# Checks for places where string concatenation can be replaced with string interpolation.
+# https://docs.rubocop.org/rubocop/0.89/cops_style.html#stylestringconcatenation
+Style/StringConcatenation:
+  Enabled: true
+
 # Checks if uses of quotes match the configured preference.
 Style/StringLiterals:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 5.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.89.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.89.1
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
@@ -44,42 +44,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.36'
+        version: '1.44'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.36'
+        version: '1.44'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -129,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".editorconfig"
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".gitlab/merge_request_templates/Release.md"
@@ -148,6 +149,7 @@ files:
 - lib/gitlab/styles/rubocop.rb
 - lib/gitlab/styles/rubocop/cop/active_record_dependent.rb
 - lib/gitlab/styles/rubocop/cop/active_record_serialize.rb
+- lib/gitlab/styles/rubocop/cop/code_reuse/active_record.rb
 - lib/gitlab/styles/rubocop/cop/custom_error_class.rb
 - lib/gitlab/styles/rubocop/cop/gem_fetcher.rb
 - lib/gitlab/styles/rubocop/cop/in_batches.rb
@@ -155,6 +157,7 @@ files:
 - lib/gitlab/styles/rubocop/cop/migration/update_large_table.rb
 - lib/gitlab/styles/rubocop/cop/polymorphic_associations.rb
 - lib/gitlab/styles/rubocop/cop/redirect_with_status.rb
+- lib/gitlab/styles/rubocop/cop/rspec/base.rb
 - lib/gitlab/styles/rubocop/cop/rspec/empty_line_after_let_block.rb
 - lib/gitlab/styles/rubocop/cop/rspec/empty_line_after_shared_example.rb
 - lib/gitlab/styles/rubocop/cop/rspec/have_link_parameters.rb
@@ -163,9 +166,11 @@ files:
 - lib/gitlab/styles/rubocop/cop/without_reactive_cache.rb
 - lib/gitlab/styles/rubocop/migration_helpers.rb
 - lib/gitlab/styles/rubocop/model_helpers.rb
+- lib/gitlab/styles/rubocop/rspec/helpers.rb
 - lib/gitlab/styles/version.rb
 - rubocop-all.yml
 - rubocop-bundler.yml
+- rubocop-code_reuse.yml
 - rubocop-default.yml
 - rubocop-gemspec.yml
 - rubocop-layout.yml
@@ -190,7 +195,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="