gitlab-styles 3.4.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5f56cd42de5afd61307ea92fd0114cb64e79b575697800b948e6d3e42e32d7c
-  data.tar.gz: 25c343aae93b4bb8d03d57b92152c5c51433cacec86c86b6449ba8a6af3cc6e2
+  metadata.gz: 9d23f16df66558ac47e1084f4558dbf68589e7c81a3e99056e193500962c6608
+  data.tar.gz: 0aedb037f3ef8a90a2c3c0c80945949832eaa52da9ec5c3f872d8fc24157f300
 SHA512:
-  metadata.gz: a7e7dbc2a80150595404fb1639266f462687668411b4410378a1021d9d07915fec14d6b34265d2a6672d65e5005cb4e2d7a1e99acff2ddbe0bc827280dc1c011
-  data.tar.gz: c0b9073e17bf0c11f283ef485612746c3baa1a6de27392029ca930413f939cc192d797e0a3a3016da2db0bdc219444c93129199fbba9ab81e533f86182c65d10
+  metadata.gz: 478c9a5284aeb471ca82131d10496ce730126c1a66fb87f6a369153bb4ef65850fef4a92834cc5ac23ea66ef000afdbc2803a05fded8332a14eee08673aa4c36
+  data.tar.gz: 1675434965d80d42e2ffd7fff89eb84460d6bc70c4971e3fcf826273a118a55967a96446addf8454d851ebbbf097adf33a5f0498de1fb8c4b2e63b47a8ca103a

data/.gitignore

@@ -9,3 +9,6 @@
 
 # rspec failure tracking
 .rspec_status
+
+# Ignore IDE specific files
+.idea/

data/Gemfile

@@ -7,6 +7,6 @@ gemspec
 
 group :test do
   # Pin these dependencies, otherwise a new rule could break the CI pipelines
-  gem 'rubocop', '0.74.0'
+  gem 'rubocop', '0.82.0'
   gem 'rubocop-rspec', '1.36.0'
 end

data/gitlab-styles.gemspec

@@ -21,10 +21,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.74.0'
+  spec.add_dependency 'rubocop', '~> 0.82.0'
   spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.0'
-  spec.add_dependency 'rubocop-performance', '~> 1.4.1'
-  spec.add_dependency 'rubocop-rails', '~> 2.0'
+  spec.add_dependency 'rubocop-performance', '~> 1.5.2'
+  spec.add_dependency 'rubocop-rails', '~> 2.5'
   spec.add_dependency 'rubocop-rspec', '~> 1.36'
 
   spec.add_development_dependency 'bundler', '~> 1.16'

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '3.4.0'
+    VERSION = '4.0.0'
   end
 end

data/rubocop-all.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.6
   # Cop names are not displayed in offense messages by default. Change behavior
   # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
   # option.

data/rubocop-layout.yml

@@ -3,18 +3,14 @@ Layout/AccessModifierIndentation:
   Enabled: true
 
 # Align the elements of an array literal if they span more than one line.
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Enabled: true
 
-# Align the elements of a hash literal if they span more than one line.
-Layout/AlignHash:
+# Checks the indentation of the first line of the right-hand-side of a
+# multi-line assignment.
+Layout/AssignmentIndentation:
   Enabled: true
 
-# Here we check if the parameters on a multi-line method call or
-# definition are aligned.
-Layout/AlignParameters:
-  Enabled: false
-
 # Align block ends correctly.
 Layout/BlockAlignment:
   Enabled: true
@@ -102,27 +98,36 @@ Layout/ExtraSpacing:
 Layout/FirstMethodParameterLineBreak:
   Enabled: true
 
+# Align the elements of a hash literal if they span more than one line.
+Layout/HashAlignment:
+  Enabled: true
+
+# This cops checks the indentation of the here document bodies.
+Layout/HeredocIndentation:
+  Enabled: false
+
 # Keep indentation straight.
 Layout/IndentationConsistency:
   Enabled: true
 
-# Use 2 spaces for indentation.
-Layout/IndentationWidth:
+# No hard tabs.
+Layout/IndentationStyle:
   Enabled: true
 
-# Checks the indentation of the first line of the right-hand-side of a
-# multi-line assignment.
-Layout/IndentAssignment:
+# Use 2 spaces for indentation.
+Layout/IndentationWidth:
   Enabled: true
 
-# This cops checks the indentation of the here document bodies.
-Layout/IndentHeredoc:
-  Enabled: false
-
 # Comments should start with a space.
 Layout/LeadingCommentSpace:
   Enabled: true
 
+# Limit lines to 120 characters.
+Layout/LineLength:
+  Enabled: true
+  Max: 120
+  IgnoredPatterns: ['\s#\srubocop']
+
 # Checks that the closing brace in an array literal is either on the same line
 # as the last array element, or a new line.
 Layout/MultilineArrayBraceLayout:
@@ -160,6 +165,11 @@ Layout/MultilineOperationIndentation:
   Enabled: true
   EnforcedStyle: indented
 
+# Here we check if the parameters on a multi-line method call or
+# definition are aligned.
+Layout/ParameterAlignment:
+  Enabled: false
+
 # Use spaces after colons.
 Layout/SpaceAfterColon:
   Enabled: true
@@ -189,6 +199,10 @@ Layout/SpaceAroundEqualsInParameterDefault:
 Layout/SpaceAroundKeyword:
   Enabled: true
 
+# Checks method call operators to not have spaces around them.
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 # Use a single space around operators.
 Layout/SpaceAroundOperators:
   Enabled: true
@@ -235,12 +249,8 @@ Layout/SpaceInsideStringInterpolation:
   EnforcedStyle: no_space
   Enabled: true
 
-# No hard tabs.
-Layout/Tab:
-  Enabled: true
-
 # Checks trailing blank lines and final newline.
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: true
 
 # Avoid trailing whitespace.

data/rubocop-lint.yml

@@ -47,10 +47,6 @@ Lint/EmptyEnsure:
 Lint/EmptyWhen:
   Enabled: true
 
-# END blocks should not be placed inside method definitions.
-Lint/EndInMethod:
-  Enabled: true
-
 # Do not use return in an ensure block.
 Lint/EnsureReturn:
   Enabled: true
@@ -67,10 +63,6 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
-# This cop checks for *rescue* blocks with no body.
-Lint/HandleExceptions:
-  Enabled: false
-
 # Checks for adjacent string literals on the same line, which could better be
 # represented as a single string literal.
 Lint/ImplicitStringConcatenation:
@@ -105,11 +97,23 @@ Lint/NextWithoutAccumulator:
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
 
+# Checks for raise or fail statements which are raising Exception class.
+Lint/RaiseException:
+  Enabled: true
+
 # Checks for `rand(1)` calls. Such calls always return `0` and most likely
 # a mistake.
 Lint/RandOne:
   Enabled: true
 
+# This cop checks for unneeded usages of splat expansion
+Lint/RedundantSplatExpansion:
+  Enabled: false
+
+# Checks for Object#to_s usage in string interpolation.
+Lint/RedundantStringCoercion:
+  Enabled: true
+
 # Use parentheses in the method call to avoid confusion about precedence.
 Lint/RequireParentheses:
   Enabled: true
@@ -131,10 +135,14 @@ Lint/ShadowedException:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
-# Checks for Object#to_s usage in string interpolation.
-Lint/StringConversionInInterpolation:
+# Checks unexpected overrides of the Struct built-in methods via Struct.new.
+Lint/StructNewOverride:
   Enabled: true
 
+# This cop checks for *rescue* blocks with no body.
+Lint/SuppressedException:
+  Enabled: false
+
 # Do not use prefix `_` for a variable that is used.
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
@@ -143,10 +151,6 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Enabled: true
 
-# This cop checks for unneeded usages of splat expansion
-Lint/UnneededSplatExpansion:
-  Enabled: false
-
 # Unreachable code.
 Lint/UnreachableCode:
   Enabled: true

data/rubocop-metrics.yml

@@ -23,12 +23,6 @@ Metrics/CyclomaticComplexity:
   Enabled: true
   Max: 13
 
-# Limit lines to 120 characters.
-Metrics/LineLength:
-  Enabled: true
-  Max: 120
-  IgnoredPatterns: ['\s#\srubocop']
-
 # Avoid methods longer than 10 lines of code.
 Metrics/MethodLength:
   Enabled: false

data/rubocop-naming.yml

@@ -30,6 +30,13 @@ Naming/MemoizedInstanceVariableName:
 Naming/MethodName:
   Enabled: true
 
+# Method parameter names for how descriptive they are.
+Naming/MethodParameterName:
+  Enabled: true
+  MinNameLength: 2
+  AllowedNames:
+    - _
+
 # Use `spam?` instead of `is_spam?`
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_
@@ -37,18 +44,11 @@ Naming/MethodName:
 # NameWhitelist: is_a?
 Naming/PredicateName:
   Enabled: true
-  NamePrefixBlacklist: is_
+  ForbiddenPrefixes: is_
   Exclude:
     - 'spec/**/*'
     - 'features/**/*'
 
-# Method parameter names for how descriptive they are.
-Naming/UncommunicativeMethodParamName:
-  Enabled: true
-  MinNameLength: 2
-  AllowedNames:
-    - _
-
 # Use the configured style when naming variables.
 Naming/VariableName:
   EnforcedStyle: snake_case

data/rubocop-style.yml

@@ -33,11 +33,6 @@ Style/BlockComments:
 Style/BlockDelimiters:
   Enabled: true
 
- # This cop checks for braces around the last parameter in a method call
-# if the last parameter is a hash.
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # This cop checks for uses of the case equality operator(===).
 Style/CaseEquality:
   Enabled: false
@@ -100,6 +95,10 @@ Style/EndBlock:
 Style/EvenOdd:
   Enabled: true
 
+# Enforces consistency when using exponential notation for numbers in the code
+Style/ExponentialNotation:
+  Enabled: true
+
 # Checks use of for or each in multiline loops.
 Style/For:
   Enabled: true
@@ -119,11 +118,27 @@ Style/GlobalVars:
     - 'lib/backup/**/*'
     - 'lib/tasks/**/*'
 
+# Checks for uses of each_key and each_value Hash methods.
+Style/HashEachMethods:
+  Enabled: true
+
 # Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
 # over 1.8 syntax `{ :a => 1, :b => 2 }`.
 Style/HashSyntax:
   Enabled: true
 
+# looks for uses of _.each_with_object({}) {...}, _.map {...}.to_h, and Hash[_.map {...}]
+# that are actually just transforming the keys of a hash, and tries to use a simpler & faster
+# call to transform_keys instead.
+Style/HashTransformKeys:
+  Enabled: true
+
+# looks for uses of _.each_with_object({}) {...}, _.map {...}.to_h, and Hash[_.map {...}]
+# that are actually just transforming the values of a hash, and tries to use a simpler & faster
+# call to transform_values instead.
+Style/HashTransformValues:
+  Enabled: true
+
 # Checks that conditional statements do not have an identical line at the
 # end of each branch, which can validly be moved out of the conditional.
 Style/IdenticalConditionalBranches:
@@ -229,6 +244,10 @@ Style/ParenthesesAroundCondition:
 Style/PreferredHashMethods:
   Enabled: false
 
+# Checks for %W when interpolation is not needed.
+Style/RedundantCapitalW:
+  Enabled: true
+
 # Checks for an obsolete RuntimeException argument in raise/fail.
 Style/RedundantException:
   Enabled: true
@@ -237,6 +256,10 @@ Style/RedundantException:
 Style/RedundantParentheses:
   Enabled: true
 
+# Checks for %q/%Q when single quotes or double quotes would do.
+Style/RedundantPercentQ:
+  Enabled: false
+
 # Use `sort` instead of `sort_by { |x| x }`.
 Style/RedundantSortBy:
   Enabled: true
@@ -284,14 +307,6 @@ Style/TrailingCommaInArguments:
   Enabled: true
   EnforcedStyleForMultiline: no_comma
 
-# Checks for %W when interpolation is not needed.
-Style/UnneededCapitalW:
-  Enabled: true
-
-# Checks for %q/%Q when single quotes or double quotes would do.
-Style/UnneededPercentQ:
-  Enabled: false
-
 # Don't interpolate global, instance and class variables directly in strings.
 Style/VariableInterpolation:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 4.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-10 00:00:00.000000000 Z
+date: 2020-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 0.82.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 0.82.0
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: 1.5.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement