gitlab-styles 2.5.2 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5334cd2272ed29d614774e483b919bebd5c62896241e18d64b6e277c420a1dba
-  data.tar.gz: dd3f4029decbe3834065539d6e341a558169417f4fc408706565a2a03f7641fa
+  metadata.gz: 4194e1fb96ce504c76fc8fc453818c3f9d97ef5bbf293756a5ba03627468da86
+  data.tar.gz: 367d84b2b4dfda10a7c27baef5c2563150aa14853be97ab11e35e3f838665642
 SHA512:
-  metadata.gz: d8537ecb94f30f617052bb90aa1097d392dc70acaeba597ff9f56fb50bb87ac498527d7780a5810e954d5b8d2920e490c96c18b51dca14675eea89be81b4f93f
-  data.tar.gz: 0f96c292047f23bf9c76b596f4c0f5d66aecfc9c7382150832fa45b9d71667e636f0f52d32db8b66cb23672115c900988aac2ad684f246439ddfc2491e1fcee3
+  metadata.gz: 7a3b37cf9de982ef9cc178b8b0cfc5fb587dc1ffaefb6be82cbb1cb8421f93aeaa6a340c85f4c1b13735929b1b70fe63536abc1e32ac4736e1b3d0e4ec30cae0
+  data.tar.gz: 603bb3c1e12eff89c8afa8876b31e0adca547f8e1d02a0541895f92b3b83a060e3b8391faf605c022345d41869036387f3937ca8d1827a0291a19250def25496

data/Gemfile

@@ -5,6 +5,6 @@ gemspec
 
 group :test do
   # Pin these dependencies, otherwise a new rule could break the CI pipelines
-  gem 'rubocop', '0.54.0'
+  gem 'rubocop', '0.68.0'
   gem 'rubocop-rspec', '1.20.1'
 end

data/gitlab-styles.gemspec

@@ -19,8 +19,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.54.0'
+  spec.add_dependency 'rubocop', '~> 0.68.0'
   spec.add_dependency 'rubocop-gitlab-security', '~> 0.1.0'
+  spec.add_dependency 'rubocop-performance', '~> 1.1.0'
   spec.add_dependency 'rubocop-rspec', '~> 1.19'
 
   spec.add_development_dependency 'bundler', '~> 1.16'

data/lib/gitlab/styles/rubocop/cop/gem_fetcher.rb

@@ -18,9 +18,7 @@ module Gitlab
 
             node.children.last.each_node(:pair) do |pair|
               key_name = pair.children[0].children[0].to_sym
-              if GIT_KEYS.include?(key_name)
-                add_offense(node, location: pair.source_range, message: MSG)
-              end
+              add_offense(node, location: pair.source_range, message: MSG) if GIT_KEYS.include?(key_name)
             end
           end
 

data/lib/gitlab/styles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Styles
-    VERSION = '2.5.2'.freeze
+    VERSION = '2.6.0'.freeze
   end
 end

data/rubocop-default.yml

@@ -1,6 +1,7 @@
 require:
-  - rubocop-rspec
   - rubocop-gitlab-security
+  - rubocop-performance
+  - rubocop-rspec
   - ./lib/gitlab/styles/rubocop
 
 inherit_from:

data/rubocop-lint.yml

@@ -55,6 +55,10 @@ Lint/EndInMethod:
 Lint/EnsureReturn:
   Enabled: true
 
+# Checks for flip flops.
+Lint/FlipFlop:
+  Enabled: true
+
 # Catches floating-point literals too large or small for Ruby to represent.
 Lint/FloatOutOfRange:
   Enabled: true

data/rubocop-performance.yml

@@ -11,10 +11,6 @@ Performance/Casecmp:
 Performance/DoubleStartEndWith:
   Enabled: true
 
-# Use `strip` instead of `lstrip.rstrip`.
-Performance/LstripRstrip:
-  Enabled: true
-
 # Use `Range#cover?` instead of `Range#include?`.
 Performance/RangeInclude:
   Enabled: true
@@ -35,10 +31,6 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 1
 
-# Use `sort` instead of `sort_by { |x| x }`.
-Performance/RedundantSortBy:
-  Enabled: true
-
 # Use `start_with?` instead of a regex match anchored to the beginning of a
 # string.
 Performance/StartWith:

data/rubocop-style.yml

@@ -100,10 +100,6 @@ Style/EndBlock:
 Style/EvenOdd:
   Enabled: true
 
-# Checks for flip flops.
-Style/FlipFlop:
-  Enabled: true
-
 # Checks use of for or each in multiline loops.
 Style/For:
   Enabled: true
@@ -150,6 +146,10 @@ Style/InverseMethods:
 Style/LambdaCall:
   Enabled: true
 
+# Use `strip` instead of `lstrip.rstrip`.
+Style/Strip:
+  Enabled: true
+
 # Checks if the method definitions have or don't have parentheses.
 Style/MethodDefParentheses:
   Enabled: true
@@ -237,6 +237,10 @@ Style/RedundantException:
 Style/RedundantParentheses:
   Enabled: true
 
+# Use `sort` instead of `sort_by { |x| x }`.
+Style/RedundantSortBy:
+  Enabled: true
+
 # Don't use semicolons to terminate expressions.
 Style/Semicolon:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.6.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-10 00:00:00.000000000 Z
+date: 2019-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 0.68.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 0.68.0
 - !ruby/object:Gem::Dependency
   name: rubocop-gitlab-security
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.1.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement