gitlab-styles 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a42799e70b411a155cfd1c8560070ec9d392b27
-  data.tar.gz: ff2d1e7abf77741598dd6b3daf7ae72ac070c01e
+  metadata.gz: 428a98eba0188d3e0da5edce2a199920e67f9f7d
+  data.tar.gz: 2524287dacb4b19dbc0fc80db30566bd4d98c55a
 SHA512:
-  metadata.gz: 062e71d3c7368f5b579a2f310d30d5fcdf9e7cfaf5c5a0b1ebea68745ea39dd15c8f470c30292119a37ce0bc95704a7337e0d715792fd5772ba53d7bef4213e5
-  data.tar.gz: 16be6ea7882ca778c10fea2710f795c021aae30a3cfb7f32fc9f1da8ad91c8eb4c8dd457d97977c6f68cfb7cf70876ef153420cc0f1e3c1331597753fb37ad8c
+  metadata.gz: 3ee7038b87dab11c007c0c30927500cce85a17c24b1aa496398ecf26eaa17188d0a76091433330d949dd91c5f831acd51e5ae74ae08e1f284c7b13c7d6603561
+  data.tar.gz: 8e8c88aaec1d8eee2a872638903fe6574ef99a3cd0bff47e80c2ae7755f03e6067056d4b5232fcb802ce7c5fafe989e4315d377b0b038ebffd26431ec2f37bb9

data/README.md

@@ -28,7 +28,7 @@ already in `rubocop-default.yml`:
 
 ```yaml
 inherit_gem:
-  gitlab-rubocop:
+  gitlab-styles:
     - rubocop-default.yml
 ```
 

data/gitlab-styles.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['remy@rymai.me']
 
   spec.summary       = 'GitLab style guides and shared style configs.'
-  spec.homepage      = 'https://github.com/gitlab-org/gitlab-styles'
+  spec.homepage      = 'https://gitlab.com/gitlab-org/gitlab-styles'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|

data/lib/gitlab/styles/rubocop.rb

@@ -3,23 +3,8 @@ require 'gitlab/styles/rubocop/cop/gem_fetcher'
 require 'gitlab/styles/rubocop/cop/active_record_serialize'
 require 'gitlab/styles/rubocop/cop/redirect_with_status'
 require 'gitlab/styles/rubocop/cop/polymorphic_associations'
-require 'gitlab/styles/rubocop/cop/project_path_helper'
 require 'gitlab/styles/rubocop/cop/active_record_dependent'
 require 'gitlab/styles/rubocop/cop/in_batches'
-require 'gitlab/styles/rubocop/cop/migration/add_column'
-require 'gitlab/styles/rubocop/cop/migration/add_column_with_default_to_large_table'
-require 'gitlab/styles/rubocop/cop/migration/add_concurrent_foreign_key'
-require 'gitlab/styles/rubocop/cop/migration/add_concurrent_index'
-require 'gitlab/styles/rubocop/cop/migration/add_index'
-require 'gitlab/styles/rubocop/cop/migration/add_timestamps'
-require 'gitlab/styles/rubocop/cop/migration/datetime'
-require 'gitlab/styles/rubocop/cop/migration/safer_boolean_column'
-require 'gitlab/styles/rubocop/cop/migration/hash_index'
-require 'gitlab/styles/rubocop/cop/migration/remove_concurrent_index'
-require 'gitlab/styles/rubocop/cop/migration/remove_index'
-require 'gitlab/styles/rubocop/cop/migration/reversible_add_column_with_default'
-require 'gitlab/styles/rubocop/cop/migration/timestamps'
-require 'gitlab/styles/rubocop/cop/migration/update_column_in_batches'
 require 'gitlab/styles/rubocop/cop/rspec/single_line_hook'
 
 module Gitlab

data/lib/gitlab/styles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Styles
-    VERSION = '1.0.0'.freeze
+    VERSION = '2.0.0'.freeze
   end
 end

data/rubocop-default.yml

@@ -5,7 +5,6 @@ require:
 
 AllCops:
   TargetRubyVersion: 2.3
-  TargetRailsVersion: 4.2
   # Cop names are not d§splayed in offense messages by default. Change behavior
   # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
   # option.
@@ -15,16 +14,6 @@ AllCops:
   # -S/--display-style-guide option.
   DisplayStyleGuide: false
   # Exclude some GitLab files
-  Exclude:
-    - 'vendor/**/*'
-    - 'node_modules/**/*'
-    - 'db/*'
-    - 'db/fixtures/**/*'
-    - 'db/geo/*'
-    - 'tmp/**/*'
-    - 'bin/**/*'
-    - 'generator_templates/**/*'
-    - 'builds/**/*'
 
 # Gems in consecutive lines should be alphabetically sorted
 Bundler/OrderedGems:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-18 00:00:00.000000000 Z
+date: 2017-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -120,29 +120,14 @@ files:
 - lib/gitlab/styles/rubocop/cop/custom_error_class.rb
 - lib/gitlab/styles/rubocop/cop/gem_fetcher.rb
 - lib/gitlab/styles/rubocop/cop/in_batches.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_column.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_column_with_default_to_large_table.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_concurrent_foreign_key.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_concurrent_index.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_index.rb
-- lib/gitlab/styles/rubocop/cop/migration/add_timestamps.rb
-- lib/gitlab/styles/rubocop/cop/migration/datetime.rb
-- lib/gitlab/styles/rubocop/cop/migration/hash_index.rb
-- lib/gitlab/styles/rubocop/cop/migration/remove_concurrent_index.rb
-- lib/gitlab/styles/rubocop/cop/migration/remove_index.rb
-- lib/gitlab/styles/rubocop/cop/migration/reversible_add_column_with_default.rb
-- lib/gitlab/styles/rubocop/cop/migration/safer_boolean_column.rb
-- lib/gitlab/styles/rubocop/cop/migration/timestamps.rb
-- lib/gitlab/styles/rubocop/cop/migration/update_column_in_batches.rb
 - lib/gitlab/styles/rubocop/cop/polymorphic_associations.rb
-- lib/gitlab/styles/rubocop/cop/project_path_helper.rb
 - lib/gitlab/styles/rubocop/cop/redirect_with_status.rb
 - lib/gitlab/styles/rubocop/cop/rspec/single_line_hook.rb
 - lib/gitlab/styles/rubocop/migration_helpers.rb
 - lib/gitlab/styles/rubocop/model_helpers.rb
 - lib/gitlab/styles/version.rb
 - rubocop-default.yml
-homepage: https://github.com/gitlab-org/gitlab-styles
+homepage: https://gitlab.com/gitlab-org/gitlab-styles
 licenses:
 - MIT
 metadata: {}

data/lib/gitlab/styles/rubocop/cop/migration/add_column.rb

@@ -1,56 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if columns are added in a way that doesn't require
-          # downtime.
-          class AddColumn < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            WHITELISTED_TABLES = [:application_settings].freeze
-
-            MSG = '`add_column` with a default value requires downtime, ' \
-              'use `add_column_with_default` instead'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              name = node.children[1]
-
-              return unless name == :add_column
-
-              # Ignore whitelisted tables.
-              return if table_whitelisted?(node.children[2])
-
-              opts = node.children.last
-
-              return unless opts&.type == :hash
-
-              opts.each_node(:pair) do |pair|
-                if hash_key_type(pair) == :sym && hash_key_name(pair) == :default
-                  add_offense(node, :selector)
-                end
-              end
-            end
-
-            def table_whitelisted?(symbol)
-              symbol&.type == :sym &&
-                WHITELISTED_TABLES.include?(symbol.children[0])
-            end
-
-            def hash_key_type(pair)
-              pair.children[0].type
-            end
-
-            def hash_key_name(pair)
-              pair.children[0].children[0]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/add_column_with_default_to_large_table.rb

@@ -1,59 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # This cop checks for `add_column_with_default` on a table that's been
-          # explicitly blacklisted because of its size.
-          #
-          # Even though this helper performs the update in batches to avoid
-          # downtime, using it with tables with millions of rows still causes a
-          # significant delay in the deploy process and is best avoided.
-          #
-          # See https://gitlab.com/gitlab-com/infrastructure/issues/1602 for more
-          # information.
-          class AddColumnWithDefaultToLargeTable < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'Using `add_column_with_default` on the `%s` table will take a ' \
-              'long time to complete, and should be avoided unless absolutely ' \
-              'necessary'.freeze
-
-            LARGE_TABLES = %i[
-              ci_pipelines
-              ci_builds
-              events
-              issues
-              merge_request_diff_files
-              merge_request_diffs
-              merge_requests
-              namespaces
-              notes
-              projects
-              routes
-              users
-            ].freeze
-
-            def_node_matcher :add_column_with_default?, <<~PATTERN
-              (send nil :add_column_with_default $(sym ...) ...)
-            PATTERN
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              matched = add_column_with_default?(node)
-              return unless matched
-
-              table = matched.to_a.first
-              return unless LARGE_TABLES.include?(table)
-
-              add_offense(node, :expression, format(MSG, table))
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/add_concurrent_foreign_key.rb

@@ -1,31 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if `add_concurrent_foreign_key` is used instead of
-          # `add_foreign_key`.
-          class AddConcurrentForeignKey < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = '`add_foreign_key` requires downtime, use `add_concurrent_foreign_key` instead'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              name = node.children[1]
-
-              add_offense(node, :selector) if name == :add_foreign_key
-            end
-
-            def method_name(node)
-              node.children.first
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/add_concurrent_index.rb

@@ -1,38 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if `add_concurrent_index` is used with `up`/`down` methods
-          # and not `change`.
-          class AddConcurrentIndex < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = '`add_concurrent_index` is not reversible so you must manually define ' \
-              'the `up` and `down` methods in your migration class, using `remove_concurrent_index` in `down`'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              name = node.children[1]
-
-              return unless name == :add_concurrent_index
-
-              node.each_ancestor(:def) do |def_node|
-                next unless method_name(def_node) == :change
-
-                add_offense(def_node, :name)
-              end
-            end
-
-            def method_name(node)
-              node.children.first
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/add_index.rb

@@ -1,52 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if indexes are added in a concurrent manner.
-          class AddIndex < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = '`add_index` requires downtime, use `add_concurrent_index` instead'.freeze
-
-            def on_def(node)
-              return unless in_migration?(node)
-
-              new_tables = []
-
-              node.each_descendant(:send) do |send_node|
-                first_arg = first_argument(send_node)
-
-                # The first argument of "create_table" / "add_index" is the table
-                # name.
-                new_tables << first_arg if create_table?(send_node)
-
-                next if method_name(send_node) != :add_index
-
-                # Using "add_index" is fine for newly created tables as there's no
-                # data in these tables yet.
-                next if new_tables.include?(first_arg)
-
-                add_offense(send_node, :selector)
-              end
-            end
-
-            def create_table?(node)
-              method_name(node) == :create_table
-            end
-
-            def method_name(node)
-              node.children[1]
-            end
-
-            def first_argument(node)
-              node.children[2] ? node.children[0] : nil
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/add_timestamps.rb

@@ -1,29 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if 'add_timestamps' method is called with timezone information.
-          class AddTimestamps < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'Do not use `add_timestamps`, use `add_timestamps_with_timezone` instead'.freeze
-
-            # Check methods.
-            def on_send(node)
-              return unless in_migration?(node)
-
-              add_offense(node, :selector) if method_name(node) == :add_timestamps
-            end
-
-            def method_name(node)
-              node.children[1]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/datetime.rb

@@ -1,40 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if datetime data type is added with timezone information.
-          class Datetime < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'Do not use the `datetime` data type, use `datetime_with_timezone` instead'.freeze
-
-            # Check methods in table creation.
-            def on_def(node)
-              return unless in_migration?(node)
-
-              node.each_descendant(:send) do |send_node|
-                add_offense(send_node, :selector) if method_name(send_node) == :datetime
-              end
-            end
-
-            # Check methods.
-            def on_send(node)
-              return unless in_migration?(node)
-
-              node.each_descendant do |descendant|
-                add_offense(node, :expression) if descendant.type == :sym && descendant.children.last == :datetime
-              end
-            end
-
-            def method_name(node)
-              node.children[1]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/hash_index.rb

@@ -1,55 +0,0 @@
-require 'set'
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that prevents the use of hash indexes in database migrations
-          class HashIndex < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'hash indexes should be avoided at all costs since they are not ' \
-              'recorded in the PostgreSQL WAL, you should use a btree index instead'.freeze
-
-            NAMES = Set.new([:add_index, :index, :add_concurrent_index]).freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              name = node.children[1]
-
-              return unless NAMES.include?(name)
-
-              opts = node.children.last
-
-              return unless opts&.type == :hash
-
-              opts.each_node(:pair) do |pair|
-                next unless hash_key_type(pair) == :sym &&
-                    hash_key_name(pair) == :using
-
-                if hash_key_value(pair).to_s == 'hash'
-                  add_offense(pair, :expression)
-                end
-              end
-            end
-
-            def hash_key_type(pair)
-              pair.children[0].type
-            end
-
-            def hash_key_name(pair)
-              pair.children[0].children[0]
-            end
-
-            def hash_key_value(pair)
-              pair.children[1].children[0]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/remove_concurrent_index.rb

@@ -1,33 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if `remove_concurrent_index` is used with `up`/`down` methods
-          # and not `change`.
-          class RemoveConcurrentIndex < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = '`remove_concurrent_index` is not reversible so you must manually define ' \
-              'the `up` and `down` methods in your migration class, using `add_concurrent_index` in `down`'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-              return unless node.children[1] == :remove_concurrent_index
-
-              node.each_ancestor(:def) do |def_node|
-                add_offense(def_node, :name) if method_name(def_node) == :change
-              end
-            end
-
-            def method_name(node)
-              node.children[0]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/remove_index.rb

@@ -1,30 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if indexes are removed in a concurrent manner.
-          class RemoveIndex < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = '`remove_index` requires downtime, use `remove_concurrent_index` instead'.freeze
-
-            def on_def(node)
-              return unless in_migration?(node)
-
-              node.each_descendant(:send) do |send_node|
-                add_offense(send_node, :selector) if method_name(send_node) == :remove_index
-              end
-            end
-
-            def method_name(node)
-              node.children[1]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/reversible_add_column_with_default.rb

@@ -1,39 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if `add_column_with_default` is used with `up`/`down` methods
-          # and not `change`.
-          class ReversibleAddColumnWithDefault < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            def_node_matcher :add_column_with_default?, <<~PATTERN
-              (send nil :add_column_with_default $...)
-            PATTERN
-
-            def_node_matcher :defines_change?, <<~PATTERN
-              (def :change ...)
-            PATTERN
-
-            MSG = '`add_column_with_default` is not reversible so you must manually define ' \
-              'the `up` and `down` methods in your migration class, using `remove_column` in `down`'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-              return unless add_column_with_default?(node)
-
-              node.each_ancestor(:def) do |def_node|
-                next unless defines_change?(def_node)
-
-                add_offense(def_node, :name)
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/safer_boolean_column.rb

@@ -1,98 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # This cop requires a default value and disallows nulls for boolean
-          # columns on small tables.
-          #
-          # In general, this prevents 3-state-booleans.
-          # https://robots.thoughtbot.com/avoid-the-threestate-boolean-problem
-          #
-          # In particular, for the `application_settings` table, this ensures that
-          # upgraded installations get a proper default for the new boolean setting.
-          # A developer might otherwise mistakenly assume that a value in
-          # `ApplicationSetting.defaults` is sufficient.
-          #
-          # See https://gitlab.com/gitlab-org/gitlab-ee/issues/2750 for more
-          # information.
-          class SaferBooleanColumn < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            DEFAULT_OFFENSE = 'Boolean columns on the `%s` table should have a default. You may wish to use `add_column_with_default`.'.freeze
-            NULL_OFFENSE = 'Boolean columns on the `%s` table should disallow nulls.'.freeze
-            DEFAULT_AND_NULL_OFFENSE = 'Boolean columns on the `%s` table should have a default and should disallow nulls. You may wish to use `add_column_with_default`.'.freeze
-
-            SMALL_TABLES = %i[
-              application_settings
-            ].freeze
-
-            def_node_matcher :add_column?, <<~PATTERN
-              (send nil :add_column $...)
-            PATTERN
-
-            def on_send(node)
-              return unless in_migration?(node)
-
-              matched = add_column?(node)
-
-              return unless matched
-
-              table, _, type = matched.to_a.take(3).map(&:children).map(&:first)
-              opts = matched[3]
-
-              return unless SMALL_TABLES.include?(table) && type == :boolean
-
-              no_default = no_default?(opts)
-              nulls_allowed = nulls_allowed?(opts)
-
-              offense = if no_default && nulls_allowed
-                          DEFAULT_AND_NULL_OFFENSE
-                        elsif no_default
-                          DEFAULT_OFFENSE
-                        elsif nulls_allowed
-                          NULL_OFFENSE
-                        end
-
-              add_offense(node, :expression, format(offense, table)) if offense
-            end
-
-            def no_default?(opts)
-              return true unless opts
-
-              each_hash_node_pair(opts) do |key, value|
-                return value == 'nil' if key == :default
-              end
-            end
-
-            def nulls_allowed?(opts)
-              return true unless opts
-
-              each_hash_node_pair(opts) do |key, value|
-                return value != 'false' if key == :null
-              end
-            end
-
-            def each_hash_node_pair(hash_node, &block)
-              hash_node.each_node(:pair) do |pair|
-                key = hash_pair_key(pair)
-                value = hash_pair_value(pair)
-                yield(key, value)
-              end
-            end
-
-            def hash_pair_key(pair)
-              pair.children[0].children[0]
-            end
-
-            def hash_pair_value(pair)
-              pair.children[1].source
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/timestamps.rb

@@ -1,31 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if 'timestamps' method is called with timezone information.
-          class Timestamps < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'Do not use `timestamps`, use `timestamps_with_timezone` instead'.freeze
-
-            # Check methods in table creation.
-            def on_def(node)
-              return unless in_migration?(node)
-
-              node.each_descendant(:send) do |send_node|
-                add_offense(send_node, :selector) if method_name(send_node) == :timestamps
-              end
-            end
-
-            def method_name(node)
-              node.children[1]
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/migration/update_column_in_batches.rb

@@ -1,45 +0,0 @@
-require_relative '../../migration_helpers'
-
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        module Migration
-          # Cop that checks if a spec file exists for any migration using
-          # `update_column_in_batches`.
-          class UpdateColumnInBatches < RuboCop::Cop::Cop
-            include MigrationHelpers
-
-            MSG = 'Migration running `update_column_in_batches` must have a spec file at' \
-              ' `%s`.'.freeze
-
-            def on_send(node)
-              return unless in_migration?(node)
-              return unless node.children[1] == :update_column_in_batches
-
-              spec_path = spec_filename(node)
-
-              add_offense(node, :expression, format(MSG, spec_path)) unless File.exist?(File.expand_path(spec_path, rails_root))
-            end
-
-            private
-
-            def spec_filename(node)
-              source_name = node.location.expression.source_buffer.name
-              path = Pathname.new(source_name).relative_path_from(rails_root)
-              dirname = File.dirname(path)
-                .sub(%r{\Adb/(migrate|post_migrate)}, 'spec/migrations')
-              filename = File.basename(source_name, '.rb').sub(/\A\d+_/, '')
-
-              File.join(dirname, "#{filename}_spec.rb")
-            end
-
-            def rails_root
-              Pathname.new(File.expand_path('../../..', __dir__))
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/gitlab/styles/rubocop/cop/project_path_helper.rb

@@ -1,55 +0,0 @@
-module Gitlab
-  module Styles
-    module Rubocop
-      module Cop
-        class ProjectPathHelper < RuboCop::Cop::Cop
-          MSG = 'Use short project path helpers without explicitly passing the namespace: ' \
-            '`foo_project_bar_path(project, bar)` instead of ' \
-            '`foo_namespace_project_bar_path(project.namespace, project, bar)`.'.freeze
-
-          METHOD_NAME_PATTERN = /\A([a-z_]+_)?namespace_project(?:_[a-z_]+)?_(?:url|path)\z/
-
-          def on_send(node)
-            return unless method_name(node).to_s =~ METHOD_NAME_PATTERN
-
-            namespace_expr, project_expr = arguments(node)
-            return unless namespace_expr && project_expr
-
-            return unless namespace_expr.type == :send
-            return unless method_name(namespace_expr) == :namespace
-            return unless receiver(namespace_expr) == project_expr
-
-            add_offense(node, :selector)
-          end
-
-          def autocorrect(node)
-            helper_name = method_name(node).to_s.sub('namespace_project', 'project')
-
-            arguments = arguments(node)
-            arguments.shift # Remove namespace argument
-
-            replacement = "#{helper_name}(#{arguments.map(&:source).join(', ')})"
-
-            lambda do |corrector|
-              corrector.replace(node.source_range, replacement)
-            end
-          end
-
-          private
-
-          def receiver(node)
-            node.children[0]
-          end
-
-          def method_name(node)
-            node.children[1]
-          end
-
-          def arguments(node)
-            node.children[2..-1]
-          end
-        end
-      end
-    end
-  end
-end