gitlab-styles 14.0.0 → 14.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e07aeadc05dafb796aaa44e43f0f0e7c53344048756b9d402a81949f71d14c2
-  data.tar.gz: 90b4af4c628cc78a537907563f14068a2d18f8eff3199db32a3434c8adb12f04
+  metadata.gz: 97c5d02f5527dfe3cfecf408460d9613ca6b2d820d21ebd95d39dbc79f3b94b8
+  data.tar.gz: 92ade99f8c31fa1617d47c80a575fe572d67a03f113c2aff9417932bca74b305
 SHA512:
-  metadata.gz: c237f8409677ebffef96022175af2604d4e14472df266f4cc00112a2f44e4b374537326540eb5786573dd6680b4215e126500bc4373af3bc01d5c40957ca68ec
-  data.tar.gz: be9a4aa227f7913295c98b2445e3f4108cd42f17ee5b81f12416f3b2e31c273b153980d6bb45c54c1d51eb3dff4c6a16c6bcac51ea96a1bfaea198d6820c9760
+  metadata.gz: 3d189c88f35cf67f0c211f40a27cd2bcac2b6964e0719279bcb4ae28601c98381150752332a0f894aedd1c7e0a57a3160ca44cc1877629594fa1eea737668e36
+  data.tar.gz: 30b2281cdb5ec7b966065ed926cdacbbcd7bdd9de66b85be0e7eb1758057759add13080e7a7c4c0c63ba5f2603c6ad8f863e8b7ccc44e412bb40bd2e0fc27ccf

data/.rubocop_todo.yml

@@ -1,19 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 10000`
-# on 2025-08-12 06:28:35 UTC using RuboCop version 1.71.2.
+# on 2026-01-26 16:12:08 UTC using RuboCop version 1.81.7.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-InternalAffairs/CopDescriptionWithExample:
-  Exclude:
-    - 'lib/rubocop/cop/gitlab_security/deep_munge.rb'
-    - 'lib/rubocop/cop/line_break_around_conditional_block.rb'
-    - 'lib/rubocop/cop/migration/update_large_table.rb'
-
 # Offense count: 10
 InternalAffairs/MissingCopDepartment:
   Exclude:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (14.0.0)
+    gitlab-styles (14.1.0)
       rubocop (= 1.81.7)
       rubocop-capybara (= 2.21.0)
       rubocop-factory_bot (= 2.26.1)

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '14.0.0'
+    VERSION = '14.1.0'
   end
 end

data/lib/rubocop/cop/gitlab_security/deep_munge.rb

@@ -13,7 +13,17 @@ module RuboCop
       #   # bad
       #   config.action_dispatch.perform_deep_munge = false
       #
+      #   # bad
+      #   config.action_dispatch.perform_deep_munge = !true
+      #
+      #   # good
+      #   config.action_dispatch.perform_deep_munge = true
+      #
+      #   # good
+      #   # Deep munge is not explicitly disabled
+      #
       # See CVE-2012-2660, CVE-2012-2694, and CVE-2013-0155.
+
       class DeepMunge < RuboCop::Cop::Base
         MSG = 'Never disable the deep munge security option.'
 

data/lib/rubocop/cop/internal_affairs/use_restrict_on_send.rb

@@ -45,37 +45,35 @@ module RuboCop
         MSG = 'Define constant `RESTRICT_ON_SEND` to speed up calls to `on_send`. ' \
           'The following line is then no longer necessary:'
 
-        # @!method method_name_plain(node)
+        # @!method method_name_plain(node, send_param)
         def_node_matcher :method_name_plain, <<~PATTERN
           {
-            (send _ :method_name _ ...)       # method_name(node)
-            (send
-              (send _ :children) :[] (int 1)  # node.children[1]
-            )
+            (send _ :method_name (lvar %1) ...)           # method_name(on_send_param)
+            (send (send (lvar %1) :children) :[] (int 1)) # on_send_param.children[1]
           }
         PATTERN
 
-        # @!method method_name_call(node)
+        # @!method method_name_call(node, send_param, local_assignments)
         def_node_matcher :method_name_call, <<~PATTERN
           {
-            #method_name_plain
-            (lvar %1)
+            #method_name_plain(%1)  # direct method_name/children[1] call on the on_send param
+            (lvar %2)               # local variable previously assigned from such a call
           }
         PATTERN
 
-        # @!method method_name_assignment(node)
+        # @!method method_name_assignment(node, send_param)
         def_node_search :method_name_assignment, <<~PATTERN
-          (lvasgn $_name #method_name_plain)
+          (lvasgn $_ #method_name_plain(%1))
         PATTERN
 
-        # @!method method_name_check(node)
+        # @!method method_name_check(node, send_param, local_assignments)
         def_node_search :method_name_check, <<~PATTERN
           (if
             ${
-              (send #method_name_call(%1) {:== :!=} _) # method_name(node) == foo
-              (send _ :include? #method_name_call(%1)) # a.include?(method_name(node))
+              (send #method_name_call(%1, %2) {:== :!=} _) # method_name(on_send_param) == foo
+              (send _ :include? #method_name_call(%1, %2)) # a.include?(method_name(on_send_param))
             }
-            {!nil? nil? | nil? !nil?}                  # has either `if` or `else` branch - not both
+            {!nil? nil? | nil? !nil?}                      # has either `if` or `else` branch - not both
           )
         PATTERN
 
@@ -83,9 +81,12 @@ module RuboCop
           return unless node.method?(:on_send)
           return if @restrict_on_send_set
 
-          local_assignments = method_name_assignment(node).to_set
+          send_param = node.first_argument&.name
+          return unless send_param
 
-          method_name_check(node, local_assignments) do |call_node|
+          local_assignments = method_name_assignment(node, send_param).to_set
+
+          method_name_check(node, send_param, local_assignments) do |call_node|
             add_offense(call_node)
           end
         end

data/lib/rubocop/cop/line_break_around_conditional_block.rb

@@ -5,43 +5,43 @@ module Rubocop
     # Ensures a line break around conditional blocks.
     #
     # @example
-    #    # bad
-    #    do_something
-    #    if condition
-    #      do_extra_stuff
-    #    end
-    #    do_something_more
+    #   # bad
+    #   do_something
+    #   if condition
+    #     do_extra_stuff
+    #   end
+    #   do_something_more
     #
-    #    # good
-    #    do_something
+    #   # good
+    #   do_something
     #
-    #    if condition
-    #      do_extra_stuff
-    #    end
+    #   if condition
+    #     do_extra_stuff
+    #   end
     #
-    #    do_something_more
+    #   do_something_more
     #
-    #    # bad
-    #    do_something
-    #    unless condition
-    #      do_extra_stuff
-    #    end
+    #   # bad
+    #   do_something
+    #   unless condition
+    #     do_extra_stuff
+    #   end
     #
-    #    do_something_more
+    #   do_something_more
     #
-    #    # good
-    #    def a_method
-    #      if condition
-    #        do_something
-    #      end
-    #    end
+    #   # good
+    #   def a_method
+    #     if condition
+    #       do_something
+    #     end
+    #   end
     #
-    #    # good
-    #    on_block do
-    #      if condition
-    #        do_something
-    #      end
-    #    end
+    #   # good
+    #   on_block do
+    #     if condition
+    #       do_something
+    #     end
+    #   end
     class LineBreakAroundConditionalBlock < RuboCop::Cop::Base
       extend RuboCop::Cop::AutoCorrector
       include RuboCop::Cop::RangeHelp

data/lib/rubocop/cop/migration/update_large_table.rb

@@ -8,10 +8,33 @@ module Rubocop
       # Checks for methods that may lead to batch type issues on a table that's been
       # explicitly denied because of its size.
       #
-      # Even though though these methods perform functions to avoid
+      # Even though these methods perform functions to avoid
       # downtime, using it with tables with millions of rows still causes a
       # significant delay in the deploy process and is best avoided.
       #
+      # @example
+      #
+      #   # bad
+      #   class ExampleMigration < ActiveRecord::Migration[7.0]
+      #     def change
+      #       denied_method(:denied_table, column: :value)
+      #     end
+      #   end
+      #
+      #   # good
+      #   class ExampleMigration < ActiveRecord::Migration[7.0]
+      #     def change
+      #       denied_method(:allowed_table, column: :value)
+      #     end
+      #   end
+      #
+      #   # good
+      #   class ExampleMigration < ActiveRecord::Migration[7.0]
+      #     def change
+      #       allowed_method(:denied_table, column: :value)
+      #     end
+      #   end
+      #
       # See https://gitlab.com/gitlab-com/infrastructure/issues/1602 for more
       # information.
       class UpdateLargeTable < RuboCop::Cop::Base

data/lib/rubocop/cop/rspec/feature_spec_max_examples.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require 'rubocop-rspec'
+require_relative 'base'
+
+module Rubocop
+  module Cop
+    module RSpec
+      # Limits the number of examples in feature spec files.
+      #
+      # Feature specs with too many examples are slow to run, hard to maintain,
+      # and often indicate the file should be split into smaller, focused specs.
+      #
+      # The maximum number of examples can be configured with the `Max` option
+      # (default: 25).
+      #
+      # @example Max: 25 (default)
+      #
+      #   # bad
+      #   # A feature spec file with more than 25 examples.
+      #
+      #   # good
+      #   # A feature spec file with 25 or fewer examples.
+      class FeatureSpecMaxExamples < Base
+        MSG = 'Feature spec file has %<count>d examples, which exceeds the maximum of %<max>d. ' \
+          'Consider splitting into smaller, focused files grouped by user flow or feature area.'
+
+        def on_new_investigation
+          super
+          @example_count = 0
+          @max = cop_config['Max'] || 25
+        end
+
+        def on_block(node)
+          @example_count += 1 if example?(node)
+        end
+        alias_method :on_numblock, :on_block
+
+        def on_investigation_end
+          add_global_offense(format(MSG, count: @example_count, max: @max)) if @example_count > @max
+        end
+      end
+    end
+  end
+end

data/rubocop-rspec.yml

@@ -96,6 +96,12 @@ RSpec/ExpectChange:
 RSpec/ExpectOutput:
   Enabled: true
 
+# Limits the number of examples in feature spec files to encourage splitting
+# large specs into smaller, focused files.
+RSpec/FeatureSpecMaxExamples:
+  Enabled: false
+  Max: 25
+
 # Checks if there are focused specs.
 RSpec/Focus:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 14.0.0
+  version: 14.1.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-12 00:00:00.000000000 Z
+date: 2026-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -357,6 +357,7 @@ files:
 - lib/rubocop/cop/rspec/empty_line_after_let_block.rb
 - lib/rubocop/cop/rspec/empty_line_after_shared_example.rb
 - lib/rubocop/cop/rspec/example_starting_character.rb
+- lib/rubocop/cop/rspec/feature_spec_max_examples.rb
 - lib/rubocop/cop/rspec/have_link_parameters.rb
 - lib/rubocop/cop/rspec/rails_controller_testing.rb
 - lib/rubocop/cop/rspec/single_line_hook.rb