gitlab-styles 13.0.2 → 13.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b05957f6a3353a50fe37009f0c78239677857f28e6d16589de5eb3aa8120868
-  data.tar.gz: d3169d41ff1af9327b2e1e3a8fb2a5a2357915542ad0bb3352e52451e3cfb0dc
+  metadata.gz: 5e57fcdf2fdb535c445887ec28fe2c32809c24b90cf0202a27cf04f086c32fbc
+  data.tar.gz: '074834caba51bf818e60afdffe2260f644d270d065af3eb46dd256d6deb90d5c'
 SHA512:
-  metadata.gz: 53891b9794f187eaa55f40dd87d2f89bbe84d4d7204fb40b40de4b7dc3761b2e4a265a670ed4255d49ef419df682a5d5e44d8283e12d01bf530be1a684527ba2
-  data.tar.gz: d77ec1fb537c34c438527eb019c12bfff2f463bfd78212384f15e2cdd327e5de2cd9572d91d6020ef72f3c885bc4f5de244d5b9a1bc842d2aa0347b0bfb75fbd
+  metadata.gz: 60c696ef6dcde1baac7ff18ba02267f1d275182cf4ffa0bdfe400c7144ae8100bfc9f15e3faea4597e45afc3dd18e3445fda8b55ce1b9251ca57b985f682ab40
+  data.tar.gz: 980a9c08bf84a10dc151c188b66cc60d3e42a953aea058955ad65bc6d8ad32d7498f154ce74257b71a1ef620d58cd3ef1f28c0025f2547c17eb5b5be02e60bb8

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2024-09-06 09:55:51 UTC using RuboCop version 1.64.0.
+# `rubocop --auto-gen-config --exclude-limit 10000`
+# on 2025-02-02 02:50:28 UTC using RuboCop version 1.71.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -22,11 +22,6 @@ InternalAffairs/CopDescriptionWithExample:
     - 'lib/rubocop/cop/performance/rubyzip.rb'
     - 'lib/rubocop/cop/polymorphic_associations.rb'
 
-# Offense count: 1
-InternalAffairs/InheritDeprecatedCopClass:
-  Exclude:
-    - 'lib/rubocop/cop/gitlab_security/json_serialization.rb'
-
 # Offense count: 10
 InternalAffairs/MissingCopDepartment:
   Exclude:
@@ -40,3 +35,31 @@ InternalAffairs/MissingCopDepartment:
     - 'lib/rubocop/cop/line_break_around_conditional_block.rb'
     - 'lib/rubocop/cop/polymorphic_associations.rb'
     - 'lib/rubocop/cop/redirect_with_status.rb'
+
+# Offense count: 24
+InternalAffairs/OnSendWithoutOnCSend:
+  Exclude:
+    - 'lib/rubocop/cop/active_record_dependent.rb'
+    - 'lib/rubocop/cop/active_record_serialize.rb'
+    - 'lib/rubocop/cop/code_reuse/active_record.rb'
+    - 'lib/rubocop/cop/gem_fetcher.rb'
+    - 'lib/rubocop/cop/gitlab_security/deep_munge.rb'
+    - 'lib/rubocop/cop/gitlab_security/json_serialization.rb'
+    - 'lib/rubocop/cop/gitlab_security/redirect_to_params_update.rb'
+    - 'lib/rubocop/cop/gitlab_security/send_file_params.rb'
+    - 'lib/rubocop/cop/gitlab_security/sql_injection.rb'
+    - 'lib/rubocop/cop/gitlab_security/system_command_injection.rb'
+    - 'lib/rubocop/cop/in_batches.rb'
+    - 'lib/rubocop/cop/internal_affairs/deprecate_cop_helper.rb'
+    - 'lib/rubocop/cop/migration/update_large_table.rb'
+    - 'lib/rubocop/cop/performance/rubyzip.rb'
+    - 'lib/rubocop/cop/polymorphic_associations.rb'
+    - 'lib/rubocop/cop/rails/include_url_helper.rb'
+    - 'lib/rubocop/cop/redirect_with_status.rb'
+    - 'lib/rubocop/cop/rspec/have_link_parameters.rb'
+    - 'lib/rubocop/cop/rspec/rails_controller_testing.rb'
+    - 'lib/rubocop/cop/rspec/specify_expected.rb'
+    - 'lib/rubocop/cop/rspec/useless_dynamic_definition.rb'
+    - 'lib/rubocop/cop/rspec/verbose_include_metadata.rb'
+    - 'lib/rubocop/cop/style/hash_transformation.rb'
+    - 'lib/rubocop/cop/style/iso8601_date.rb'

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (13.0.2)
-      rubocop (~> 1.68.0)
+    gitlab-styles (13.1.0)
+      rubocop (= 1.71.1)
       rubocop-capybara (~> 2.21.0)
       rubocop-factory_bot (~> 2.26.1)
       rubocop-graphql (~> 1.5.4)
@@ -132,7 +132,7 @@ GEM
     rainbow (3.1.1)
     rake (13.0.6)
     rchardet (1.8.0)
-    regexp_parser (2.9.2)
+    regexp_parser (2.10.0)
     rexml (3.2.8)
       strscan (>= 3.0.9)
     rspec (3.12.0)
@@ -156,17 +156,17 @@ GEM
       binding_of_caller
       rspec-parameterized-core (< 2)
     rspec-support (3.12.0)
-    rubocop (1.68.0)
+    rubocop (1.71.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.38.0)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)

data/gitlab-styles.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.68.0'
+  spec.add_dependency 'rubocop', '1.71.1'
   spec.add_dependency 'rubocop-capybara', '~> 2.21.0'
   spec.add_dependency 'rubocop-factory_bot', '~> 2.26.1'
   spec.add_dependency 'rubocop-graphql', '~> 1.5.4'

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '13.0.2'
+    VERSION = '13.1.0'
   end
 end

data/lib/rubocop/cop/avoid_return_from_blocks.rb

@@ -67,7 +67,7 @@ module Rubocop
       end
 
       def def?(node)
-        node.def_type? || node.defs_type? ||
+        node.type?(:def, :defs) ||
           (node.block_type? && DEF_METHODS.include?(node.method_name))
       end
 

data/lib/rubocop/cop/custom_error_class.rb

@@ -51,7 +51,7 @@ module Rubocop
       # So recurse through that to get the name as written in the source.
       #
       def class_name_from_node(node, suffix = nil)
-        return unless node&.type == :const
+        return unless node&.const_type?
 
         name = node.children[1].to_s
         name = "#{name}::#{suffix}" if suffix

data/lib/rubocop/cop/gitlab_security/public_send.rb

@@ -29,7 +29,7 @@ module RuboCop
 
         # @!method send?(node)
         def_node_matcher :send?, <<-PATTERN
-          ({csend | send} _ ${:send :public_send :__send__} ...)
+          (call _ ${:send :public_send :__send__} ...)
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/rspec/rails_controller_testing.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rubocop-rspec'
+require_relative 'base'
+
+module Rubocop
+  module Cop
+    module RSpec
+      # Flags the use of `assigns` and `render_template`
+      # in controller and request specs.
+      #
+      # @example
+      #   # bad
+      #   ssh_key = create(:personal_key, user: user)
+      #   get admin_credentials_path(filter: 'ssh_keys')
+      #   expect(assigns(:credentials)).to match_array([ssh_key])
+      #
+      #   # good
+      #   ssh_keys = create_list(:personal_key, user: user)
+      #   get admin_credentials_path(filter: 'ssh_keys')
+      #   expect(response.body).to include(ssh_key.title)
+      #
+      #   # bad
+      #   expect(response).to render_template :show
+      #
+      #   # good
+      #   expect(response.body).to include('Cool stuff')
+      #
+      # @see https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html#about-controller-tests
+      # @see https://www.bigbinary.com/blog/changes-to-test-controllers-in-rails-5#reasons-for-removing-assigns-and-assert-template
+      class RailsControllerTesting < Base
+        MSG_TEMPLATE = "Avoid using `%{name}`. Instead, assert on observable outputs such as the response body. See https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html#about-controller-tests"
+
+        RESTRICT_ON_SEND = %i[assigns render_template].freeze
+
+        def on_send(node)
+          add_offense(node, message: format(MSG_TEMPLATE, name: node.method_name))
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/open_struct_use.rb

@@ -41,7 +41,7 @@ module Rubocop
         def custom_class_or_module_definition?(node)
           parent = node.parent
 
-          (parent.class_type? || parent.module_type?) && node.left_siblings.empty?
+          parent.type?(:class, :module) && node.left_siblings.empty?
         end
       end
     end

data/rubocop-rspec.yml

@@ -174,6 +174,12 @@ RSpec/PredicateMatcher:
 RSpec/RepeatedDescription:
   Enabled: false
 
+RSpec/RailsControllerTesting:
+  Enabled: false
+  Include:
+    - 'spec/controllers/**/*'
+    - 'spec/requests/**/*'
+
 # Ensure RSpec hook blocks are always multi-line.
 RSpec/SingleLineHook:
   Enabled: true

data/rubocop-style.yml

@@ -127,6 +127,11 @@ Style/DoubleNegation:
 Style/EndBlock:
   Enabled: true
 
+# See https://gitlab.com/gitlab-org/gitlab/-/issues/465428
+Style/EndlessMethod:
+  Enabled: true
+  EnforcedStyle: disallow
+
 # Favor the use of Fixnum#even? && Fixnum#odd?
 Style/EvenOdd:
   Enabled: true

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 13.0.2
+  version: 13.1.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-11-27 00:00:00.000000000 Z
+date: 2025-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.68.0
+        version: 1.71.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.68.0
+        version: 1.71.1
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
@@ -358,6 +358,7 @@ files:
 - lib/rubocop/cop/rspec/empty_line_after_shared_example.rb
 - lib/rubocop/cop/rspec/example_starting_character.rb
 - lib/rubocop/cop/rspec/have_link_parameters.rb
+- lib/rubocop/cop/rspec/rails_controller_testing.rb
 - lib/rubocop/cop/rspec/single_line_hook.rb
 - lib/rubocop/cop/rspec/specify_expected.rb
 - lib/rubocop/cop/rspec/useless_dynamic_definition.rb