gitlab-styles 13.0.0 → 13.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c8f4c0e301ccd103fbf7b527b4fc81563742555650b5e660ff4dcb18bad7de5
-  data.tar.gz: 7eb4ec96135389f35d7a5b5787c9ab1963b4bf670b64417cc1d31000a67f13f0
+  metadata.gz: 260717767462cb5c7d3c94c228d8a00f9ec264a7b4a550056200349262f4c50e
+  data.tar.gz: 2031cf6ed85f7ea0f14fbaf475f7281c4b451af29973f258fda34f0e01360aef
 SHA512:
-  metadata.gz: a16a93bb989ef4057c9018f4cc8ba0916f31401546c50210d6d97f16445be17b0438a6f07d42d00e7fa1dcad711fb9c6e89aa86f19e08f7af6a3a0979ef47b35
-  data.tar.gz: 8304c777e6c7bac4a57a7583ba580367261483bcef4a4fcb97d81cc7086c76e5b1c8065df78466af537fe4bb2f9a85b4fded2e4841f49aae7a00f5c833fa338b
+  metadata.gz: 390db75820765a83667b91e370513595ce74e03a7ad6c17a6a5679059d320b950401f7aa45723299e13e810db3c5c590d1c91f0a1bc13ef4d63d2fab6d92d84c
+  data.tar.gz: 3746d0712a9fa09def9d490862860d6bc67af3ef02c207be186ed1641b81d24734f23222256655c6296604bbf2a0d2d86d06ccb09f4f04eb606158b282004e0c

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (13.0.0)
-      rubocop (~> 1.66.0)
+    gitlab-styles (13.0.1)
+      rubocop (~> 1.67.0)
       rubocop-capybara (~> 2.21.0)
       rubocop-factory_bot (~> 2.26.1)
       rubocop-graphql (~> 1.5.4)
@@ -156,17 +156,17 @@ GEM
       binding_of_caller
       rspec-parameterized-core (< 2)
     rspec-support (3.12.0)
-    rubocop (1.66.0)
+    rubocop (1.67.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.1, < 2.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.1)
+    rubocop-ast (1.32.3)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)

data/gitlab-styles.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.66.0'
+  spec.add_dependency 'rubocop', '~> 1.67.0'
   spec.add_dependency 'rubocop-capybara', '~> 2.21.0'
   spec.add_dependency 'rubocop-factory_bot', '~> 2.26.1'
   spec.add_dependency 'rubocop-graphql', '~> 1.5.4'

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '13.0.0'
+    VERSION = '13.0.1'
   end
 end

data/lib/rubocop/cop/gitlab_security/json_serialization.rb

@@ -30,7 +30,7 @@ module RuboCop
       #   )
       #
       # See https://gitlab.com/gitlab-org/gitlab-ce/issues/29661
-      class JsonSerialization < RuboCop::Cop::Cop
+      class JsonSerialization < RuboCop::Cop::Base
         MSG = "Don't use `%s` without specifying `only`"
 
         # Check for `to_json` sent to any object that's not a Hash literal or
@@ -72,8 +72,9 @@ module RuboCop
           @method = matched.first
 
           if matched.last.nil? || matched.last.empty?
+            @offense_found = true
             # Empty `to_json` call
-            add_offense(node, location: :selector, message: format_message)
+            add_offense(node.loc.selector, message: format_message)
           else
             check_arguments(node, matched)
           end
@@ -102,6 +103,8 @@ module RuboCop
 
           return unless requires_only?
 
+          @offense_found = true
+
           # Add a top-level offense for the entire argument list, but only if
           # we haven't yet added any offenses to the child Hash values (such
           # as `include`)
@@ -117,6 +120,7 @@ module RuboCop
             includes.each_child_node do |child_node|
               next if contains_only?(child_node)
 
+              @offense_found = true
               add_offense(child_node, message: format_message)
             end
           end
@@ -125,7 +129,7 @@ module RuboCop
         def requires_only?
           return false if @_has_top_level_only
 
-          offenses.count.zero?
+          !@offense_found
         end
       end
     end

data/lib/rubocop/cop/internal_affairs/cop_description_with_example.rb

@@ -90,9 +90,3 @@ module Rubocop
     end
   end
 end
-
-# Don't match files programmatically and use `Include` directives instead.
-# See https://github.com/rubocop/rubocop/pull/13209#issuecomment-2337963170
-class RuboCop::Cop::InternalAffairs::CopDescription
-  remove_method :relevant_file? if instance_method(:relevant_file?)
-end

data/rubocop-rspec.yml

@@ -68,6 +68,11 @@ RSpec/ExampleLength:
   Enabled: false
   Max: 5
 
+# Avoid `it do` instead use `specify do`
+RSpec/ExampleWithoutDescription:
+  Enabled: true
+  EnforcedStyle: single_line_only
+
 # Do not use should when describing your tests.
 RSpec/ExampleWording:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 13.0.1
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-08 00:00:00.000000000 Z
+date: 2024-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.66.0
+        version: 1.67.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.66.0
+        version: 1.67.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement