gitlab-styles 10.1.0 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cd204f5572b14a03cd4f6faec35d9973f07dcab0579cf17ebb5fc10d56ac6b0
-  data.tar.gz: 7a126190155bc1b39eea832c88e4636306f0fafb09f4b6c2c12c9fb275032a8c
+  metadata.gz: aeba900b1e2b7dc4f6a82fa6defd2daaf2b4c6c87101e1d4fd8b2099e1c00aff
+  data.tar.gz: 02c28507a2a0ed18e555b9d2e44fde520e41de6cccd0e7b77a36b9452b651531
 SHA512:
-  metadata.gz: ef80fd1223c28800de324bb2e71bc1c4e381137ddf7e4a4605e7d1e6e301cca3fc5cee69146a80fe23213a77c8c459d7037e305372242702d4cc8c9bb2b08c0b
-  data.tar.gz: 4f60365ef4232d584eb8ec18f99f8ac5537bd4bf933777d5125c4fb2f71423e7c487dd61f18e9e4e40738c4d02949d9291d7fda7a66fa88442bcdeb8854621c0
+  metadata.gz: 1ba653a6135f6cd2cb62268e6ee7df569827c3e6958763acb0d8b1d263192fbcf5634168266c60c13df05cd8635e9ca65560965a19ad2fb2a1816a6982cfefb6
+  data.tar.gz: 5da95736858e333062c060a33069a248e4b15824fd0d6c759a2c223e3c772a164534c9c2741760dd17d65eee67f98e1b0909d2f4199d96081e16de91967b8f69

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    gitlab-styles (10.1.0)
-      rubocop (~> 1.50.2)
+    gitlab-styles (11.0.0)
+      rubocop (~> 1.57.1)
       rubocop-graphql (~> 0.18)
       rubocop-performance (~> 1.15)
       rubocop-rails (~> 2.17)
@@ -16,9 +16,10 @@ GEM
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.4)
+    addressable (2.8.5)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
+    base64 (0.1.1)
     binding_of_caller (1.0.0)
       debug_inspector (>= 0.0.1)
     byebug (11.1.3)
@@ -32,18 +33,18 @@ GEM
     concurrent-ruby (1.2.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (9.3.0)
+    danger (9.3.2)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.13.0)
+      git (~> 1.13)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
-      octokit (~> 5.0)
+      octokit (~> 6.0)
       terminal-table (>= 1, < 4)
     danger-gitlab (8.0.0)
       danger
@@ -76,16 +77,16 @@ GEM
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    git (1.13.2)
+    git (1.18.0)
       addressable (~> 2.8)
       rchardet (~> 1.8)
     gitlab (4.19.0)
       httparty (~> 0.20)
       terminal-table (>= 1.5.1)
-    gitlab-dangerfiles (3.6.7)
-      danger (>= 8.4.5)
+    gitlab-dangerfiles (4.6.0)
+      danger (>= 9.3.0)
       danger-gitlab (>= 8.0.0)
-      rake
+      rake (~> 13.0)
     httparty (0.21.0)
       mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
@@ -96,21 +97,23 @@ GEM
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
+    language_server-protocol (3.17.0.3)
     lefthook (1.3.13)
     method_source (1.0.0)
-    mini_mime (1.1.2)
+    mini_mime (1.1.5)
     minitest (5.18.0)
     multi_xml (0.6.0)
     multipart-post (2.3.0)
     nap (1.1.0)
     no_proxy_fix (0.1.2)
-    octokit (5.6.1)
+    octokit (6.1.1)
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
     open4 (1.3.4)
     parallel (1.23.0)
-    parser (3.2.2.1)
+    parser (3.2.2.4)
       ast (~> 2.4.1)
+      racc
     proc_to_ast (0.1.0)
       coderay
       parser
@@ -121,13 +124,14 @@ GEM
     pry-byebug (3.10.1)
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
-    public_suffix (5.0.1)
+    public_suffix (5.0.3)
+    racc (1.7.1)
     rack (3.0.7)
     rainbow (3.1.1)
     rake (13.0.6)
     rchardet (1.8.0)
-    regexp_parser (2.8.0)
-    rexml (3.2.5)
+    regexp_parser (2.8.1)
+    rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
@@ -149,25 +153,27 @@ GEM
       binding_of_caller
       rspec-parameterized-core (< 2)
     rspec-support (3.12.0)
-    rubocop (1.50.2)
+    rubocop (1.57.1)
+      base64 (~> 0.1.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
+    rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.0)
+    rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
     rubocop-graphql (0.19.0)
       rubocop (>= 0.87, < 2)
-    rubocop-performance (1.17.1)
+    rubocop-performance (1.19.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     rubocop-rails (2.19.1)
@@ -176,7 +182,7 @@ GEM
       rubocop (>= 1.33.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.22.0)
+    rubocop-rspec (2.24.1)
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
@@ -200,7 +206,7 @@ GEM
       faraday (~> 1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     unparser (0.6.7)
       diff-lcs (~> 1.3)
       parser (>= 3.2.0)
@@ -210,7 +216,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 2.1)
-  gitlab-dangerfiles (~> 3.6.7)
+  gitlab-dangerfiles (~> 4.6.0)
   gitlab-styles!
   lefthook (~> 1.3.13)
   pry-byebug (~> 3.10)

data/README.md

@@ -91,7 +91,8 @@ To release a new version:
 1. Create a Merge Request.
 1. Use Merge Request template [Release.md](https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/blob/master/.gitlab/merge_request_templates/Release.md).
 1. Follow the instructions.
-1. After the Merge Request has been merged, a new gem version is [published automatically](https://gitlab.com/gitlab-org/quality/pipeline-common/-/blob/master/ci/gem-release.yml)
+1. After the Merge Request has been merged, a new gem version is [published automatically](https://gitlab.com/gitlab-org/quality/pipeline-common/-/blob/master/ci/gem-release.yml).
+1. Once the new gem version is visible on [RubyGems.org](https://rubygems.org/gems/gitlab-styles), it is recommended to update [GitLab's `Gemfile`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/Gemfile) to bump the `gitlab-styles` Ruby gem to the new version also.
 
 See [!123](https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/merge_requests/123) as an example.
 

data/gitlab-styles.gemspec

@@ -22,14 +22,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.50.2'
+  spec.add_dependency 'rubocop', '~> 1.57.1'
   spec.add_dependency 'rubocop-graphql', '~> 0.18'
   spec.add_dependency 'rubocop-performance', '~> 1.15'
   spec.add_dependency 'rubocop-rails', '~> 2.17'
   spec.add_dependency 'rubocop-rspec', '~> 2.22'
 
   spec.add_development_dependency 'bundler', '~> 2.1'
-  spec.add_development_dependency 'gitlab-dangerfiles', '~> 3.6.7'
+  spec.add_development_dependency 'gitlab-dangerfiles', '~> 4.6.0'
   spec.add_development_dependency 'lefthook', '~> 1.3.13'
   spec.add_development_dependency 'pry-byebug', '~> 3.10'
   spec.add_development_dependency 'rake', '~> 13.0'

data/lib/gitlab/styles/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module Styles
-    VERSION = '10.1.0'
+    VERSION = '11.0.0'
   end
 end

data/lib/rubocop/cop/rspec/specify_expected.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require 'rubocop-rspec'
+require_relative 'base'
+
+module Rubocop
+  module Cop
+    module RSpec
+      # Checks whether `specify` is used with `is_expected` and suggests the
+      # use of `it`.
+      #
+      # @example
+      #
+      #   # bad
+      #   specify { is_expected.to eq(true) }
+      #
+      #   # good
+      #   it { is_expected.to eq(true) }
+      #
+      class SpecifyExpected < Base
+        extend RuboCop::Cop::AutoCorrector
+
+        MSG = 'Prefer using `it` when used with `is_expected`.'
+
+        # @!method specify_with_expected?(node)
+        def_node_matcher :specify_with_expected?, <<~PATTERN
+          (block
+            (send nil? :specify ...)
+            _args
+            (send
+              (send nil? :is_expected)
+              ...
+            )
+          )
+        PATTERN
+
+        RESTRICT_ON_SEND = %i[specify].freeze
+
+        def on_send(node)
+          return unless specify_with_expected?(node.parent)
+
+          add_offense(node) do |corrector|
+            corrector.replace(node, 'it')
+          end
+        end
+      end
+    end
+  end
+end

data/rubocop-gemspec.yml

@@ -1,12 +1,23 @@
 ---
+# Checks that deprecated attributes are not set in a gemspec file. Removing
+# deprecated attributes allows the user to receive smaller packed gems.
+Gemspec/DeprecatedAttributeAssignment:
+  Enabled: true
+
+# Enforce that development dependencies for a gem are specified in Gemfile,
+# rather than in the gemspec using add_development_dependency
+# Reason: Each project may decide to use a different strategy.
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
 # Dependencies in the gemspec should be alphabetically sorted
 # Configuration parameters: Include, TreatCommentsAsGroupSeparators.
 Gemspec/OrderedDependencies:
   Include:
     - '**/*.gemspec'
 
-# Enforce that development dependencies for a gem are specified in Gemfile,
-# rather than in the gemspec using add_development_dependency
-# Reason: Each project may decide to use a different strategy.
-Gemspec/DevelopmentDependencies:
+# Requires a gemspec to have rubygems_mfa_required metadata set.
+# Most gems are released via CI and MFA cannot be used with improved security.
+# See https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/merge_requests/313#note_1605402392
+Gemspec/RequireMFA:
   Enabled: false

data/rubocop-rails.yml

@@ -178,6 +178,11 @@ Rails/RenderInline:
 Rails/RenderPlainText:
   Enabled: true
 
+# Checks for the usage of obsolete `require_dependency` method for Rails
+# applications running in Zeitwerk mode.
+Rails/RequireDependency:
+  Enabled: true
+
 # Checks the arguments of ActiveRecord scopes.
 Rails/ScopeArgs:
   Enabled: true

data/rubocop-rspec.yml

@@ -83,6 +83,7 @@ RSpec/ExpectOutput:
   Enabled: true
 
 # Checks the file and folder naming of the spec file.
+# Will be replaced with RSpec/SpecFilePathFormat and RSpec/SpecFilePathSuffix.
 RSpec/FilePath:
   Enabled: true
   IgnoreMethods: true
@@ -137,7 +138,7 @@ RSpec/MultipleExpectations:
 
 # Checks for explicitly referenced test subjects.
 RSpec/NamedSubject:
-  Enabled: false
+  Enabled: true
 
 # Checks for nested example groups.
 RSpec/NestedGroups:
@@ -163,6 +164,17 @@ RSpec/SingleLineHook:
     - 'spec/factories/*'
     - 'spec/requests/api/v3/*'
 
+# Checks the file and folder naming of the spec file.
+# Will replace RSpec/FilePath.
+RSpec/SpecFilePathFormat:
+  Enabled: false
+  IgnoreMethods: true
+
+# Checks the file and folder naming of the spec file.
+# Will replace RSpec/FilePath.
+RSpec/SpecFilePathSuffix:
+  Enabled: false
+
 # Checks that message expectations do not have a configured response.
 # https://docs.rubocop.org/rubocop-rspec/1.44/cops_rspec.html#rspecstubbedmock
 RSpec/StubbedMock:

data/rubocop-style.yml

@@ -52,10 +52,14 @@ Style/BisectedAttrAccessor:
 Style/BlockComments:
   Enabled: true
 
-# Avoid using {...} for multi-line blocks (multiline chaining is # always
-# ugly). Prefer {...} over do...end for single-line blocks.
+# Avoid using {...} for multi-line blocks (multi-line chaining is always ugly).
+# Prefer {...} over do...end for single-line blocks.
 Style/BlockDelimiters:
   Enabled: true
+  # Do flag `it {` in multi-line blocks. Off by default.
+  AllowedMethods:
+    - proc
+    - lambda
 
 # Checks for uses of the case equality operator(===).
 Style/CaseEquality:
@@ -127,11 +131,10 @@ Style/EndBlock:
 Style/EvenOdd:
   Enabled: true
 
-# Enforces the use of explicit block argument to avoid writing block literal that
-# just passes its arguments to another block.
-# https://docs.rubocop.org/rubocop/0.89/cops_style.html#styleexplicitblockargument
+# Reason: Using `yield` is ~20% faster than `&block`.
+# See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94090#note_1452639709
 Style/ExplicitBlockArgument:
-  Enabled: true
+  Enabled: false
 
 # Enforces consistency when using exponential notation for numbers in the code
 Style/ExponentialNotation:
@@ -308,6 +311,11 @@ Style/NumberedParametersLimit:
 Style/NumericLiterals:
   Enabled: false
 
+
+# Enforces the use Object#then instead of Object#yield_self.
+Style/ObjectThen:
+  Enabled: true
+
 # Favor the ternary operator(?:) over if/then/else/end constructs.
 Style/OneLineConditional:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-styles
 version: !ruby/object:Gem::Version
-  version: 10.1.0
+  version: 11.0.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-06-29 00:00:00.000000000 Z
+date: 2023-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.57.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.50.2
+        version: 1.57.1
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 4.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.6.7
+        version: 4.6.0
 - !ruby/object:Gem::Dependency
   name: lefthook
   requirement: !ruby/object:Gem::Requirement
@@ -316,6 +316,7 @@ files:
 - lib/rubocop/cop/rspec/factory_bot/excessive_create_list.rb
 - lib/rubocop/cop/rspec/have_link_parameters.rb
 - lib/rubocop/cop/rspec/single_line_hook.rb
+- lib/rubocop/cop/rspec/specify_expected.rb
 - lib/rubocop/cop/rspec/useless_dynamic_definition.rb
 - lib/rubocop/cop/rspec/verbose_include_metadata.rb
 - lib/rubocop/cop/style/hash_transformation.rb