gitlab-qa 7.29.1 → 7.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f3a8d250f26a5899d776475ac349829311045b51aeed7b73f1a40fc41cd23dc
-  data.tar.gz: 2258303729505a302fe0a6d05b57f5deee6efe21f0d7cbfb2542e92febfe2dc7
+  metadata.gz: 04b20a54aa036ec24fb463e50ad5b4be00f81a054cdae02dee966b38c0538c56
+  data.tar.gz: d8c1715674a879d58359d8f8293452f68ae4d516e4c19d4ad888f34ac018498d
 SHA512:
-  metadata.gz: 2ad81f0b8d7bcb59ff76963f0463ae2d221be28b262455c22e6ee11ad91a9c6b768291639ed25b9ff756c9b319566f4aa596281ca2c09d470a5a1374174f3929
-  data.tar.gz: 6e5a9601b50167f4cae9c87fe1415b1a6a740c855e56580cc553559d481842f6ed9feced7760a0403bb7993ef5ba7e11c1fd5723d2812a06227d1a64b87aefd1
+  metadata.gz: 5ccf3ee587dfef9f148fa98aa47b043bb6e2487aca12eb699f489f86fdf05f3939e5ece80ddde46a4e01b9b183dfb24742b287ac616ebc0939665786e8bbeba0
+  data.tar.gz: bc1a167d1b2500974abe0b3ec7f7966debe7b7f211f79324f87685f2e0906606e0c2799164f03adfff69d1af97697cf10128c6fe45eec46534832ad4b4ff0fb5

data/.gitlab/ci/jobs/base.gitlab-ci.yml

@@ -70,6 +70,8 @@ workflow:
 variables:
   DOCKER_DRIVER: overlay2
   DOCKER_HOST: tcp://docker:2375
+  COLORIZED_LOGS: "true"
+  QA_DEBUG: "false"
   QA_CAN_TEST_GIT_PROTOCOL_V2: "true"
   QA_CAN_TEST_PRAEFECT: "false"
   QA_GENERATE_ALLURE_REPORT: "true"

data/.rubocop.yml

@@ -36,3 +36,6 @@ Style/SignalException:
 
 Layout/SpaceBeforeFirstArg:
   Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false

data/.rubocop_todo.yml

@@ -89,11 +89,6 @@ RSpec/LeakyConstantDeclaration:
   Exclude:
     - 'spec/gitlab/qa/scenario/test/instance/deployment_base_spec.rb'
 
-# Offense count: 221
-# Configuration parameters: AllowSubject.
-RSpec/MultipleMemoizedHelpers:
-  Max: 22
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/ExplicitBlockArgument:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab-qa (7.29.1)
+    gitlab-qa (7.30.0)
       activesupport (~> 6.1)
       gitlab (~> 4.18.0)
       http (~> 5.0)

data/lib/gitlab/qa/component/gitlab.rb

@@ -176,6 +176,7 @@ module Gitlab
           exec_commands << seed_admin_token_command if seed_admin_token
           exec_commands << seed_test_data_command if seed_db
           exec_commands << Runtime::Scenario.omnibus_exec_commands
+          exec_commands << add_git_server_hooks unless Runtime::Scenario.skip_server_hooks
 
           commands = exec_commands.flatten.uniq
           return if commands.empty?
@@ -184,14 +185,17 @@ module Gitlab
           commands.each { |command| @docker.exec(name, command) }
         end
 
-        def sha_version
+        def rails_version
           json = @docker.read_file(
             @release.image, @release.tag,
             '/opt/gitlab/version-manifest.json'
           )
 
           manifest = JSON.parse(json)
-          manifest['software']['gitlab-rails']['locked_version']
+          {
+            sha: manifest['software']['gitlab-rails']['locked_version'],
+            source: manifest['software']['gitlab-rails']['locked_source']['git']
+          }
         end
 
         def copy_key_file(env_key)
@@ -243,6 +247,25 @@ module Gitlab
           ["gitlab-rails runner #{DATA_PATH}/admin_access_token_seed.rb"]
         end
 
+        def add_git_server_hooks
+          global_server_prereceive_hook = <<~SCRIPT
+            #!/usr/bin/env bash
+
+            if [[ \\\$GL_PROJECT_PATH =~ 'reject-prereceive' ]]; then
+              echo 'GL-HOOK-ERR: Custom error message rejecting prereceive hook for projects with GL_PROJECT_PATH matching pattern reject-prereceive'
+              exit 1
+            fi
+          SCRIPT
+
+          [
+            @docker.exec(name, 'mkdir -p /opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d'),
+            @docker.write_files(name) do |f|
+              f.write('/opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d/pre-receive.d', global_server_prereceive_hook, false)
+            end,
+            @docker.exec(name, 'chmod +x /opt/gitlab/embedded/service/gitlab-shell/hooks/pre-receive.d/*')
+          ]
+        end
+
         class Availability
           def initialize(name, relative_path: '', scheme: 'http', protocol_port: 80)
             @docker = Docker::Engine.new

data/lib/gitlab/qa/docker/engine.rb

@@ -61,8 +61,15 @@ module Gitlab
         def write_files(name)
           exec(name, yield(
             Class.new do
-              def self.write(file, contents)
-                %(echo "#{contents}" > #{file};)
+              # @param file The name of the file
+              # @param contents The content of the file to write
+              # @param expand_vars Set false if you need to write an environment variable '$' to a file. The variable should be escaped \\\$
+              def self.write(file, contents, expand_vars = true)
+                if expand_vars
+                  %(echo "#{contents}" > #{file};)
+                else
+                  %(echo '#{contents}' > #{file};)
+                end
               end
 
               def self.append(file, contents)

data/lib/gitlab/qa/report/relate_failure_issue.rb

@@ -210,10 +210,10 @@ module Gitlab
 
           failure = full_stacktrace(test)
 
-          if test.screenshot? && !failure.include?('500 Internal Server Error') && !failure.include?('fabricate_via_api!')
+          if test.screenshot? && !['500 Internal Server Error', 'fabricate_via_api!', 'Error Code 500'].any? { |e| failure.include?(e) }
             relative_url = gitlab.upload_file(file_fullpath: test.failure_screenshot)
 
-            section = "### Screenshot: #{relative_url.markdown}"
+            section = "### Screenshot: #{relative_url.markdown}" if relative_url
           end
 
           section

data/lib/gitlab/qa/report/report_results.rb

@@ -7,7 +7,9 @@ module Gitlab
       class ReportResults < ReportAsIssue
         attr_accessor :testcase_project_reporter, :results_issue_project_reporter, :files, :test_case_project, :results_issue_project, :gitlab
 
-        def initialize(token:, input_files:, test_case_project:, results_issue_project:, dry_run: false, **kwargs)
+        IGNORE_EXCEPTIONS = ['Net::ReadTimeout'].freeze
+
+        def initialize(token:, input_files:, test_case_project: nil, results_issue_project: nil, dry_run: false, **kwargs)
           @testcase_project_reporter = Gitlab::QA::Report::ResultsInTestCases.new(token: token, input_files: input_files, project: test_case_project, dry_run: dry_run, **kwargs)
           @results_issue_project_reporter = Gitlab::QA::Report::ResultsInIssues.new(token: token, input_files: input_files, project: results_issue_project, dry_run: dry_run, **kwargs)
           @test_case_project = test_case_project
@@ -32,7 +34,7 @@ module Gitlab
             test_results.each do |test|
               puts "Reporting test: #{test.file} | #{test.name}\n"
 
-              report_test(test) unless test.skipped
+              report_test(test) if should_report?(test)
             end
 
             test_results.write
@@ -54,6 +56,40 @@ module Gitlab
           testcase_project_reporter.update_testcase(testcase, test)
           results_issue_project_reporter.update_issue(issue, test)
         end
+
+        # Checks if a test result should be reported.
+        #
+        # @return [Boolean] false if the test was skipped or failed because of a transient error that can be ignored.
+        # Otherwise returns true.
+        def should_report?(test)
+          return false if test.skipped
+
+          if test.report.key?('exceptions')
+            reason = ignore_failure_reason(test.report['exceptions'])
+
+            if reason
+              puts "Issue update skipped because #{reason}"
+
+              return false
+            end
+          end
+
+          true
+        end
+
+        # Determine any reason to ignore a failure.
+        #
+        # @param [Array<Hash>] exceptions the exceptions associated with the failure.
+        # @return [String] the reason to ignore the exceptions, or `nil` if any exceptions should not be ignored.
+        def ignore_failure_reason(exceptions)
+          exception_classes = exceptions
+            .filter_map { |exception| exception['class'] if IGNORE_EXCEPTIONS.include?(exception['class']) }
+            .compact
+          return if exception_classes.empty? || exception_classes.size < exceptions.size
+
+          msg = exception_classes.many? ? 'the errors were' : 'the error was'
+          "#{msg} #{exception_classes.join(', ')}"
+        end
       end
     end
   end

data/lib/gitlab/qa/report/results_in_issues.rb

@@ -35,7 +35,7 @@ module Gitlab
           note_posted = note_status(issue, test)
 
           if labels_updated || note_posted
-            puts "Issue updated."
+            puts "Issue updated: #{issue.web_url}"
           else
             puts "Test passed, no results issue update needed."
           end

data/lib/gitlab/qa/runner.rb

@@ -15,6 +15,7 @@ module Gitlab
         Runtime::Scenario.define(:seed_db, false)
         Runtime::Scenario.define(:seed_admin_token, true) # Create an admin access token for root user by default
         Runtime::Scenario.define(:omnibus_exec_commands, [])
+        Runtime::Scenario.define(:skip_server_hooks, false)
 
         # Omnibus Configurators specified by flags
         @active_configurators = []
@@ -37,6 +38,10 @@ module Gitlab
             Runtime::Scenario.define(:seed_admin_token, false)
           end
 
+          opts.on('--skip-server-hooks', 'Skip adding global git server hooks') do
+            Runtime::Scenario.define(:skip_server_hooks, true)
+          end
+
           opts.on('--qa-image QA_IMAGE', String, 'Specifies a QA image to be used instead of inferring it from the GitLab image. See Gitlab::QA::Release#qa_image') do |value|
             Runtime::Scenario.define(:qa_image, value)
           end

data/lib/gitlab/qa/scenario/test/sanity/version.rb

@@ -12,22 +12,43 @@ module Gitlab
           # the window defined by the `weekday_hours` method.
           # We perform a single API call to get the commit
           class Version < Scenario::Template
+            SOURCE_MAP = {
+              'git@dev.gitlab.org:gitlab/gitlab-ee.git' => {
+                host: 'dev.gitlab.org',
+                project: 'gitlab/gitlab-ee'
+              },
+              'git@dev.gitlab.org:gitlab/gitlabhq.git' => {
+                host: 'dev.gitlab.org',
+                project: 'gitlab/gitlabhq'
+              },
+              'git@gitlab.com:gitlab-org/gitlab.git' => {
+                host: 'gitlab.com',
+                project: 'gitlab-org/gitlab'
+              },
+              'git@gitlab.com:gitlab-org/gitlab-foss.git' => {
+                host: 'gitlab.com',
+                project: 'gitlab-org/gitlab-foss'
+              }
+            }.freeze
+
             def perform(release = 'ce')
               version = Component::Gitlab.perform do |gitlab|
                 gitlab.release = release
                 gitlab.act do
                   pull
-                  sha_version
+                  rails_version
                 end
               end
 
-              project = "gitlab-org/#{QA::Release.new(release).api_project_name}"
-              commit = api_commit_detail(project, version)
+              project = SOURCE_MAP[version[:source]][:project]
+              host = SOURCE_MAP[version[:source]][:host]
+              sha = version[:sha]
+              commit = api_commit_detail(host, project, sha)
 
               if commit_within_hours?(commit['created_at'], weekday_hours(commit['created_at']))
-                puts "Found commit #{version} in recent history of #{project}"
+                puts "Found commit #{sha} in recent history of #{project} on #{host}"
               else
-                puts "Did not find #{version} in recent history of #{project}"
+                puts "Did not find #{sha} in recent history of #{project} on #{host}"
                 exit 1
               end
             end
@@ -51,9 +72,14 @@ module Gitlab
               Time.at(Time.parse(commit_time_string).utc).to_datetime > Time.at((Time.now - hours * 60 * 60).utc).to_datetime
             end
 
-            def api_commit_detail(project, commit_id)
-              api = 'https://gitlab.com/api/v4'
-              url = "#{api}/projects/#{CGI.escape(project)}/repository/commits/#{commit_id}"
+            def api_commit_detail(host, project, sha)
+              url = "https://#{host}/api/v4/projects/#{CGI.escape(project)}/repository/commits/#{sha}"
+
+              if host == 'dev.gitlab.org'
+                Runtime::Env.require_qa_dev_access_token!
+
+                url = "#{url}?private_token=#{Runtime::Env.qa_dev_access_token}"
+              end
 
               JSON.parse(Net::HTTP.get(URI(url)))
             end

data/lib/gitlab/qa/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   module QA
-    VERSION = '7.29.1'
+    VERSION = '7.30.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 7.29.1
+  version: 7.30.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-05-31 00:00:00.000000000 Z
+date: 2022-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control