gitlab-qa 6.6.0 → 6.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5774bb53da5791580f00788fede32864529d0221748c86fa62e76a74a73e1fcd
-  data.tar.gz: f94d8a02877d5f15988357cc208b5acde672822881a9d92c9a3cda4c2d4e588b
+  metadata.gz: 1615e54144d0b669245a15b6a5874efc1d00157fe859dbc6ff2e723380e9da10
+  data.tar.gz: f3ccd0528987c838c793d1bbc2f742833584756bf7a87c58c29b60fa2f7b6ac3
 SHA512:
-  metadata.gz: 8d853b45ec499807f46691b719283544d7c3260e24ccec1fa0632e55e885201f38bac15ebb147672ea949fdaf830c81f8a4a827c46c2fb135a32d40b445cfaf8
-  data.tar.gz: a66c9779a3f128e0dc2226b4a9306b9be33567b6cc21ec1e9fab3ef0d245b8f2b20c29ec9a71b9b264e558489e2cb0749e57fd08992b2776b40709c0a0317805
+  metadata.gz: 47fce0af7a769ccb9dca14c87f3d1f169495324f753f3db60bb8aa10fc6e05a4612f0bc1704e884dca3d7349bd6d0972d5ca77421bba71f60fd03258e24bc52b
+  data.tar.gz: f1d65176693a0091989392eec19425a34d2cbc1ee92cb428178ee22ca438b19e7246fd1306bfdaaa73f5d531a6c01ad5a6b2ee1324ca72ef0ba9b255ae4782f3

data/.gitlab-ci.yml

@@ -5,7 +5,7 @@ stages:
   - notify
 
 default:
-  image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-ruby-2.6
+  image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-ruby-2.7
   tags:
     - gitlab-org
   cache:

data/.rubocop.yml

@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 require:
   # Due to a probably bug in rubocop (https://github.com/bbatsov/rubocop/issues/5251)
   # we need to require rubocop-rspec a second time so that RSpec/FilePath does

data/.rubocop_todo.yml

@@ -0,0 +1,98 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-10-31 07:26:03 -0700 using RuboCop version 0.82.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 51
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 210
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'lib/gitlab/qa/component/staging.rb'
+    - 'lib/gitlab/qa/runtime/scenario.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'lib/gitlab/qa/component/staging.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'lib/gitlab/qa/component/gitlab.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterLetBlock:
+  Exclude:
+    - 'spec/gitlab/qa/support/dev_eeqa_image_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: CustomTransform, IgnoredWords.
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/gitlab/qa/component/gitlab_spec.rb'
+
+# Offense count: 2
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/gitlab/qa/scenario/test/instance/deployment_base_spec.rb'
+
+# Offense count: 93
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/HashTransformKeys:
+  Exclude:
+    - 'lib/gitlab/qa/docker/volumes.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/gitlab/qa/component/gitlab.rb'
+    - 'lib/gitlab/qa/release.rb'
+    - 'lib/gitlab/qa/runtime/env.rb'
+    - 'lib/gitlab/qa/runtime/scenario.rb'
+    - 'lib/gitlab/qa/scenario/test/omnibus/upgrade.rb'
+    - 'lib/gitlab/qa/support/http_request.rb'
+
+# Offense count: 1
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/gitlab/qa/runtime/scenario.rb'
+
+# Offense count: 1
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/gitlab/qa/runtime/scenario.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'db/migrate/**/*'
+    - 'db/post_migrate/**/*'
+    - 'db/geo/migrate/**/*'
+    - 'lib/gitlab/qa/release.rb'
+    - 'lib/gitlab/qa/report/update_screenshot_path.rb'

data/gitlab-qa.gemspec

@@ -20,12 +20,12 @@ Gem::Specification.new do |spec|
 
   # Some dependencies are pinned, to prevent new cops from breaking the CI pipelines
   spec.add_development_dependency 'climate_control', '~> 0.2'
-  spec.add_development_dependency 'gitlab-styles', '2.4.0'
+  spec.add_development_dependency 'gitlab-styles', '~> 4.3.0'
   spec.add_development_dependency 'pry', '~> 0.11'
   spec.add_development_dependency 'rake', '~> 12.2'
   spec.add_development_dependency 'rspec', '~> 3.7'
-  spec.add_development_dependency 'rubocop', '~> 0.54.0'
-  spec.add_development_dependency 'rubocop-rspec', '1.20.1'
+  spec.add_development_dependency 'rubocop', '~> 0.82.0'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.36'
   spec.add_development_dependency 'webmock', '3.7.0'
   spec.add_runtime_dependency 'activesupport', '~>  6.0.2'
   spec.add_runtime_dependency 'gitlab', '~>  4.11.0'

data/lib/gitlab/qa/component/base.rb

@@ -61,7 +61,7 @@ module Gitlab
         end
 
         def prepare_network
-          if runner_network && !docker.network_exists?(runner_network)
+          if runner_network && !docker.network_exists?(runner_network) # rubocop:disable Style/IfUnlessModifier
             docker.network_create("--driver=bridge --internal #{runner_network}")
           end
 

data/lib/gitlab/qa/docker/shellout.rb

@@ -27,7 +27,7 @@ module Gitlab
               end
             end
 
-            if wait.value.exited? && wait.value.exitstatus.nonzero?
+            if wait.value.exited? && wait.value.exitstatus.nonzero? # rubocop:disable Style/IfUnlessModifier
               raise StatusError, "Docker command `#{@command.mask_secrets}` failed!"
             end
           end

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '6.6.0'.freeze
+    VERSION = '6.7.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 6.6.0
+  version: 6.7.0
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-10-26 00:00:00.000000000 Z
+date: 2020-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -28,16 +28,16 @@ dependencies:
   name: gitlab-styles
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 4.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 4.3.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -86,28 +86,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 0.82.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 0.82.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.20.1
+        version: '1.36'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.20.1
+        version: '1.36'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -207,6 +207,7 @@ files:
 - ".gitlab/merge_request_templates/Release.md"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile