gitlab-qa 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2417c38c75bb22753661942c5431959e224d9439
-  data.tar.gz: de43e7bbe95039d2118d66cbbdb4b1b222efe4cb
+SHA256:
+  metadata.gz: 6f352f47419c62cba301b61f8dae9e8eaabeb5e9ec40def22f5770f158d027f6
+  data.tar.gz: af84f87fe4e1cdfd58ed15f116e924d7cac299428d3b578be5c57e89ff9776f6
 SHA512:
-  metadata.gz: 561abef16e8297daf5ae70ad37e1f6e05be302815cf0c60088b8bb486af1079d57e96f20e3cbc9d833094479e841fd59ea669da2960a25aacc67bcf2b84d6d4d
-  data.tar.gz: 9a8ebd4089627554cb9f45ac5586c3210441b1a428ac68fbe286742e93b3cd02ba2cd4d2e1293e12d2cefc8d2970d31c64bd0668c69948a0ded5d49816825644
+  metadata.gz: 285d3c5aa401f083311d9aecb09e34758278cdadcaaca49ee53242a5883b2c08307e5010f64a155bc1113722671fee8d239a1e641e899e47d4d89813ae8c21a1
+  data.tar.gz: 8848ec793a59d57c56d6e829eb5defb58591eb90675274d8528ee10d295515726baca2452138ebbd82c625cb71c774857ab614bc697f7816b325fa2d52320b4b

data/docs/README.md

@@ -5,3 +5,4 @@
 - [What tests can be run?](what_tests_can_be_run.md)
 - [Run Geo QA tests against your Geo GDK setup](run_geo_qa_against_gdk.md)
 - [Trainings](trainings.md)
+- [Waits](waits.md)

data/docs/waits.md

@@ -0,0 +1,24 @@
+Waits
+---
+
+All Capybara Node Finders utilize a waiting mechanism.
+
+Per the [Capybara API](https://www.rubydoc.info/github/jnicklas/capybara/Capybara/Node/Finders:find) -
+
+> If the driver is capable of executing JavaScript, `find` will wait for a set amount of time and continuously retry finding the element until either the element is found or the time expires. The length of time find will wait is controlled through `Capybara.default_max_wait_time` and defaults to `2` seconds. `find` takes the same options as all.
+
+Ideally the [GitLab QA Framework](https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa) should implement its own explicit waiting to avoid hard sleeps but currently that is [not the case](https://gitlab.com/gitlab-org/gitlab-qa/issues/280).
+
+## Hard Sleeps
+
+**[qa/qa/page/base.rb](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/qa/qa/page/base.rb#L16)**
+
+```
+def wait(max: 60, time: 0.1, reload: true)
+  ...
+end
+```
+
+- `max`    : Specifies the max amount of *seconds* to wait until the block given is satisfied
+- `time`   : The interval/poll time to sleep *in seconds*. If this time reaches `max`, the wait returns `false`
+- `reload` : If the wait is not satiated, the test will sleep then reload the page if `:reload` is set to `true`

data/gitlab-qa.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   # Some dependencies are pinned, to prevent new cops from breaking the CI pipelines
+  spec.add_development_dependency 'climate_control', '~> 0.2'
   spec.add_development_dependency 'gitlab-styles', '2.2.0'
   spec.add_development_dependency 'pry', '~> 0.11'
   spec.add_development_dependency 'rake', '~> 12.2'

data/lib/gitlab/qa/release.rb

@@ -47,7 +47,7 @@ module Gitlab
           if canonical?
             "gitlab/gitlab-#{edition}"
           else
-            release.sub(/:.+\z/, '')
+            release.sub(%r{(?<image_without_tag>.+(?<port>:\d+)?/.+)(?<tag>:.+)\z}, '\k<image_without_tag>')
           end
       end
 

data/lib/gitlab/qa/runtime/env.rb

@@ -12,6 +12,7 @@ module Gitlab
           'GITLAB_USER_TYPE' => :user_type,
           'GITLAB_SANDBOX_NAME' => :gitlab_sandbox_name,
           'GITLAB_QA_ACCESS_TOKEN' => :qa_access_token,
+          'GITHUB_ACCESS_TOKEN' => :github_access_token,
           'GITLAB_URL' => :gitlab_url,
           'EE_LICENSE' => :ee_license
         }.freeze

data/lib/gitlab/qa/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module QA
-    VERSION = '1.0.0'.freeze
+    VERSION = '1.0.1'.freeze
   end
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-qa
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Grzegorz Bizon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-29 00:00:00.000000000 Z
+date: 2018-07-05 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: climate_control
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: gitlab-styles
   requirement: !ruby/object:Gem::Requirement
@@ -121,6 +135,7 @@ files:
 - docs/how_it_works.md
 - docs/run_geo_qa_against_gdk.md
 - docs/trainings.md
+- docs/waits.md
 - docs/what_tests_can_be_run.md
 - exe/gitlab-qa
 - fixtures/ldap/tanuki.ldif
@@ -169,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Integration tests for GitLab