gitlab-experiment 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4b1d80362166d1e86dd434fffe2a8e31676440f48b578e4bfcca4624fc819a8
-  data.tar.gz: 4535076f1c77f3faefc92f59be23689a5412f462bda088b67a4fbbdb58c74254
+  metadata.gz: 1c4e4a4b19b67700aab0629cd615617c4452d8b4b145ef8ff85d12443994362b
+  data.tar.gz: 802c31143890f2431a80ed3dcb247cbf46247ce276053e8e27a4d190822650df
 SHA512:
-  metadata.gz: d9d3445f7ee60be9d445760f103162861b1983c35ed6a9347e8703bc44c4bef2d7b154a62b2b05aa02c84471b8cfa95f91aa5521ee5743b9afa8ea5b4a4088eb
-  data.tar.gz: cb49261fe14971ff76799bac943e5826b04cad84982b8d061cbd7b2843a0817854772f2b3e8e55600023aff9b5266c0ba562df50c47bb90703cb686c4f973ebd
+  metadata.gz: 86f86cd9dd01006be9668a2ceb4d60351e943487576d236e12b40eb9405e4255fdbbffb0c5811b17a4f1c8d2784b011eb20bc783e622f4f4f05fc6fb166f0df3
+  data.tar.gz: bca224adeaade21b59077effd1faa0d6ca95607fe02f6c7735b8c9b79b7d5a08f76675549ddbc874ce63adbe39895d7b3f6f1fb71e908ae22a76c817a1d0f88d

data/lib/gitlab/experiment.rb

@@ -74,9 +74,7 @@ module Gitlab
 
       if enabled?
         @resolving_variant = true
-        @variant_name ||= :control if excluded?
-        result = cache_variant(@variant_name) { resolve_variant_name }
-        @variant_name = result.to_sym if result.present?
+        @variant_name = cached_variant_resolver(@variant_name)
       end
 
       run_callbacks(segmentation_callback_chain) do

data/lib/gitlab/experiment/base_interface.rb

@@ -72,6 +72,13 @@ module Gitlab
         false
       end
 
+      def cached_variant_resolver(provided_variant)
+        return :control if excluded?
+
+        result = cache_variant(provided_variant) { resolve_variant_name }
+        result.to_sym if result.present?
+      end
+
       def generate_result(variant_name)
         observation = Scientist::Observation.new(variant_name, self, &behaviors[variant_name])
         Scientist::Result.new(self, [observation], observation)

data/lib/gitlab/experiment/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   class Experiment
-    VERSION = '0.5.2'
+    VERSION = '0.5.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-experiment
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-02 00:00:00.000000000 Z
+date: 2021-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport