gitlab-experiment 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b1a2f81e8680cffda06d116655200c055dbb74a42a52a7fa8adcb84c720fb01
-  data.tar.gz: 715ea6dd8494457c169ef3147ca2edf2fc6e4c63571801e1f5b22814182ebb56
+  metadata.gz: 81476752521c6ead83308324fdcf360db7b8182bab340c9ffe7ad4eec21b998e
+  data.tar.gz: 006d94ff92104bef820be7d6c7c9638b20a6e0a4a533439fca056b4cba31a0bc
 SHA512:
-  metadata.gz: 7eec246157542ff0897f9af9f3135272d4d7fea31049443519fb550d5ca9cb3ad2d073ae8594104256d353b8042132f7ae5cba399bb44c38d7d5332154d5b849
-  data.tar.gz: ff4145fbe06fad2de4ef6295f4a0715c71c9ef4165308452d9dacd0c02a0df94d2152d138a6945c583c68d6c5966e1bb1e200fd79a7d9668382ee7c1d68861ea
+  metadata.gz: a5644f3cf6798ddc27034b8857cf03bb77904b3b5c8a80b84c398134ad143b919e16ddc23746a58e63b71d0464c92ec5cce682ddb2039e471b55cfeb42e3cd4a
+  data.tar.gz: 2dd2adf62427f96a9745d9681ee87b5621acf43fc4dae33ffefdadfad5af6ec3a0ad1e79e601a4d6260e61fa64faf635af9ae753e3fb474e033af7d2d7d55381

data/README.md

@@ -341,7 +341,7 @@ Gitlab::Experiment.configure do |config|
 end
 ```
 
-More examples for configuration are available in the provided [rails initializer](lib/generators/gitlab/experiment/install/templates/initializer.rb).
+More examples for configuration are available in the provided [rails initializer](lib/generators/gitlab/experiment/install/templates/initializer.rb.tt).
 
 ### Client layer / JavaScript
 

data/lib/gitlab/experiment.rb

@@ -30,7 +30,7 @@ module Gitlab
         raise ArgumentError, 'name is required' if name.nil? && base?
 
         instance = constantize(name).new(name, variant_name, **context, &block)
-        return instance unless block_given?
+        return instance unless block
 
         instance.context.frozen? ? instance.run : instance.tap(&:run)
       end
@@ -58,9 +58,9 @@ module Gitlab
       raise ArgumentError, 'name is required' if name.blank? && self.class.base?
 
       @name = self.class.experiment_name(name, suffix: false)
-      @variant_name = variant_name
       @excluded = []
       @context = Context.new(self, **context)
+      @variant_name = cache_variant(variant_name) { nil } if variant_name.present?
 
       exclude { !@context.trackable? }
       compare { false }
@@ -102,11 +102,7 @@ module Gitlab
       @result ||= begin
         variant_name = variant(variant_name).name
         run_callbacks(variant_assigned? ? :unsegmented_run : :segmented_run) do
-          if respond_to?((behavior_name = "#{variant_name}_behavior"))
-            behaviors[variant_name] ||= -> { send(behavior_name) } # rubocop:disable GitlabSecurity/PublicSend
-          end
-
-          super(@variant_name = variant_name)
+          super(@variant_name ||= variant_name)
         end
       end
     end
@@ -129,6 +125,20 @@ module Gitlab
       @variant_names ||= behaviors.keys.map(&:to_sym) - [:control]
     end
 
+    def behaviors
+      @behaviors ||= public_methods.each_with_object(super) do |name, behaviors|
+        next unless name.end_with?('_behavior')
+
+        behavior_name = name.to_s.sub(/_behavior$/, '')
+        behaviors[behavior_name] ||= -> { send(name) } # rubocop:disable GitlabSecurity/PublicSend
+      end
+    end
+
+    def try(name = nil, &block)
+      name = (name || 'candidate').to_s
+      behaviors[name] = block
+    end
+
     def signature
       { variant: variant.name, experiment: name }.merge(context.signature)
     end

data/lib/gitlab/experiment/callbacks.rb

@@ -7,31 +7,20 @@ module Gitlab
       include ActiveSupport::Callbacks
 
       included do
-        define_callbacks(
-          :unsegmented_run,
-          skip_after_callbacks_if_terminated: true
-        )
-
-        define_callbacks(
-          :segmented_run,
-          skip_after_callbacks_if_terminated: false,
-          terminator: lambda do |target, result_lambda|
-            result_lambda.call
-            target.variant_assigned?
-          end
-        )
+        define_callbacks(:unsegmented_run)
+        define_callbacks(:segmented_run)
       end
 
       class_methods do
         def segment(*filter_list, variant:, **options, &block)
           filters = filter_list.unshift(block).compact.map do |filter|
             result_lambda = ActiveSupport::Callbacks::CallTemplate.build(filter, self).make_lambda
-            ->(target) { target.variant(variant) if result_lambda.call(target, nil) }
+            ->(target) { target.variant(variant) if !target.variant_assigned? && result_lambda.call(target, nil) }
           end
 
           raise ArgumentError, 'no filters provided' if filters.empty?
 
-          set_callback(:segmented_run, :before, *filters, options, &block)
+          set_callback(:segmented_run, :before, *filters, options)
         end
       end
     end

data/lib/gitlab/experiment/version.rb

@@ -2,6 +2,6 @@
 
 module Gitlab
   class Experiment
-    VERSION = '0.4.4'
+    VERSION = '0.4.5'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-experiment
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-15 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport