gitlab-dangerfiles 4.6.0 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 501394f58303715430e058da5fbc46a6c539136b8a888ed22521ab56da6595c3
-  data.tar.gz: 520c933eb21695e1cdc9e74cea42ec1e636b08455377d2b9dc3ebafe405977ac
+  metadata.gz: a3462c1433faf49899f1472e4411ce488ada1b6f59da331ede45114703fe2dfa
+  data.tar.gz: 37b7134a0cec36afed2dc1a4d78321cf9c9a80a405c5551fe52b2ce4834fd312
 SHA512:
-  metadata.gz: 5d68efa303d47210a6e1d126d9e7706f8872ae61a5a24dacce6b6a48242f8e9d0854f8067d35c64e6340602768e4ed65bd1fcfab71f7447798576172095497bc
-  data.tar.gz: 79b38327e2b8a133c58124952b2ff371cb551fde1d61aeb29b5f67d29ee212f93c1c423842121f0247304af52414efd5e690d3fa1c4e50083a9dfacdca7f4d33
+  metadata.gz: 9a7d44496574a8336bd42665f3c096e4b5c4bb7eeb322533b0b0a84d901d541104878fa13ab214a80fecea15c5c875ad4cb6f98d751b290b8f00108d2d837816
+  data.tar.gz: c032a92c6fb18de185e1552faabc9b648573ff95ee1d0b5e88fe3f57c7668e502d251cb51f2bd9e4b36d555c147cb9f538f6904223546b3e4fbbb5591d9826b5

data/.gitignore

@@ -3,7 +3,6 @@
 /.rspec
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /pkg/

data/.gitlab-ci.yml

@@ -2,9 +2,6 @@ stages:
   - test
   - deploy
 
-variables:
-  DEFAULT_CI_IMAGE: "ruby:${RUBY_VERSION}"
-
 workflow:
   rules:
     # For merge requests, create a pipeline.
@@ -15,12 +12,8 @@ workflow:
     - if: '$CI_COMMIT_TAG'
 
 default:
-  image: "${DEFAULT_CI_IMAGE}"
   tags:
     - gitlab-org
-  before_script:
-    - gem install bundler
-    - bundle install -j $(nproc) --path vendor
   cache:
     key:
       files:
@@ -28,12 +21,14 @@ default:
         - gitlab-dangerfiles.gemspec
     paths:
       - vendor/ruby
-      - Gemfile.lock
-    policy: pull
 
 .default-test-job:
+  image: "ruby:${RUBY_VERSION}"
   stage: test
   needs: []
+  before_script:
+    - gem install bundler
+    - bundle install -j $(nproc) --path vendor
   parallel:
     matrix:
       - RUBY_VERSION: ['3.0', '3.1', '3.2']
@@ -49,15 +44,13 @@ test:rubocop:
     - bundle exec rubocop -P -E .
 
 include:
-  - template: Security/Dependency-Scanning.gitlab-ci.yml
-  - template: Security/SAST.gitlab-ci.yml
-  - template: Security/Secret-Detection.gitlab-ci.yml
-  - project: 'gitlab-org/quality/pipeline-common'
-    file:
-      - '/ci/danger-review.yml'
-  - component: "gitlab.com/gitlab-org/quality/pipeline-common/gem-release@7.6.1"
+  - component: gitlab.com/components/sast/sast@~latest
+  - component: gitlab.com/components/secret-detection/secret-detection@~latest
+  - component: gitlab.com/gitlab-org/components/gem-release/gem-release@~latest
     inputs:
       smoke_test_script: "ruby -r 'gitlab-dangerfiles' -e \"puts Gitlab::Dangerfiles::VERSION\""
+  - component: gitlab.com/gitlab-org/components/danger-review/danger-review@~latest
+  - template: Security/Dependency-Scanning.gitlab-ci.yml
 
 # run security jobs on MRs
 # see: https://gitlab.com/gitlab-org/gitlab/-/issues/218444#note_478761991

data/.rubocop.yml

@@ -28,6 +28,9 @@ RSpec/FilePath:
 RSpec/SpecFilePathFormat:
   Enabled: false
 
+Style/ArrayIntersect:
+  Enabled: false # We're still supporting Ruby 3.1 and below
+
 Style/HashSyntax:
   EnforcedStyle: ruby19_no_mixed_keys
   # Introduced in Ruby 3.1. Disable for now.

data/Gemfile.lock

@@ -0,0 +1,231 @@
+PATH
+  remote: .
+  specs:
+    gitlab-dangerfiles (4.7.0)
+      danger (>= 9.3.0)
+      danger-gitlab (>= 8.0.0)
+      rake (~> 13.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (7.0.4.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
+    ast (2.4.2)
+    binding_of_caller (1.0.0)
+      debug_inspector (>= 0.0.1)
+    claide (1.1.0)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    climate_control (1.2.0)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    concurrent-ruby (1.2.0)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    crack (0.4.5)
+      rexml
+    danger (9.3.0)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (>= 0.9.0, < 3.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.13.0)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 5.0)
+      terminal-table (>= 1, < 4)
+    danger-gitlab (8.0.0)
+      danger
+      gitlab (~> 4.2, >= 4.2.0)
+    debug_inspector (1.1.0)
+    diff-lcs (1.5.0)
+    faraday (2.7.10)
+      faraday-net_http (>= 2.0, < 3.1)
+      ruby2_keywords (>= 0.0.4)
+    faraday-http-cache (2.5.0)
+      faraday (>= 0.8)
+    faraday-net_http (3.0.2)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    git (1.13.2)
+      addressable (~> 2.8)
+      rchardet (~> 1.8)
+    gitlab (4.19.0)
+      httparty (~> 0.20)
+      terminal-table (>= 1.5.1)
+    gitlab-styles (10.0.0)
+      rubocop (~> 1.43.0)
+      rubocop-graphql (~> 0.18)
+      rubocop-performance (~> 1.15)
+      rubocop-rails (~> 2.17)
+      rubocop-rspec (~> 2.18)
+    guard (2.18.0)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.13.0)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    hashdiff (1.0.1)
+    httparty (0.21.0)
+      mini_mime (>= 1.0.0)
+      multi_xml (>= 0.5.2)
+    i18n (1.12.0)
+      concurrent-ruby (~> 1.0)
+    json (2.6.3)
+    kramdown (2.4.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    lefthook (1.5.2)
+    listen (3.8.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    mini_mime (1.1.2)
+    minitest (5.17.0)
+    multi_xml (0.6.0)
+    nap (1.1.0)
+    nenv (0.3.0)
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (5.6.1)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
+    open4 (1.3.4)
+    parallel (1.22.1)
+    parser (3.2.1.0)
+      ast (~> 2.4.1)
+    proc_to_ast (0.1.0)
+      coderay
+      parser
+      unparser
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (5.0.1)
+    rack (3.0.4.1)
+    rainbow (3.1.1)
+    rake (13.0.6)
+    rb-fsevent (0.11.2)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (2.7.0)
+    rexml (3.2.5)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.1)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-parameterized (1.0.0)
+      rspec-parameterized-core (< 2)
+      rspec-parameterized-table_syntax (< 2)
+    rspec-parameterized-core (1.0.0)
+      parser
+      proc_to_ast
+      rspec (>= 2.13, < 4)
+      unparser
+    rspec-parameterized-table_syntax (1.0.0)
+      binding_of_caller
+      rspec-parameterized-core (< 2)
+    rspec-support (3.12.0)
+    rubocop (1.43.0)
+      json (~> 2.3)
+      parallel (~> 1.10)
+      parser (>= 3.2.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.24.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.26.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.19.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.24.0)
+      rubocop (~> 1.33)
+    rubocop-graphql (0.19.0)
+      rubocop (>= 0.87, < 2)
+    rubocop-performance (1.19.1)
+      rubocop (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rails (2.17.4)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.33.0, < 2.0)
+    rubocop-rspec (2.24.1)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.5)
+    sawyer (0.9.2)
+      addressable (>= 2.3.5)
+      faraday (>= 0.17.3, < 3)
+    shellany (0.0.1)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.2.1)
+    timecop (0.9.6)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.4.2)
+    unparser (0.6.7)
+      diff-lcs (~> 1.3)
+      parser (>= 3.2.0)
+    webmock (3.18.1)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
+    webrick (1.7.0)
+    yard (0.9.28)
+      webrick (~> 1.7.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  climate_control
+  gitlab-dangerfiles!
+  gitlab-styles (~> 10.0)
+  guard-rspec (~> 4.7.3)
+  lefthook (~> 1.3)
+  rspec (~> 3.8)
+  rspec-parameterized
+  rubocop-rails (< 2.21.2)
+  timecop
+  webmock
+  yard
+
+BUNDLED WITH
+   2.5.4

data/lib/danger/plugins/internal/helper.rb

@@ -27,7 +27,8 @@ module Danger
       analytics_instrumentation: '~"analytics instrumentation"',
       import_integrate_be: '~"group::import and integrate" (backend)',
       import_integrate_fe: '~"group::import and integrate" (frontend)',
-      "Authentication and Authorization": '~"group::authentication and authorization"',
+      Authentication: '~"group::authentication"',
+      Authorization: '~"group::authorization"',
       Compliance: '~"group::compliance"',
     }.freeze
     # rubocop:enable Style/HashSyntax

data/lib/danger/plugins/roulette.rb

@@ -1,34 +1,16 @@
 # frozen_string_literal: true
 
+require_relative "../../gitlab/dangerfiles/approval"
+require_relative "../../gitlab/dangerfiles/spinner"
 require_relative "../../gitlab/dangerfiles/teammate"
-require_relative "../../gitlab/dangerfiles/weightage/maintainers"
-require_relative "../../gitlab/dangerfiles/weightage/reviewers"
 
 module Danger
   # Common helper functions for our danger scripts. See Danger::Helper
   # for more details
   class Roulette < Danger::Plugin
-    ROULETTE_DATA_URL = "https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json"
     HOURS_WHEN_PERSON_CAN_BE_PICKED = (6..14).freeze
-
-    Spin = Struct.new(:category, :reviewer, :maintainer, :optional_role)
     HTTPError = Class.new(StandardError)
 
-    Approval = Struct.new(:category, :spin) do
-      def self.from_approval_rule(rule, maintainer)
-        category =
-          if rule["section"] == "codeowners"
-            "`#{rule["name"]}`"
-          else
-            rule["section"]
-          end.to_sym
-
-        spin = Spin.new(category, nil, maintainer, :reviewer)
-
-        new(category, spin)
-      end
-    end
-
     def prepare_categories(changes_keys)
       categories = Set.new(changes_keys)
 
@@ -53,7 +35,7 @@ module Danger
     #
     # @return [Gitlab::Dangerfiles::Teammate]
     def team_mr_author
-      @team_mr_author ||= find_member(helper.mr_author)
+      @team_mr_author ||= Gitlab::Dangerfiles::Teammate.find_member(helper.mr_author)
     end
 
     # Assigns GitLab team members to be reviewer and maintainer
@@ -63,70 +45,22 @@ module Danger
     # @param categories [Array<Symbol>] An array of categories symbols.
     #
     # @return [Array<Spin>]
-    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def spin(project = nil, categories = [:none], ux_fallback_wider_community_reviewer: teammate_pedroms)
+      # TODO: Deprecate the project argument. It prevents us from
+      # memorizing Spinner and can cause unexpected results if it's
+      # passing a different project than the merge request project.
       project = (project || config_project_name).downcase
       categories = categories.map { |category| category&.downcase || :none }
-      categories.reject! { |category| import_and_integrate_reject_category?(category, project) }
-
-      spins = categories.sort_by(&:to_s).map do |category|
-        spin_for_category(project, category)
-      end
-
-      backend_spin = spins.find { |spin| spin.category == :backend }
-      frontend_spin = spins.find { |spin| spin.category == :frontend }
-
-      spins.each do |spin|
-        case spin.category
-        when :qa
-          # MR includes QA changes, but also other changes, and author isn't an SET
-          if categories.size > 1 &&
-             !(team_mr_author && team_mr_author.capabilities(project).any? { |capability| capability.end_with?("qa") })
-            spin.optional_role = :maintainer
-          end
-        when :test
-          spin.optional_role = :maintainer
-
-          if spin.reviewer.nil?
-            # Fetch an already picked backend reviewer, or pick one otherwise
-            spin.reviewer = backend_spin&.reviewer || spin_for_category(project, :backend).reviewer
-          end
-        when :tooling
-          if spin.maintainer.nil?
-            # Fetch an already picked backend maintainer, or pick one otherwise
-            spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend).maintainer
-          end
-        when :ci_template
-          if spin.maintainer.nil?
-            # Fetch an already picked backend maintainer, or pick one otherwise
-            spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend).maintainer
-          end
-        when :analytics_instrumentation
-          spin.optional_role = :maintainer
-
-          if spin.maintainer.nil?
-            # Fetch an already picked maintainer, or pick one otherwise
-            spin.maintainer = backend_spin&.maintainer || frontend_spin&.maintainer || spin_for_category(project, :backend).maintainer
-          end
-        when :import_integrate_be, :import_integrate_fe
-          spin.optional_role = :maintainer
-        when :ux
-          spin.optional_role = :maintainer
 
-          # We want at least a UX reviewer who can review any wider community
-          # contribution even without a team designer. We assign this to Pedro.
-          spin.reviewer = ux_fallback_wider_community_reviewer if
-            labels.include?("Community contribution") &&
-            spin.reviewer.nil? &&
-            spin.maintainer.nil?
-        end
-      end
-
-      spins
+      Gitlab::Dangerfiles::Spinner.new(
+        project: project,
+        author: helper.mr_author, team_author: team_mr_author,
+        labels: labels, categories: categories, random: random,
+        ux_fallback_wider_community_reviewer:
+          ux_fallback_wider_community_reviewer)
+        .spin
     end
 
-    # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-
     def codeowners_approvals
       approval_rules = helper.mr_approval_state["rules"]
 
@@ -134,23 +68,31 @@ module Danger
 
       required_approval_rules = unique_approval_rules(approval_rules)
       required_approval_rules.filter_map do |rule|
-        spin_for_approval_rule?(rule) &&
-          Approval.from_approval_rule(rule, spin_for_approver(rule))
+        if spin_for_approval_rule?(rule)
+          approver = Gitlab::Dangerfiles::Spinner.new(
+            project: config_project_name.downcase,
+            author: helper.mr_author, team_author: team_mr_author,
+            random: random
+          ).spin_for_approver(rule)
+
+          Gitlab::Dangerfiles::Approval.from_approval_rule(rule, approver)
+        end
       end
     end
 
+    alias_method :required_approvals, :codeowners_approvals
+
+    # For backward compatibility
     def warnings
-      @warnings ||= []
+      Gitlab::Dangerfiles::Teammate.warnings
     end
 
+    private
+
     def teammate_pedroms
-      @teammate_pedroms ||= find_member("pedroms")
+      @teammate_pedroms ||= Gitlab::Dangerfiles::Teammate.find_member("pedroms")
     end
 
-    alias_method :required_approvals, :codeowners_approvals
-
-    private
-
     def spin_for_approval_rule?(rule)
       rule["rule_type"] == "code_owner" &&
         should_include_codeowners_rule?(rule) &&
@@ -188,179 +130,17 @@ module Danger
       end
     end
 
-    # @param [Gitlab::Dangerfiles::Teammate] person
-    # @return [Boolean]
-    def valid_person?(person)
-      !mr_author?(person) && person.available
-    end
-
-    # @param [Gitlab::Dangerfiles::Teammate] person
-    # @return [Boolean]
-    def mr_author?(person)
-      person.username == helper.mr_author
-    end
-
-    # @param [String] category name
-    # @return [Boolean]
-    def import_and_integrate_reject_category?(category, project)
-      # Reject Import and Integrate categories if the MR author has reviewing abilities for the category.
-      team_mr_author&.import_integrate_be?(project, category, labels) ||
-        team_mr_author&.import_integrate_fe?(project, category, labels)
-    end
-
     def random
       @random ||= Random.new(Digest::MD5.hexdigest(helper.mr_source_branch).to_i(16))
     end
 
-    def spin_role_for_category(team, role, project, category)
-      team.select do |member|
-        member.public_send("#{role}?", project, category, labels)
-      end
-    end
-
-    # Known issue: If someone is rejected due to OOO, and then becomes not OOO, the
-    # selection will change on next spin.
-    #
-    # @param [Array<Gitlab::Dangerfiles::Teammate>] people
-    #
-    # @return [Gitlab::Dangerfiles::Teammate]
-    def spin_for_person(people)
-      shuffled_people = people.shuffle(random: random)
-
-      shuffled_people.find(&method(:valid_person?))
-    end
-
-    # Spin a reviewer for a particular approval rule
-    #
-    # @param [Hash] rule of approval
-    #
-    # @return [Gitlab::Dangerfiles::Teammate]
-    def spin_for_approver(rule)
-      approvers = rule["eligible_approvers"].filter_map do |approver|
-        find_member(approver["username"], project: config_project_name.downcase)
-      end
-
-      spin_for_person(approvers) || spin_for_approver_fallback(rule)
-    end
-
-    # It can be possible that we don't have a valid reviewer for approval.
-    # In this case, we sample again without considering:
-    #
-    # * If they're available
-    # * If they're an actual reviewer from roulette data
-    #
-    # We do this because we strictly require an approval from the approvers.
-    #
-    # @param [Hash] rule of approval
-    #
-    # @return [Gitlab::Dangerfiles::Teammate]
-    def spin_for_approver_fallback(rule)
-      fallback_approvers = rule["eligible_approvers"].map do |approver|
-        find_member(approver["username"]) ||
-          Gitlab::Dangerfiles::Teammate.new(approver)
-      end
-
-      # Intentionally not using `spin_for_person` to skip `valid_person?`.
-      # This should strictly return someone so we don't filter anything,
-      # and it's a fallback mechanism which should not happen often that
-      # deserves a complex algorithm.
-      fallback_approvers.sample(random: random)
-    end
-
-    def spin_for_category(project, category)
-      team = project_team(project)
-      reviewers, traintainers, maintainers =
-        %i[reviewer traintainer maintainer].map do |role|
-          spin_role_for_category(team, role, project, category)
-        end
-
-      weighted_reviewers = Gitlab::Dangerfiles::Weightage::Reviewers.new(reviewers, traintainers).execute
-      weighted_maintainers = Gitlab::Dangerfiles::Weightage::Maintainers.new(maintainers).execute
-
-      reviewer = spin_for_person(weighted_reviewers)
-      maintainer = spin_for_person(weighted_maintainers)
-
-      # allow projects with small number of reviewers to take from maintainers if possible
-      if reviewer.nil? && weighted_maintainers.uniq.size > 1
-        weighted_maintainers.delete(maintainer)
-        reviewer = spin_for_person(weighted_maintainers)
-      end
-
-      Spin.new(category, reviewer, maintainer, false)
-    end
-
     def prepare_ux_category!(categories)
-      if labels.include?("Community contribution")
+      if labels.include?("Community contribution") ||
+        # We only want to spin a reviewer for merge requests which has a
+        # designer for the team.
+        Gitlab::Dangerfiles::Teammate.has_member_for_the_group?(
+          :ux, project: config_project_name.downcase, labels: labels)
         categories << :ux
-      else
-        begin
-          # We only want to spin a reviewer for merge requests which has a
-          # designer for the team. There's no easy way to tell this, so we
-          # pretend this is a community contribution, in which case we only
-          # pick the team designer. If there's no one got picked, it means
-          # there's no designer for this team.
-          labels << "Community contribution"
-
-          # Don't use a fallback reviewer so when a group doesn't have
-          # available reviewers, it'll not give us any reviewers.
-          ux_spin = spin(nil, [:ux], ux_fallback_wider_community_reviewer: nil).first
-
-          categories << :ux if ux_spin.reviewer || ux_spin.maintainer
-        ensure
-          # Make sure we delete the label afterward
-          labels.delete("Community contribution")
-        end
-      end
-    end
-
-    # Fetches the given +url+ and parse its response as JSON.
-    #
-    # @param [String] url
-    #
-    # @return [Hash, Array, NilClass]
-    def http_get_json(url)
-      rsp = Net::HTTP.get_response(URI.parse(url))
-
-      if rsp.is_a?(Net::HTTPRedirection)
-        uri = URI.parse(rsp.header["location"])
-
-        uri.query = nil if uri
-
-        warnings << "Redirection detected: #{uri}."
-        return nil
-      end
-
-      unless rsp.is_a?(Net::HTTPOK)
-        message = rsp.message[0, 30]
-        warnings << "HTTPError: Failed to read #{url}: #{rsp.code} #{message}."
-        return nil
-      end
-
-      JSON.parse(rsp.body)
-    end
-
-    # Looks up the current list of GitLab team members and parses it into a
-    # useful form.
-    #
-    # @return [Array<Gitlab::Dangerfiles::Teammate>]
-    def company_members
-      @company_members ||= begin
-          data = http_get_json(ROULETTE_DATA_URL) || []
-          data.map { |hash| Gitlab::Dangerfiles::Teammate.new(hash) }
-        rescue JSON::ParserError
-          warnings << "Failed to parse JSON response from #{ROULETTE_DATA_URL}"
-          []
-        end
-    end
-
-    def find_member(username, project: nil)
-      company_members.find do |member|
-        member.username == username &&
-          if project
-            member.in_project?(project)
-          else
-            true
-          end
       end
     end
 
@@ -377,18 +157,5 @@ module Danger
     def labels
       @labels ||= helper.mr_labels
     end
-
-    # Like +team+, but only returns teammates in the current project, based on
-    # project_name.
-    #
-    # @return [Array<Gitlab::Dangerfiles::Teammate>]
-    def project_team(project_name)
-      company_members.select do |member|
-        member.in_project?(project_name)
-      end
-    rescue => err
-      warn("Reviewer roulette failed to load team data: #{err.message}")
-      []
-    end
   end
 end