gitlab-dangerfiles 4.5.1 → 4.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3371fdf6ddb99f838b75a15726a1750b14f9b56537949c86caae8b9345b9569d
-  data.tar.gz: 18eb20e9a7b43ab2b2556cd2a59ae344af3d11a5c003e76ca5fd4a5a5d819331
+  metadata.gz: 501394f58303715430e058da5fbc46a6c539136b8a888ed22521ab56da6595c3
+  data.tar.gz: 520c933eb21695e1cdc9e74cea42ec1e636b08455377d2b9dc3ebafe405977ac
 SHA512:
-  metadata.gz: ba10efb103ab0c9355e102de004d512918fb558e6e3a486b1adcc609a9d4b083f714d33b5e595b3f2a210dec8be934bb4d0df3bb9f8d46c95c4557407f79f481
-  data.tar.gz: c37a12218910f95359591f91509d99f61e230ecd3022d4886ff03635cddf8455c34bf045a15438e50bdf2688e7f5eafe206a8a2735a08adb13397d4a2eb8491d
+  metadata.gz: 5d68efa303d47210a6e1d126d9e7706f8872ae61a5a24dacce6b6a48242f8e9d0854f8067d35c64e6340602768e4ed65bd1fcfab71f7447798576172095497bc
+  data.tar.gz: 79b38327e2b8a133c58124952b2ff371cb551fde1d61aeb29b5f67d29ee212f93c1c423842121f0247304af52414efd5e690d3fa1c4e50083a9dfacdca7f4d33

data/gitlab-dangerfiles.gemspec

@@ -40,7 +40,7 @@ Gem::Specification.new do |spec|
   # we do not commit the bundle lockfile, so this temporary workaround needs to be
   # present until 2.21.3 or 2.22.x is released
   # See https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/63
-  spec.add_development_dependency "rubocop-rails", "!= 2.21.2"
+  spec.add_development_dependency "rubocop-rails", "< 2.21.2"
   spec.add_development_dependency "timecop"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "yard"

data/lib/danger/plugins/internal/helper.rb

@@ -21,9 +21,8 @@ module Danger
       ux: "~UX",
       codeowners: '~"Code Owners"',
       test: "~test for `spec/features/*`",
-      # Deprecated as of 2.3.0 in favor of tooling
-      engineering_productivity: '~"Engineering Productivity" for CI, Danger',
-      tooling: '~"maintenance::workflow" / ~"maintenance::pipelines" for CI, Danger',
+      tooling: '~"maintenance::workflow" for tooling, Danger, and RuboCop',
+      pipeline: '~"maintenance::pipelines" for CI',
       ci_template: '~"ci::templates"',
       analytics_instrumentation: '~"analytics instrumentation"',
       import_integrate_be: '~"group::import and integrate" (backend)',

data/lib/danger/plugins/roulette.rb

@@ -91,7 +91,7 @@ module Danger
             # Fetch an already picked backend reviewer, or pick one otherwise
             spin.reviewer = backend_spin&.reviewer || spin_for_category(project, :backend).reviewer
           end
-        when :tooling, :engineering_productivity # Deprecated as of 2.3.0 in favor of tooling
+        when :tooling
           if spin.maintainer.nil?
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend).maintainer

data/lib/danger/rules/z_add_labels/Dangerfile

@@ -9,7 +9,7 @@ def post_labels(labels)
     helper.mr_iid,
     add_labels: labels.join(","))
 rescue Gitlab::Error::Forbidden
-  warn("This Merge Request needs to be labelled with #{helper.labels_list(labels)}. Please request a reviewer or maintainer to add them.")
+  warn("Labels missing: please ask a reviewer or maintainer to add #{helper.labels_list(labels)} to this merge request.")
 end
 
 post_labels(helper.labels_to_add) if helper.labels_to_add.any?

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "4.5.1"
+    VERSION = "4.6.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 4.5.1
+  version: 4.6.0
 platform: ruby
 authors:
 - GitLab
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-23 00:00:00.000000000 Z
+date: 2023-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -140,14 +140,14 @@ dependencies:
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - "<"
       - !ruby/object:Gem::Version
         version: 2.21.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - "<"
       - !ruby/object:Gem::Version
         version: 2.21.2
 - !ruby/object:Gem::Dependency