gitlab-dangerfiles 3.9.0 → 3.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5759d8762183090115e7cb10b4b2d7244735d3225b53966c8feaf28e9d9eee7e
-  data.tar.gz: f49d06c663430072bad4c4f05b8bd1f509ca2c1a095bd1e499e3870fbe061fc9
+  metadata.gz: ad2ad158af390c0b6b52fdd86927b4dd0a6118b7b2eca3ad60aaa88ac40b840a
+  data.tar.gz: 2872e01e85bf7190e2a3fd4cab71868f2e4924234443797e7479a3ab03497120
 SHA512:
-  metadata.gz: 3cd96f3ceb33c2a028f62b1f72a16196ee1afa3768f0463783262ce3a4bd1d98d85e9ab905a916c0ad27cf7bfaf2c16608c5d533e07c30b6463807122d711f09
-  data.tar.gz: 253aa1b4a8a31c2c323ff05fbad3e2f613b932c82a5f1d61505e92966c1bfe7c593d17bae094f6ebd59b5568433d93d83e443b16df7c75d1b257d1015834a405
+  metadata.gz: 7dccc5481318999e83be3a9535983ebbf69d731d5394cf66543df0fd77bf7e274d1b012255c9582a503caae5248956aa2441af1b9ad6ffddf6c5bc2bc730013b
+  data.tar.gz: 5d217f45be9fb3c68032bbffd9a7eee4eb4cdb4056200c8dabdaf8255aa084a28ff3cd3ac74a5fa2588634607c4a5d23ffc6d58cc709e9343296112b6b3457b3

data/README.md

@@ -218,17 +218,32 @@ danger-review:
     - bundle add gitlab-dangerfiles --version 3.1.0
 ```
 
-## Rake tasks
+## Local Danger Rake task
 
-You can import this gem's Rake tasks by adding the following to your project's `Rakefile`:
+You can run a Danger Rake task locally in a project to detect Danger errors before pushing commits to a remote
+branch.
 
-```ruby
-require 'gitlab-dangerfiles'
+1. [Install `gitlab-dangerfiles`](#installation) in your project.
+1. Add the following to your project's `Rakefile`:
+
+   ```ruby
+   require 'gitlab-dangerfiles'
+
+   Gitlab::Dangerfiles.load_tasks
+   ```
+
+To run the Danger Rake task in a project that has `master` as the default branch, run:
 
-Gitlab::Dangerfiles.load_tasks
+```shell
+bundle exec rake danger_local
 ```
 
-That will add the `danger_local` Rake task that allows to run Danger locally.
+To run the Danger Rake task in a project that doesn't have `master` as the default branch, you must set the
+`DANGER_LOCAL_BASE` environment variable. For example, in a project with `main` as the default branch:
+
+```shell
+DANGER_LOCAL_BASE="origin/main" bundle exec rake danger_local
+```
 
 ## Documentation
 
@@ -264,6 +279,12 @@ end
 
 See an [example](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92580) for more details.
 
+## Contributing
+
+Bug reports and merge requests are welcome at https://gitlab.com/gitlab-org/gitlab-dangerfiles. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://gitlab.com/gitlab-org/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).
+
+Make sure to include a changelog entry in your commit message and read the [changelog entries section](https://docs.gitlab.com/ee/development/changelog.html).
+
 ## Release
 
 [Automated gem release process](https://gitlab.com/gitlab-org/quality/pipeline-common#release-process) is used to release new version of `gitlab-dangerfiles` through [pipelines](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/blob/4f33cf30cab84f7e27ca0cb9a7c0da3ecc675c11/.gitlab-ci.yml#L51), and this will:
@@ -272,24 +293,22 @@ See an [example](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92580) fo
 - Add a release in the `gitlab-dangerfiles` project: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/releases
 - Populate the release log with the API contents. For example: https://gitlab.com/api/v4/projects/19861191/repository/changelog?version=3.4.4
 
+We follow this release process in a separate merge request from the one that introduced the changes. The release merge request should just contain a version bump.
+
 ### Before release
 
-Make sure to include a changelog entry in your commit message and read the [changelog entries section](https://docs.gitlab.com/ee/development/changelog.html).
+Changes merged since the last release should have had changelog entries (see [Contributing](#contributing)).
 
-If you forget to set the changelog entry in your commit messages, you can also edit the release notes after it's being released.
+If changelog entries are missing, you can also edit the release notes after it's being released.
 
 ### Steps to release
 
-Use a `Release` merge request template and create a merge requet to update the version number in `version.rb`, and get the merge request merged by a maintainer.
+Use a `Release` merge request template and create a merge request to update the version number in `version.rb`, and get the merge request merged by a maintainer.
 
 This will then be packaged into a gem and pushed to [rubygems.org](https://rubygems.org) by the CI/CD.
 
 For example: [Bump version to 3.4.3](https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/merge_requests/149).
 
-## Contributing
-
-Bug reports and merge requests are welcome at https://gitlab.com/gitlab-org/gitlab-dangerfiles. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://gitlab.com/gitlab-org/gitlab-dangerfiles/blob/master/CODE_OF_CONDUCT.md).
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/danger/plugins/internal/helper.rb

@@ -25,7 +25,7 @@ module Danger
       engineering_productivity: '~"Engineering Productivity" for CI, Danger',
       tooling: '~"maintenance::workflow" / ~"maintenance::pipelines" for CI, Danger',
       ci_template: '~"ci::templates"',
-      product_intelligence: '~"product intelligence"',
+      analytics_instrumentation: '~"analytics instrumentation"',
       import_integrate_be: '~"group::import and integrate" (backend)',
       import_integrate_fe: '~"group::import and integrate" (frontend)',
       "Authentication and Authorization": '~"group::authentication and authorization"',

data/lib/danger/plugins/roulette.rb

@@ -89,7 +89,7 @@ module Danger
             # Fetch an already picked backend maintainer, or pick one otherwise
             spin.maintainer = backend_spin&.maintainer || spin_for_category(project, :backend, timezone_experiment: including_timezone).maintainer
           end
-        when :product_intelligence
+        when :analytics_instrumentation
           spin.optional_role = :maintainer
 
           if spin.maintainer.nil?

data/lib/danger/rules/simple_roulette/Dangerfile

@@ -92,11 +92,11 @@ categories << :database if helper.mr_labels.include?('database')
 # Ensure to spin for UX reviewer when ~UX is applied (e.g. to review changes to the UI) except when it's from wider community contribution where we want to assign from the corresponding group
 categories << :ux if helper.mr_labels.include?('UX') && !helper.mr_labels.include?('Community contribution')
 
-# Ensure to spin for Product Intelligence reviewer when ~"product intelligence::review pending" is applied
-categories << :product_intelligence if helper.mr_labels.include?("product intelligence::review pending")
+# Ensure to spin for Analytics Instrumentation reviewer when ~"analytics instrumentation::review pending" is applied
+categories << :analytics_instrumentation if helper.mr_labels.include?("analytics instrumentation::review pending")
 
-# Skip Product intelligence reviews for growth experiment MRs
-categories.delete(:product_intelligence) if helper.mr_labels.include?("growth experiment")
+# Skip Analytics Instrumentation reviews for growth experiment MRs
+categories.delete(:analytics_instrumentation) if helper.mr_labels.include?("growth experiment")
 
 # Remove disabled categories
 categories.subtract(helper.config.disabled_roulette_categories)

data/lib/gitlab/dangerfiles/category.rb

@@ -76,7 +76,7 @@ module Gitlab
 
         def has_particular_capability?(teammate)
           kind == :reviewer &&
-            teammate.role.match?(/Backend Engineer.+Manage:Integrations/)
+            teammate.role.match?(/Backend Engineer.+Manage:Import and Integrate/)
         end
       end
 
@@ -85,7 +85,7 @@ module Gitlab
 
         def has_particular_capability?(teammate)
           kind == :reviewer &&
-            teammate.role.match?(/Frontend Engineer.+Manage:Integrations/)
+            teammate.role.match?(/Frontend Engineer.+Manage:Import and Integrate/)
         end
       end
 

data/lib/gitlab/dangerfiles/version.rb

@@ -1,5 +1,5 @@
 module Gitlab
   module Dangerfiles
-    VERSION = "3.9.0"
+    VERSION = "3.10.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab-dangerfiles
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 3.10.0
 platform: ruby
 authors:
 - GitLab
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-05-02 00:00:00.000000000 Z
+date: 2023-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake